172414 2017-05-20 08:30:10 -0700 -Wreturn-type warning triggered by WKNotification.cpp:77 2017-05-20 12:25:59 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro sam oldest_to_newest 1311006 0 mcatanzaro 2017-05-20 08:30:10 -0700 Fix -Wreturn-type warning triggered by WKNotification.cpp:77: [4626/5527] Building CXX object Source...r/UIProcess/API/C/WKNotification.cpp.o ../../Source/WebKit2/UIProcess/API/C/WKNotification.cpp: In function ‘const OpaqueWKString* WKNotificationCopyDir(WKNotificationRef)’: ../../Source/WebKit2/UIProcess/API/C/WKNotification.cpp:77:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ 1311007 1 310771 mcatanzaro 2017-05-20 08:32:01 -0700 Created attachment 310771 Patch 1311033 2 310771 sam 2017-05-20 11:58:36 -0700 Comment on attachment 310771 Patch My bad. 1311038 3 310771 commit-queue 2017-05-20 12:25:57 -0700 Comment on attachment 310771 Patch Clearing flags on attachment: 310771 Committed r217189: <http://trac.webkit.org/changeset/217189> 1311039 4 commit-queue 2017-05-20 12:25:59 -0700 All reviewed patches have been landed. Closing bug. 310771 2017-05-20 08:32:01 -0700 2017-05-20 12:25:57 -0700 Patch bug-172414-20170520103200.patch text/plain 1397 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTU1MjFlODk2MjIxMWYx NThmOTlmYjk3ZThiZTM0YjZjMThlNjUwZi4uOTY1MTkwNjQ2NjZhMThmZjk2NjEzNWViNjVhNzU1 NmZlN2ViYjJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA1LTIwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV3JldHVy bi10eXBlIHdhcm5pbmcgdHJpZ2dlcmVkIGJ5IFdLTm90aWZpY2F0aW9uLmNwcDo3NworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyNDE0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0MvV0tOb3RpZmljYXRpb24uY3BwOgorICAgICAgICAoV0tOb3RpZmljYXRpb25Db3B5RGlyKToK KwogMjAxNy0wNS0xOSAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXNvdXJjZSBMb2FkIFN0YXRpc3RpY3M6IFVzZSBXZWJQcm9jZXNzUG9vbDo6YWxsUHJv Y2Vzc1Bvb2xzKCkgd2hlbiBzZW5kaW5nIG1lc3NhZ2UgdG8gbmV0d29yayBwcm9jZXNzIGFib3V0 IHBhcnRpdGlvbmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D L1dLTm90aWZpY2F0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS05v dGlmaWNhdGlvbi5jcHAKaW5kZXggZDEwMGUxNWE0YjMxOTVlMzJmYmJkNmRlNTUzNjQ2MzFmM2Fm NDI3Zi4uOGI2YzAzNDQ0MDZlOTljNzdhNzhlOWZjNzY4Mzc5NzZiZjdiMGFhNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLTm90aWZpY2F0aW9uLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tOb3RpZmljYXRpb24uY3BwCkBAIC03 NCw2ICs3NCw4IEBAIFdLU3RyaW5nUmVmIFdLTm90aWZpY2F0aW9uQ29weURpcihXS05vdGlmaWNh dGlvblJlZiBub3RpZmljYXRpb24pCiAgICAgY2FzZSBXZWJDb3JlOjpOb3RpZmljYXRpb25EaXJl Y3Rpb246OlJ0bDoKICAgICAgICAgcmV0dXJuIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5n KCJydGwiKTsKICAgICB9CisKKyAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQog CiBXS1NlY3VyaXR5T3JpZ2luUmVmIFdLTm90aWZpY2F0aW9uR2V0U2VjdXJpdHlPcmlnaW4oV0tO b3RpZmljYXRpb25SZWYgbm90aWZpY2F0aW9uKQo=