172347 2017-05-19 00:24:42 -0700 Speedometer 2.0: Flight.js test is sometime broken 2017-05-19 03:05:14 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 172339 1 rniwa rniwa addyo cdumez commit-queue fpizlo ggaren koivisto lforschler saam oldest_to_newest 1310503 0 rniwa 2017-05-19 00:24:42 -0700 Flight.js test is flaky because it doesn't always wait for the app to be ready. We need to add the same hack as v1 to wait for all dependencies to be loaded via require.js 1310504 1 310628 rniwa 2017-05-19 00:29:58 -0700 Created attachment 310628 Fixes the test 1310519 2 310628 koivisto 2017-05-19 01:56:56 -0700 Comment on attachment 310628 Fixes the test r=me 1310544 3 310641 rniwa 2017-05-19 02:49:55 -0700 Created attachment 310641 Wait for dependencies to load 1310552 4 rniwa 2017-05-19 03:05:14 -0700 Committed r217118: <http://trac.webkit.org/changeset/217118> 310628 2017-05-19 00:29:58 -0700 2017-05-19 02:49:53 -0700 Fixes the test bug-172347-20170519003001.patch text/plain 2699 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTcxMDIpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA1LTE5ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogRmxpZ2h0LmpzIHRlc3QgaXMgc29tZXRpbWUgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIzNDcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdhcyBjYXVzZWQgYnkgdGhlIHRl c3QgcnVubmVyIG9ubHkgd2FpdGluZyBmb3IgI25ldy10b2RvLCB3aGljaCBoYXBwZW5zIGJlZm9y ZSBhbGwgb3RoZXIgc3RhdGVzIGFyZQorICAgICAgICB1cGRhdGVkIGluIHRoZSBGbGlnaHQuanMg ZGVwZW5kZW5jeSBleGFtcGxlLiBBcyBkb25lIGluIFNwZWVkb21ldGVyIHYxLCBpbnNlcnQgYSBk dW1teSBlbGVtZW50IHdpdGggaWQgc2V0CisgICAgICAgIHRvIGFwcElzUmVhZHkgYW5kIHdhaXQg Zm9yIHRoaXMgZWxlbWVudCB0byBhcHBlYXIgaW4gdGhlIGJlbmNobWFyayBoYXJuZXNzLgorCisg ICAgICAgICogU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3Rlc3RzLmpzOiBXYWl0IGZvciAjYXBwSXNS ZWFkeS4KKyAgICAgICAgKiBTcGVlZG9tZXRlci9yZXNvdXJjZXMvdG9kb212Yy9kZXBlbmRlbmN5 LWV4YW1wbGVzL2ZsaWdodC9mbGlnaHQvYXBwL2pzL21haW4uanM6IEluc2VydCAjYXBwSXNSZWFk eSBvbmNlCisgICAgICAgIGV2ZXJ5dGhpbmcgaXMgc2V0dXAuCisKIDIwMTctMDUtMTggIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIxNjY5 NCAtIDIxNjcxMik6IFBlcmZvcm1hbmNlIHRlc3QgU3BlZWRvbWV0ZXIvRnVsbC5odG1sIGlzIGZh aWxpbmcKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3Rlc3Rz LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2Vz L3Rlc3RzLmpzCShyZXZpc2lvbiAyMTcwODcpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21l dGVyL3Jlc291cmNlcy90ZXN0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtNDUxLDkgKzQ1MSwxMCBA QCBTdWl0ZXMucHVzaCh7CiAgICAgbmFtZTogJ0ZsaWdodC1Ub2RvTVZDJywKICAgICB1cmw6ICd0 b2RvbXZjL2RlcGVuZGVuY3ktZXhhbXBsZXMvZmxpZ2h0L2ZsaWdodC9pbmRleC5odG1sJywKICAg ICBwcmVwYXJlOiBmdW5jdGlvbiAocnVubmVyLCBjb250ZW50V2luZG93LCBjb250ZW50RG9jdW1l bnQpIHsKLSAgICAgICAgcmV0dXJuIHJ1bm5lci53YWl0Rm9yRWxlbWVudCgnI25ldy10b2RvJyku dGhlbihmdW5jdGlvbiAoZWxlbWVudCkgewotICAgICAgICAgICAgZWxlbWVudC5mb2N1cygpOwot ICAgICAgICAgICAgcmV0dXJuIGVsZW1lbnQ7CisgICAgICAgIHJldHVybiBydW5uZXIud2FpdEZv ckVsZW1lbnQoJyNhcHBJc1JlYWR5JykudGhlbihmdW5jdGlvbiAoZWxlbWVudCkgeworICAgICAg ICAgICAgdmFyIG5ld1RvZG8gPSBjb250ZW50RG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ25ldy10 b2RvJyk7CisgICAgICAgICAgICBuZXdUb2RvLmZvY3VzKCk7CisgICAgICAgICAgICByZXR1cm4g bmV3VG9kbzsKICAgICAgICAgfSk7CiAgICAgfSwKICAgICB0ZXN0czogWwpJbmRleDogUGVyZm9y bWFuY2VUZXN0cy9TcGVlZG9tZXRlci9yZXNvdXJjZXMvdG9kb212Yy9kZXBlbmRlbmN5LWV4YW1w bGVzL2ZsaWdodC9mbGlnaHQvYXBwL2pzL21haW4uanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFu Y2VUZXN0cy9TcGVlZG9tZXRlci9yZXNvdXJjZXMvdG9kb212Yy9kZXBlbmRlbmN5LWV4YW1wbGVz L2ZsaWdodC9mbGlnaHQvYXBwL2pzL21haW4uanMJKHJldmlzaW9uIDIxNzA4NykKKysrIFBlcmZv cm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3RvZG9tdmMvZGVwZW5kZW5jeS1leGFt cGxlcy9mbGlnaHQvZmxpZ2h0L2FwcC9qcy9tYWluLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw2 ICsyNiw4IEBAIHJlcXVpcmUuY29uZmlnKHsKIHJlcXVpcmUoW10sIGZ1bmN0aW9uICgpIHsKICAg ICByZXF1aXJlKFsnYXBwL3BhZ2UvYXBwJ10sZnVuY3Rpb24oQXBwKXsKICAgICAgICAgQXBwLmlu aXRpYWxpemUoKTsKLSAgICAgICAgY29uc29sZS5sb2coQXBwKTsKKyAgICAgICAgdmFyIGR1bW15 Tm9kZVRvTm90aWZ5QXBwSXNSZWFkeSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOwor ICAgICAgICBkdW1teU5vZGVUb05vdGlmeUFwcElzUmVhZHkuaWQgPSAnYXBwSXNSZWFkeSc7Cisg ICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZHVtbXlOb2RlVG9Ob3RpZnlBcHBJc1Jl YWR5KTsKICAgICB9KTsKIH0pOwo= 310641 2017-05-19 02:49:55 -0700 2017-05-19 03:01:52 -0700 Wait for dependencies to load bug-172347-20170519024958.patch text/plain 4330 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTcxMDgpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE3LTA1LTE4ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogRmxpZ2h0LmpzIHRlc3QgaXMgc29tZXRpbWUgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIzNDcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdhcyBjYXVzZWQgYnkgdGhlIHRl c3QgcnVubmVyIG9ubHkgd2FpdGluZyBmb3IgI25ldy10b2RvLCB3aGljaCBoYXBwZW5zIGJlZm9y ZSBhbGwgb3RoZXIgc3RhdGVzIGFyZQorICAgICAgICB1cGRhdGVkIGluIHRoZSBGbGlnaHQuanMg ZGVwZW5kZW5jeSBleGFtcGxlLiBBcyBkb25lIGluIFNwZWVkb21ldGVyIHYxLCBpbnNlcnQgYSBk dW1teSBlbGVtZW50IHdpdGggaWQgc2V0CisgICAgICAgIHRvIGFwcElzUmVhZHkgYW5kIHdhaXQg Zm9yIHRoaXMgZWxlbWVudCB0byBhcHBlYXIgaW4gdGhlIGJlbmNobWFyayBoYXJuZXNzLgorCisg ICAgICAgICogU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3Rlc3RzLmpzOiBXYWl0IGZvciAjYXBwSXNS ZWFkeS4KKyAgICAgICAgKiBTcGVlZG9tZXRlci9yZXNvdXJjZXMvdG9kb212Yy9kZXBlbmRlbmN5 LWV4YW1wbGVzL2ZsaWdodC9mbGlnaHQvYXBwL2pzL21haW4uanM6IFJlbW92ZWQgdGhlIHN1cGVy ZmxvdXMgY2FsbAorICAgICAgICB0byBjb25zb2xlLmxvZy4KKyAgICAgICAgKGNoZWNrUmVhZHkp OiBBZGRlZC4gSW5zZXJ0ICNhcHBJc1JlYWR5IGlmIGNoZWNrTG9hZGVkIGlzIG5vIGxvbmdlciBy dW5uaW5nIGF0IDUwbXMgaW50ZXJ2YWwuIEJlY2F1c2UgdGhpcworICAgICAgICBjb3VsZCBoYXBw ZW4gYXN5bmNocm9ub3VzbHksIHdlIGNoZWNrIHRoZSBhYnNlbnNlIG9mIGNoZWNrTG9hZGVkVGlt ZW91dElkIM6pZXZlcnkgMTBtcyBmb3IgNSB0aW1lcyBmb3IKKyAgICAgICAgdGhlIHRvdGFsIGR1 cmF0aW9uIG9mIDUwbXMuIElmIGNoZWNrTG9hZGVkVGltZW91dElkIHdhcyBuZXZlciBwcmVzZW50 LCB3ZSBjYWxsIGl0IHJlYWR5LiBJZiB3ZSBldmVyIG9ic2VydmVkCisgICAgICAgIHRoZSBwcmVz ZW5jZSBvZiBjaGVja0xvYWRlZFRpbWVvdXRJZCwgd2FpdCBhbm90aGVyIDUwbXMgYW5kIHN0YXJ0 IG92ZXIuCisgICAgICAgICogU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3RvZG9tdmMvZGVwZW5kZW5j eS1leGFtcGxlcy9mbGlnaHQvZmxpZ2h0L25vZGVfbW9kdWxlcy9yZXF1aXJlanMvcmVxdWlyZS5q czoKKyAgICAgICAgKC5uZXdDb250ZXh0LmNoZWNrTG9hZGVkKTogRXhwb3NlIGNoZWNrTG9hZGVk VGltZW91dElkIHdoaWNoIGlzIGEgdGltZXIgSUQgdXNlZCB0byBjaGVjayB0aGUgZGVwZW5kZW5j eS4KKwogMjAxNy0wNS0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAg ICAgICBTcGVlZG9tZXRlciAyLjA6IFZhbmlsbGEgSlMgdGVzdCBkb2Vzbid0IG1hcmsgYWxsIHRv ZG8gaXRlbXMgYXMgY29tcGxldGVkCkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVy L3Jlc291cmNlcy90ZXN0cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL1NwZWVk b21ldGVyL3Jlc291cmNlcy90ZXN0cy5qcwkocmV2aXNpb24gMjE3MTA4KQorKysgUGVyZm9ybWFu Y2VUZXN0cy9TcGVlZG9tZXRlci9yZXNvdXJjZXMvdGVzdHMuanMJKHdvcmtpbmcgY29weSkKQEAg LTQ1MSw5ICs0NTEsMTAgQEAgU3VpdGVzLnB1c2goewogICAgIG5hbWU6ICdGbGlnaHQtVG9kb01W QycsCiAgICAgdXJsOiAndG9kb212Yy9kZXBlbmRlbmN5LWV4YW1wbGVzL2ZsaWdodC9mbGlnaHQv aW5kZXguaHRtbCcsCiAgICAgcHJlcGFyZTogZnVuY3Rpb24gKHJ1bm5lciwgY29udGVudFdpbmRv dywgY29udGVudERvY3VtZW50KSB7Ci0gICAgICAgIHJldHVybiBydW5uZXIud2FpdEZvckVsZW1l bnQoJyNuZXctdG9kbycpLnRoZW4oZnVuY3Rpb24gKGVsZW1lbnQpIHsKLSAgICAgICAgICAgIGVs ZW1lbnQuZm9jdXMoKTsKLSAgICAgICAgICAgIHJldHVybiBlbGVtZW50OworICAgICAgICByZXR1 cm4gcnVubmVyLndhaXRGb3JFbGVtZW50KCcjYXBwSXNSZWFkeScpLnRoZW4oZnVuY3Rpb24gKGVs ZW1lbnQpIHsKKyAgICAgICAgICAgIHZhciBuZXdUb2RvID0gY29udGVudERvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCduZXctdG9kbycpOworICAgICAgICAgICAgbmV3VG9kby5mb2N1cygpOworICAg ICAgICAgICAgcmV0dXJuIG5ld1RvZG87CiAgICAgICAgIH0pOwogICAgIH0sCiAgICAgdGVzdHM6 IFsKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3RvZG9tdmMv ZGVwZW5kZW5jeS1leGFtcGxlcy9mbGlnaHQvZmxpZ2h0L2FwcC9qcy9tYWluLmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3RvZG9tdmMvZGVw ZW5kZW5jeS1leGFtcGxlcy9mbGlnaHQvZmxpZ2h0L2FwcC9qcy9tYWluLmpzCShyZXZpc2lvbiAy MTcxMDgpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy90b2RvbXZj L2RlcGVuZGVuY3ktZXhhbXBsZXMvZmxpZ2h0L2ZsaWdodC9hcHAvanMvbWFpbi5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMjMsOSArMjMsMjAgQEAgcmVxdWlyZS5jb25maWcoewogICAgIH0KIH0pOwog CitmdW5jdGlvbiBjaGVja1JlYWR5KGNvdW50KSB7CisgICAgaWYgKHdpbmRvdy5jaGVja0xvYWRl ZFRpbWVvdXRJZCkKKyAgICAgICAgcmV0dXJuIHNldFRpbWVvdXQoY2hlY2tSZWFkeS5iaW5kKHRo aXMsIDApLCA1MCk7CisgICAgaWYgKGNvdW50IDwgNSkKKyAgICAgICAgcmV0dXJuIHNldFRpbWVv dXQoY2hlY2tSZWFkeS5iaW5kKHRoaXMsIGNvdW50ICsgMSksIDEwKTsKKworICAgIHZhciBkdW1t eU5vZGVUb05vdGlmeUFwcElzUmVhZHkgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsK KyAgICBkdW1teU5vZGVUb05vdGlmeUFwcElzUmVhZHkuaWQgPSAnYXBwSXNSZWFkeSc7CisgICAg ZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkdW1teU5vZGVUb05vdGlmeUFwcElzUmVhZHkpOwor fQorCiByZXF1aXJlKFtdLCBmdW5jdGlvbiAoKSB7CiAgICAgcmVxdWlyZShbJ2FwcC9wYWdlL2Fw cCddLGZ1bmN0aW9uKEFwcCl7CiAgICAgICAgIEFwcC5pbml0aWFsaXplKCk7Ci0gICAgICAgIGNv bnNvbGUubG9nKEFwcCk7CisgICAgICAgIGNoZWNrUmVhZHkoMCk7CiAgICAgfSk7CiB9KTsKSW5k ZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3RvZG9tdmMvZGVwZW5k ZW5jeS1leGFtcGxlcy9mbGlnaHQvZmxpZ2h0L25vZGVfbW9kdWxlcy9yZXF1aXJlanMvcmVxdWly ZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNl cy90b2RvbXZjL2RlcGVuZGVuY3ktZXhhbXBsZXMvZmxpZ2h0L2ZsaWdodC9ub2RlX21vZHVsZXMv cmVxdWlyZWpzL3JlcXVpcmUuanMJKHJldmlzaW9uIDIxNzEwOCkKKysrIFBlcmZvcm1hbmNlVGVz dHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3RvZG9tdmMvZGVwZW5kZW5jeS1leGFtcGxlcy9mbGln aHQvZmxpZ2h0L25vZGVfbW9kdWxlcy9yZXF1aXJlanMvcmVxdWlyZS5qcwkod29ya2luZyBjb3B5 KQpAQCAtNzE4LDYgKzcxOCw3IEBAIHZhciByZXF1aXJlanMsIHJlcXVpcmUsIGRlZmluZTsKICAg ICAgICAgICAgICAgICAgICAgICAgIGNoZWNrTG9hZGVkVGltZW91dElkID0gMDsKICAgICAgICAg ICAgICAgICAgICAgICAgIGNoZWNrTG9hZGVkKCk7CiAgICAgICAgICAgICAgICAgICAgIH0sIDUw KTsKKyAgICAgICAgICAgICAgICAgICAgd2luZG93LmNoZWNrTG9hZGVkVGltZW91dElkID0gY2hl Y2tMb2FkZWRUaW1lb3V0SWQ7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogCg==