172345 2017-05-18 23:48:48 -0700 REGRESSION(r216977): [GTK] Ephemeral sessions broken after r216977 2017-05-19 09:11:44 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned achristensen beidson bugs-noreply mcatanzaro oldest_to_newest 1310495 0 cgarcia 2017-05-18 23:48:48 -0700 Since r216977, WebProcessPool sends the page session ID to the web process, but the WebsiteDataStoreParameters session ID to the network process. WebsiteDataStoreParameters is only implemented for Cocoa, so we are sending 0 session ID to the network process, while using the right session ID everywhere else. $ MiniBrowser -p Attempted to create a NetworkLoad with a session (id=9223372036854775810) that does not exist. This has also broken two unit tests. 1310496 1 310625 cgarcia 2017-05-18 23:52:27 -0700 Created attachment 310625 Patch 1310615 2 310625 mcatanzaro 2017-05-19 09:04:20 -0700 Comment on attachment 310625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310625&action=review Glad the API tests caught this. Technically you need an owner to approve the cross-platform assertion, but since it's one line I assume you can get approval on IRC on something. > Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:1302 > + // FIXME: Implement cookies. What needs to happen here? 1310617 3 cgarcia 2017-05-19 09:11:44 -0700 Committed r217128: <http://trac.webkit.org/changeset/217128> 310625 2017-05-18 23:52:27 -0700 2017-05-19 09:04:20 -0700 Patch wk2-ephemeral-broken.diff text/plain 2824 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzZjRmMzlhYzRkOC4uNjBmMWFhODcxZGIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNy0wNS0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjE2OTc3KTogW0dUS10gRXBoZW1lcmFs IHNlc3Npb25zIGJyb2tlbiBhZnRlciByMjE2OTc3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIzNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSByMjE2OTc3LCBXZWJQcm9jZXNzUG9vbCBzZW5k cyB0aGUgcGFnZSBzZXNzaW9uIElEIHRvIHRoZSB3ZWIgcHJvY2VzcywgYnV0IHRoZSBXZWJzaXRl RGF0YVN0b3JlUGFyYW1ldGVycworICAgICAgICBzZXNzaW9uIElEIHRvIHRoZSBuZXR3b3JrIHBy b2Nlc3MuIFdlYnNpdGVEYXRhU3RvcmVQYXJhbWV0ZXJzIGlzIG9ubHkgaW1wbGVtZW50ZWQgZm9y IENvY29hLCBzbyB3ZSBhcmUgc2VuZGluZyAwCisgICAgICAgIHNlc3Npb24gSUQgdG8gdGhlIG5l dHdvcmsgcHJvY2Vzcywgd2hpbGUgdXNpbmcgdGhlIHJpZ2h0IHNlc3Npb24gSUQgZXZlcnl3aGVy ZSBlbHNlLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnBhZ2VBZGRlZFRvUHJvY2Vzcyk6IEFkZCBhbiBB U1NFUlQgdG8gZW5zdXJlIHdlIGFyZSBzZW5kaW5nIHRoZSBzYW1lIHNlc3Npb24gSUQgdG8gV2Vi CisgICAgICAgIGFuZCBOZXR3b3JrIHByb2Nlc3Nlcy4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vi c2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYnNpdGVE YXRhU3RvcmU6OnBhcmFtZXRlcnMpOiBBZGQgbWluaW1hbCBpbXBsZW1lbnRhdGlvbiBmb3Igbm9u LUNvY29hIHBvcnRzIHRvIGF0IGxlYXN0IHNldCB0aGUKKyAgICAgICAgc2Vzc2lvbiBJRC4KKwog MjAxNy0wNS0xOCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAg ICAgICBbTWVkaWFTdHJlYW1dIGRvIG5vdCBjYWNoZSBnVU0gcGVybWlzc2lvbnMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCmluZGV4IDEyYjExNzhmZDcxLi4y NmY1YjJiN2NmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nl c3NQb29sLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wu Y3BwCkBAIC05NDcsNiArOTQ3LDcgQEAgdm9pZCBXZWJQcm9jZXNzUG9vbDo6cGFnZUFkZGVkVG9Q cm9jZXNzKFdlYlBhZ2VQcm94eSYgcGFnZSkKICAgICBpZiAoc2Vzc2lvbklELmlzRXBoZW1lcmFs KCkpIHsKICAgICAgICAgLy8gRklYTUU6IE1lcmdlIE5ldHdvcmtQcm9jZXNzOjpFbnN1cmVQcml2 YXRlQnJvd3NpbmdTZXNzaW9uIGFuZCBOZXR3b3JrUHJvY2Vzczo6QWRkV2Vic2l0ZURhdGFTdG9y ZSBpbnRvIG9uZSBtZXNzYWdlIHR5cGUuCiAgICAgICAgIC8vIFRoZXkgZG8gYmFzaWNhbGx5IHRo ZSBzYW1lIHRoaW5nLgorICAgICAgICBBU1NFUlQocGFnZS53ZWJzaXRlRGF0YVN0b3JlKCkucGFy YW1ldGVycygpLnNlc3Npb25JRCA9PSBzZXNzaW9uSUQpOwogICAgICAgICBzZW5kVG9OZXR3b3Jr aW5nUHJvY2VzcyhNZXNzYWdlczo6TmV0d29ya1Byb2Nlc3M6OkVuc3VyZVByaXZhdGVCcm93c2lu Z1Nlc3Npb24ocGFnZS53ZWJzaXRlRGF0YVN0b3JlKCkucGFyYW1ldGVycygpKSk7CiAgICAgICAg IHBhZ2UucHJvY2VzcygpLnNlbmQoTWVzc2FnZXM6OldlYlByb2Nlc3M6OkVuc3VyZVByaXZhdGVC cm93c2luZ1Nlc3Npb24oc2Vzc2lvbklEKSwgMCk7CiAgICAgfSBlbHNlIGlmIChzZXNzaW9uSUQg IT0gU2Vzc2lvbklEOjpkZWZhdWx0U2Vzc2lvbklEKCkpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAppbmRl eCAxMDY5NTk5OGQzMy4uZGUyMzUxNzUyYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKQEAgLTEyOTks OSArMTI5OSwxMCBAQCB2b2lkIFdlYnNpdGVEYXRhU3RvcmU6OnJlbW92ZVBlbmRpbmdDb29raWUo Y29uc3QgV2ViQ29yZTo6Q29va2llJiBjb29raWUpCiAjaWYgIVBMQVRGT1JNKENPQ09BKQogV2Vi c2l0ZURhdGFTdG9yZVBhcmFtZXRlcnMgV2Vic2l0ZURhdGFTdG9yZTo6cGFyYW1ldGVycygpCiB7 Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudC4KLQotICAgIHJldHVybiB7IH07CisgICAgLy8gRklY TUU6IEltcGxlbWVudCBjb29raWVzLgorICAgIFdlYnNpdGVEYXRhU3RvcmVQYXJhbWV0ZXJzIHBh cmFtZXRlcnM7CisgICAgcGFyYW1ldGVycy5zZXNzaW9uSUQgPSBtX3Nlc3Npb25JRDsKKyAgICBy ZXR1cm4gcGFyYW1ldGVyczsKIH0KICNlbmRpZgogCg==