172317 2017-05-18 15:05:46 -0700 [CMake] Add HAVE check for __int128_t 2017-05-19 01:58:35 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 172144 1 don.olmstead don.olmstead achristensen commit-queue lforschler ysuzuki oldest_to_newest 1310283 0 don.olmstead 2017-05-18 15:05:46 -0700 CMake can be used to verify the presence of __int128_t. 1310293 1 don.olmstead 2017-05-18 15:20:44 -0700 Blocks compilation of JSCOnly on Windows 1310298 2 310558 don.olmstead 2017-05-18 15:31:57 -0700 Created attachment 310558 Patch This patch adds a HAVE check for __int128_t. I did not want to do a COMPILER check because clang-cl shows up as both Clang and MSVC so a HAVE check is the best choice. A patch for clang-cl support is coming in the near future. Currently GCC and Clang expose this. It appears this is exposed only on x64 according to GCC docs https://gcc.gnu.org/onlinedocs/gcc/_005f_005fint128.html. I also saw that clang-cl seems to have that behavior as it does not expose it for x86 builds but does for x64. I don't believe that the Intel compiler exposes this value in case anyone is using that. The Platform.h file is modified within the block that has all the corresponding HAVE checks in OptionsCommon. This is to support DARWIN targets that are not using CMake. 1310512 3 310558 ysuzuki 2017-05-19 01:30:39 -0700 Comment on attachment 310558 Patch r=me 1310520 4 310558 commit-queue 2017-05-19 01:58:33 -0700 Comment on attachment 310558 Patch Clearing flags on attachment: 310558 Committed r217105: <http://trac.webkit.org/changeset/217105> 1310521 5 commit-queue 2017-05-19 01:58:35 -0700 All reviewed patches have been landed. Closing bug. 310558 2017-05-18 15:31:57 -0700 2017-05-19 01:58:33 -0700 Patch bug-172317.diff text/plain 2925 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxOGQ5YTJkNDk4NC4uMWRk MzU2NzQxMTggMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0wNS0xOCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNvbnku Y29tPgorCisgICAgICAgIFtDTWFrZV0gQWRkIEhBVkUgY2hlY2sgZm9yIF9faW50MTI4X3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjMxNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2Nt YWtlL09wdGlvbnNDb21tb24uY21ha2U6CisKIDIwMTctMDUtMTYgIFphbiBEb2JlcnNlayAgPHpk b2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIFNldCBhbmQgZXhwb3NlIEVOQUJM RV9ERVZFTE9QRVJfTU9ERSBpbiBidWlsZCB3aGVuIERFVkVMT1BFUl9NT0RFIGlzIGVuYWJsZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNzlkNmFhMTZlMzIuLjM4NThiMTNhNTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3 LTA1LTE4ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAYW0uc29ueS5jb20+CisKKyAgICAg ICAgW0NNYWtlXSBBZGQgSEFWRSBjaGVjayBmb3IgX19pbnQxMjhfdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyMzE3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvTWVkaWFUaW1lLmNwcDoKKyAg ICAgICAgKFdURjo6TWVkaWFUaW1lOjpzZXRUaW1lU2NhbGUpOgorICAgICAgICAqIHd0Zi9QbGF0 Zm9ybS5oOgorCiAyMDE3LTA1LTE4ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+ CiAKICAgICAgICAgQXV0b21hdGljVGhyZWFkIHNob3VsZCB3YWl0IGxvbmdlciBiZWZvcmUgdGlt aW5nIG91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWVkaWFUaW1lLmNwcCBiL1NvdXJj ZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKaW5kZXggYjBhMTI0MmMwNWQuLmFlMGUwZDlmYjBjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCisrKyBiL1NvdXJjZS9XVEYv d3RmL01lZGlhVGltZS5jcHAKQEAgLTQ4OSw3ICs0ODksNyBAQCB2b2lkIE1lZGlhVGltZTo6c2V0 VGltZVNjYWxlKHVpbnQzMl90IHRpbWVTY2FsZSwgUm91bmRpbmdGbGFncyBmbGFncykKIAogICAg IHRpbWVTY2FsZSA9IHN0ZDo6bWluKE1heGltdW1UaW1lU2NhbGUsIHRpbWVTY2FsZSk7CiAKLSNp ZiAhUExBVEZPUk0oV0lOKSAmJiAoQ1BVKFg4Nl82NCkgfHwgQ1BVKEFSTTY0KSkKKyNpZiBIQVZF KElOVDEyOF9UKQogICAgIF9faW50MTI4X3QgbmV3VmFsdWUgPSBzdGF0aWNfY2FzdDxfX2ludDEy OF90PihtX3RpbWVWYWx1ZSkgKiB0aW1lU2NhbGU7CiAgICAgaW50NjRfdCByZW1haW5kZXIgPSBu ZXdWYWx1ZSAlIG1fdGltZVNjYWxlOwogICAgIG5ld1ZhbHVlID0gbmV3VmFsdWUgLyBtX3RpbWVT Y2FsZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RG L3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDY3N2Y4MTI0YTAxLi44OTM5NzljYWE5MCAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bS5oCkBAIC02NDgsNiArNjQ4LDEwIEBACiAjZGVmaW5lIEhBVkVfVE1fR01UT0ZGIDEKICNkZWZp bmUgSEFWRV9UTV9aT05FIDEKICNkZWZpbmUgSEFWRV9USU1FR00gMQorCisjaWYgQ1BVKFg4Nl82 NCkgfHwgQ1BVKEFSTTY0KQorI2RlZmluZSBIQVZFX0lOVDEyOF9UIDEKKyNlbmRpZgogI2VuZGlm IC8qIE9TKERBUldJTikgKi8KIAogI2lmIE9TKFVOSVgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21h a2UvT3B0aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtl CmluZGV4IDcxNzlmNDc5NjVkLi5kMzJlZDdkNjdhNCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtl L09wdGlvbnNDb21tb24uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21h a2UKQEAgLTIyOCw2ICsyMjgsNyBAQCBpbmNsdWRlKENoZWNrSW5jbHVkZUZpbGUpCiBpbmNsdWRl KENoZWNrRnVuY3Rpb25FeGlzdHMpCiBpbmNsdWRlKENoZWNrU3ltYm9sRXhpc3RzKQogaW5jbHVk ZShDaGVja1N0cnVjdEhhc01lbWJlcikKK2luY2x1ZGUoQ2hlY2tUeXBlU2l6ZSkKIAogbWFjcm8o X0hBVkVfQ0hFQ0tfSU5DTFVERSBfdmFyaWFibGUgX2hlYWRlcikKICAgICBjaGVja19pbmNsdWRl X2ZpbGUoJHtfaGVhZGVyfSAke192YXJpYWJsZX1fdmFsdWUpCkBAIC0yODAsMyArMjgxLDEwIEBA IF9IQVZFX0NIRUNLX1NZTUJPTChIQVZFX1NJR05BTF9IIFNJR1RSQVAgc2lnbmFsLmgpCiBfSEFW RV9DSEVDS19TVFJVQ1QoSEFWRV9TVEFUX0JJUlRIVElNRSAic3RydWN0IHN0YXQiIHN0X2JpcnRo dGltZSBzeXMvc3RhdC5oKQogX0hBVkVfQ0hFQ0tfU1RSVUNUKEhBVkVfVE1fR01UT0ZGICJzdHJ1 Y3QgdG0iIHRtX2dtdG9mZiB0aW1lLmgpCiBfSEFWRV9DSEVDS19TVFJVQ1QoSEFWRV9UTV9aT05F ICJzdHJ1Y3QgdG0iIHRtX3pvbmUgdGltZS5oKQorCisjIENoZWNrIGZvciBpbnQgdHlwZXMKK2No ZWNrX3R5cGVfc2l6ZSgiX19pbnQxMjhfdCIgSU5UMTI4X1ZBTFVFKQorCitpZiAoSEFWRV9JTlQx MjhfVkFMVUUpCisgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEhBVkVfSU5UMTI4X1QgSU5UMTI4 X1ZBTFVFKQorZW5kaWYgKCkK