172313 2017-05-18 14:29:52 -0700 Web Inspector: Release InjectedScripts when frontends close 2017-05-18 19:59:22 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck kling oldest_to_newest 1310262 0 joepeck 2017-05-18 14:29:52 -0700 Summary: Release InjectedScripts when frontends close When all inspector frontends close, we can release some more inspector resources. Should can reduce memory use and allow some things to be collected after closing web inspector. 1310267 1 310551 joepeck 2017-05-18 14:34:20 -0700 Created attachment 310551 [PATCH] Proposed Fix 1310281 2 310551 kling 2017-05-18 15:04:24 -0700 Comment on attachment 310551 [PATCH] Proposed Fix r=me, great find! 1310411 3 310551 commit-queue 2017-05-18 19:59:20 -0700 Comment on attachment 310551 [PATCH] Proposed Fix Clearing flags on attachment: 310551 Committed r217087: <http://trac.webkit.org/changeset/217087> 1310412 4 commit-queue 2017-05-18 19:59:22 -0700 All reviewed patches have been landed. Closing bug. 310551 2017-05-18 14:34:20 -0700 2017-05-18 19:59:20 -0700 [PATCH] Proposed Fix release-1.patch text/plain 2628 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYTNiMWVlMTgyOC4uNDdmOTZiZjRlYmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0wNS0xOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbGVhc2UgSW5qZWN0ZWRTY3JpcHRzIHdo ZW4gZnJvbnRlbmRzIGNsb3NlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzIzMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OmRpc2Nvbm5lY3RGcm9udGVuZCk6CisgICAg ICAgIFJlbGVhc2UgaW5zcGVjdG9yIHJlc291cmNlcyB0b2dldGhlciwgaW5jbHVkaW5nIGRpc2Nh cmRpbmcgaW5qZWN0ZWQKKyAgICAgICAgc2NyaXB0cyBzbyB0aGF0IHRoZXkgbWF5IGJlIGNvbGxl Y3RlZC4KKworICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6aW5zcGVjdGVk UGFnZURlc3Ryb3llZCk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpk aXNjb25uZWN0QWxsRnJvbnRlbmRzKToKKyAgICAgICAgTW92ZSB0aGUgZGlzY29ubmVjdCBjYWxs IGluc2lkZSBvZiBkaXNjb25uZWN0QWxsRnJvbnRlbmRzIHRvIGVzdGFibGlzaAorICAgICAgICBh IHBhdHRlcm4gb2YgcmVsZWFzaW5nIHdlYiBpbnNwZWN0b3IgcmVzb3VyY2VzIHRvZ2V0aGVyLgor CiAyMDE3LTA1LTE4ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjE3MDMxLCByMjE3MDMyLCBhbmQgcjIx NzAzNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250 cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVy LmNwcAppbmRleCAyZDA1ZTUxODI0NC4uMzUzNTIzYTIxMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKQEAgLTIwMiw4ICsyMDIsNiBA QCBJbnNwZWN0b3JDb250cm9sbGVyOjp+SW5zcGVjdG9yQ29udHJvbGxlcigpCiAKIHZvaWQgSW5z cGVjdG9yQ29udHJvbGxlcjo6aW5zcGVjdGVkUGFnZURlc3Ryb3llZCgpCiB7Ci0gICAgbV9pbmpl Y3RlZFNjcmlwdE1hbmFnZXItPmRpc2Nvbm5lY3QoKTsKLQogICAgIC8vIENsZWFuIHVwIHJlc291 cmNlcyBhbmQgZGlzY29ubmVjdCBsb2NhbCBhbmQgcmVtb3RlIGZyb250ZW5kcy4KICAgICBkaXNj b25uZWN0QWxsRnJvbnRlbmRzKCk7CiAKQEAgLTI4Myw4ICsyODEsOSBAQCB2b2lkIEluc3BlY3Rv ckNvbnRyb2xsZXI6OmRpc2Nvbm5lY3RGcm9udGVuZChGcm9udGVuZENoYW5uZWwqIGZyb250ZW5k Q2hhbm5lbCkKICAgICAgICAgLy8gTm90aWZ5IGFnZW50cyBmaXJzdC4KICAgICAgICAgbV9hZ2Vu dHMud2lsbERlc3Ryb3lGcm9udGVuZEFuZEJhY2tlbmQoRGlzY29ubmVjdFJlYXNvbjo6SW5zcGVj dG9yRGVzdHJveWVkKTsKIAotICAgICAgICAvLyBEZXN0cm95IHRoZSBpbnNwZWN0b3Igb3Zlcmxh eSdzIHBhZ2UuCisgICAgICAgIC8vIENsZWFuIHVwIGluc3BlY3RvciByZXNvdXJjZXMuCiAgICAg ICAgIG1fb3ZlcmxheS0+ZnJlZVBhZ2UoKTsKKyAgICAgICAgbV9pbmplY3RlZFNjcmlwdE1hbmFn ZXItPmRpc2NhcmRJbmplY3RlZFNjcmlwdHMoKTsKIAogICAgICAgICAvLyBVbnBsdWcgYWxsIGlu c3RydW1lbnRhdGlvbnMgc2luY2UgdGhleSBhcmVuJ3QgbmVlZGVkIG5vdy4KICAgICAgICAgSW5z cGVjdG9ySW5zdHJ1bWVudGF0aW9uOjp1bnJlZ2lzdGVySW5zdHJ1bWVudGluZ0FnZW50cyhtX2lu c3RydW1lbnRpbmdBZ2VudHMuZ2V0KCkpOwpAQCAtMzE3LDggKzMxNiw5IEBAIHZvaWQgSW5zcGVj dG9yQ29udHJvbGxlcjo6ZGlzY29ubmVjdEFsbEZyb250ZW5kcygpCiAgICAgLy8gTm90aWZ5IGFn ZW50cyBmaXJzdCwgc2luY2UgdGhleSBtYXkgbmVlZCB0byB1c2UgSW5zcGVjdG9yQ2xpZW50Lgog ICAgIG1fYWdlbnRzLndpbGxEZXN0cm95RnJvbnRlbmRBbmRCYWNrZW5kKERpc2Nvbm5lY3RSZWFz b246Okluc3BlY3RlZFRhcmdldERlc3Ryb3llZCk7CiAKLSAgICAvLyBEZXN0cm95IHRoZSBpbnNw ZWN0b3Igb3ZlcmxheSdzIHBhZ2UuCisgICAgLy8gQ2xlYW4gdXAgaW5zcGVjdG9yIHJlc291cmNl cy4KICAgICBtX292ZXJsYXktPmZyZWVQYWdlKCk7CisgICAgbV9pbmplY3RlZFNjcmlwdE1hbmFn ZXItPmRpc2Nvbm5lY3QoKTsKIAogICAgIC8vIERpc2Nvbm5lY3QgYW55IHJlbWFpbmluZyByZW1v dGUgZnJvbnRlbmRzLgogICAgIG1fZnJvbnRlbmRSb3V0ZXItPmRpc2Nvbm5lY3RBbGxGcm9udGVu ZHMoKTsK