172311 2017-05-18 14:12:15 -0700 [macOS Sierra] Layout Test http/tests/dom/document-attributes-null-handling.html is flaky. 2017-05-18 20:21:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jlewis3 cdumez achristensen cdumez commit-queue kling koivisto rniwa oldest_to_newest 1310253 0 jlewis3 2017-05-18 14:12:15 -0700 The test http/tests/dom/document-attributes-null-handling.html is flaky on Both WK1 and WK2 on macOS Sierra. The test fails more frequently on Sierra Debug. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fdom%2Fdocument-attributes-null-handling.html https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r217052%20(1076)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1076 Diff: --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/dom/document-attributes-null-handling-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/dom/document-attributes-null-handling-actual.txt @@ -8,7 +8,7 @@ document.cookie = 'key=value' PASS document.cookie is "key=value" document.cookie = null -PASS document.cookie is "key=value; null=" +FAIL document.cookie should be key=value; null=. Was null=; key=value. * title attribute PASS document.title is "" 1310257 1 jlewis3 2017-05-18 14:14:14 -0700 I was able to reproduce the failure on Sierra debug and release with: run-webkit-tests http/tests/dom/document-attributes-null-handling.html -f --iterations=500 --no-retry-failure and run-webkit-tests http/tests/dom/document-attributes-null-handling.html -f --iterations=500 --no-retry-failure --debug The failures were flaky and had to be run several times before failures occurred. 1310403 2 cdumez 2017-05-18 19:36:15 -0700 Was able to reproduce, thanks. I'll take a look. 1310404 3 310595 cdumez 2017-05-18 19:41:33 -0700 Created attachment 310595 Patch 1310406 4 310595 kling 2017-05-18 19:53:07 -0700 Comment on attachment 310595 Patch r=me 1310424 5 310595 commit-queue 2017-05-18 20:21:57 -0700 Comment on attachment 310595 Patch Clearing flags on attachment: 310595 Committed r217091: <http://trac.webkit.org/changeset/217091> 1310425 6 commit-queue 2017-05-18 20:21:59 -0700 All reviewed patches have been landed. Closing bug. 310595 2017-05-18 19:41:33 -0700 2017-05-18 20:21:57 -0700 Patch bug-172311-20170518194130.patch text/plain 2585 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MDgxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODYyODczMjA3MTYzYjA3YjY2YWQ3 YWViZTA2M2Q3MmUyZGE4ZjYyMi4uNTU0NTkzOTBkMmFiNWIxNGM1YzMxMzlmNmFhNDJkMzM2N2U4 Y2UxYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA1LTE4ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TIFNpZXJyYV0gTGF5b3V0IFRlc3QgaHR0 cC90ZXN0cy9kb20vZG9jdW1lbnQtYXR0cmlidXRlcy1udWxsLWhhbmRsaW5nLmh0bWwgaXMgZmxh a3kuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIz MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3Qg c3VyZSB3aHkgdGhlIGNvb2tpZXMgYXJlIHNvbWV0aW1lcyByZXR1cm5lZCBieSBDRk5ldHdvcmsg aW4gYSBkaWZmZXJlbnQgb3JkZXIuIEhvd2V2ZXIsCisgICAgICAgIHdoYXQgbWF0dGVycyBhbmQg d2hhdCB3ZSB3YW50IHRvIHRlc3QgaXMgdGhhdCB0aGUgY29va2llIHdhcyBhY3R1YWxseSBhZGRl ZCBzbyBtYWtlIHRoZQorICAgICAgICB0ZXN0IG5vdCByZWx5IG9uIGEgc3BlY2lmaWMgb3JkZXIg dG8gYWRkcmVzcyBmbGFraW5lc3MuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL2RvbS9kb2N1bWVu dC1hdHRyaWJ1dGVzLW51bGwtaGFuZGxpbmctZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAv dGVzdHMvZG9tL2RvY3VtZW50LWF0dHJpYnV0ZXMtbnVsbC1oYW5kbGluZy5odG1sOgorCiAyMDE3 LTA1LTE4ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAg IFtNZWRpYVN0cmVhbV0gZG8gbm90IGNhY2hlIGdVTSBwZXJtaXNzaW9ucwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9kb20vZG9jdW1lbnQtYXR0cmlidXRlcy1udWxsLWhhbmRs aW5nLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZG9tL2RvY3VtZW50LWF0 dHJpYnV0ZXMtbnVsbC1oYW5kbGluZy1leHBlY3RlZC50eHQKaW5kZXggMTRiZjRlMWNmMjM0YTM0 YjI2ZjIyNTJkNmE0Yzc5OWM1ZmJmODFiNi4uZjNiZmY1M2YyZWFhY2I5ZmQ2YWQ3NWQ1YWQyZDA4 MDYyOTEwZjA5NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9kb20vZG9jdW1l bnQtYXR0cmlidXRlcy1udWxsLWhhbmRsaW5nLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL2RvbS9kb2N1bWVudC1hdHRyaWJ1dGVzLW51bGwtaGFuZGxpbmctZXhwZWN0 ZWQudHh0CkBAIC04LDcgKzgsOCBAQCBQQVNTIGRvY3VtZW50LmNvb2tpZSBpcyAiIgogZG9jdW1l bnQuY29va2llID0gJ2tleT12YWx1ZScKIFBBU1MgZG9jdW1lbnQuY29va2llIGlzICJrZXk9dmFs dWUiCiBkb2N1bWVudC5jb29raWUgPSBudWxsCi1QQVNTIGRvY3VtZW50LmNvb2tpZSBpcyAia2V5 PXZhbHVlOyBudWxsPSIKK1BBU1MgZG9jdW1lbnQuY29va2llLmluZGV4T2YoJ2tleT12YWx1ZScp ICE9IC0xIGlzIHRydWUKK1BBU1MgZG9jdW1lbnQuY29va2llLmluZGV4T2YoJ251bGw9JykgIT0g LTEgaXMgdHJ1ZQogCiAqIHRpdGxlIGF0dHJpYnV0ZQogUEFTUyBkb2N1bWVudC50aXRsZSBpcyAi IgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9kb20vZG9jdW1lbnQtYXR0cmli dXRlcy1udWxsLWhhbmRsaW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2RvbS9kb2N1 bWVudC1hdHRyaWJ1dGVzLW51bGwtaGFuZGxpbmcuaHRtbAppbmRleCA4ZDBiY2M5MWM0YWI2OWYy Y2Y0NWY3MDNkYWUzMmEwYjBlZWExMzY1Li5hZTk1N2MwYzRjZmUzNmQ0MzYyMmIzZjM0YzlkMjQ1 YTc3MzMwOTE0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2RvbS9kb2N1bWVu dC1hdHRyaWJ1dGVzLW51bGwtaGFuZGxpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2RvbS9kb2N1bWVudC1hdHRyaWJ1dGVzLW51bGwtaGFuZGxpbmcuaHRtbApAQCAtMTAsNyAr MTAsOCBAQCBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRvY3VtZW50LmNvb2tpZSIsICIiKTsKIGV2 YWxBbmRMb2coImRvY3VtZW50LmNvb2tpZSA9ICdrZXk9dmFsdWUnIik7CiBzaG91bGRCZUVxdWFs VG9TdHJpbmcoImRvY3VtZW50LmNvb2tpZSIsICJrZXk9dmFsdWUiKTsKIGV2YWxBbmRMb2coImRv Y3VtZW50LmNvb2tpZSA9IG51bGwiKTsKLXNob3VsZEJlRXF1YWxUb1N0cmluZygiZG9jdW1lbnQu Y29va2llIiwgImtleT12YWx1ZTsgbnVsbD0iKTsKK3Nob3VsZEJlVHJ1ZSgiZG9jdW1lbnQuY29v a2llLmluZGV4T2YoJ2tleT12YWx1ZScpICE9IC0xIik7CitzaG91bGRCZVRydWUoImRvY3VtZW50 LmNvb2tpZS5pbmRleE9mKCdudWxsPScpICE9IC0xIik7CiAKIGRlYnVnKCIiKTsKIGRlYnVnKCIq IHRpdGxlIGF0dHJpYnV0ZSIpOwo=