172307 2017-05-18 13:05:44 -0700 Make WebRTC logging happen in Release 2017-05-18 18:43:41 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue eric.carlson krollin simon.fraser oldest_to_newest 1310220 0 youennf 2017-05-18 13:05:44 -0700 This will allow easier debugging 1310221 1 310540 youennf 2017-05-18 13:07:22 -0700 Created attachment 310540 Patch 1310226 2 310540 simon.fraser 2017-05-18 13:19:48 -0700 Comment on attachment 310540 Patch This logging doesn't look useful. I don't see logging on any error conditions. 1310229 3 youennf 2017-05-18 13:30:58 -0700 (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 310540 [details] > Patch > > This logging doesn't look useful. I don't see logging on any error > conditions. This logging allows to see what are the parameters of the session. This is extremely useful when you are not controlling the website or the other endpoint. What we do not have here: - Whether the network connection is successful or not. This should be added as a follow-up. Useful when you are not sure of the network - The state of the network connection once successful. This might be perf sensitive but would be useful as long as we do not have some inspector functionality similar to chrome:://webrtc-internals. - Any media element state. This should also be added as a follow-up. Useful when we have issues with autoplay and such. 1310386 4 310540 commit-queue 2017-05-18 18:43:39 -0700 Comment on attachment 310540 Patch Clearing flags on attachment: 310540 Committed r217082: <http://trac.webkit.org/changeset/217082> 1310387 5 commit-queue 2017-05-18 18:43:41 -0700 All reviewed patches have been landed. Closing bug. 310540 2017-05-18 13:07:22 -0700 2017-05-18 18:43:39 -0700 Patch bug-172307-20170518130720.patch text/plain 9958 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRmYjY0YTIzZmI4MjMw NWI0ZDZhMTY3ZWQ4NDcwZjIzZGFiNDYwOS4uZjdlNTJmOTU1MGRhMzFkNTU5MGVkNTZjYWVlNTE4 Zjg1ZDRiY2E4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM1IEBACiAyMDE3LTA1LTE4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBNYWtlIFdlYlJUQyBsb2dn aW5nIGhhcHBlbiBpbiBSZWxlYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzIzMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisgICAgICAgIE1vdmUgZnJvbSBM T0coV2ViUlRDLi4uKSB0byBSRUxFQVNFX0xPRyhXZWJSVEMuLi4pLgorCisgICAgICAgICogTW9k dWxlcy9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UGVlckNvbm5lY3Rpb25CYWNrZW5kOjpjcmVhdGVPZmZlclN1Y2NlZWRlZCk6CisgICAg ICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6OmNyZWF0ZU9mZmVyRmFpbGVkKToK KyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0aW9uQmFja2VuZDo6Y3JlYXRlQW5zd2VyU3Vj Y2VlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0aW9uQmFja2VuZDo6Y3JlYXRl QW5zd2VyRmFpbGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0aW9uQmFja2VuZDo6 c2V0TG9jYWxEZXNjcmlwdGlvblN1Y2NlZWRlZCk6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29u bmVjdGlvbkJhY2tlbmQ6OnNldExvY2FsRGVzY3JpcHRpb25GYWlsZWQpOgorICAgICAgICAoV2Vi Q29yZTo6UGVlckNvbm5lY3Rpb25CYWNrZW5kOjpzZXRSZW1vdGVEZXNjcmlwdGlvblN1Y2NlZWRl ZCk6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6OnNldFJlbW90ZURl c2NyaXB0aW9uRmFpbGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0aW9uQmFja2Vu ZDo6YWRkSWNlQ2FuZGlkYXRlU3VjY2VlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25u ZWN0aW9uQmFja2VuZDo6YWRkSWNlQ2FuZGlkYXRlRmFpbGVkKToKKyAgICAgICAgKFdlYkNvcmU6 OlBlZXJDb25uZWN0aW9uQmFja2VuZDo6bmV3SUNFQ2FuZGlkYXRlKToKKyAgICAgICAgKFdlYkNv cmU6OlBlZXJDb25uZWN0aW9uQmFja2VuZDo6ZG9uZUdhdGhlcmluZ0NhbmRpZGF0ZXMpOgorICAg ICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UlRDUGVlckNvbm5lY3Rpb246OnF1ZXVlZENyZWF0ZU9mZmVyKToKKyAgICAg ICAgKFdlYkNvcmU6OlJUQ1BlZXJDb25uZWN0aW9uOjpxdWV1ZWRDcmVhdGVBbnN3ZXIpOgorICAg ICAgICAoV2ViQ29yZTo6UlRDUGVlckNvbm5lY3Rpb246OnF1ZXVlZFNldExvY2FsRGVzY3JpcHRp b24pOgorICAgICAgICAoV2ViQ29yZTo6UlRDUGVlckNvbm5lY3Rpb246OnF1ZXVlZFNldFJlbW90 ZURlc2NyaXB0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlJUQ1BlZXJDb25uZWN0aW9uOjpxdWV1 ZWRBZGRJY2VDYW5kaWRhdGUpOgorCisyMDE3LTA1LTE4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5u QGFwcGxlLmNvbT4KKwogICAgICAgICBSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2Ugc2hvdWxk IHVzZSB0aGUgc291cmNlIHNhbXBsZSByYXRlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIyOTcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwCmluZGV4 IDIyMDA2MTYyMjI1OTdjZjg0MGY0ZDhjZmEyNzBmZjU3Mjc3Yjg4YzcuLmI5NzBhYmNiNDU1NTVj Yzk3ZDUyNDBiOTI0MDUzNTAyYTdhNzY2MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rpb25CYWNrZW5kLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9uQmFja2VuZC5jcHAKQEAg LTU2LDcgKzU2LDcgQEAgdm9pZCBQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6OmNyZWF0ZU9mZmVyKFJU Q09mZmVyT3B0aW9ucyYmIG9wdGlvbnMsIFBlZXJDb25uZWN0aW8KIHZvaWQgUGVlckNvbm5lY3Rp b25CYWNrZW5kOjpjcmVhdGVPZmZlclN1Y2NlZWRlZChTdHJpbmcmJiBzZHApCiB7CiAgICAgQVNT RVJUKGlzTWFpblRocmVhZCgpKTsKLSAgICBMT0coV2ViUlRDLCAiQ3JlYXRpbmcgb2ZmZXIgc3Vj Y2VlZGVkOlxuJXNcbiIsIHNkcC51dGY4KCkuZGF0YSgpKTsKKyAgICBSRUxFQVNFX0xPRyhXZWJS VEMsICJDcmVhdGluZyBvZmZlciBzdWNjZWVkZWQ6XG4lc1xuIiwgc2RwLnV0ZjgoKS5kYXRhKCkp OwogCiAgICAgaWYgKG1fcGVlckNvbm5lY3Rpb24uaXNDbG9zZWQoKSkKICAgICAgICAgcmV0dXJu OwpAQCAtNjksNyArNjksNyBAQCB2b2lkIFBlZXJDb25uZWN0aW9uQmFja2VuZDo6Y3JlYXRlT2Zm ZXJTdWNjZWVkZWQoU3RyaW5nJiYgc2RwKQogdm9pZCBQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6OmNy ZWF0ZU9mZmVyRmFpbGVkKEV4Y2VwdGlvbiYmIGV4Y2VwdGlvbikKIHsKICAgICBBU1NFUlQoaXNN YWluVGhyZWFkKCkpOwotICAgIExPRyhXZWJSVEMsICJDcmVhdGluZyBvZmZlciBmYWlsZWQ6XG4l c1xuIiwgZXhjZXB0aW9uLm1lc3NhZ2UoKS51dGY4KCkuZGF0YSgpKTsKKyAgICBSRUxFQVNFX0xP RyhXZWJSVEMsICJDcmVhdGluZyBvZmZlciBmYWlsZWQ6XG4lc1xuIiwgZXhjZXB0aW9uLm1lc3Nh Z2UoKS51dGY4KCkuZGF0YSgpKTsKIAogICAgIGlmIChtX3BlZXJDb25uZWN0aW9uLmlzQ2xvc2Vk KCkpCiAgICAgICAgIHJldHVybjsKQEAgLTkxLDcgKzkxLDcgQEAgdm9pZCBQZWVyQ29ubmVjdGlv bkJhY2tlbmQ6OmNyZWF0ZUFuc3dlcihSVENBbnN3ZXJPcHRpb25zJiYgb3B0aW9ucywgUGVlckNv bm5lY3QKIHZvaWQgUGVlckNvbm5lY3Rpb25CYWNrZW5kOjpjcmVhdGVBbnN3ZXJTdWNjZWVkZWQo U3RyaW5nJiYgc2RwKQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0gICAgTE9HKFdl YlJUQywgIkNyZWF0aW5nIGFuc3dlciBzdWNjZWVkZWQ6XG4lc1xuIiwgc2RwLnV0ZjgoKS5kYXRh KCkpOworICAgIFJFTEVBU0VfTE9HKFdlYlJUQywgIkNyZWF0aW5nIGFuc3dlciBzdWNjZWVkZWQ6 XG4lc1xuIiwgc2RwLnV0ZjgoKS5kYXRhKCkpOwogICAgIAogICAgIGlmIChtX3BlZXJDb25uZWN0 aW9uLmlzQ2xvc2VkKCkpCiAgICAgICAgIHJldHVybjsKQEAgLTEwNCw3ICsxMDQsNyBAQCB2b2lk IFBlZXJDb25uZWN0aW9uQmFja2VuZDo6Y3JlYXRlQW5zd2VyU3VjY2VlZGVkKFN0cmluZyYmIHNk cCkKIHZvaWQgUGVlckNvbm5lY3Rpb25CYWNrZW5kOjpjcmVhdGVBbnN3ZXJGYWlsZWQoRXhjZXB0 aW9uJiYgZXhjZXB0aW9uKQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0gICAgTE9H KFdlYlJUQywgIkNyZWF0aW5nIGFuc3dlciBmYWlsZWQ6XG4lc1xuIiwgZXhjZXB0aW9uLm1lc3Nh Z2UoKS51dGY4KCkuZGF0YSgpKTsKKyAgICBSRUxFQVNFX0xPRyhXZWJSVEMsICJDcmVhdGluZyBh bnN3ZXIgZmFpbGVkOlxuJXNcbiIsIGV4Y2VwdGlvbi5tZXNzYWdlKCkudXRmOCgpLmRhdGEoKSk7 CiAKICAgICBpZiAobV9wZWVyQ29ubmVjdGlvbi5pc0Nsb3NlZCgpKQogICAgICAgICByZXR1cm47 CkBAIC0xNDksNyArMTQ5LDcgQEAgdm9pZCBQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6OnNldExvY2Fs RGVzY3JpcHRpb24oUlRDU2Vzc2lvbkRlc2NyaXB0aW9uJiBzZXNzaW9uRGUKIHZvaWQgUGVlckNv bm5lY3Rpb25CYWNrZW5kOjpzZXRMb2NhbERlc2NyaXB0aW9uU3VjY2VlZGVkKCkKIHsKICAgICBB U1NFUlQoaXNNYWluVGhyZWFkKCkpOwotICAgIExPRyhXZWJSVEMsICJTZXR0aW5nIGxvY2FsIGRl c2NyaXB0aW9uIHN1Y2NlZWRlZFxuIik7CisgICAgUkVMRUFTRV9MT0coV2ViUlRDLCAiU2V0dGlu ZyBsb2NhbCBkZXNjcmlwdGlvbiBzdWNjZWVkZWRcbiIpOwogCiAgICAgaWYgKG1fcGVlckNvbm5l Y3Rpb24uaXNDbG9zZWQoKSkKICAgICAgICAgcmV0dXJuOwpAQCAtMTYzLDcgKzE2Myw3IEBAIHZv aWQgUGVlckNvbm5lY3Rpb25CYWNrZW5kOjpzZXRMb2NhbERlc2NyaXB0aW9uU3VjY2VlZGVkKCkK IHZvaWQgUGVlckNvbm5lY3Rpb25CYWNrZW5kOjpzZXRMb2NhbERlc2NyaXB0aW9uRmFpbGVkKEV4 Y2VwdGlvbiYmIGV4Y2VwdGlvbikKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwotICAg IExPRyhXZWJSVEMsICJTZXR0aW5nIGxvY2FsIGRlc2NyaXB0aW9uIGZhaWxlZDpcbiVzXG4iLCBl eGNlcHRpb24ubWVzc2FnZSgpLnV0ZjgoKS5kYXRhKCkpOworICAgIFJFTEVBU0VfTE9HKFdlYlJU QywgIlNldHRpbmcgbG9jYWwgZGVzY3JpcHRpb24gZmFpbGVkOlxuJXNcbiIsIGV4Y2VwdGlvbi5t ZXNzYWdlKCkudXRmOCgpLmRhdGEoKSk7CiAKICAgICBpZiAobV9wZWVyQ29ubmVjdGlvbi5pc0Ns b3NlZCgpKQogICAgICAgICByZXR1cm47CkBAIC0yMDksNyArMjA5LDcgQEAgdm9pZCBQZWVyQ29u bmVjdGlvbkJhY2tlbmQ6OnNldFJlbW90ZURlc2NyaXB0aW9uKFJUQ1Nlc3Npb25EZXNjcmlwdGlv biYgc2Vzc2lvbkQKIHZvaWQgUGVlckNvbm5lY3Rpb25CYWNrZW5kOjpzZXRSZW1vdGVEZXNjcmlw dGlvblN1Y2NlZWRlZCgpCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKLSAgICBMT0co V2ViUlRDLCAiU2V0dGluZyByZW1vdGUgZGVzY3JpcHRpb24gc3VjY2VlZGVkXG4iKTsKKyAgICBS RUxFQVNFX0xPRyhXZWJSVEMsICJTZXR0aW5nIHJlbW90ZSBkZXNjcmlwdGlvbiBzdWNjZWVkZWRc biIpOwogCiAgICAgaWYgKG1fcGVlckNvbm5lY3Rpb24uaXNDbG9zZWQoKSkKICAgICAgICAgcmV0 dXJuOwpAQCAtMjIzLDcgKzIyMyw3IEBAIHZvaWQgUGVlckNvbm5lY3Rpb25CYWNrZW5kOjpzZXRS ZW1vdGVEZXNjcmlwdGlvblN1Y2NlZWRlZCgpCiB2b2lkIFBlZXJDb25uZWN0aW9uQmFja2VuZDo6 c2V0UmVtb3RlRGVzY3JpcHRpb25GYWlsZWQoRXhjZXB0aW9uJiYgZXhjZXB0aW9uKQogewogICAg IEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0gICAgTE9HKFdlYlJUQywgIlNldHRpbmcgcmVtb3Rl IGRlc2NyaXB0aW9uIGZhaWxlZDpcbiVzXG4iLCBleGNlcHRpb24ubWVzc2FnZSgpLnV0ZjgoKS5k YXRhKCkpOworICAgIFJFTEVBU0VfTE9HKFdlYlJUQywgIlNldHRpbmcgcmVtb3RlIGRlc2NyaXB0 aW9uIGZhaWxlZDpcbiVzXG4iLCBleGNlcHRpb24ubWVzc2FnZSgpLnV0ZjgoKS5kYXRhKCkpOwog CiAgICAgaWYgKG1fcGVlckNvbm5lY3Rpb24uaXNDbG9zZWQoKSkKICAgICAgICAgcmV0dXJuOwpA QCAtMjU1LDcgKzI1NSw3IEBAIHZvaWQgUGVlckNvbm5lY3Rpb25CYWNrZW5kOjphZGRJY2VDYW5k aWRhdGUoUlRDSWNlQ2FuZGlkYXRlKiBpY2VDYW5kaWRhdGUsIERPTVByCiB2b2lkIFBlZXJDb25u ZWN0aW9uQmFja2VuZDo6YWRkSWNlQ2FuZGlkYXRlU3VjY2VlZGVkKCkKIHsKICAgICBBU1NFUlQo aXNNYWluVGhyZWFkKCkpOwotICAgIExPRyhXZWJSVEMsICJBZGRpbmcgaWNlIGNhbmRpZGF0ZSBz dWNjZWVkZWRcbiIpOworICAgIFJFTEVBU0VfTE9HKFdlYlJUQywgIkFkZGluZyBpY2UgY2FuZGlk YXRlIHN1Y2NlZWRlZFxuIik7CiAKICAgICBpZiAobV9wZWVyQ29ubmVjdGlvbi5pc0Nsb3NlZCgp KQogICAgICAgICByZXR1cm47CkBAIC0yNzAsNyArMjcwLDcgQEAgdm9pZCBQZWVyQ29ubmVjdGlv bkJhY2tlbmQ6OmFkZEljZUNhbmRpZGF0ZVN1Y2NlZWRlZCgpCiB2b2lkIFBlZXJDb25uZWN0aW9u QmFja2VuZDo6YWRkSWNlQ2FuZGlkYXRlRmFpbGVkKEV4Y2VwdGlvbiYmIGV4Y2VwdGlvbikKIHsK ICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwotICAgIExPRyhXZWJSVEMsICJBZGRpbmcgaWNl IGNhbmRpZGF0ZSBmYWlsZWQ6XG4lc1xuIiwgZXhjZXB0aW9uLm1lc3NhZ2UoKS51dGY4KCkuZGF0 YSgpKTsKKyAgICBSRUxFQVNFX0xPRyhXZWJSVEMsICJBZGRpbmcgaWNlIGNhbmRpZGF0ZSBmYWls ZWQ6XG4lc1xuIiwgZXhjZXB0aW9uLm1lc3NhZ2UoKS51dGY4KCkuZGF0YSgpKTsKIAogICAgIGlm IChtX3BlZXJDb25uZWN0aW9uLmlzQ2xvc2VkKCkpCiAgICAgICAgIHJldHVybjsKQEAgLTMzNCw3 ICszMzQsNyBAQCBzdGF0aWMgaW5saW5lIFN0cmluZyBmaWx0ZXJJQ0VDYW5kaWRhdGUoU3RyaW5n JiYgc2RwKQogCiB2b2lkIFBlZXJDb25uZWN0aW9uQmFja2VuZDo6bmV3SUNFQ2FuZGlkYXRlKFN0 cmluZyYmIHNkcCwgU3RyaW5nJiYgbWlkKQogewotICAgIExPRyhXZWJSVEMsICJHYXRoZXJlZCBp Y2UgY2FuZGlkYXRlOlxuJXNcbiIsIHNkcC51dGY4KCkuZGF0YSgpKTsKKyAgICBSRUxFQVNFX0xP RyhXZWJSVEMsICJHYXRoZXJlZCBpY2UgY2FuZGlkYXRlOlxuJXNcbiIsIHNkcC51dGY4KCkuZGF0 YSgpKTsKIAogICAgIGlmICghbV9zaG91bGRGaWx0ZXJJQ0VDYW5kaWRhdGVzKSB7CiAgICAgICAg IGZpcmVJQ0VDYW5kaWRhdGVFdmVudChSVENJY2VDYW5kaWRhdGU6OmNyZWF0ZShXVEZNb3ZlKHNk cCksIFdURk1vdmUobWlkKSwgMCkpOwpAQCAtMzUwLDcgKzM1MCw3IEBAIHZvaWQgUGVlckNvbm5l Y3Rpb25CYWNrZW5kOjpuZXdJQ0VDYW5kaWRhdGUoU3RyaW5nJiYgc2RwLCBTdHJpbmcmJiBtaWQp CiB2b2lkIFBlZXJDb25uZWN0aW9uQmFja2VuZDo6ZG9uZUdhdGhlcmluZ0NhbmRpZGF0ZXMoKQog ewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0gICAgTE9HKFdlYlJUQywgIkZpbmlzaGVk IGljZSBjYW5kaWRhdGUgZ2F0aGVyaW5nXG4iKTsKKyAgICBSRUxFQVNFX0xPRyhXZWJSVEMsICJG aW5pc2hlZCBpY2UgY2FuZGlkYXRlIGdhdGhlcmluZ1xuIik7CiAKICAgICBtX3BlZXJDb25uZWN0 aW9uLmZpcmVFdmVudChSVENQZWVyQ29ubmVjdGlvbkljZUV2ZW50OjpjcmVhdGUoZmFsc2UsIGZh bHNlLCBudWxscHRyKSk7CiAgICAgbV9wZWVyQ29ubmVjdGlvbi51cGRhdGVJY2VHYXRoZXJpbmdT dGF0ZShSVENJY2VHYXRoZXJpbmdTdGF0ZTo6Q29tcGxldGUpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAppbmRl eCA5MTMxNjAzNzAxOGFjNjNlNzllMTRiNWJiNzM1MmE0M2MxN2NmMWJhLi5kZGNjNmM1MTU0Yjhh NjhmN2RjMjI2NGM5NzYyODRjYTI3ODJkMDg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcApAQCAtMjE0LDcg KzIxNCw3IEBAIFJlZjxSVENSdHBUcmFuc2NlaXZlcj4gUlRDUGVlckNvbm5lY3Rpb246OmNvbXBs ZXRlQWRkVHJhbnNjZWl2ZXIoUmVmPFJUQ1J0cFNlbmRlCiAKIHZvaWQgUlRDUGVlckNvbm5lY3Rp b246OnF1ZXVlZENyZWF0ZU9mZmVyKFJUQ09mZmVyT3B0aW9ucyYmIG9wdGlvbnMsIFNlc3Npb25E ZXNjcmlwdGlvblByb21pc2UmJiBwcm9taXNlKQogewotICAgIExPRyhXZWJSVEMsICJDcmVhdGlu ZyBvZmZlclxuIik7CisgICAgUkVMRUFTRV9MT0coV2ViUlRDLCAiQ3JlYXRpbmcgb2ZmZXJcbiIp OwogICAgIGlmIChpc0Nsb3NlZCgpKSB7CiAgICAgICAgIHByb21pc2UucmVqZWN0KElOVkFMSURf U1RBVEVfRVJSKTsKICAgICAgICAgcmV0dXJuOwpAQCAtMjI1LDcgKzIyNSw3IEBAIHZvaWQgUlRD UGVlckNvbm5lY3Rpb246OnF1ZXVlZENyZWF0ZU9mZmVyKFJUQ09mZmVyT3B0aW9ucyYmIG9wdGlv bnMsIFNlc3Npb25EZXNjCiAKIHZvaWQgUlRDUGVlckNvbm5lY3Rpb246OnF1ZXVlZENyZWF0ZUFu c3dlcihSVENBbnN3ZXJPcHRpb25zJiYgb3B0aW9ucywgU2Vzc2lvbkRlc2NyaXB0aW9uUHJvbWlz ZSYmIHByb21pc2UpCiB7Ci0gICAgTE9HKFdlYlJUQywgIkNyZWF0aW5nIGFuc3dlclxuIik7Cisg ICAgUkVMRUFTRV9MT0coV2ViUlRDLCAiQ3JlYXRpbmcgYW5zd2VyXG4iKTsKICAgICBpZiAoaXND bG9zZWQoKSkgewogICAgICAgICBwcm9taXNlLnJlamVjdChJTlZBTElEX1NUQVRFX0VSUik7CiAg ICAgICAgIHJldHVybjsKQEAgLTIzNiw3ICsyMzYsNyBAQCB2b2lkIFJUQ1BlZXJDb25uZWN0aW9u OjpxdWV1ZWRDcmVhdGVBbnN3ZXIoUlRDQW5zd2VyT3B0aW9ucyYmIG9wdGlvbnMsIFNlc3Npb25E ZQogCiB2b2lkIFJUQ1BlZXJDb25uZWN0aW9uOjpxdWV1ZWRTZXRMb2NhbERlc2NyaXB0aW9uKFJU Q1Nlc3Npb25EZXNjcmlwdGlvbiYgZGVzY3JpcHRpb24sIERPTVByb21pc2VEZWZlcnJlZDx2b2lk PiYmIHByb21pc2UpCiB7Ci0gICAgTE9HKFdlYlJUQywgIlNldHRpbmcgbG9jYWwgZGVzY3JpcHRp b246XG4lc1xuIiwgZGVzY3JpcHRpb24uc2RwKCkudXRmOCgpLmRhdGEoKSk7CisgICAgUkVMRUFT RV9MT0coV2ViUlRDLCAiU2V0dGluZyBsb2NhbCBkZXNjcmlwdGlvbjpcbiVzXG4iLCBkZXNjcmlw dGlvbi5zZHAoKS51dGY4KCkuZGF0YSgpKTsKICAgICBpZiAoaXNDbG9zZWQoKSkgewogICAgICAg ICBwcm9taXNlLnJlamVjdChJTlZBTElEX1NUQVRFX0VSUik7CiAgICAgICAgIHJldHVybjsKQEAg LTI2Miw3ICsyNjIsNyBAQCBSZWZQdHI8UlRDU2Vzc2lvbkRlc2NyaXB0aW9uPiBSVENQZWVyQ29u bmVjdGlvbjo6cGVuZGluZ0xvY2FsRGVzY3JpcHRpb24oKSBjb25zdAogCiB2b2lkIFJUQ1BlZXJD b25uZWN0aW9uOjpxdWV1ZWRTZXRSZW1vdGVEZXNjcmlwdGlvbihSVENTZXNzaW9uRGVzY3JpcHRp b24mIGRlc2NyaXB0aW9uLCBET01Qcm9taXNlRGVmZXJyZWQ8dm9pZD4mJiBwcm9taXNlKQogewot ICAgIExPRyhXZWJSVEMsICJTZXR0aW5nIHJlbW90ZSBkZXNjcmlwdGlvbjpcbiVzXG4iLCBkZXNj cmlwdGlvbi5zZHAoKS51dGY4KCkuZGF0YSgpKTsKKyAgICBSRUxFQVNFX0xPRyhXZWJSVEMsICJT ZXR0aW5nIHJlbW90ZSBkZXNjcmlwdGlvbjpcbiVzXG4iLCBkZXNjcmlwdGlvbi5zZHAoKS51dGY4 KCkuZGF0YSgpKTsKIAogICAgIGlmIChpc0Nsb3NlZCgpKSB7CiAgICAgICAgIHByb21pc2UucmVq ZWN0KElOVkFMSURfU1RBVEVfRVJSKTsKQEAgLTI4OCw3ICsyODgsNyBAQCBSZWZQdHI8UlRDU2Vz c2lvbkRlc2NyaXB0aW9uPiBSVENQZWVyQ29ubmVjdGlvbjo6cGVuZGluZ1JlbW90ZURlc2NyaXB0 aW9uKCkgY29ucwogCiB2b2lkIFJUQ1BlZXJDb25uZWN0aW9uOjpxdWV1ZWRBZGRJY2VDYW5kaWRh dGUoUlRDSWNlQ2FuZGlkYXRlKiBydGNDYW5kaWRhdGUsIERPTVByb21pc2VEZWZlcnJlZDx2b2lk PiYmIHByb21pc2UpCiB7Ci0gICAgTE9HKFdlYlJUQywgIlJlY2VpdmVkIGljZSBjYW5kaWRhdGU6 XG4lc1xuIiwgcnRjQ2FuZGlkYXRlID8gcnRjQ2FuZGlkYXRlLT5jYW5kaWRhdGUoKS51dGY4KCku ZGF0YSgpIDogIm51bGwiKTsKKyAgICBSRUxFQVNFX0xPRyhXZWJSVEMsICJSZWNlaXZlZCBpY2Ug Y2FuZGlkYXRlOlxuJXNcbiIsIHJ0Y0NhbmRpZGF0ZSA/IHJ0Y0NhbmRpZGF0ZS0+Y2FuZGlkYXRl KCkudXRmOCgpLmRhdGEoKSA6ICJudWxsIik7CiAKICAgICBpZiAoaXNDbG9zZWQoKSkgewogICAg ICAgICBwcm9taXNlLnJlamVjdChJTlZBTElEX1NUQVRFX0VSUik7Cg==