172297 2017-05-18 11:21:27 -0700 RealtimeOutgoingAudioSource should use the source sample rate 2017-05-18 12:07:59 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson jonlee webkit-bug-importer oldest_to_newest 1310156 0 youennf 2017-05-18 11:21:27 -0700 Currently it expects the data to be 48000 1310159 1 310520 youennf 2017-05-18 11:23:50 -0700 Created attachment 310520 Patch 1310164 2 310520 eric.carlson 2017-05-18 11:38:16 -0700 Comment on attachment 310520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310520&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable): Using the audio source sample rate so that the converter does the right conversion. Nit: this line is too long. Nit: "Using" => "Use". 1310168 3 webkit-bug-importer 2017-05-18 11:41:02 -0700 <rdar://problem/32277335> 1310188 4 310520 commit-queue 2017-05-18 12:07:58 -0700 Comment on attachment 310520 Patch Clearing flags on attachment: 310520 Committed r217058: <http://trac.webkit.org/changeset/217058> 1310189 5 commit-queue 2017-05-18 12:07:59 -0700 All reviewed patches have been landed. Closing bug. 310520 2017-05-18 11:23:50 -0700 2017-05-18 12:07:58 -0700 Patch bug-172297-20170518112348.patch text/plain 2174 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU5YjQyYWJkZTQyYmVm OGQ5OTJiM2NkYWEzODNmNThhMGY1ZDRmMi4uYWRmYjY0YTIzZmI4MjMwNWI0ZDZhMTY3ZWQ4NDcw ZjIzZGFiNDYwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTE4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWFsdGltZU91dGdvaW5n QXVkaW9Tb3VyY2Ugc2hvdWxkIHVzZSB0aGUgc291cmNlIHNhbXBsZSByYXRlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIyOTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IG1hbnVhbCB0 ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZU91dGdv aW5nQXVkaW9Tb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVhbHRpbWVPdXRnb2luZ0F1 ZGlvU291cmNlOjphdWRpb1NhbXBsZXNBdmFpbGFibGUpOiBVc2luZyB0aGUgYXVkaW8gc291cmNl IHNhbXBsZSByYXRlIHNvIHRoYXQgdGhlIGNvbnZlcnRlciBkb2VzIHRoZSByaWdodCBjb252ZXJz aW9uLgorCiAyMDE3LTA1LTE4ICBWYW5lc3NhIENoaXBpcnLDoXMgTmF2YWzDs24gIDx2Y2hpcGly cmFzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bR1N0cmVhbWVyXVtNU0VdIENyYXNoIG9u IHlvdXR1YmUgd2hlbiBNU0UgaXMgZW5hYmxlZCBidXQgZ3N0cmVhbWVyIGNhbnQgZmluZCB0aGUg ZGVjb2RlciBlbGVtZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNl LmNwcAppbmRleCBmYTg5ZmU4YjIwN2Y5YWFmZGQ3ZjNmNGVjOTRlODlhMTdjNzJmMjQzLi44Y2Q4 MjYyNGVkMTMwMjViMmVjNDFjYjFlMGQ2MDlhOTllMzZjYzEzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291 cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVh bHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlLmNwcApAQCAtOTMsOCArOTMsMTAgQEAgdm9pZCBSZWFs dGltZU91dGdvaW5nQXVkaW9Tb3VyY2U6OmF1ZGlvU2FtcGxlc0F2YWlsYWJsZShjb25zdCBNZWRp YVRpbWUmLCBjb25zdAogICAgICAgICBzdGF0dXMgPSBtX3NhbXBsZUNvbnZlcnRlci0+c2V0T3V0 cHV0Rm9ybWF0KG1fb3V0cHV0U3RyZWFtRGVzY3JpcHRpb24uc3RyZWFtRGVzY3JpcHRpb24oKSk7 CiAgICAgICAgIEFTU0VSVCghc3RhdHVzKTsKICAgICB9Ci0KLSAgICBtX3NhbXBsZUNvbnZlcnRl ci0+cHVzaFNhbXBsZXMoTWVkaWFUaW1lKG1fd3JpdGVDb3VudCwgTGliV2ViUlRDQXVkaW9Gb3Jt YXQ6OnNhbXBsZVJhdGUpLCBhdWRpb0RhdGEsIHNhbXBsZUNvdW50KTsKKyAgICAKKyAgICAvLyBJ ZiB3ZSBjaGFuZ2UgdGhlIGF1ZGlvIHRyYWNrIG9yIGl0cyBzYW1wbGUgcmF0ZSBjaGFuZ2VzLCB0 aGUgdGltZXN0YW1wIGJhc2VkIG9uIG1fd3JpdGVDb3VudCBtYXkgYmUgd3JvbmcuCisgICAgLy8g RklYTUU6IFdlIHNob3VsZCB1cGRhdGUgbV93cml0ZUNvdW50IHRvIGJlIHZhbGlkIGFjY29yZGlu ZyB0aGUgbmV3IHNhbXBsZVJhdGUuCisgICAgbV9zYW1wbGVDb252ZXJ0ZXItPnB1c2hTYW1wbGVz KE1lZGlhVGltZShtX3dyaXRlQ291bnQsIHN0YXRpY19jYXN0PHVpbnQzMl90PihtX2lucHV0U3Ry ZWFtRGVzY3JpcHRpb24uc2FtcGxlUmF0ZSgpKSksIGF1ZGlvRGF0YSwgc2FtcGxlQ291bnQpOwog ICAgIG1fd3JpdGVDb3VudCArPSBzYW1wbGVDb3VudDsKIAogICAgIExpYldlYlJUQ1Byb3ZpZGVy OjpjYWxsT25XZWJSVENTaWduYWxpbmdUaHJlYWQoW3Byb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0 aGlzKV0gewo=