172294 2017-05-18 11:17:28 -0700 [JSC] Remove PLATFORM(WIN) references 2017-05-19 02:39:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 172144 1 don.olmstead don.olmstead bfulgham buildbot commit-queue keith_miller mark.lam msaboff pvollan saam ysuzuki oldest_to_newest 1310152 0 don.olmstead 2017-05-18 11:17:28 -0700 PLATFORM(WIN) should not be used when OS(WINDOWS) can be used. 1310153 1 don.olmstead 2017-05-18 11:18:11 -0700 Blocks compilation of JSCOnly on Windows. 1310160 2 310521 don.olmstead 2017-05-18 11:24:43 -0700 Created attachment 310521 Patch Using OS(WINDOWS) instead of PLATFORM(WIN). Updated Offline ASM to check for MSVC instead of PLATFORM(WIN) for MASM. 1310166 3 annulen 2017-05-18 11:40:10 -0700 LGTM 1310527 4 310521 ysuzuki 2017-05-19 02:11:46 -0700 Comment on attachment 310521 Patch OK, r=me 1310535 5 310521 commit-queue 2017-05-19 02:39:31 -0700 Comment on attachment 310521 Patch Clearing flags on attachment: 310521 Committed r217109: <http://trac.webkit.org/changeset/217109> 1310536 6 commit-queue 2017-05-19 02:39:33 -0700 All reviewed patches have been landed. Closing bug. 310521 2017-05-18 11:24:43 -0700 2017-05-19 02:39:31 -0700 Patch bug-172294.diff text/plain 4253 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDc2MDdlYWZkMGY1Li4xYjc4YjllOGJhOSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMDUtMTggIERvbiBP bG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBhbS5zb255LmNvbT4KKworICAgICAgICBbSlNDXSBSZW1v dmUgUExBVEZPUk0oV0lOKSByZWZlcmVuY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIyOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGhlYXAvTWFjaGluZVN0YWNrTWFya2VyLmNwcDoKKyAgICAg ICAgKEpTQzo6TWFjaGluZVRocmVhZHM6OnJlbW92ZVRocmVhZCk6CisgICAgICAgICogbGxpbnQv TExJbnRPZmZsaW5lQXNtQ29uZmlnLmg6CisgICAgICAgICogcnVudGltZS9Db25maWdGaWxlLmg6 CisgICAgICAgICogcnVudGltZS9WTS5jcHA6CisgICAgICAgIChKU0M6OlZNOjp1cGRhdGVTdGFj a0xpbWl0cyk6CisKIDIwMTctMDUtMTcgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IGRlYnVnIGFuZCBub24tSklUIGJ1aWxk CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYWNoaW5lU3RhY2tNYXJr ZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFjaGluZVN0YWNrTWFya2VyLmNw cAppbmRleCBhNThmZDliOTFmMC4uNWIxZWU5MDFlMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL01hY2hpbmVTdGFja01hcmtlci5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvTWFjaGluZVN0YWNrTWFya2VyLmNwcApAQCAtMTYyLDcgKzE2Miw3IEBA IHZvaWQgVEhSRUFEX1NQRUNJRklDX0NBTEwgTWFjaGluZVRocmVhZHM6OnJlbW92ZVRocmVhZCh2 b2lkKiBwKQogICAgICAgICAvLyBtYXkgbm90IGJlIGZvdW5kIGluIHRoaXMgTWFjaGluZVRocmVh ZHMgcmVnaXN0cnkuIFdlIG9ubHkgbmVlZCB0bwogICAgICAgICAvLyBkbyBhIHJlbW92YWwgaWYg dGhpcyB0aHJlYWQgaXMgZm91bmQgaW4gaXQuCiAKLSNpZiBQTEFURk9STShXSU4pCisjaWYgT1Mo V0lORE9XUykKICAgICAgICAgLy8gT24gV2luZG93cyB0aGUgdGhyZWFkIHNwZWNpZmljIGRlc3Ry dWN0b3IgaXMgYWxzbyBjYWxsZWQgd2hlbiB0aGUKICAgICAgICAgLy8gbWFpbiB0aHJlYWQgaXMg ZXhpdGluZy4gVGhpcyBtYXkgbGVhZCB0byB0aGUgbWFpbiB0aHJlYWQgd2FpdGluZwogICAgICAg ICAvLyBmb3JldmVyIGZvciB0aGUgbWFjaGluZSB0aHJlYWQgbG9jayB3aGVuIGV4aXRpbmcsIGlm IHRoZSBzYW1wbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xM SW50T2ZmbGluZUFzbUNvbmZpZy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50 T2ZmbGluZUFzbUNvbmZpZy5oCmluZGV4IDYzZTdlYjVjNDJmLi5iMWI1NGFkYWEyMSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50T2ZmbGluZUFzbUNvbmZpZy5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludE9mZmxpbmVBc21Db25maWcu aApAQCAtNDgsMTMgKzQ4LDEzIEBACiAKICNkZWZpbmUgT0ZGTElORV9BU01fQ19MT09QIDAKIAot I2lmIENQVShYODYpICYmICFQTEFURk9STShXSU4pCisjaWYgQ1BVKFg4NikgJiYgIUNPTVBJTEVS KE1TVkMpCiAjZGVmaW5lIE9GRkxJTkVfQVNNX1g4NiAxCiAjZWxzZQogI2RlZmluZSBPRkZMSU5F X0FTTV9YODYgMAogI2VuZGlmCiAKLSNpZiBDUFUoWDg2KSAmJiBQTEFURk9STShXSU4pCisjaWYg Q1BVKFg4NikgJiYgQ09NUElMRVIoTVNWQykKICNkZWZpbmUgT0ZGTElORV9BU01fWDg2X1dJTiAx CiAjZWxzZQogI2RlZmluZSBPRkZMSU5FX0FTTV9YODZfV0lOIDAKQEAgLTkxLDEzICs5MSwxMyBA QAogI2RlZmluZSBPRkZMSU5FX0FTTV9BUk0gMAogI2VuZGlmCiAKLSNpZiBDUFUoWDg2XzY0KSAm JiAhUExBVEZPUk0oV0lOKQorI2lmIENQVShYODZfNjQpICYmICFDT01QSUxFUihNU1ZDKQogI2Rl ZmluZSBPRkZMSU5FX0FTTV9YODZfNjQgMQogI2Vsc2UKICNkZWZpbmUgT0ZGTElORV9BU01fWDg2 XzY0IDAKICNlbmRpZgogCi0jaWYgQ1BVKFg4Nl82NCkgJiYgUExBVEZPUk0oV0lOKQorI2lmIENQ VShYODZfNjQpICYmIENPTVBJTEVSKE1TVkMpCiAjZGVmaW5lIE9GRkxJTkVfQVNNX1g4Nl82NF9X SU4gMQogI2Vsc2UKICNkZWZpbmUgT0ZGTElORV9BU01fWDg2XzY0X1dJTiAwCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25maWdGaWxlLmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9Db25maWdGaWxlLmgKaW5kZXggMDUzNzFmYzJiYmMuLmYyZGIw NjNkZmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25maWdG aWxlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29uZmlnRmlsZS5oCkBA IC00MCw3ICs0MCw3IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgdm9pZCBjYW5vbmljYWxpemVQ YXRocygpOwogCi0jaWYgUExBVEZPUk0oV0lOKQorI2lmIE9TKFdJTkRPV1MpCiAgICAgc3RhdGlj IGNvbnN0IHNpemVfdCBzX21heFBhdGhMZW5ndGggPSAyNjA7IC8vIFdpbmRvd3MgdmFsdWUgZm9y ICJNQVhfUEFUSCIKICNlbHNlCiAgICAgc3RhdGljIGNvbnN0IHNpemVfdCBzX21heFBhdGhMZW5n dGggPSBQQVRIX01BWDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1ZNLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAppbmRleCBiNDEw NWYxNjU5OS4uMDBjOTU3ZDQwMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1ZNLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAK QEAgLTY1Myw3ICs2NTMsNyBAQCBzaXplX3QgVk06OnVwZGF0ZVNvZnRSZXNlcnZlZFpvbmVTaXpl KHNpemVfdCBzb2Z0UmVzZXJ2ZWRab25lU2l6ZSkKICAgICByZXR1cm4gb2xkU29mdFJlc2VydmVk Wm9uZVNpemU7CiB9CiAKLSNpZiBQTEFURk9STShXSU4pCisjaWYgT1MoV0lORE9XUykKIC8vIE9u IFdpbmRvd3MgdGhlIHJlc2VydmVkIHN0YWNrIHNwYWNlIGNvbnNpc3RzIG9mIGNvbW1pdHRlZCBt ZW1vcnksIGEgZ3VhcmQgcGFnZSwgYW5kIHVuY29tbWl0dGVkIG1lbW9yeSwKIC8vIHdoZXJlIHRo ZSBndWFyZCBwYWdlIGlzIGEgYmFycmllciBiZXR3ZWVuIGNvbW1pdHRlZCBhbmQgdW5jb21taXR0 ZWQgbWVtb3J5LgogLy8gV2hlbiBkYXRhIGZyb20gdGhlIGd1YXJkIHBhZ2UgaXMgcmVhZCBvciB3 cml0dGVuLCB0aGUgZ3VhcmQgcGFnZSBpcyBtb3ZlZCwgYW5kIG1lbW9yeSBpcyBjb21taXR0ZWQu CkBAIC02ODAsNyArNjgwLDcgQEAgc3RhdGljIHZvaWQgcHJlQ29tbWl0U3RhY2tNZW1vcnkodm9p ZCogc3RhY2tMaW1pdCkKIAogaW5saW5lIHZvaWQgVk06OnVwZGF0ZVN0YWNrTGltaXRzKCkKIHsK LSNpZiBQTEFURk9STShXSU4pCisjaWYgT1MoV0lORE9XUykKICAgICB2b2lkKiBsYXN0U29mdFN0 YWNrTGltaXQgPSBtX3NvZnRTdGFja0xpbWl0OwogI2VuZGlmCiAKQEAgLTY5NSw3ICs2OTUsNyBA QCBpbmxpbmUgdm9pZCBWTTo6dXBkYXRlU3RhY2tMaW1pdHMoKQogICAgICAgICBtX3N0YWNrTGlt aXQgPSB3dGZUaHJlYWREYXRhKCkuc3RhY2soKS5yZWN1cnNpb25MaW1pdChyZXNlcnZlZFpvbmVT aXplKTsKICAgICB9CiAKLSNpZiBQTEFURk9STShXSU4pCisjaWYgT1MoV0lORE9XUykKICAgICAv LyBXZSBvbmx5IG5lZWQgdG8gcHJlY29tbWl0IHN0YWNrIG1lbW9yeSBkaWN0YXRlZCBieSB0aGUg Vk06Om1fc29mdFN0YWNrTGltaXQgbGltaXQuCiAgICAgLy8gVGhpcyBpcyBiZWNhdXNlIFZNOjpt X3NvZnRTdGFja0xpbWl0IGFwcGxpZXMgdG8gc3RhY2sgdXNhZ2UgYnkgTExJTlQgYXNtIG9yIEpJ VAogICAgIC8vIGdlbmVyYXRlZCBjb2RlIHdoaWNoIGNhbiBhbGxvY2F0ZSBzdGFjayBzcGFjZSB0 aGF0IHRoZSBDKysgY29tcGlsZXIgZG9lcyBub3Qga25vdwo=