172288 2017-05-18 09:09:05 -0700 [Readable Streams API] Align respondInClosedState with spec 2017-05-23 09:24:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 romain.wkt romain.wkt cdumez commit-queue nael.ouedp youennf oldest_to_newest 1310105 0 romain.wkt 2017-05-18 09:09:05 -0700 The issue reported to GH [1] while working on bug 168781 has now been fixed. WebKit implementation should be aligned with corresponding fix. [1] https://github.com/whatwg/streams/issues/686 1310106 1 310512 romain.wkt 2017-05-18 09:21:35 -0700 Created attachment 310512 Patch 1311394 2 310512 cdumez 2017-05-22 09:41:40 -0700 Comment on attachment 310512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310512&action=review > Source/WebCore/ChangeLog:17 > + No added test (already covered by existing tests). You cannot say that the behavior change is covered by existing tests but then not rebaseline those tests in the patch. Either: 1. This patch does not change Web-facing behavior 2. The existing tests do not cover the behavior change and more testing should be added 1311395 3 310512 cdumez 2017-05-22 09:48:09 -0700 Comment on attachment 310512 Patch r=me. Code change looks fine but please fix the Changelog to explain that this is not testable (if I understand correctly). If it is testable, please add a test. 1311857 4 311009 romain.wkt 2017-05-23 07:36:37 -0700 Created attachment 311009 Patch 1311887 5 romain.wkt 2017-05-23 09:04:45 -0700 Thanks for the comment, I updated the ChangeLog to clarify why there was no added test nor updated test expectations (one change does not impact behavior, and the other one is not reachable for the moment). 1311897 6 311009 commit-queue 2017-05-23 09:24:42 -0700 Comment on attachment 311009 Patch Clearing flags on attachment: 311009 Committed r217279: <http://trac.webkit.org/changeset/217279> 1311898 7 commit-queue 2017-05-23 09:24:44 -0700 All reviewed patches have been landed. Closing bug. 310512 2017-05-18 09:21:35 -0700 2017-05-23 07:36:33 -0700 Patch bug-172288-20170518182133.patch text/plain 3127 romain.wkt U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmY0OTVjNzEyOGUxMTEy YzgyYTFkYzIxOWUyNjNjMWI2Mzg0ZjYwYi4uYmI3ZmU4ZTZkMDg0NDM1YWExNjEwMWExMDEyYjk0 OTgyYTc5MzFkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTA1LTE4ICBSb21h aW4gQmVsbGVzc29ydCAgPHJvbWFpbi5iZWxsZXNzb3J0QGNyZi5jYW5vbi5mcj4KKworICAgICAg ICBbUmVhZGFibGUgU3RyZWFtcyBBUEldIEFsaWduIHJlc3BvbmRJbkNsb3NlZFN0YXRlIHdpdGgg c3BlYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcy Mjg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQW4g aXNzdWUgd2FzIHJlcG9ydGVkIHRvIEdIIFsxXSB3aGlsZSB3b3JraW5nIG9uIHJlc3BvbmRJbkNs b3NlZFN0YXRlIGltcGxlbWVudGF0aW9uLgorICAgICAgICBUaGlzIGlzc3VlIGhhcyBub3cgYmVl biBmaXhlZCwgYW5kIHRoaXMgcGF0Y2ggYWxpZ25zIGltcGxlbWVudGF0aW9uIHdpdGggdGhlIHNw ZWMgWzJdLgorICAgICAgICBJbiBhZGRpdGlvbiwgdGhpcyBwYXRjaCBmaXhlcyBhIGJ1ZyB0aGF0 IHdlbnQgdW5ub3RpY2VkIGFzIGNvZGUgaXMgbm90IHlldCByZWFjaGFibGUKKyAgICAgICAgKHVz YWdlIG9mIGNvbnRyb2xsZXIuQHJlYWRlciBpcyBub3QgdmFsaWQgYW5kIGlzIHRoZXJlZm9yZSBy ZXBsYWNlZCBieQorICAgICAgICBjb250cm9sbGVyLkBjb250cm9sbGVkUmVhZGFibGVTdHJlYW0u QHJlYWRlcikuCisKKyAgICAgICAgWzFdIGh0dHBzOi8vZ2l0aHViLmNvbS93aGF0d2cvc3RyZWFt cy9pc3N1ZXMvNjg2CisgICAgICAgIFsyXSBodHRwczovL3N0cmVhbXMuc3BlYy53aGF0d2cub3Jn LyNyZWFkYWJsZS1ieXRlLXN0cmVhbS1jb250cm9sbGVyLXJlc3BvbmQtaW4tY2xvc2VkLXN0YXRl CisKKyAgICAgICAgTm8gYWRkZWQgdGVzdCAoYWxyZWFkeSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRl c3RzKS4KKworICAgICAgICAqIE1vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZUJ5dGVTdHJlYW1JbnRl cm5hbHMuanM6CisgICAgICAgIChyZWFkYWJsZUJ5dGVTdHJlYW1Db250cm9sbGVyUmVzcG9uZElu Q2xvc2VkU3RhdGUpOiBBbGlnbmVkIHdpdGggc3BlYy4KKwogMjAxNy0wNS0xOCAgQW50dGkgS29p dmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRGVzaWduIG1vZGUgc2hvdWxkIG5v dCBhZmZlY3QgVUEgc2hhZG93IHRyZWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3N0cmVhbXMvUmVhZGFibGVCeXRlU3RyZWFtSW50ZXJuYWxzLmpzIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlQnl0ZVN0cmVhbUludGVybmFscy5qcwppbmRleCA2 YjEwZDQ3ODkzY2JlOTE2ZjFlMzA1OWM4ZDg5NTAzMzlhOGNlYTNjLi44MjZmZTA3NjlkMDY0M2Nm NGE1YjNhN2I3ZWE4Y2Q1Mzk1OTY2ZWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3N0cmVhbXMvUmVhZGFibGVCeXRlU3RyZWFtSW50ZXJuYWxzLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZUJ5dGVTdHJlYW1JbnRlcm5hbHMuanMKQEAg LTQ1NiwxNiArNDU2LDExIEBAIGZ1bmN0aW9uIHJlYWRhYmxlQnl0ZVN0cmVhbUNvbnRyb2xsZXJS ZXNwb25kSW5DbG9zZWRTdGF0ZShjb250cm9sbGVyLCBmaXJzdERlc2NyCiAgICAgZmlyc3REZXNj cmlwdG9yLmJ1ZmZlciA9IEB0cmFuc2ZlckJ1ZmZlclRvQ3VycmVudFJlYWxtKGZpcnN0RGVzY3Jp cHRvci5idWZmZXIpOwogICAgIEBhc3NlcnQoZmlyc3REZXNjcmlwdG9yLmJ5dGVzRmlsbGVkID09 PSAwKTsKIAotICAgIC8vIEZJWE1FOiBTcGVjIGRvZXMgbm90IGRlc2NyaWJlIGJlbG93IHRlc3Qu IEhvd2V2ZXIsIG9ubHkgUmVhZGFibGVTdHJlYW1CWU9CUmVhZGVyIGhhcyBhIHJlYWRJbnRvUmVx dWVzdHMKLSAgICAvLyBwcm9wZXJ0eS4gVGhpcyBpc3N1ZSBoYXMgYmVlbiByZXBvcnRlZCB0aHJv dWdoIFdIQVRXRy9zdHJlYW1zIEdpdEh1YgotICAgIC8vIChodHRwczovL2dpdGh1Yi5jb20vd2hh dHdnL3N0cmVhbXMvaXNzdWVzLzY4NiksIGJ1dCBubyBzb2x1dGlvbiBoYXMgYmVlbiBwcm92aWRl ZCBmb3IgdGhlIG1vbWVudC4KLSAgICAvLyBUaGVyZWZvcmUsIGJlbG93IHRlc3QgaXMgYWRkZWQg YXMgYSB0ZW1wb3JhcnkgZml4LgotICAgIGlmICghQGlzUmVhZGFibGVTdHJlYW1CWU9CUmVhZGVy KGNvbnRyb2xsZXIuQHJlYWRlcikpCi0gICAgICAgIHJldHVybjsKLQotICAgIHdoaWxlIChjb250 cm9sbGVyLkByZWFkZXIuQHJlYWRJbnRvUmVxdWVzdHMubGVuZ3RoID4gMCkgewotICAgICAgICBs ZXQgcHVsbEludG9EZXNjcmlwdG9yID0gQHJlYWRhYmxlQnl0ZVN0cmVhbUNvbnRyb2xsZXJTaGlm dFBlbmRpbmdEZXNjcmlwdG9yKGNvbnRyb2xsZXIpOwotICAgICAgICBAcmVhZGFibGVCeXRlU3Ry ZWFtQ29udHJvbGxlckNvbW1pdERlc2NyaXB0b3IoY29udHJvbGxlci5AY29udHJvbGxlZFJlYWRh YmxlU3RyZWFtLCBwdWxsSW50b0Rlc2NyaXB0b3IpOworICAgIGlmIChAcmVhZGFibGVTdHJlYW1I YXNCWU9CUmVhZGVyKGNvbnRyb2xsZXIuQGNvbnRyb2xsZWRSZWFkYWJsZVN0cmVhbSkpIHsKKyAg ICAgICAgd2hpbGUgKGNvbnRyb2xsZXIuQGNvbnRyb2xsZWRSZWFkYWJsZVN0cmVhbS5AcmVhZGVy LkByZWFkSW50b1JlcXVlc3RzLmxlbmd0aCA+IDApIHsKKyAgICAgICAgICAgIGxldCBwdWxsSW50 b0Rlc2NyaXB0b3IgPSBAcmVhZGFibGVCeXRlU3RyZWFtQ29udHJvbGxlclNoaWZ0UGVuZGluZ0Rl c2NyaXB0b3IoY29udHJvbGxlcik7CisgICAgICAgICAgICBAcmVhZGFibGVCeXRlU3RyZWFtQ29u dHJvbGxlckNvbW1pdERlc2NyaXB0b3IoY29udHJvbGxlci5AY29udHJvbGxlZFJlYWRhYmxlU3Ry ZWFtLCBwdWxsSW50b0Rlc2NyaXB0b3IpOworICAgICAgICB9CiAgICAgfQogfQogCg== 311009 2017-05-23 07:36:37 -0700 2017-05-23 09:24:42 -0700 Patch bug-172288-20170523163636.patch text/plain 3334 romain.wkt U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3Mjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTJjYTY2MTA4MmQ3NzVj ZDEwMmVmYWQ0MDljYmRkN2QzMzhkMDgyMS4uMTM1N2Q0YTMxOGNhNWQwMjJiNDhmMmZlNGQ5ZjY1 OTRhZjBhZjhiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE3LTA1LTIzICBSb21h aW4gQmVsbGVzc29ydCAgPHJvbWFpbi5iZWxsZXNzb3J0QGNyZi5jYW5vbi5mcj4KKworICAgICAg ICBbUmVhZGFibGUgU3RyZWFtcyBBUEldIEFsaWduIHJlc3BvbmRJbkNsb3NlZFN0YXRlIHdpdGgg c3BlYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcy Mjg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgVHdvIGNo YW5nZXMgYXJlIGltcGxlbWVudGVkIGluIHRoaXMgcGF0Y2g6CisgICAgICAgIC0gQ2hhbmdlICMx OiBBbiBpc3N1ZSB3YXMgcmVwb3J0ZWQgdG8gR0ggWzFdIHdoaWxlIHdvcmtpbmcgb24gcmVzcG9u ZEluQ2xvc2VkU3RhdGUgCisgICAgICAgIGltcGxlbWVudGF0aW9uLiBUaGlzIGlzc3VlIGhhcyBu b3cgYmVlbiBmaXhlZCwgYW5kIHRoaXMgcGF0Y2ggYWxpZ25zIGltcGxlbWVudGF0aW9uIAorICAg ICAgICB3aXRoIHNwZWMgWzJdLgorICAgICAgICAtIENoYW5nZSAjMjogSW4gYWRkaXRpb24sIHRo aXMgcGF0Y2ggYWxzbyBmaXhlcyBhIGJ1ZyB0aGF0IHdlbnQgdW5ub3RpY2VkIGFzIGNvZGUgCisg ICAgICAgIGlzIG5vdCB5ZXQgcmVhY2hhYmxlICh1c2FnZSBvZiBjb250cm9sbGVyLkByZWFkZXIg aXMgbm90IHZhbGlkIGFuZCBpcyB0aGVyZWZvcmUgCisgICAgICAgIHJlcGxhY2VkIGJ5IGNvbnRy b2xsZXIuQGNvbnRyb2xsZWRSZWFkYWJsZVN0cmVhbS5AcmVhZGVyKS4KKworICAgICAgICBbMV0g aHR0cHM6Ly9naXRodWIuY29tL3doYXR3Zy9zdHJlYW1zL2lzc3Vlcy82ODYKKyAgICAgICAgWzJd IGh0dHBzOi8vc3RyZWFtcy5zcGVjLndoYXR3Zy5vcmcvI3JlYWRhYmxlLWJ5dGUtc3RyZWFtLWNv bnRyb2xsZXItcmVzcG9uZC1pbi1jbG9zZWQtc3RhdGUKKworICAgICAgICBObyBhZGRlZCB0ZXN0 IGFzOgorICAgICAgICAtIENoYW5nZSAjMSBkb2VzIG5vdCBjaGFuZ2UgYmVoYXZpb3I7CisgICAg ICAgIC0gQ2hhbmdlICMyIGlzIG5vdCB0ZXN0YWJsZSBhcyB0aGUgY29kZSBpcyBub3QgeWV0IHJl YWNoYWJsZS4KKworICAgICAgICAqIE1vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZUJ5dGVTdHJlYW1J bnRlcm5hbHMuanM6CisgICAgICAgIChyZWFkYWJsZUJ5dGVTdHJlYW1Db250cm9sbGVyUmVzcG9u ZEluQ2xvc2VkU3RhdGUpOiBBbGlnbmVkIHdpdGggc3BlYy4KKwogMjAxNy0wNS0yMiBFbWlsaW8g Q29ib3Mgw4FsdmFyZXogIDxlY29ib3NAaWdhbGlhLmNvbT4KIAogICAgICAgICBBZGQgYSBSdW50 aW1lRW5hYmxlZEZlYXR1cmUgZm9yIGRpc3BsYXk6IGNvbnRlbnRzLCBkZWZhdWx0ZWQgdG8gZmFs c2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVC eXRlU3RyZWFtSW50ZXJuYWxzLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1Jl YWRhYmxlQnl0ZVN0cmVhbUludGVybmFscy5qcwppbmRleCA2YjEwZDQ3ODkzY2JlOTE2ZjFlMzA1 OWM4ZDg5NTAzMzlhOGNlYTNjLi44MjZmZTA3NjlkMDY0M2NmNGE1YjNhN2I3ZWE4Y2Q1Mzk1OTY2 ZWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVC eXRlU3RyZWFtSW50ZXJuYWxzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFt cy9SZWFkYWJsZUJ5dGVTdHJlYW1JbnRlcm5hbHMuanMKQEAgLTQ1NiwxNiArNDU2LDExIEBAIGZ1 bmN0aW9uIHJlYWRhYmxlQnl0ZVN0cmVhbUNvbnRyb2xsZXJSZXNwb25kSW5DbG9zZWRTdGF0ZShj b250cm9sbGVyLCBmaXJzdERlc2NyCiAgICAgZmlyc3REZXNjcmlwdG9yLmJ1ZmZlciA9IEB0cmFu c2ZlckJ1ZmZlclRvQ3VycmVudFJlYWxtKGZpcnN0RGVzY3JpcHRvci5idWZmZXIpOwogICAgIEBh c3NlcnQoZmlyc3REZXNjcmlwdG9yLmJ5dGVzRmlsbGVkID09PSAwKTsKIAotICAgIC8vIEZJWE1F OiBTcGVjIGRvZXMgbm90IGRlc2NyaWJlIGJlbG93IHRlc3QuIEhvd2V2ZXIsIG9ubHkgUmVhZGFi bGVTdHJlYW1CWU9CUmVhZGVyIGhhcyBhIHJlYWRJbnRvUmVxdWVzdHMKLSAgICAvLyBwcm9wZXJ0 eS4gVGhpcyBpc3N1ZSBoYXMgYmVlbiByZXBvcnRlZCB0aHJvdWdoIFdIQVRXRy9zdHJlYW1zIEdp dEh1YgotICAgIC8vIChodHRwczovL2dpdGh1Yi5jb20vd2hhdHdnL3N0cmVhbXMvaXNzdWVzLzY4 NiksIGJ1dCBubyBzb2x1dGlvbiBoYXMgYmVlbiBwcm92aWRlZCBmb3IgdGhlIG1vbWVudC4KLSAg ICAvLyBUaGVyZWZvcmUsIGJlbG93IHRlc3QgaXMgYWRkZWQgYXMgYSB0ZW1wb3JhcnkgZml4Lgot ICAgIGlmICghQGlzUmVhZGFibGVTdHJlYW1CWU9CUmVhZGVyKGNvbnRyb2xsZXIuQHJlYWRlcikp Ci0gICAgICAgIHJldHVybjsKLQotICAgIHdoaWxlIChjb250cm9sbGVyLkByZWFkZXIuQHJlYWRJ bnRvUmVxdWVzdHMubGVuZ3RoID4gMCkgewotICAgICAgICBsZXQgcHVsbEludG9EZXNjcmlwdG9y ID0gQHJlYWRhYmxlQnl0ZVN0cmVhbUNvbnRyb2xsZXJTaGlmdFBlbmRpbmdEZXNjcmlwdG9yKGNv bnRyb2xsZXIpOwotICAgICAgICBAcmVhZGFibGVCeXRlU3RyZWFtQ29udHJvbGxlckNvbW1pdERl c2NyaXB0b3IoY29udHJvbGxlci5AY29udHJvbGxlZFJlYWRhYmxlU3RyZWFtLCBwdWxsSW50b0Rl c2NyaXB0b3IpOworICAgIGlmIChAcmVhZGFibGVTdHJlYW1IYXNCWU9CUmVhZGVyKGNvbnRyb2xs ZXIuQGNvbnRyb2xsZWRSZWFkYWJsZVN0cmVhbSkpIHsKKyAgICAgICAgd2hpbGUgKGNvbnRyb2xs ZXIuQGNvbnRyb2xsZWRSZWFkYWJsZVN0cmVhbS5AcmVhZGVyLkByZWFkSW50b1JlcXVlc3RzLmxl bmd0aCA+IDApIHsKKyAgICAgICAgICAgIGxldCBwdWxsSW50b0Rlc2NyaXB0b3IgPSBAcmVhZGFi bGVCeXRlU3RyZWFtQ29udHJvbGxlclNoaWZ0UGVuZGluZ0Rlc2NyaXB0b3IoY29udHJvbGxlcik7 CisgICAgICAgICAgICBAcmVhZGFibGVCeXRlU3RyZWFtQ29udHJvbGxlckNvbW1pdERlc2NyaXB0 b3IoY29udHJvbGxlci5AY29udHJvbGxlZFJlYWRhYmxlU3RyZWFtLCBwdWxsSW50b0Rlc2NyaXB0 b3IpOworICAgICAgICB9CiAgICAgfQogfQogCg==