172286 2017-05-18 06:28:49 -0700 [Win] Many layout tests are failing. 2017-05-18 11:28:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham lforschler oldest_to_newest 1310076 0 pvollan 2017-05-18 06:28:49 -0700 The following line of text appears unexpectedly in many test results: ERROR: TestRunner::grantWebNotificationPermission(JSStringRef) not implemented 1310077 1 310504 pvollan 2017-05-18 06:34:15 -0700 Created attachment 310504 Patch 1310115 2 310504 bfulgham 2017-05-18 09:39:43 -0700 Comment on attachment 310504 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310504&action=review > Tools/ChangeLog:8 > + Add a FIXME comment about unimplemented functions, instead of writing this to the test result file. Can you please file a Bugzilla to implement the work, and then include it in the Fixme's below? 1310162 3 pvollan 2017-05-18 11:28:01 -0700 (In reply to Brent Fulgham from comment #2) > Comment on attachment 310504 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=310504&action=review > > > Tools/ChangeLog:8 > > + Add a FIXME comment about unimplemented functions, instead of writing this to the test result file. > > Can you please file a Bugzilla to implement the work, and then include it in > the Fixme's below? Thanks for reviewing! I will update the patch with Bugzilla links before landing. 1310163 4 pvollan 2017-05-18 11:28:23 -0700 Committed <https://trac.webkit.org/changeset/217053/webkit> 310504 2017-05-18 06:34:15 -0700 2017-05-18 09:39:43 -0700 Patch bug-172286-20170518063417.patch text/plain 2067 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNzA0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTA1LTE4ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBNYW55IGxheW91dCB0ZXN0cyBhcmUgZmFpbGluZy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjI4NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIEZJWE1FIGNv bW1lbnQgYWJvdXQgdW5pbXBsZW1lbnRlZCBmdW5jdGlvbnMsIGluc3RlYWQgb2Ygd3JpdGluZyB0 aGlzIHRvIHRoZSB0ZXN0IHJlc3VsdCBmaWxlLgorIAorICAgICAgICAqIER1bXBSZW5kZXJUcmVl L3dpbi9UZXN0UnVubmVyV2luLmNwcDoKKyAgICAgICAgKFRlc3RSdW5uZXI6OmdyYW50V2ViTm90 aWZpY2F0aW9uUGVybWlzc2lvbik6CisgICAgICAgIChUZXN0UnVubmVyOjpkZW55V2ViTm90aWZp Y2F0aW9uUGVybWlzc2lvbik6CisgICAgICAgIChUZXN0UnVubmVyOjpyZW1vdmVBbGxXZWJOb3Rp ZmljYXRpb25QZXJtaXNzaW9ucyk6CisgICAgICAgIChUZXN0UnVubmVyOjpzaW11bGF0ZVdlYk5v dGlmaWNhdGlvbkNsaWNrKToKKwogMjAxNy0wNS0xOCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0 ZWFkQGFtLnNvbnkuY29tPgogCiAgICAgICAgIFtXaW5dIFJlbW92ZSB1c2FnZSBvZiBfc25wcmlu dGYKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9UZXN0UnVubmVyV2luLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vVGVzdFJ1bm5lcldpbi5jcHAJKHJl dmlzaW9uIDIxNzAzNikKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9UZXN0UnVubmVyV2lu LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM2OCwyMiArMTM2OCwyMiBAQCB2b2lkIFRlc3RSdW5u ZXI6OnNldFBhZ2VWaXNpYmlsaXR5KGNvbnN0CiAKIHZvaWQgVGVzdFJ1bm5lcjo6Z3JhbnRXZWJO b3RpZmljYXRpb25QZXJtaXNzaW9uKEpTU3RyaW5nUmVmIG9yaWdpbikKIHsKLSAgICBmcHJpbnRm KHRlc3RSZXN1bHQsICJFUlJPUjogVGVzdFJ1bm5lcjo6Z3JhbnRXZWJOb3RpZmljYXRpb25QZXJt aXNzaW9uKEpTU3RyaW5nUmVmKSBub3QgaW1wbGVtZW50ZWRcbiIpOworICAgIC8vIEZJWE1FOiBJ bXBsZW1lbnQuCiB9CiAKIHZvaWQgVGVzdFJ1bm5lcjo6ZGVueVdlYk5vdGlmaWNhdGlvblBlcm1p c3Npb24oSlNTdHJpbmdSZWYganNPcmlnaW4pCiB7Ci0gICAgZnByaW50Zih0ZXN0UmVzdWx0LCAi RVJST1I6IFRlc3RSdW5uZXI6OmRlbnlXZWJOb3RpZmljYXRpb25QZXJtaXNzaW9uKEpTU3RyaW5n UmVmKSBub3QgaW1wbGVtZW50ZWRcbiIpOworICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCiB9CiAK IHZvaWQgVGVzdFJ1bm5lcjo6cmVtb3ZlQWxsV2ViTm90aWZpY2F0aW9uUGVybWlzc2lvbnMoKQog ewotICAgIGZwcmludGYodGVzdFJlc3VsdCwgIkVSUk9SOiBUZXN0UnVubmVyOjpyZW1vdmVBbGxX ZWJOb3RpZmljYXRpb25QZXJtaXNzaW9ucygpIG5vdCBpbXBsZW1lbnRlZFxuIik7CisgICAgLy8g RklYTUU6IEltcGxlbWVudC4KIH0KIAogdm9pZCBUZXN0UnVubmVyOjpzaW11bGF0ZVdlYk5vdGlm aWNhdGlvbkNsaWNrKEpTVmFsdWVSZWYganNOb3RpZmljYXRpb24pCiB7Ci0gICAgZnByaW50Zih0 ZXN0UmVzdWx0LCAiRVJST1I6IFRlc3RSdW5uZXI6OnNpbXVsYXRlV2ViTm90aWZpY2F0aW9uQ2xp Y2soKSBub3QgaW1wbGVtZW50ZWRcbiIpOworICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCiB9CiAK IHZvaWQgVGVzdFJ1bm5lcjo6c2ltdWxhdGVMZWdhY3lXZWJOb3RpZmljYXRpb25DbGljayhKU1N0 cmluZ1JlZiB0aXRsZSkK