172281 2017-05-18 03:43:20 -0700 [ATK] Test accessibility/insert-children-assert.html is crashing since added in r216980 2019-04-10 00:59:20 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 magomez webkit-unassigned aboxhall apinheiro bugs-noreply cfleizach cgarcia dmazzoni ews-watchlist jcraig jdiggs mcatanzaro Ms2ger samuel_white webkit-bug-importer oldest_to_newest 1310055 0 magomez 2017-05-18 03:43:20 -0700 Test accessibility/insert-children-assert.html is crashing since added in r216980 1392492 1 Ms2ger 2018-01-24 01:44:04 -0800 Backtrace: STDERR: ASSERTION FAILED: lastChildRenderer->node() STDERR: /Source/WebCore/accessibility/AccessibilityRenderObject.cpp(644) : virtual WTF::String WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const STDERR: 1 0x7f20190684ab /WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7f20190684ab] STDERR: 2 0x7f2026b7b2e9 /WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const+0x301) [0x7f2026b7b2e9] STDERR: 3 0x7f2026bc9fd1 /WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x93c8fd1) [0x7f2026bc9fd1] STDERR: 4 0x7f1fc5a23a07 /WebKitBuild/Debug/lib/libTestRunnerInjectedBundle.so(WTR::AccessibilityUIElement::stringValue()+0xef) [0x7f1fc5a23a07] STDERR: 5 0x7f1fc5a0a42e /WebKitBuild/Debug/lib/libTestRunnerInjectedBundle.so(WTR::JSAccessibilityUIElement::stringValue(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSString*, OpaqueJSValue const**)+0x6a) [0x7f1fc5a0a42e] STDERR: 6 0x7f2017f13280 /WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(JSC::JSCallbackObject<JSC::JSDestructibleObject>::getStaticValue(JSC::ExecState*, JSC::PropertyName)+0x1c2) [0x7f2017f13280] STDERR: 7 0x7f2017f0acf2 /WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(JSC::JSCallbackObject<JSC::JSDestructibleObject>::getOwnPropertySlot(JSC::JSObject*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&)+0x498) [0x7f2017f0acf2] STDERR: 8 0x7f2025904798 /WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(JSC::JSObject::getNonIndexPropertySlot(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&)+0x1c6) [0x7f2025904798] STDERR: 9 0x7f2025903ea4 /WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(JSC::JSObject::getPropertySlot(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&)+0xd8) [0x7f2025903ea4] STDERR: 10 0x7f20185bf387 /WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(JSC::JSValue::getPropertySlot(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) const+0x1e9) [0x7f20185bf387] STDERR: 11 0x7f20185bf0e2 /WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(JSC::JSValue::get(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) const+0xac) [0x7f20185bf0e2] STDERR: 12 0x7f2018ab7b36 /WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x27fcb36) [0x7f2018ab7b36] STDERR: 13 0x7f2018aae742 /WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x27f3742) [0x7f2018aae742] STDERR: LEAK: 1 WebPageProxy 1394566 2 webkit-bug-importer 2018-01-30 09:10:19 -0800 <rdar://problem/37030990> 1525589 3 cgarcia 2019-04-09 01:28:24 -0700 The crash happens because at some point the test tries to get the anonymous block text getting the RenderText as first child and RenderFullScreen as last child and the latter doesn't have a node. This is because in atk we do thing differently, we don't include the static text elements individually, and parent element uses textUnderElement() to get all the pieces together. I think we could just turn the asserts into actual null checks. That won't fix the test (because it expects the mac behavior of having static text nodes in the tree), but at least it won't crash. 1525592 4 367036 cgarcia 2019-04-09 01:59:36 -0700 Created attachment 367036 Patch 1525894 5 cgarcia 2019-04-10 00:59:20 -0700 Committed r244105: <https://trac.webkit.org/changeset/244105> 367036 2019-04-09 01:59:36 -0700 2019-04-09 04:56:12 -0700 Patch wcore-atk-crash.diff text/plain 4724 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3YmQwYTJjYWU1Mi4uNGIwMDIzMWU2ZDUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAxOS0wNC0wOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0FUS10gVGVzdCBhY2Nlc3NpYmlsaXR5L2luc2VydC1jaGlsZHJlbi1hc3NlcnQu aHRtbCBpcyBjcmFzaGluZyBzaW5jZSBhZGRlZCBpbiByMjE2OTgwCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIyODEKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzM3MDMwOTkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVwZGF0ZSB0aGUgdGVzdCB0byBleHBlY3QgdGhlIHdob2xlIGNvbnRlbnQgdGV4 dCBvbiBhdGsgYW5kIHJlbW92ZSB0aGUgdGVzdCBleHBlY3RhdGlvbnMuCisKKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L2luc2VydC1jaGlsZHJlbi1hc3NlcnQuaHRtbDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxOS0wNC0wNiAgQW50dGkgS29pdmlzdG8g IDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgQ29tYmluZSBldmVudCBhbmQgdG91Y2ggYWN0 aW9uIHJlZ2lvbnMgaW50byBhIHNpbmdsZSBjbGFzcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9pbnNlcnQtY2hpbGRyZW4tYXNzZXJ0Lmh0bWwgYi9MYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L2luc2VydC1jaGlsZHJlbi1hc3NlcnQuaHRtbAppbmRleCBmOTYyM2QyZmE0 Zi4uOTIyMGJjMzNjY2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvaW5z ZXJ0LWNoaWxkcmVuLWFzc2VydC5odG1sCisrKyBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkv aW5zZXJ0LWNoaWxkcmVuLWFzc2VydC5odG1sCkBAIC0yNyw3ICsyNywxMSBAQCBib2R5IHsKIAog ICAgIGlmICgid2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4iIGluIEVsZW1lbnQucHJvdG90eXBlKSB7 CiAgICAgICAgIHZhciBjb250ZW50ID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJs ZUVsZW1lbnRCeUlkKCJjb250ZW50Iik7Ci0gICAgICAgIHZhciB2YWx1ZSA9ICJBWFZhbHVlOiBk IjsKKyAgICAgICAgdmFyIHZhbHVlOworICAgICAgICBpZiAoYWNjZXNzaWJpbGl0eUNvbnRyb2xs ZXIucGxhdGZvcm1OYW1lID09ICJhdGsiKQorICAgICAgICAgICAgdmFsdWUgPSAiQVhWYWx1ZTog YWI8XFxuPmM8XFxuPmRlPFxcbj4iOworICAgICAgICBlbHNlCisgICAgICAgICAgICB2YWx1ZSA9 ICJBWFZhbHVlOiBkIjsKICAgICAgICAgZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7CiAgICAgICAg IHZhciBzcGFuID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3NwYW4nKVswXTsKIApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA3ZmFlNDA5NGQx ZC4uMTMzMmZhZDM0ODIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0 RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zCkBAIC0xMjg3LDggKzEyODcsNiBAQCB3ZWJraXQub3JnL2IvMTMxNTQ2IG1lZGlhL3RyYWNr L3RyYWNrLWluLWJhbmQuaHRtbCBbIENyYXNoIFRpbWVvdXQgRmFpbHVyZSBdCiAKIHdlYmtpdC5v cmcvYi8xNjM3ODIgbWVkaWEvdmlkZW8tcGxheWVkLXJhbmdlcy0xLmh0bWwgWyBDcmFzaCBQYXNz IEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTcyMjgxIGFjY2Vzc2liaWxpdHkvaW5zZXJ0LWNo aWxkcmVuLWFzc2VydC5odG1sIFsgQ3Jhc2ggXQotCiB3ZWJraXQub3JnL2IvMTcyOTU1IG1lZGlh L3ZpZGVvLXByZWxvYWQuaHRtbCBbIENyYXNoIFBhc3MgXQogCiB3ZWJraXQub3JnL2IvMTc1NTc1 IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQt Y29udGVudC9tZWRpYS1lbGVtZW50cy9yZWFkeS1zdGF0ZXMvYXV0b3BsYXktd2l0aC1zbG93LXRl eHQtdHJhY2tzLmh0bWwgWyBDcmFzaCBQYXNzIF0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMzg0YWJkZWQxNi4u NjIzYTJjY2Y1NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxOS0wNC0wOSAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0FUS10g VGVzdCBhY2Nlc3NpYmlsaXR5L2luc2VydC1jaGlsZHJlbi1hc3NlcnQuaHRtbCBpcyBjcmFzaGlu ZyBzaW5jZSBhZGRlZCBpbiByMjE2OTgwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzIyODEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM3MDMwOTkw PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBj cmFzaCBoYXBwZW5zIGJlY2F1c2UgYXQgc29tZSBwb2ludCB0aGUgdGVzdCB0cmllcyB0byBnZXQg dGhlIGFub255bW91cyBibG9jayB0ZXh0LCBnZXR0aW5nIHRoZSBSZW5kZXJUZXh0IGFzCisgICAg ICAgIGZpcnN0IGNoaWxkIGFuZCBSZW5kZXJGdWxsU2NyZWVuIGFzIGxhc3QgY2hpbGQgYW5kIHRo ZSBsYXR0ZXIgZG9lc24ndCBoYXZlIGEgbm9kZS4gVGhpcyBpcyBiZWNhdXNlIGluIGF0ayB3ZSBk bworICAgICAgICB0aGluZ3MgZGlmZmVyZW50bHksIHdlIGRvbid0IGluY2x1ZGUgdGhlIHN0YXRp YyB0ZXh0IGVsZW1lbnRzIGluZGl2aWR1YWxseSwgYnV0IHBhcmVudCBlbGVtZW50IHVzZXMKKyAg ICAgICAgdGV4dFVuZGVyRWxlbWVudCgpIHRvIGdldCBhbGwgdGhlIHBpZWNlcyB0b2dldGhlci4g V2UgY2FuIGp1c3QgdHVybiB0aGUgYXNzZXJ0cyBpbnRvIGFjdHVhbCBudWxscHRyIGNoZWNrcy4K KworICAgICAgICBGaXhlczogYWNjZXNzaWJpbGl0eS9pbnNlcnQtY2hpbGRyZW4tYXNzZXJ0Lmh0 bWwKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojp0ZXh0VW5k ZXJFbGVtZW50IGNvbnN0KToKKwogMjAxOS0wNC0wNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0FUS10gQ2xlYW51cCBXZWJLaXRBY2Nlc3Np YmxlSHlwZXJsaW5rCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAppbmRleCBiMDQ0NzAzYzY2Mi4uYWJkMzll YWIwM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eVJlbmRlck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcApAQCAtNjQwLDEwICs2NDAsNyBAQCBTdHJpbmcg QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dGV4dFVuZGVyRWxlbWVudChBY2Nlc3NpYmlsaXR5 VGV4dFVuZGVyRWxlbWVudAogICAgICAgICAgICAgLy8gZGVmaW5pbmcgb25lIGJhc2VkIGluIHRo ZSB0d28gZXh0ZXJuYWwgcG9zaXRpb25zIGRlZmluaW5nIHRoZSBib3VuZGFyaWVzIG9mIHRoZSBz dWJ0cmVlLgogICAgICAgICAgICAgUmVuZGVyT2JqZWN0KiBmaXJzdENoaWxkUmVuZGVyZXIgPSBt X3JlbmRlcmVyLT5maXJzdENoaWxkU2xvdygpOwogICAgICAgICAgICAgUmVuZGVyT2JqZWN0KiBs YXN0Q2hpbGRSZW5kZXJlciA9IG1fcmVuZGVyZXItPmxhc3RDaGlsZFNsb3coKTsKLSAgICAgICAg ICAgIGlmIChmaXJzdENoaWxkUmVuZGVyZXIgJiYgbGFzdENoaWxkUmVuZGVyZXIpIHsKLSAgICAg ICAgICAgICAgICBBU1NFUlQoZmlyc3RDaGlsZFJlbmRlcmVyLT5ub2RlKCkpOwotICAgICAgICAg ICAgICAgIEFTU0VSVChsYXN0Q2hpbGRSZW5kZXJlci0+bm9kZSgpKTsKLQorICAgICAgICAgICAg aWYgKGZpcnN0Q2hpbGRSZW5kZXJlciAmJiBmaXJzdENoaWxkUmVuZGVyZXItPm5vZGUoKSAmJiBs YXN0Q2hpbGRSZW5kZXJlciAmJiBsYXN0Q2hpbGRSZW5kZXJlci0+bm9kZSgpKSB7CiAgICAgICAg ICAgICAgICAgLy8gV2UgZGVmaW5lIHRoZSBzdGFydCBhbmQgZW5kIHBvc2l0aW9ucyBmb3IgdGhl IHJhbmdlIGFzIHRoZSBvbmVzIHJpZ2h0IGJlZm9yZSBhbmQgYWZ0ZXIKICAgICAgICAgICAgICAg ICAvLyB0aGUgZmlyc3QgYW5kIHRoZSBsYXN0IG5vZGVzIGluIHRoZSBET00gdHJlZSB0aGF0IGlz IHdyYXBwZWQgaW5zaWRlIHRoZSBhbm9ueW1vdXMgYmxvY2suCiAgICAgICAgICAgICAgICAgTm9k ZSogZmlyc3ROb2RlSW5CbG9jayA9IGZpcnN0Q2hpbGRSZW5kZXJlci0+bm9kZSgpOwo=