172263 2017-05-18 00:25:21 -0700 AudioSourceProviderAVFObjC::m_tap member access is not thread safe. 2017-06-07 03:57:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan bfulgham commit-queue darin eric.carlson jer.noble oldest_to_newest 1310015 0 pvollan 2017-05-18 00:25:21 -0700 It it possible that the main thread will modify the m_tap member by calling AudioSourceProviderAVFObjC::destroyMix(), while m_tap is being read on a secondary thread in AudioSourceProviderAVFObjC::process(). 1310016 1 310493 pvollan 2017-05-18 00:38:22 -0700 Created attachment 310493 Patch 1316218 2 310493 darin 2017-06-06 13:54:50 -0700 Comment on attachment 310493 Patch Can we construct a test case? 1316429 3 pvollan 2017-06-07 03:29:10 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 310493 [details] > Patch > > Can we construct a test case? I have not been able to reproduce this. I believe the probability of two threads simultaneously accessing m_tap is (very) small. Thanks for reviewing! 1316434 4 310493 commit-queue 2017-06-07 03:57:27 -0700 Comment on attachment 310493 Patch Clearing flags on attachment: 310493 Committed r217878: <http://trac.webkit.org/changeset/217878> 1316435 5 commit-queue 2017-06-07 03:57:28 -0700 All reviewed patches have been landed. Closing bug. 310493 2017-05-18 00:38:22 -0700 2017-06-07 03:57:27 -0700 Patch bug-172263-20170518003844.patch text/plain 4205 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzAzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE3LTA1LTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBdWRpb1NvdXJjZVByb3Zp ZGVyQVZGT2JqQzo6bV90YXAgbWVtYmVyIGFjY2VzcyBpcyBub3QgdGhyZWFkIHNhZmUuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIyNjMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpdCBwb3NzaWJs ZSB0aGF0IHRoZSBtYWluIHRocmVhZCB3aWxsIG1vZGlmeSB0aGUgbV90YXAgbWVtYmVyIGJ5IGNh bGxpbmcKKyAgICAgICAgQXVkaW9Tb3VyY2VQcm92aWRlckFWRk9iakM6OmRlc3Ryb3lNaXgoKSwg d2hpbGUgbV90YXAgaXMgYmVpbmcgcmVhZCBvbiBhIHNlY29uZGFyeQorICAgICAgICB0aHJlYWQg dW5kZXIgQXVkaW9Tb3VyY2VQcm92aWRlckFWRk9iakM6OnByb2Nlc3NDYWxsYmFjaygpLiBJbnN0 ZWFkIG9mIGFjY2Vzc2luZworICAgICAgICB0aGUgbV90YXAgbWVtYmVyIG9uIHRoZSBzZWNvbmRh cnkgdGhyZWFkLCB3ZSBjYW4gdXNlIHRoZSBzYW1lIE1UQXVkaW9Qcm9jZXNzaW5nVGFwUmVmCisg ICAgICAgIHByb3ZpZGVkIGJ5IE1lZGlhVG9vbGJveCBpbiB0aGUgY2FsbGJhY2suIFdlIGFzc3Vt ZSB0aGUgdGFwIHJlZiBpcyByZXRhaW5lZCBieQorICAgICAgICBNZWRpYVRvb2xib3gsIHNvIGl0 IHNob3VsZCBiZSBzYWZlIHRvIHVzZSBldmVuIGlmIHRoZSB0aGUgbV90YXAgbWVtYmVyIGlzIHNl dCB0byBudWxsLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vQXVkaW9Tb3VyY2VQcm92aWRlckFW Rk9iakMuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vQXVkaW9T b3VyY2VQcm92aWRlckFWRk9iakMubW06CisgICAgICAgIChXZWJDb3JlOjpBdWRpb1NvdXJjZVBy b3ZpZGVyQVZGT2JqQzo6cHJvY2Vzc0NhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlv U291cmNlUHJvdmlkZXJBVkZPYmpDOjpwcm9jZXNzKToKKwogMjAxNy0wNS0xNiAgWXVzdWtlIFN1 enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXVtERkddW0RPTUpJ VF0gRXh0ZW5kIENoZWNrRE9NIHRvIENoZWNrU3ViQ2xhc3MKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9BdWRpb1NvdXJjZVByb3ZpZGVyQVZGT2Jq Qy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9BdWRpb1NvdXJjZVByb3ZpZGVyQVZGT2JqQy5oCShyZXZpc2lvbiAyMTcwMzUpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vQXVkaW9Tb3Vy Y2VQcm92aWRlckFWRk9iakMuaAkod29ya2luZyBjb3B5KQpAQCAtNzcsNyArNzcsNyBAQCBwcml2 YXRlOgogICAgIHZvaWQgZmluYWxpemUoKTsKICAgICB2b2lkIHByZXBhcmUoQ01JdGVtQ291bnQg bWF4RnJhbWVzLCBjb25zdCBBdWRpb1N0cmVhbUJhc2ljRGVzY3JpcHRpb24gKnByb2Nlc3NpbmdG b3JtYXQpOwogICAgIHZvaWQgdW5wcmVwYXJlKCk7Ci0gICAgdm9pZCBwcm9jZXNzKENNSXRlbUNv dW50IG51bWJlckZyYW1lcywgTVRBdWRpb1Byb2Nlc3NpbmdUYXBGbGFncyBmbGFnc0luLCBBdWRp b0J1ZmZlckxpc3QgKmJ1ZmZlckxpc3RJbk91dCwgQ01JdGVtQ291bnQgKm51bWJlckZyYW1lc091 dCwgTVRBdWRpb1Byb2Nlc3NpbmdUYXBGbGFncyAqZmxhZ3NPdXQpOworICAgIHZvaWQgcHJvY2Vz cyhNVEF1ZGlvUHJvY2Vzc2luZ1RhcFJlZiwgQ01JdGVtQ291bnQgbnVtYmVyRnJhbWVzLCBNVEF1 ZGlvUHJvY2Vzc2luZ1RhcEZsYWdzIGZsYWdzSW4sIEF1ZGlvQnVmZmVyTGlzdCAqYnVmZmVyTGlz dEluT3V0LCBDTUl0ZW1Db3VudCAqbnVtYmVyRnJhbWVzT3V0LCBNVEF1ZGlvUHJvY2Vzc2luZ1Rh cEZsYWdzICpmbGFnc091dCk7CiAKICAgICBSZXRhaW5QdHI8QVZQbGF5ZXJJdGVtPiBtX2F2UGxh eWVySXRlbTsKICAgICBSZXRhaW5QdHI8QVZBc3NldFRyYWNrPiBtX2F2QXNzZXRUcmFjazsKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9BdWRpb1Nv dXJjZVByb3ZpZGVyQVZGT2JqQy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vQXVkaW9Tb3VyY2VQcm92aWRlckFWRk9iakMubW0J KHJldmlzaW9uIDIxNzAzNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9BdWRpb1NvdXJjZVByb3ZpZGVyQVZGT2JqQy5tbQkod29ya2luZyBjb3B5KQpA QCAtMjg3LDcgKzI4Nyw3IEBAIHZvaWQgQXVkaW9Tb3VyY2VQcm92aWRlckFWRk9iakM6OnByb2Nl c3MKICAgICBzdGQ6OmxvY2tfZ3VhcmQ8TG9jaz4gbG9jayh0YXBTdG9yYWdlLT5tdXRleCk7CiAK ICAgICBpZiAodGFwU3RvcmFnZS0+X3RoaXMpCi0gICAgICAgIHRhcFN0b3JhZ2UtPl90aGlzLT5w cm9jZXNzKG51bWJlckZyYW1lcywgZmxhZ3MsIGJ1ZmZlckxpc3RJbk91dCwgbnVtYmVyRnJhbWVz T3V0LCBmbGFnc091dCk7CisgICAgICAgIHRhcFN0b3JhZ2UtPl90aGlzLT5wcm9jZXNzKHRhcCwg bnVtYmVyRnJhbWVzLCBmbGFncywgYnVmZmVyTGlzdEluT3V0LCBudW1iZXJGcmFtZXNPdXQsIGZs YWdzT3V0KTsKIH0KIAogdm9pZCBBdWRpb1NvdXJjZVByb3ZpZGVyQVZGT2JqQzo6aW5pdCh2b2lk KiBjbGllbnRJbmZvLCB2b2lkKiogdGFwU3RvcmFnZU91dCkKQEAgLTM1NywxNyArMzU3LDEzIEBA IHZvaWQgQXVkaW9Tb3VyY2VQcm92aWRlckFWRk9iakM6OnVucHJlcGEKICAgICBtX2xpc3QgPSBu dWxscHRyOwogfQogCi12b2lkIEF1ZGlvU291cmNlUHJvdmlkZXJBVkZPYmpDOjpwcm9jZXNzKENN SXRlbUNvdW50IG51bWJlck9mRnJhbWVzLCBNVEF1ZGlvUHJvY2Vzc2luZ1RhcEZsYWdzIGZsYWdz LCBBdWRpb0J1ZmZlckxpc3QqIGJ1ZmZlckxpc3RJbk91dCwgQ01JdGVtQ291bnQqIG51bWJlckZy YW1lc091dCwgTVRBdWRpb1Byb2Nlc3NpbmdUYXBGbGFncyogZmxhZ3NPdXQpCit2b2lkIEF1ZGlv U291cmNlUHJvdmlkZXJBVkZPYmpDOjpwcm9jZXNzKE1UQXVkaW9Qcm9jZXNzaW5nVGFwUmVmIHRh cCwgQ01JdGVtQ291bnQgbnVtYmVyT2ZGcmFtZXMsIE1UQXVkaW9Qcm9jZXNzaW5nVGFwRmxhZ3Mg ZmxhZ3MsIEF1ZGlvQnVmZmVyTGlzdCogYnVmZmVyTGlzdEluT3V0LCBDTUl0ZW1Db3VudCogbnVt YmVyRnJhbWVzT3V0LCBNVEF1ZGlvUHJvY2Vzc2luZ1RhcEZsYWdzKiBmbGFnc091dCkKIHsKICAg ICBVTlVTRURfUEFSQU0oZmxhZ3MpOwogICAgIAotICAgIFJldGFpblB0cjxNVEF1ZGlvUHJvY2Vz c2luZ1RhcFJlZj4gdGFwID0gbV90YXA7Ci0gICAgaWYgKCF0YXApCi0gICAgICAgIHJldHVybjsK LQogICAgIENNSXRlbUNvdW50IGl0ZW1Db3VudCA9IDA7CiAgICAgQ01UaW1lUmFuZ2UgcmFuZ2VP dXQ7Ci0gICAgT1NTdGF0dXMgc3RhdHVzID0gTVRBdWRpb1Byb2Nlc3NpbmdUYXBHZXRTb3VyY2VB dWRpbyh0YXAuZ2V0KCksIG51bWJlck9mRnJhbWVzLCBidWZmZXJMaXN0SW5PdXQsIGZsYWdzT3V0 LCAmcmFuZ2VPdXQsICZpdGVtQ291bnQpOworICAgIE9TU3RhdHVzIHN0YXR1cyA9IE1UQXVkaW9Q cm9jZXNzaW5nVGFwR2V0U291cmNlQXVkaW8odGFwLCBudW1iZXJPZkZyYW1lcywgYnVmZmVyTGlz dEluT3V0LCBmbGFnc091dCwgJnJhbmdlT3V0LCAmaXRlbUNvdW50KTsKICAgICBpZiAoc3RhdHVz ICE9IG5vRXJyIHx8ICFpdGVtQ291bnQpCiAgICAgICAgIHJldHVybjsKIAo=