17226 2008-02-08 13:48:31 -0800 Patch to correct Windows(Cairo) build of image-decoders 2008-02-08 22:48:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bfulgham webkit-unassigned oldest_to_newest 69796 0 bfulgham 2008-02-08 13:48:31 -0800 The GIF and PNG image decoders do not include the "config.h" file, which causes various syntax errors such as: "IFImageDecoder.cpp c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2544: expected ')' for operator '()' c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2143: syntax error : missing ';' before 'string' c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2433: '()' : 'inline' not permitted on data declarations c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2059: syntax error : ')' c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2143: syntax error : missing ';' before '{' c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2447: '{' : missing function header (old-style formal list?)" 69797 1 19008 bfulgham 2008-02-08 13:49:07 -0800 Created attachment 19008 Patch adding #include "config.h" 69799 2 19008 aroben 2008-02-08 13:50:04 -0800 Comment on attachment 19008 Patch adding #include "config.h" r=me 69895 3 mrowe 2008-02-08 22:48:19 -0800 Landed in r30107. 19008 2008-02-08 13:49:07 -0800 2008-02-08 13:50:04 -0800 Patch adding #include "config.h" decoders.patch text/plain 1451 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDA5NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMDItMDggIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBwbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYvR0lGSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAgICAgKiBw bGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcvUE5HSW1hZ2VEZWNvZGVyLmNwcDoKKwogMjAwOC0w Mi0wOCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEh5YXR0LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYvR0lGSW1h Z2VEZWNvZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29k ZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuY3BwCShyZXZpc2lvbiAzMDA5NikKKysrIFdlYkNvcmUv cGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlRGVjb2Rlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTIzLDYgKzIzLDcgQEAKICAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURW SVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuIAogICovCiAKKyNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJHSUZJbWFnZURlY29kZXIuaCIKICNpbmNsdWRlICJHSUZJ bWFnZVJlYWRlci5oIgogCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3Bu Zy9QTkdJbWFnZURlY29kZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vaW1h Z2UtZGVjb2RlcnMvcG5nL1BOR0ltYWdlRGVjb2Rlci5jcHAJKHJldmlzaW9uIDMwMDk2KQorKysg V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcvUE5HSW1hZ2VEZWNvZGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUsNyBAQAogICogdmVyc2lvbiBvZiB0aGlzIGZpbGUg dW5kZXIgYW55IG9mIHRoZSBMR1BMLCB0aGUgTVBMIG9yIHRoZSBHUEwuCiAgKi8KIAorI2luY2x1 ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlBOR0ltYWdlRGVjb2Rlci5oIgogI2luY2x1ZGUgInBu Zy5oIgogI2luY2x1ZGUgImFzc2VydC5oIgo=