172256 2017-05-17 17:14:44 -0700 It should be a runtime error to call ExceptionOr::releaseReturnValue() more than once 2017-05-18 09:36:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=172253 P2 Normal --- 1 aestes webkit-unassigned cdumez darin mitz sam oldest_to_newest 1309924 0 aestes 2017-05-17 17:14:44 -0700 Bug #172253 was caused by accidentally calling releaseReturnValue() twice on the same ExceptionOr value. This is a mistake because releaseReturnValue() moves the return value. We should ASSERT that releaseReturnValue() hasn't been called more than once. 1310112 1 darin 2017-05-18 09:36:30 -0700 I guess we can do this. We do this for Ref by asserting the pointer is not null in Ref::leakRef. We don’t do this for RefPtr. Longer term I think we want to move from ExceptionOr to std::expected. Is that right? If so, we should figure out if std::expected can assert for cases like this.