172253 2017-05-17 16:39:04 -0700 [Cocoa] errors are not propagated to PassKit when calling ApplePaySession.completePayment() 2017-05-17 17:58:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=169427 https://bugs.webkit.org/show_bug.cgi?id=172256 InRadar P2 Normal --- 1 aestes aestes andersca bdakin commit-queue ggaren mitz sam thorton webkit-bug-importer oldest_to_newest 1309904 0 aestes 2017-05-17 16:39:04 -0700 [Cocoa] errors are not propogated to PassKit when calling ApplePaySession.completePayment() 1309908 1 aestes 2017-05-17 16:41:25 -0700 rdar://problem/32258020 1309910 2 310461 aestes 2017-05-17 16:46:11 -0700 Created attachment 310461 Patch 1309911 3 310461 aestes 2017-05-17 16:48:56 -0700 Comment on attachment 310461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310461&action=review > Source/WebCore/ChangeLog:3 > + [Cocoa] errors are not propogated to PassKit when calling ApplePaySession.completePayment() Will fix my shameful spelling error before landing. 1309922 4 mitz 2017-05-17 17:08:20 -0700 Can we make it a runtime error to call releaseReturnValue a second time, at least in Debug builds? 1309925 5 aestes 2017-05-17 17:15:40 -0700 (In reply to mitz from comment #4) > Can we make it a runtime error to call releaseReturnValue a second time, at > least in Debug builds? I filed https://bugs.webkit.org/show_bug.cgi?id=172256 Thanks for the review! 1309930 6 310466 aestes 2017-05-17 17:17:12 -0700 Created attachment 310466 Patch 1309947 7 310466 commit-queue 2017-05-17 17:58:57 -0700 Comment on attachment 310466 Patch Clearing flags on attachment: 310466 Committed r217022: <http://trac.webkit.org/changeset/217022> 1309948 8 commit-queue 2017-05-17 17:58:59 -0700 All reviewed patches have been landed. Closing bug. 310461 2017-05-17 16:46:11 -0700 2017-05-17 17:17:11 -0700 Patch bug-172253-20170517164601.patch text/plain 2477 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2OTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjRjNzg1NDlhODYzZDU2 ZTVjMjNjODhiNTQ2ZDlmZThmMjRmZThiYS4uYzFhMjY5OTIyNDUwMmFkOGE5MjNhMWY0YjVjZTMz Yzk3NGI3OTdjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA1LTE3ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIGVycm9ycyBhcmUg bm90IHByb3BvZ2F0ZWQgdG8gUGFzc0tpdCB3aGVuIGNhbGxpbmcgQXBwbGVQYXlTZXNzaW9uLmNv bXBsZXRlUGF5bWVudCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzIyNTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyMjU4MDIwPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEFwcGxlUGF5U2Vz c2lvbjo6Y29tcGxldGVQYXltZW50KCksIHJlbGVhc2VSZXR1cm5WYWx1ZSgpIHdhcyBiZWluZyBj YWxsZWQgdHdpY2Ugb24gdGhlCisgICAgICAgIHNhbWUgY29udmVydGVkUmVzdWx0LiBTaW5jZSB0 aGUgZmlyc3QgY2FsbCBtb3ZlZCB0aGUgZXJyb3JzIHZlY3RvciBvdXQgb2YgY29udmVydGVkUmVz dWx0LAorICAgICAgICB0aGUgdmVjdG9yIGlzIGVtcHR5IGluIHRoZSBzZWNvbmQgY2FsbC4gSXQn cyB0aGUgc2Vjb25kIGNhbGwgdGhhdCBzZW5kcyB0aGUgcmVzdWx0IHRvIHRoZQorICAgICAgICBV SSBwcm9jZXNzLCBzbyB3ZSBlbmQgdXAgd2l0aCBhbiBlbXB0eSBhcmFyeSB3aGVuIHdlIGNhbGwg UGFzc0tpdCdzIGRlbGVnYXRlIGNvbXBsZXRpb24KKyAgICAgICAgaGFuZGxlci4KKworICAgICAg ICAqIE1vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkFwcGxlUGF5U2Vzc2lvbjo6Y29tcGxldGVQYXltZW50KToKKwogMjAxNy0wNS0xNyAgTWF0 dCBMZXdpcyAgPGpsZXdpczNAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIyMTY5NzQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2FwcGxl cGF5L0FwcGxlUGF5U2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2FwcGxlcGF5 L0FwcGxlUGF5U2Vzc2lvbi5jcHAKaW5kZXggNjFhOWU1Y2EwMTVkZTFkZGUyOGRjMmEwZmMwMGUw ZWY1YTM5NmZlYS4uMDM0ZWY4YmMyY2RkYjYzMjdiY2JiYmFlOTg4ZmE5OWZhN2QyMWM1ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVNlc3Npb24u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlTZXNzaW9u LmNwcApAQCAtNzgzLDEzICs3ODMsMTQgQEAgRXhjZXB0aW9uT3I8dm9pZD4gQXBwbGVQYXlTZXNz aW9uOjpjb21wbGV0ZVBheW1lbnQoQXBwbGVQYXlQYXltZW50QXV0aG9yaXphdGlvblIKICAgICBp ZiAoIWNhbkNvbXBsZXRlUGF5bWVudCgpKQogICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgSU5W QUxJRF9BQ0NFU1NfRVJSIH07CiAKLSAgICBhdXRvIGNvbnZlcnRlZFJlc3VsdCA9IGNvbnZlcnRB bmRWYWxpZGF0ZShXVEZNb3ZlKHJlc3VsdCkpOwotICAgIGlmIChjb252ZXJ0ZWRSZXN1bHQuaGFz RXhjZXB0aW9uKCkpCi0gICAgICAgIHJldHVybiBjb252ZXJ0ZWRSZXN1bHQucmVsZWFzZUV4Y2Vw dGlvbigpOworICAgIGF1dG8gY29udmVydGVkUmVzdWx0T3JFeGNlcHRpb24gPSBjb252ZXJ0QW5k VmFsaWRhdGUoV1RGTW92ZShyZXN1bHQpKTsKKyAgICBpZiAoY29udmVydGVkUmVzdWx0T3JFeGNl cHRpb24uaGFzRXhjZXB0aW9uKCkpCisgICAgICAgIHJldHVybiBjb252ZXJ0ZWRSZXN1bHRPckV4 Y2VwdGlvbi5yZWxlYXNlRXhjZXB0aW9uKCk7CiAKLSAgICBib29sIGlzRmluYWxTdGF0ZSA9IGlz RmluYWxTdGF0ZVJlc3VsdChjb252ZXJ0ZWRSZXN1bHQucmVsZWFzZVJldHVyblZhbHVlKCkpOwor ICAgIGF1dG8mJiBjb252ZXJ0ZWRSZXN1bHQgPSBjb252ZXJ0ZWRSZXN1bHRPckV4Y2VwdGlvbi5y ZWxlYXNlUmV0dXJuVmFsdWUoKTsKKyAgICBib29sIGlzRmluYWxTdGF0ZSA9IGlzRmluYWxTdGF0 ZVJlc3VsdChjb252ZXJ0ZWRSZXN1bHQpOwogCi0gICAgcGF5bWVudENvb3JkaW5hdG9yKCkuY29t cGxldGVQYXltZW50U2Vzc2lvbihjb252ZXJ0ZWRSZXN1bHQucmVsZWFzZVJldHVyblZhbHVlKCkp OworICAgIHBheW1lbnRDb29yZGluYXRvcigpLmNvbXBsZXRlUGF5bWVudFNlc3Npb24oV1RGTW92 ZShjb252ZXJ0ZWRSZXN1bHQpKTsKIAogICAgIGlmICghaXNGaW5hbFN0YXRlKSB7CiAgICAgICAg IG1fc3RhdGUgPSBTdGF0ZTo6QWN0aXZlOwo= 310466 2017-05-17 17:17:12 -0700 2017-05-17 17:58:57 -0700 Patch bug-172253-20170517171702.patch text/plain 2476 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2OTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjRjNzg1NDlhODYzZDU2 ZTVjMjNjODhiNTQ2ZDlmZThmMjRmZThiYS4uOTM3M2Q5MTRlMDk1ZmU1NTkwMGQ4NzY1MGQwNjJi NDBkN2Q4ODM4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA1LTE3ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIGVycm9ycyBhcmUg bm90IHByb3BhZ2F0ZWQgdG8gUGFzc0tpdCB3aGVuIGNhbGxpbmcgQXBwbGVQYXlTZXNzaW9uLmNv bXBsZXRlUGF5bWVudCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzIyNTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyMjU4MDIwPgorCisgICAg ICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCisKKyAgICAgICAgSW4gQXBwbGVQYXlTZXNz aW9uOjpjb21wbGV0ZVBheW1lbnQoKSwgcmVsZWFzZVJldHVyblZhbHVlKCkgd2FzIGJlaW5nIGNh bGxlZCB0d2ljZSBvbiB0aGUKKyAgICAgICAgc2FtZSBjb252ZXJ0ZWRSZXN1bHQuIFNpbmNlIHRo ZSBmaXJzdCBjYWxsIG1vdmVkIHRoZSBlcnJvcnMgdmVjdG9yIG91dCBvZiBjb252ZXJ0ZWRSZXN1 bHQsCisgICAgICAgIHRoZSB2ZWN0b3IgaXMgZW1wdHkgaW4gdGhlIHNlY29uZCBjYWxsLiBJdCdz IHRoZSBzZWNvbmQgY2FsbCB0aGF0IHNlbmRzIHRoZSByZXN1bHQgdG8gdGhlCisgICAgICAgIFVJ IHByb2Nlc3MsIHNvIHdlIGVuZCB1cCB3aXRoIGFuIGVtcHR5IGFyYXJ5IHdoZW4gd2UgY2FsbCBQ YXNzS2l0J3MgZGVsZWdhdGUgY29tcGxldGlvbgorICAgICAgICBoYW5kbGVyLgorCisgICAgICAg ICogTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVNlc3Npb24uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6QXBwbGVQYXlTZXNzaW9uOjpjb21wbGV0ZVBheW1lbnQpOgorCiAyMDE3LTA1LTE3ICBNYXR0 IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu ZyBvdXQgcjIxNjk3NC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXBwbGVw YXkvQXBwbGVQYXlTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkv QXBwbGVQYXlTZXNzaW9uLmNwcAppbmRleCA2MWE5ZTVjYTAxNWRlMWRkZTI4ZGMyYTBmYzAwZTBl ZjVhMzk2ZmVhLi4wMzRlZjhiYzJjZGRiNjMyN2JjYmJiYWU5ODhmYTk5ZmE3ZDIxYzVmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2FwcGxlcGF5L0FwcGxlUGF5U2Vzc2lvbi5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVNlc3Npb24u Y3BwCkBAIC03ODMsMTMgKzc4MywxNCBAQCBFeGNlcHRpb25Pcjx2b2lkPiBBcHBsZVBheVNlc3Np b246OmNvbXBsZXRlUGF5bWVudChBcHBsZVBheVBheW1lbnRBdXRob3JpemF0aW9uUgogICAgIGlm ICghY2FuQ29tcGxldGVQYXltZW50KCkpCiAgICAgICAgIHJldHVybiBFeGNlcHRpb24geyBJTlZB TElEX0FDQ0VTU19FUlIgfTsKIAotICAgIGF1dG8gY29udmVydGVkUmVzdWx0ID0gY29udmVydEFu ZFZhbGlkYXRlKFdURk1vdmUocmVzdWx0KSk7Ci0gICAgaWYgKGNvbnZlcnRlZFJlc3VsdC5oYXNF eGNlcHRpb24oKSkKLSAgICAgICAgcmV0dXJuIGNvbnZlcnRlZFJlc3VsdC5yZWxlYXNlRXhjZXB0 aW9uKCk7CisgICAgYXV0byBjb252ZXJ0ZWRSZXN1bHRPckV4Y2VwdGlvbiA9IGNvbnZlcnRBbmRW YWxpZGF0ZShXVEZNb3ZlKHJlc3VsdCkpOworICAgIGlmIChjb252ZXJ0ZWRSZXN1bHRPckV4Y2Vw dGlvbi5oYXNFeGNlcHRpb24oKSkKKyAgICAgICAgcmV0dXJuIGNvbnZlcnRlZFJlc3VsdE9yRXhj ZXB0aW9uLnJlbGVhc2VFeGNlcHRpb24oKTsKIAotICAgIGJvb2wgaXNGaW5hbFN0YXRlID0gaXNG aW5hbFN0YXRlUmVzdWx0KGNvbnZlcnRlZFJlc3VsdC5yZWxlYXNlUmV0dXJuVmFsdWUoKSk7Cisg ICAgYXV0byYmIGNvbnZlcnRlZFJlc3VsdCA9IGNvbnZlcnRlZFJlc3VsdE9yRXhjZXB0aW9uLnJl bGVhc2VSZXR1cm5WYWx1ZSgpOworICAgIGJvb2wgaXNGaW5hbFN0YXRlID0gaXNGaW5hbFN0YXRl UmVzdWx0KGNvbnZlcnRlZFJlc3VsdCk7CiAKLSAgICBwYXltZW50Q29vcmRpbmF0b3IoKS5jb21w bGV0ZVBheW1lbnRTZXNzaW9uKGNvbnZlcnRlZFJlc3VsdC5yZWxlYXNlUmV0dXJuVmFsdWUoKSk7 CisgICAgcGF5bWVudENvb3JkaW5hdG9yKCkuY29tcGxldGVQYXltZW50U2Vzc2lvbihXVEZNb3Zl KGNvbnZlcnRlZFJlc3VsdCkpOwogCiAgICAgaWYgKCFpc0ZpbmFsU3RhdGUpIHsKICAgICAgICAg bV9zdGF0ZSA9IFN0YXRlOjpBY3RpdmU7Cg==