172252 2017-05-17 16:30:18 -0700 Bindings: Require value for extended attributes EnabledAtRuntime and EnabledForWorld 2017-05-18 14:35:39 -0700 1 1 1 Unclassified WebKit Bindings WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates cdumez sam oldest_to_newest 1309894 0 dbates 2017-05-17 16:30:18 -0700 In bug #172233, comment 2, Sam Weinig said that generating code when EnabledAtRuntime does not have a value is an "anti-feature". We should require that EnabledAtRuntime has a value. Similarly we should require that EnabledForWorld has a value. There is a larger discussion about whether to keep EnabledAtRuntime. Regardless of the outcome of this discussion fixing this bug is meaningful. 1309903 1 310460 dbates 2017-05-17 16:37:49 -0700 Created attachment 310460 Patch 1309918 2 dbates 2017-05-17 17:01:39 -0700 In case it was not obvious and as can be seen from the EWS failures we were using the "anti-feature" of specifying EnabledAtRuntime without a value on interfaces so that we could write: [ EnabledAtRuntime, ] interface A { ... } instead of: [ EnabledAtRuntime=A, ] interface A { ... } 1310268 3 dbates 2017-05-18 14:35:39 -0700 Committed r217066: <http://trac.webkit.org/changeset/217066> 310460 2017-05-17 16:37:49 -0700 2017-05-17 16:42:02 -0700 Patch bug-172252-20170517163748.patch text/plain 2856 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVjZjRmOWZiY2U0NWVh NGExMTY1ZDQ3NWNjZTQ2ODZiYmRkZDBmYS4uNjQ5YmQ3OGQ2MGM5MDE3OGNmMGM0YThmMTBjNmE4 NDBhN2I3MWRlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA1LTE3ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBCaW5kaW5nczogUmVxdWly ZSB2YWx1ZSBmb3IgZXh0ZW5kZWQgYXR0cmlidXRlcyBFbmFibGVkQXRSdW50aW1lIGFuZCBFbmFi bGVkRm9yV29ybGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MjI1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFjY29yZGluZyB0byBTYW0gV2VpbmlnIGl0IGlzIGFuIGFudGktZmVhdHVyZSB0aGF0IEVu YWJsZWRBdFJ1bnRpbWUgY2FuIGJlIHNwZWNpZmllZAorICAgICAgICB3aXRob3V0IGEgdmFsdWUu IFdlIHNob3VsZCBtYWtlIGl0IHJlcXVpcmUgYSB2YWx1ZSBmb3IgdGhlIG5hbWUgb2YgdGhlIFJ1 bnRpbWVFbmFibGVkRmVhdHVyZXMKKyAgICAgICAgZnVuY3Rpb24gdG8gdXNlIGluIHRoZSBnZW5l cmF0ZWQgY29kZS4gRm9yIHNpbWlsYXIgcmVhc29ucyB3ZSBzaG91bGQgYWxzbyByZXF1aXJlCisg ICAgICAgIGEgdmFsdWUgZm9yIHRoZSBleHRlbmRlZCBhdHRyaWJ1dGUgRW5hYmxlZEZvcldvcmxk LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAg ICAgIChHZXRSdW50aW1lRW5hYmxlRnVuY3Rpb25OYW1lKToKKwogMjAxNy0wNS0xNyAgUGVyIEFy bmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggdW5kZXIgV2Vi Q29yZTo6QXVkaW9Tb3VyY2VQcm92aWRlckFWRk9iakM6OnByb2Nlc3MoKS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggZTBi MzQ2ZWYzYmNmMGE0NzUwOTk2ZTY3MGQ4MDU4N2VhZGNlZmM0ZC4uMmRmZmQwNmQ5N2QwODA1MjBh MzgxZmQ4NzkxMjEwNDUyYTUwYTAzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTI5NzAsMTEgKzI5NzAsMTIgQEAgc3Vi IEdldFJ1bnRpbWVFbmFibGVGdW5jdGlvbk5hbWUKICAgICBBZGRUb0ltcGxJbmNsdWRlcygiUnVu dGltZUVuYWJsZWRGZWF0dXJlcy5oIik7CiAKICAgICBpZiAoJGNvbnRleHQtPmV4dGVuZGVkQXR0 cmlidXRlcy0+e0VuYWJsZWRGb3JXb3JsZH0pIHsKKyAgICAgICAgYXNzZXJ0KCJNdXN0IHNwZWNp ZnkgdmFsdWUgZm9yIEVuYWJsZWRGb3JXb3JsZC4iKSBpZiAkY29udGV4dC0+ZXh0ZW5kZWRBdHRy aWJ1dGVzLT57RW5hYmxlZEZvcldvcmxkfSBlcSAiVkFMVUVfSVNfTUlTU0lORyI7CiAgICAgICAg IHJldHVybiAid29ybGRGb3JET01PYmplY3QodGhpcykuIiAuIFRvTWV0aG9kTmFtZSgkY29udGV4 dC0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57RW5hYmxlZEZvcldvcmxkfSkgLiAiKCkiOwogICAgIH0K IAotICAgICMgSWYgYSBwYXJhbWV0ZXIgaXMgZ2l2ZW4gKGUuZy4gIkVuYWJsZWRBdFJ1bnRpbWU9 RmVhdHVyZU5hbWUiKSByZXR1cm4gdGhlIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZl YXR1cmVzKCkue0ZlYXR1cmVOYW1lfUVuYWJsZWQoKSBtZXRob2QuCi0gICAgaWYgKCRjb250ZXh0 LT5leHRlbmRlZEF0dHJpYnV0ZXMtPntFbmFibGVkQXRSdW50aW1lfSAmJiAkY29udGV4dC0+ZXh0 ZW5kZWRBdHRyaWJ1dGVzLT57RW5hYmxlZEF0UnVudGltZX0gbmUgIlZBTFVFX0lTX01JU1NJTkci KSB7CisgICAgaWYgKCRjb250ZXh0LT5leHRlbmRlZEF0dHJpYnV0ZXMtPntFbmFibGVkQXRSdW50 aW1lfSkgeworICAgICAgICBhc3NlcnQoIk11c3Qgc3BlY2lmeSB2YWx1ZSBmb3IgRW5hYmxlZEF0 UnVudGltZS4iKSBpZiAkY29udGV4dC0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57RW5hYmxlZEF0UnVu dGltZX0gZXEgIlZBTFVFX0lTX01JU1NJTkciOwogICAgICAgICBteSBAZmxhZ3MgPSBzcGxpdCAv Ji8sICRjb250ZXh0LT5leHRlbmRlZEF0dHJpYnV0ZXMtPntFbmFibGVkQXRSdW50aW1lfTsKICAg ICAgICAgbXkgJHJlc3VsdCA9ICIiOwogICAgICAgICBmb3JlYWNoIG15ICRmbGFnIChAZmxhZ3Mp IHsKQEAgLTI5ODQsOSArMjk4NSw2IEBAIHN1YiBHZXRSdW50aW1lRW5hYmxlRnVuY3Rpb25OYW1l CiAgICAgICAgICRyZXN1bHQgPSAiKCIgLiAkcmVzdWx0IC4gIikiIHVubGVzcyBzY2FsYXIgQGZs YWdzIGVxIDE7CiAgICAgICAgIHJldHVybiAkcmVzdWx0OwogICAgIH0KLQotICAgICMgT3RoZXJ3 aXNlIHJldHVybiBhIGZ1bmN0aW9uIG5hbWVkIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJl ZEZlYXR1cmVzKCkue21ldGhvZE5hbWV9RW5hYmxlZCgpLgotICAgIHJldHVybiAiUnVudGltZUVu YWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS4iIC4gVG9NZXRob2ROYW1lKCRjb250ZXh0 LT5uYW1lKSAuICJFbmFibGVkKCkiOwogfQogCiBzdWIgR2V0Q2FzdGluZ0hlbHBlckZvclRoaXNP YmplY3QK