172248 2017-05-17 15:28:49 -0700 [Win] Support $vm.getpid() 2017-05-17 16:13:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead buildbot commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1309870 0 don.olmstead 2017-05-17 15:28:49 -0700 Add Windows implementation of vm.getpid() 1309873 1 310452 don.olmstead 2017-05-17 15:37:04 -0700 Created attachment 310452 Patch The original bug https://bugs.webkit.org/show_bug.cgi?id=163493 did not go for a windows implementation because of restrictions in getpid and _getpid. From MSDN https://docs.microsoft.com/en-us/cpp/cppcx/crt-functions-not-supported-in-universal-windows-platform-apps it appears that both _getpid and getpid should just use GetCurrentProcessId so getProcessId from ProcessID.h can be used since it calls that. Found this while trying to compile out JSCOnly on Windows. It fails on this file because PLATFORM(WIN) is used instead of OS(WINDOWS). 1309874 2 310452 mark.lam 2017-05-17 15:40:54 -0700 Comment on attachment 310452 Patch LGTM. Did you mean to r? this patch? 1309875 3 310452 mark.lam 2017-05-17 15:45:12 -0700 Comment on attachment 310452 Patch r=me 1309876 4 don.olmstead 2017-05-17 15:45:46 -0700 (In reply to Mark Lam from comment #3) > Comment on attachment 310452 [details] > Patch > > r=me Thanks for the review! 1309888 5 310452 commit-queue 2017-05-17 16:13:32 -0700 Comment on attachment 310452 Patch Clearing flags on attachment: 310452 Committed r217011: <http://trac.webkit.org/changeset/217011> 1309889 6 commit-queue 2017-05-17 16:13:33 -0700 All reviewed patches have been landed. Closing bug. 310452 2017-05-17 15:37:04 -0700 2017-05-17 16:13:32 -0700 Patch bug-172248.diff text/plain 1960 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDYwMjM1ZTJhMDFmLi5iZjBiYTliOTBiOSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDUtMTcgIERvbiBP bG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBhbS5zb255LmNvbT4KKworICAgICAgICBbV2luXSBTdXBw b3J0ICR2bS5nZXRwaWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTcyMjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiB0b29scy9KU0RvbGxhclZNUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6 ZnVuY3Rpb25HZXRQSUQpOgorICAgICAgICAoSlNDOjpKU0RvbGxhclZNUHJvdG90eXBlOjpmaW5p c2hDcmVhdGlvbik6CisKIDIwMTctMDUtMTcgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBs ZS5jb20+CiAKICAgICAgICAgW2lPU10gVGhlIEdhcmJhZ2UgQ29sbGVjdG9yIHNob3VsZG4ndCBy ZWx5IG9uIHRoZSBibWFsbG9jIHNjYXZlbmdlciBmb3IgdXAgdG8gZGF0ZSBtZW1vcnkgZm9vdHBy aW50IGluZm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxh clZNUHJvdG90eXBlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZN UHJvdG90eXBlLmNwcAppbmRleCBhZjc0NzJiMTY3ZS4uNDZiZjFlMTAwNmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNUHJvdG90eXBlLmNwcAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTVByb3RvdHlwZS5jcHAKQEAg LTM1LDYgKzM1LDcgQEAKICNpbmNsdWRlICJNYXJrZWRTcGFjZUlubGluZXMuaCIKICNpbmNsdWRl ICJTdGFja1Zpc2l0b3IuaCIKICNpbmNsdWRlIDx3dGYvRGF0YUxvZy5oPgorI2luY2x1ZGUgPHd0 Zi9Qcm9jZXNzSUQuaD4KICNpbmNsdWRlIDx3dGYvU3RyaW5nUHJpbnRTdHJlYW0uaD4KIAogbmFt ZXNwYWNlIEpTQyB7CkBAIC00MzgsMTIgKzQzOSwxMCBAQCBzdGF0aWMgRW5jb2RlZEpTVmFsdWUg SlNDX0hPU1RfQ0FMTCBmdW5jdGlvblZhbHVlKEV4ZWNTdGF0ZSogZXhlYykKICAgICByZXR1cm4g SlNWYWx1ZTo6ZW5jb2RlKGpzU3RyaW5nKGV4ZWMsIHN0cmVhbS50b1N0cmluZygpKSk7CiB9CiAK LSNpZiAhUExBVEZPUk0oV0lOKQogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwg ZnVuY3Rpb25HZXRQSUQoRXhlY1N0YXRlKikKIHsKLSAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2Rl KGpzTnVtYmVyKGdldHBpZCgpKSk7CisgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc051bWJl cihnZXRDdXJyZW50UHJvY2Vzc0lEKCkpKTsKIH0KLSNlbmRpZgogCiB2b2lkIEpTRG9sbGFyVk1Q cm90b3R5cGU6OmZpbmlzaENyZWF0aW9uKFZNJiB2bSwgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9i amVjdCkKIHsKQEAgLTQ2OSw5ICs0NjgsNyBAQCB2b2lkIEpTRG9sbGFyVk1Qcm90b3R5cGU6OmZp bmlzaENyZWF0aW9uKFZNJiB2bSwgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkKICAgICBh ZGRGdW5jdGlvbih2bSwgZ2xvYmFsT2JqZWN0LCAicHJpbnRTdGFjayIsIGZ1bmN0aW9uUHJpbnRT dGFjaywgMCk7CiAKICAgICBhZGRGdW5jdGlvbih2bSwgZ2xvYmFsT2JqZWN0LCAidmFsdWUiLCBm dW5jdGlvblZhbHVlLCAxKTsKLSNpZiAhUExBVEZPUk0oV0lOKQogICAgIGFkZEZ1bmN0aW9uKHZt LCBnbG9iYWxPYmplY3QsICJnZXRwaWQiLCBmdW5jdGlvbkdldFBJRCwgMCk7Ci0jZW5kaWYKIH0K IAogfSAvLyBuYW1lc3BhY2UgSlNDCg==