172236 2017-05-17 12:19:06 -0700 Cleanup: Remove unnecessary call to AddToImplIncludes("RuntimeEnabledFeatures.h") in GenerateImplementation() 2017-05-18 11:56:39 -0700 1 1 1 Unclassified WebKit Bindings WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates cdumez sam oldest_to_newest 1309741 0 dbates 2017-05-17 12:19:06 -0700 It is unnecessary for GenerateImplementation() to explicitly call AddToImplIncludes("RuntimeEnabledFeatures.h") to add the header RuntimeEnabledFeatures.h to the list of headers in the generated implementation as this header is added when GetRuntimeEnableFunctionName() is called. And GenerateImplementation() calls GetRuntimeEnableFunctionName(). 1309742 1 310426 dbates 2017-05-17 12:20:04 -0700 Created attachment 310426 Patch 1309856 2 310426 cdumez 2017-05-17 15:10:08 -0700 Comment on attachment 310426 Patch r=me 1310176 3 310426 dbates 2017-05-18 11:56:37 -0700 Comment on attachment 310426 Patch Clearing flags on attachment: 310426 Committed r217056: <http://trac.webkit.org/changeset/217056> 1310177 4 dbates 2017-05-18 11:56:39 -0700 All reviewed patches have been landed. Closing bug. 310426 2017-05-17 12:20:04 -0700 2017-05-18 11:56:37 -0700 Patch bug-172236-20170517122004.patch text/plain 2104 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2OTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWZkZWIxZGYxYzczNTYx YzE5N2ViYzU1NjA4YjBmMjM5Njg1MTdlOS4uMjQ0N2Q5YmJkNjY1MGM0MTVhZmNjNjBlNmZlNzZm ZDAxMGZhYjM0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA1LTE3ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbnVwOiBSZW1vdmUg dW5uZWNlc3NhcnkgY2FsbCB0byBBZGRUb0ltcGxJbmNsdWRlcygiUnVudGltZUVuYWJsZWRGZWF0 dXJlcy5oIikgaW4gR2VuZXJhdGVJbXBsZW1lbnRhdGlvbigpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIyMzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpcyB1bm5lY2Vzc2FyeSBmb3IgR2VuZXJh dGVJbXBsZW1lbnRhdGlvbigpIHRvIGV4cGxpY2l0bHkgY2FsbCBBZGRUb0ltcGxJbmNsdWRlcygi UnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIikKKyAgICAgICAgdG8gYWRkIHRoZSBoZWFkZXIgUnVu dGltZUVuYWJsZWRGZWF0dXJlcy5oIHRvIHRoZSBsaXN0IG9mIGhlYWRlcnMgaW4gdGhlIGdlbmVy YXRlZCBpbXBsZW1lbnRhdGlvbgorICAgICAgICBhcyB0aGlzIGhlYWRlciBpcyBhZGRlZCB3aGVu IEdldFJ1bnRpbWVFbmFibGVGdW5jdGlvbk5hbWUoKSBpcyBjYWxsZWQuIEFuZCBHZW5lcmF0ZUlt cGxlbWVudGF0aW9uKCkKKyAgICAgICAgY2FsbHMgR2V0UnVudGltZUVuYWJsZUZ1bmN0aW9uTmFt ZSgpLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlZC4gU28sIG5vIG5ldyB0ZXN0 cy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAg ICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisKIDIwMTctMDUtMTcgIERhdmlkIEtpbHpl ciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBCbG9iRGF0YUZpbGVSZWZlcmVuY2U6 OmdlbmVyYXRlUmVwbGFjZW1lbnRGaWxlKCkgc2hvdWxkIHVzZSBta3N0ZW1wKCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXgg ZTBiMzQ2ZWYzYmNmMGE0NzUwOTk2ZTY3MGQ4MDU4N2VhZGNlZmM0ZC4uYzI1NWYzZGVhZmQ1MGRk NWI1NGMzMWRlZjMzNmQxZmU4ODhlMjE3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTM0MTksNyArMzQxOSw2IEBAIHN1 YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgIGZvcmVhY2ggbXkgJGZ1bmN0aW9uT3JB dHRyaWJ1dGUgKEBydW50aW1lRW5hYmxlZFByb3BlcnRpZXMpIHsKICAgICAgICAgICAgIG15ICRj b25kaXRpb25hbFN0cmluZyA9ICRjb2RlR2VuZXJhdG9yLT5HZW5lcmF0ZUNvbmRpdGlvbmFsU3Ry aW5nKCRmdW5jdGlvbk9yQXR0cmlidXRlKTsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50 LCAiI2lmICR7Y29uZGl0aW9uYWxTdHJpbmd9XG4iKSBpZiAkY29uZGl0aW9uYWxTdHJpbmc7Ci0g ICAgICAgICAgICBBZGRUb0ltcGxJbmNsdWRlcygiUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIik7 CiAgICAgICAgICAgICBteSAkZW5hYmxlX2Z1bmN0aW9uX3Jlc3VsdCA9IEdldFJ1bnRpbWVFbmFi bGVGdW5jdGlvbk5hbWUoJGZ1bmN0aW9uT3JBdHRyaWJ1dGUpOwogICAgICAgICAgICAgbXkgJG5h bWUgPSAkZnVuY3Rpb25PckF0dHJpYnV0ZS0+bmFtZTsKICAgICAgICAgICAgIHB1c2goQGltcGxD b250ZW50LCAiICAgIGlmICghJHtlbmFibGVfZnVuY3Rpb25fcmVzdWx0fSkge1xuIik7Cg==