172217 2017-05-17 06:01:13 -0700 Regression (198943): <marquee> shouldn't wrap text 2017-05-17 08:12:53 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned cdumez commit-queue kling oldest_to_newest 1309572 0 koivisto 2017-05-17 06:01:13 -0700 <marquee><span>text</span></marquee> should render the text in single line. 1309575 1 310385 koivisto 2017-05-17 06:15:58 -0700 Created attachment 310385 patch 1309584 2 koivisto 2017-05-17 07:21:09 -0700 <rdar://problem/31812669> 1309586 3 310385 kling 2017-05-17 07:25:39 -0700 Comment on attachment 310385 patch View in context: https://bugs.webkit.org/attachment.cgi?id=310385&action=review Wow, I was not expecting to see a marquee patch in 2017. r=me > Source/WebCore/rendering/RenderMarquee.cpp:200 > - auto& style = m_layer->renderer().mutableStyle(); > + auto& style = m_layer->renderer().style(); Nice. 1309600 4 310385 commit-queue 2017-05-17 08:12:52 -0700 Comment on attachment 310385 patch Clearing flags on attachment: 310385 Committed r216973: <http://trac.webkit.org/changeset/216973> 1309601 5 commit-queue 2017-05-17 08:12:53 -0700 All reviewed patches have been landed. Closing bug. 310385 2017-05-17 06:15:58 -0700 2017-05-17 08:12:52 -0700 patch marquee-wrap.patch text/plain 6052 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjk3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE3LTA1LTE3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uICgxOTg5NDMp OiA8bWFycXVlZT4gc2hvdWxkbid0IHdyYXAgdGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyMjE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuZGVyTWFycXVlZTo6dXBkYXRlTWFycXVlZVN0eWxl IG11dGF0ZWQgdGhlIHN0eWxlIGFuZCB0aGVuIGV4cGVjdGVkIGl0IHRvIGluaGVyaXQgdG8gY2hp bGRyZW4uCisgICAgICAgIFRoaXMgZG9lc24ndCB3b3JrIGFueW1vcmUgYmVjYXVzZSByZW5kZXIg dHJlZSBjb25zdHJ1Y3Rpb24gaXMgbm93IHNlcGFyYXRlZCBmcm9tIHN0eWxlIHJlc29sdXRpb24K KyAgICAgICAgd2hlcmUgaW5oZXJpdGFuY2UgaGFwcGVucy4KKworICAgICAgICBUZXN0OiBmYXN0 L2h0bWwvbWFycXVlZS1jaGlsZC13cmFwLmh0bWwKKworICAgICAgICAqIGNzcy9TdHlsZVJlc29s dmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OmFkanVzdFJlbmRlclN0 eWxlKToKKworICAgICAgICAgICAgSW1wbGVtZW50IG1hcnF1ZWUgaGFja3MgaW4gYWRqdXN0UmVu ZGVyU3R5bGUgaW5zdGVhZC4gVGhpcyBjYW4ndCBkbyB0aGUgY2hpbGRyZW5JbmxpbmUgY2hlY2sK KyAgICAgICAgICAgIHRoZSBwcmV2aW91cyBjb2RlIGhhZCBidXQgaXQgd2Fzbid0IHdvcmtpbmcg YW55d2F5ICh0aGVyZSBhcmUgbm8gY2hpbGRyZW4gd2hlbiB1cGRhdGVNYXJxdWVlU3R5bGUKKyAg ICAgICAgICAgIGdldHMgY2FsbGVkKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNYXJx dWVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck1hcnF1ZWU6OnVwZGF0ZU1hcnF1ZWVT dHlsZSk6CisKKyAgICAgICAgICAgIFRoaXMgbm8gbG9uZ2VyIG5lZWRzIG11dGFibGUgc3R5bGUu CisKIDIwMTctMDUtMTYgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZW1vdmUgQy1zdHlsZSBjYXN0cyBieSB1c2luZyB4bWxEb2NQdHIgaW5zdGVhZCBvZiB2 b2lkKgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAkocmV2aXNpb24gMjE2 OTAyKQorKysgU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC05MzAsMTAgKzkzMCwyMCBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6OmFkanVzdFJlbmRl clN0eWxlKFJlCiAgICAgICAgIGlmICghZWxlbWVudC0+c2hhZG93UHNldWRvSWQoKS5pc051bGwo KSkKICAgICAgICAgICAgIHN0eWxlLnNldFVzZXJNb2RpZnkoUkVBRF9PTkxZKTsKIAotICAgICAg ICAvLyBGb3Igbm93LCA8bWFycXVlZT4gcmVxdWlyZXMgYW4gb3ZlcmZsb3cgY2xpcCB0byB3b3Jr IHByb3Blcmx5LgogICAgICAgICBpZiAoaXM8SFRNTE1hcnF1ZWVFbGVtZW50PigqZWxlbWVudCkp IHsKKyAgICAgICAgICAgIC8vIEZvciBub3csIDxtYXJxdWVlPiByZXF1aXJlcyBhbiBvdmVyZmxv dyBjbGlwIHRvIHdvcmsgcHJvcGVybHkuCiAgICAgICAgICAgICBzdHlsZS5zZXRPdmVyZmxvd1go T0hJRERFTik7CiAgICAgICAgICAgICBzdHlsZS5zZXRPdmVyZmxvd1koT0hJRERFTik7CisKKyAg ICAgICAgICAgIGJvb2wgaXNWZXJ0aWNhbCA9IHN0eWxlLm1hcnF1ZWVEaXJlY3Rpb24oKSA9PSBN VVAgfHwgc3R5bGUubWFycXVlZURpcmVjdGlvbigpID09IE1ET1dOOworICAgICAgICAgICAgLy8g TWFrZSBob3Jpem9udGFsIG1hcnF1ZWVzIG5vdCB3cmFwLgorICAgICAgICAgICAgaWYgKCFpc1Zl cnRpY2FsKSB7CisgICAgICAgICAgICAgICAgc3R5bGUuc2V0V2hpdGVTcGFjZShOT1dSQVApOwor ICAgICAgICAgICAgICAgIHN0eWxlLnNldFRleHRBbGlnbihUQVNUQVJUKTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgICAgIC8vIEFwcGFyZW50bHkgdGhpcyBpcyB0aGUgZXhwZWN0ZWQgbGVnYWN5 IGJlaGF2aW9yLgorICAgICAgICAgICAgaWYgKGlzVmVydGljYWwgJiYgc3R5bGUuaGVpZ2h0KCku aXNBdXRvKCkpCisgICAgICAgICAgICAgICAgc3R5bGUuc2V0SGVpZ2h0KExlbmd0aCgyMDAsIEZp eGVkKSk7CiAgICAgICAgIH0KICAgICB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJNYXJxdWVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTWFycXVlZS5jcHAJKHJldmlzaW9uIDIxNjkwMSkKKysrIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJNYXJxdWVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk3LDcgKzE5 Nyw3IEBAIHZvaWQgUmVuZGVyTWFycXVlZTo6dXBkYXRlTWFycXVlZVBvc2l0aW8KIAogdm9pZCBS ZW5kZXJNYXJxdWVlOjp1cGRhdGVNYXJxdWVlU3R5bGUoKQogewotICAgIGF1dG8mIHN0eWxlID0g bV9sYXllci0+cmVuZGVyZXIoKS5tdXRhYmxlU3R5bGUoKTsKKyAgICBhdXRvJiBzdHlsZSA9IG1f bGF5ZXItPnJlbmRlcmVyKCkuc3R5bGUoKTsKICAgICAKICAgICBpZiAobV9kaXJlY3Rpb24gIT0g c3R5bGUubWFycXVlZURpcmVjdGlvbigpIHx8IChtX3RvdGFsTG9vcHMgIT0gc3R5bGUubWFycXVl ZUxvb3BDb3VudCgpICYmIG1fY3VycmVudExvb3AgPj0gbV90b3RhbExvb3BzKSkKICAgICAgICAg bV9jdXJyZW50TG9vcCA9IDA7IC8vIFdoZW4gZGlyZWN0aW9uIGNoYW5nZXMgb3Igb3VyIGxvb3BD b3VudCBpcyBhIHNtYWxsZXIgbnVtYmVyIHRoYW4gb3VyIGN1cnJlbnQgbG9vcCwgcmVzZXQgb3Vy IGxvb3AuCkBAIC0yMTAsMjMgKzIxMCw4IEBAIHZvaWQgUmVuZGVyTWFycXVlZTo6dXBkYXRlTWFy cXVlZVN0eWxlKCkKICAgICAgICAgLy8gb25lIGxvb3AuCiAgICAgICAgIGlmIChtX3RvdGFsTG9v cHMgPD0gMCAmJiBzdHlsZS5tYXJxdWVlQmVoYXZpb3IoKSA9PSBNU0xJREUpCiAgICAgICAgICAg ICBtX3RvdGFsTG9vcHMgPSAxOwotICAgICAgICAKLSAgICAgICAgLy8gSGFjayBhbGVydDogU2V0 IHRoZSB3aGl0ZS1zcGFjZSB2YWx1ZSB0byBub3dyYXAgZm9yIGhvcml6b250YWwgbWFycXVlZXMg d2l0aCBpbmxpbmUgY2hpbGRyZW4sIHRodXMgZW5zdXJpbmcKLSAgICAgICAgLy8gYWxsIHRoZSB0 ZXh0IGVuZHMgdXAgb24gb25lIGxpbmUgYnkgZGVmYXVsdC4gIExpbWl0IHRoaXMgaGFjayB0byB0 aGUgPG1hcnF1ZWU+IGVsZW1lbnQgdG8gZW11bGF0ZQotICAgICAgICAvLyBXaW5JRSdzIGJlaGF2 aW9yLiAgU29tZW9uZSB1c2luZyBDU1MzIGNhbiB1c2Ugd2hpdGUtc3BhY2U6IG5vd3JhcCBvbiB0 aGVpciBvd24gdG8gZ2V0IHRoaXMgZWZmZWN0LgotICAgICAgICAvLyBTZWNvbmQgaGFjayBhbGVy dDogU2V0IHRoZSB0ZXh0LWFsaWduIGJhY2sgdG8gYXV0by4gIFdpbklFIGNvbXBsZXRlbHkgaWdu b3JlcyB0ZXh0LWFsaWduIG9uIHRoZQotICAgICAgICAvLyBtYXJxdWVlIGVsZW1lbnQuCi0gICAg ICAgIC8vIEZJWE1FOiBCcmluZyB0aGVzZSB1cCB3aXRoIHRoZSBDU1MgV0cuCi0gICAgICAgIGlm IChpc0hvcml6b250YWwoKSAmJiBtX2xheWVyLT5yZW5kZXJlcigpLmNoaWxkcmVuSW5saW5lKCkp IHsKLSAgICAgICAgICAgIHN0eWxlLnNldFdoaXRlU3BhY2UoTk9XUkFQKTsKLSAgICAgICAgICAg IHN0eWxlLnNldFRleHRBbGlnbihUQVNUQVJUKTsKLSAgICAgICAgfQogICAgIH0KICAgICAKLSAg ICAvLyBMZWdhY3kgaGFjayAtIG11bHRpcGxlIGJyb3dzZXJzIGRlZmF1bHQgdmVydGljYWwgbWFy cXVlZXMgdG8gMjAwcHggdGFsbC4KLSAgICBpZiAoIWlzSG9yaXpvbnRhbCgpICYmIHN0eWxlLmhl aWdodCgpLmlzQXV0bygpKQotICAgICAgICBzdHlsZS5zZXRIZWlnaHQoTGVuZ3RoKDIwMCwgRml4 ZWQpKTsgCi0gICAKICAgICBpZiAoc3BlZWQoKSAhPSBtYXJxdWVlU3BlZWQoKSkgewogICAgICAg ICBtX3NwZWVkID0gbWFycXVlZVNwZWVkKCk7CiAgICAgICAgIGlmIChtX3RpbWVyLmlzQWN0aXZl KCkpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTY5MDEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wNS0xNyAgQW50dGkgS29pdmlz dG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbiAoMTk4OTQzKTogPG1h cnF1ZWU+IHNob3VsZG4ndCB3cmFwIHRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3MjIxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZmFzdC9odG1sL21hcnF1ZWUtY2hpbGQtd3JhcC1leHBlY3Rl ZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2h0bWwvbWFycXVlZS1jaGlsZC13cmFwLmh0 bWw6IEFkZGVkLgorCiAyMDE3LTA1LTE1ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3 YUBhcHBsZS5jb20+CiAKICAgICAgICAgRG8gbm90IGRlbGV0ZSBhc3luY2hyb25vdXNseSBkZWNv ZGVkIGZyYW1lcyBmb3IgbGFyZ2UgaW1hZ2VzIGlmIHRoZWlyIGNsaWVudHMgYXJlIGluIHRoZSB2 aWV3cG9ydApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9odG1sL21hcnF1ZWUtY2hpbGQtd3JhcC1l eHBlY3RlZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaHRtbC9tYXJxdWVl LWNoaWxkLXdyYXAtZXhwZWN0ZWQuaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9m YXN0L2h0bWwvbWFycXVlZS1jaGlsZC13cmFwLWV4cGVjdGVkLmh0bWwJKHdvcmtpbmcgY29weSkK QEAgLTAsMCArMSw0IEBACis8ZGl2IHN0eWxlPSJ3aWR0aDoyMDBweCI+CisgICAgPGRpdiBzdHls ZT0iYm9yZGVyOjJweCBzb2xpZCBncmVlbiI+PHNwYW4gc3R5bGU9InZpc2liaWxpdHk6aGlkZGVu Ij5UZXh0PC9zcGFuPjwvZGl2PgorPC9kaXY+CisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaHRt bC9tYXJxdWVlLWNoaWxkLXdyYXAuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0 L2h0bWwvbWFycXVlZS1jaGlsZC13cmFwLmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVz dHMvZmFzdC9odG1sL21hcnF1ZWUtY2hpbGQtd3JhcC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMyBAQAorPGRpdiBzdHlsZT0id2lkdGg6MjAwcHgiPgorPG1hcnF1ZWUgc3R5bGU9ImJv cmRlcjoycHggc29saWQgZ3JlZW4iPjxzcGFuPlRleHQgdGV4dCB0ZXh0IHRleHQgdGV4dCB0ZXh0 IHRleHQgdGV4dCB0ZXh0IHRleHQgdGV4dCB0ZXh0IHRleHQgdGV4dCB0ZXh0IHRleHQgdGV4dCB0 ZXh0IHRleHQgdGV4dCB0ZXh0IHRleHQgdGV4dCB0ZXh0IHRleHQgdGV4dCB0ZXh0IHRleHQgdGV4 dCB0ZXh0IHRleHQgdGV4dCB0ZXh0IHRleHQgdGV4dCB0ZXh0IHRleHQ8L3NwYW4+PC9tYXJxdWVl PgorPC9kaXY+Cg==