172201 2017-05-16 17:16:26 -0700 [macOS WK2] LayoutTest webaudio/silent-audio-interrupted-in-background.html is a flaky timeout on older OSes (El Capitan / Sierra) 2022-03-11 09:34:38 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=173916 https://bugs.webkit.org/show_bug.cgi?id=180510 InRadar P2 Normal --- 1 jlewis3 webkit-unassigned ap cdumez jbedard ryanhaddad webkit-bug-importer youennf oldest_to_newest 1309398 0 jlewis3 2017-05-16 17:16:26 -0700 The test webaudio/silent-audio-interrupted-in-background.html is a flaky timeout on macOS wk2. The test was last edited in r214721 https://trac.webkit.org/changeset/214721/webkit https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/1525 https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r216951%20(1525)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webaudio%2Fsilent-audio-interrupted-in-background.html diff: --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/webaudio/silent-audio-interrupted-in-background-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/webaudio/silent-audio-interrupted-in-background-actual.txt @@ -1,14 +1,5 @@ -Tests that silent WebAudio rendering gets interrupted in hidden pages. +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 95499) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS context.state became 'running' -* Setting page visibility to hidden -PASS context.state became 'interrupted' -* Setting page visibility to visible -PASS context.state became 'running' -PASS successfullyParsed is true - -TEST COMPLETE - +#EOF +#EOF 1309402 1 jlewis3 2017-05-16 17:24:37 -0700 I was able to reproduce the timeout on Sierra Release with: run-webkit-tests webaudio/silent-audio-interrupted-in-background.html -f --iterations=100 --no-retry-failure -g It is flaky so it did occasionally pass all test. 1309447 2 ap 2017-05-16 19:59:42 -0700 +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 95499) I believe that this error means that the issue is caused by the preceding test. Perhaps both this and preceding test can cause this? Definitely seems worth a deeper look. 1309450 3 ap 2017-05-16 20:04:09 -0700 Sorry, I misread. "Timed out waiting for notifyDone to be called" is normally about the current test. 1309451 4 ap 2017-05-16 20:07:12 -0700 This test is normally very fast, but times out fairly frequently. 1309454 5 cdumez 2017-05-16 20:13:08 -0700 I will take a look soon. 1309457 6 webkit-bug-importer 2017-05-16 20:16:13 -0700 <rdar://problem/32239545> 1314798 7 cdumez 2017-06-01 13:29:53 -0700 (In reply to Matt Lewis from comment #1) > I was able to reproduce the timeout on Sierra Release with: > > run-webkit-tests webaudio/silent-audio-interrupted-in-background.html -f > --iterations=100 --no-retry-failure -g > > It is flaky so it did occasionally pass all test. I have tried this repeatedly: Tools/Scripts/run-webkit-tests webaudio/silent-audio-interrupted-in-background.html -f --iterations=1000 --no-retry-failure -g So far, no failures though :/ 1314808 8 cdumez 2017-06-01 13:49:04 -0700 (In reply to Chris Dumez from comment #7) > (In reply to Matt Lewis from comment #1) > > I was able to reproduce the timeout on Sierra Release with: > > > > run-webkit-tests webaudio/silent-audio-interrupted-in-background.html -f > > --iterations=100 --no-retry-failure -g > > > > It is flaky so it did occasionally pass all test. > > I have tried this repeatedly: > Tools/Scripts/run-webkit-tests > webaudio/silent-audio-interrupted-in-background.html -f --iterations=1000 > --no-retry-failure -g > > So far, no failures though :/ Looks like I have managed to reproduce with: Tools/Scripts/run-webkit-tests webaudio/silent-audio-interrupted-in-background.html -f --iterations=1000 --no-retry-failure -g --child-processes=50 1314831 9 cdumez 2017-06-01 14:43:24 -0700 This is somehow related to page visibility. The onvisibilitychange event handler on document sometimes does not get called after calling testRunner.setPageVisibility("hidden"). 1314881 10 cdumez 2017-06-01 16:33:05 -0700 (In reply to Chris Dumez from comment #9) > This is somehow related to page visibility. The onvisibilitychange event > handler on document sometimes does not get called after calling > testRunner.setPageVisibility("hidden"). When setting the page visibility to hidden, we end up calling: void TestController::setHidden(bool hidden) { NSWindow *window = [mainWebView()->platformView() window]; if (!window) return; if (hidden) [window orderOut:nil]; else [window makeKeyAndOrderFront:nil]; } 1321970 11 ryanhaddad 2017-06-22 11:06:06 -0700 Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/218706 1573346 12 ap 2019-09-23 10:32:27 -0700 It continues to be a flaky timeout on new OSes. 1850478 13 youennf 2022-03-11 06:19:51 -0800 It is no longer flaky on bots 1850536 14 ap 2022-03-11 09:34:38 -0800 Seems like flaky expectations still need to be removed?