172193 2017-05-16 15:09:08 -0700 WorkerRunLoop::Task::performTask() needs to null check context->script() before use. 2017-05-16 16:07:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo webkit-bug-importer oldest_to_newest 1309325 0 mark.lam 2017-05-16 15:09:08 -0700 Details coming in the patch. <rdar://problem/32225346> 1309351 1 310310 mark.lam 2017-05-16 15:52:31 -0700 Created attachment 310310 proposed patch. 1309361 2 mark.lam 2017-05-16 16:07:30 -0700 Thanks for the review. Landed in r216953: <http://trac.webkit.org/r216953>. 310310 2017-05-16 15:52:31 -0700 2017-05-16 15:55:00 -0700 proposed patch. bug-172193.patch text/plain 3400 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjk0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ0IEBACisyMDE3LTA1LTE2ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBXb3JrZXJSdW5Mb29wOjpUYXNrOjpw ZXJmb3JtVGFzaygpIG5lZWRzIHRvIG51bGwgY2hlY2sgY29udGV4dC0+c2NyaXB0KCkgYmVmb3Jl IHVzZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 MjE5MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzIyMjUzNDY+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIGh0dHBzOi8vYnVp bGQtc2FmYXJpLmFwcGxlLmNvbS9yZXN1bHRzL1RydW5rJTIwRnVqaSUyMEd1YXJkTWFsbG9jJTIw UHJvZHVjdGlvbiUyMFdLMiUyMFRlc3RzL3IyMTY5MjlfNDU5NzYwZTA5MTgzMTYxODdjOGU1MmM2 NTg1YTNhOWJhOTE4MTIwNCUyMCgxMjA2NikvcmVzdWx0cy5odG1sLAorICAgICAgICB3ZSBzZWUg YSBjcmFzaCB3aXRoIHRoaXMgY3Jhc2ggdHJhY2U6CisKKyAgICAgICAgVGhyZWFkIDEzIENyYXNo ZWQ6OiBXZWJDb3JlOiBXb3JrZXIKKyAgICAgICAgMCBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAg MHgwMDAwMDAwMTA5OTYwN2IyIFdlYkNvcmU6OldvcmtlclNjcmlwdENvbnRyb2xsZXI6OmlzVGVy bWluYXRpbmdFeGVjdXRpb24oKSBjb25zdCArIDE4CisgICAgICAgIDEgY29tLmFwcGxlLldlYkNv cmUgICAgICAgIDB4MDAwMDAwMDEwOTk1ZWJiZiBXZWJDb3JlOjpXb3JrZXJSdW5Mb29wOjpydW5D bGVhbnVwVGFza3MoV2ViQ29yZTo6V29ya2VyR2xvYmFsU2NvcGUqKSArIDE0MworICAgICAgICAy IGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAweDAwMDAwMDAxMDk5NWU4MGYgV2ViQ29yZTo6V29y a2VyUnVuTG9vcDo6cnVuKFdlYkNvcmU6Oldvcmtlckdsb2JhbFNjb3BlKikgKyAxMTEKKyAgICAg ICAgMyBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgMHgwMDAwMDAwMTA5OTYyMWI2IFdlYkNvcmU6 OldvcmtlclRocmVhZDo6d29ya2VyVGhyZWFkKCkgKyA3NDIKKyAgICAgICAgNCBjb20uYXBwbGUu SmF2YVNjcmlwdENvcmUgMHgwMDAwMDAwMTBhOTY0YjkyIFdURjo6dGhyZWFkRW50cnlQb2ludCh2 b2lkKikgKyAxNzgKKyAgICAgICAgNSBjb20uYXBwbGUuSmF2YVNjcmlwdENvcmUgMHgwMDAwMDAw MTBhOTY0YTY5IFdURjo6d3RmVGhyZWFkRW50cnlQb2ludCh2b2lkKikgKyAxMjEKKyAgICAgICAg NiBsaWJzeXN0ZW1fcHRocmVhZC5keWxpYiAgMHgwMDAwN2ZmZmJkYjVjYWFiIF9wdGhyZWFkX2Jv ZHkgKyAxODAKKyAgICAgICAgNyBsaWJzeXN0ZW1fcHRocmVhZC5keWxpYiAgMHgwMDAwN2ZmZmJk YjVjOWY3IF9wdGhyZWFkX3N0YXJ0ICsgMjg2CisgICAgICAgIDggbGlic3lzdGVtX3B0aHJlYWQu ZHlsaWIgIDB4MDAwMDdmZmZiZGI1YzFmZCB0aHJlYWRfc3RhcnQgKyAxMworCisgICAgICAgIC4u LiBhbmQgdGhlIGNyYXNoaW5nIGFkZHJlc3MgaXM6CisKKyAgICAgICAgRXhjZXB0aW9uIENvZGVz OiBLRVJOX0lOVkFMSURfQUREUkVTUyBhdCAweDAwMDAwMDAwMDAwMDAwMjIKKworICAgICAgICAw eDAwMDAwMDAwMDAwMDAwMjIgaXMgdGhlIG9mZnNldCBvZiBtX3NjaGVkdWxlZFRlcm1pbmF0aW9u TXV0ZXggaW4gdGhlCisgICAgICAgIFdvcmtlclNjcmlwdENvbnRyb2xsZXIuICBUaGlzIG1lYW5z IHRoYXQgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6aXNUZXJtaW5hdGluZ0V4ZWN1dGlvbigpCisg ICAgICAgIGlzIHBhc3NlZCBhIE5VTEwgdGhpcyBwb2ludGVyLiAgVGhpcyBtZWFucyB0aGF0IGl0 J3MgcG9zc2libGUgdG8gaGF2ZSBhIHJhY2UKKyAgICAgICAgd2hlcmUgYSBXb3JrZXJSdW5Mb29w OjpUYXNrIGdldHMgZW5xdWV1ZWQgYmV5b25kIHRoZSBDbGVhbnVwIHRhc2sgdGhhdCBkZWxldGVz IHRoZQorICAgICAgICBjb250ZXh0LT5zY3JpcHQoKS4gIEFzIGEgcmVzdWx0LCBXb3JrZXJSdW5M b29wOjpUYXNrOjpwZXJmb3JtVGFzaygpIChjYWxsZWQgYnkKKyAgICAgICAgcnVuQ2xlYW51cFRh c2tzKCkpIG1heSBzZWUgYSBudWxsIGNvbnRleHQtPnNjcmlwdCgpLgorCisgICAgICAgIEhlbmNl LCBXb3JrZXJSdW5Mb29wOjpUYXNrOjpwZXJmb3JtVGFzaygpIHNob3VsZCBudWxsIGNoZWNrIGNv bnRleHQtPnNjcmlwdCgpCisgICAgICAgIGJlZm9yZSBpbnZva2luZyB0aGUgaXNUZXJtaW5hdGlu Z0V4ZWN1dGlvbigpIHF1ZXJ5IG9uIGl0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNl IHRoaXMgaXMgYWxyZWFkeSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICog d29ya2Vycy9Xb3JrZXJSdW5Mb29wLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlclJ1bkxv b3A6OlRhc2s6OnBlcmZvcm1UYXNrKToKKwogMjAxNy0wNS0xNiAgWW91ZW5uIEZhYmxldCAgPHlv dWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlIHNo b3VsZCBzdXBwb3J0IHNpbmtXYW50cyBmb3Igcm90YXRpb24KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3dvcmtlcnMvV29ya2VyUnVuTG9vcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv d29ya2Vycy9Xb3JrZXJSdW5Mb29wLmNwcAkocmV2aXNpb24gMjE2OTQ4KQorKysgU291cmNlL1dl YkNvcmUvd29ya2Vycy9Xb3JrZXJSdW5Mb29wLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU0LDgg KzI1NCw3IEBAIHZvaWQgV29ya2VyUnVuTG9vcDo6cG9zdFRhc2tGb3JNb2RlKFNjcmkKIAogdm9p ZCBXb3JrZXJSdW5Mb29wOjpUYXNrOjpwZXJmb3JtVGFzayhXb3JrZXJHbG9iYWxTY29wZSogY29u dGV4dCkKIHsKLSAgICBBU1NFUlQoY29udGV4dC0+c2NyaXB0KCkpOwotICAgIGlmICgoIWNvbnRl eHQtPmlzQ2xvc2luZygpICYmICFjb250ZXh0LT5zY3JpcHQoKS0+aXNUZXJtaW5hdGluZ0V4ZWN1 dGlvbigpKSB8fCBtX3Rhc2suaXNDbGVhbnVwVGFzaygpKQorICAgIGlmICgoIWNvbnRleHQtPmlz Q2xvc2luZygpICYmIGNvbnRleHQtPnNjcmlwdCgpICYmICFjb250ZXh0LT5zY3JpcHQoKS0+aXNU ZXJtaW5hdGluZ0V4ZWN1dGlvbigpKSB8fCBtX3Rhc2suaXNDbGVhbnVwVGFzaygpKQogICAgICAg ICBtX3Rhc2sucGVyZm9ybVRhc2soKmNvbnRleHQpOwogfQogCg==