172170 2017-05-16 08:59:48 -0700 WebItemProviderPasteboard should be robust when temporary files are missing path extensions 2017-05-18 12:40:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue megan_gardner thorton oldest_to_newest 1309142 0 wenson_hsieh 2017-05-16 08:59:48 -0700 WebItemProviderPasteboard should be robust when temporary files are missing path extensions 1309144 1 310265 wenson_hsieh 2017-05-16 09:07:06 -0700 Created attachment 310265 Patch 1309165 2 310265 thorton 2017-05-16 10:19:12 -0700 Comment on attachment 310265 Patch Wut, requiring an extension is bizarre regardless of the mechanism. 1309170 3 310265 wenson_hsieh 2017-05-16 10:23:42 -0700 Comment on attachment 310265 Patch Thanks Tim! 1309187 4 310265 commit-queue 2017-05-16 10:53:01 -0700 Comment on attachment 310265 Patch Clearing flags on attachment: 310265 Committed r216936: <http://trac.webkit.org/changeset/216936> 1309188 5 commit-queue 2017-05-16 10:53:02 -0700 All reviewed patches have been landed. Closing bug. 1310204 6 wenson_hsieh 2017-05-18 12:40:51 -0700 <rdar://problem/32278538> 310265 2017-05-16 09:07:06 -0700 2017-05-16 10:53:01 -0700 Patch bug-172170-20170516090705.patch text/plain 4197 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWU3NGFkMjlkYzNiMGVi ZTQ1N2ViNjkxNThlN2FiNWNiMWNiYzg4ZS4uODNkNTAwMjQ0OGYzY2Q3NjIwNjcwZGJhZWQ1Y2Y4 YjUzN2ZkOTA4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA1LTE2ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFdlYkl0ZW1Qcm92 aWRlclBhc3RlYm9hcmQgc2hvdWxkIGJlIHJvYnVzdCB3aGVuIHRlbXBvcmFyeSBmaWxlcyBhcmUg bWlzc2luZyBwYXRoIGV4dGVuc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MjE3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1ha2VzIGEgc2xpZ2h0IGFkanVzdG1lbnQgdG8gdGhlIHRlbXBvcmFy eSBmaWxlIFVSTHMgYXJlIGhhbmRsZWQgd2hlbiB1c2luZyBXZWJJdGVtUHJvdmlkZXJQYXN0ZWJv YXJkIHRvIGxvYWQKKyAgICAgICAgZGF0YSBvZmYgb2YgaXRlbSBwcm92aWRlcnMuIFByZXZpb3Vz bHksIHdlIHdvdWxkIGJhaWwgZWFybHkgYW5kIG5vdCBsb2FkIGFueSBkYXRhIGlmIHRoZSB0ZW1w b3JhcnkgVVJMIGlzCisgICAgICAgIG1pc3NpbmcgYW4gZXh0ZW5zaW9uLiBTaW5jZSB0aGUgc3dp dGNoIHRvIE5TSXRlbVByb3ZpZGVycyBmcm9tIFVJSXRlbVByb3ZpZGVycywgc29tZSB0eXBlcyBv ZiB0ZW1wb3JhcnkgZmlsZXMKKyAgICAgICAgZ2VuZXJhdGVkIGJ5IGl0ZW0gcHJvdmlkZXJzIGFy ZSBtaXNzaW5nIGV4dGVuc2lvbnMsIHNvIHRoaXMgZXh0cmEgY2hlY2sgaXMgbWVhbmluZ2xlc3Mu CisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyBkYXRhIGludGVyYWN0aW9uIHVuaXQgdGVz dHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViSXRlbVByb3ZpZGVyUGFzdGVib2FyZC5t bToKKyAgICAgICAgKHRlbXBvcmFyeUZpbGVVUkxGb3JEYXRhSW50ZXJhY3Rpb25Db250ZW50KToK KyAgICAgICAgKC1bV2ViSXRlbVByb3ZpZGVyUGFzdGVib2FyZCBkb0FmdGVyTG9hZGluZ1Byb3Zp ZGVkQ29udGVudEludG9GaWxlVVJMczpzeW5jaHJvbm91c1RpbWVvdXQ6XSk6CisKIDIwMTctMDUt MTAgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQ29yZUF1ZGlv Q2FwdHVyZVNvdXJjZSByZXBvcnRzIDMgb3IgNSBjaGFubmVsIGF1ZGlvIG91dHB1dDsgYWN0dWFs bHkgb25seSBtb25vCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2Vi SXRlbVByb3ZpZGVyUGFzdGVib2FyZC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9X ZWJJdGVtUHJvdmlkZXJQYXN0ZWJvYXJkLm1tCmluZGV4IDZjMDU4MjM4OWRmZjgwMmE5ZGJiOWYw MGU1NmEyZGIxNTFkZGRhZTIuLjFmN2ZkM2VkM2FjZTlhOTY1Zjg5NTgxNjQ5N2VlMzliMjZjZmUy NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJJdGVtUHJvdmlk ZXJQYXN0ZWJvYXJkLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJJdGVt UHJvdmlkZXJQYXN0ZWJvYXJkLm1tCkBAIC00MDUsMTkgKzQwNSwxOSBAQCAtIChOU0ludGVnZXIp bnVtYmVyT2ZGaWxlcwogICAgIHJldHVybiBudW1iZXJPZkZpbGVzOwogfQogCi1zdGF0aWMgTlNV UkwgKnRlbXBvcmFyeUZpbGVVUkxGb3JEYXRhSW50ZXJhY3Rpb25Db250ZW50KE5TU3RyaW5nICpm aWxlRXh0ZW5zaW9uLCBOU1N0cmluZyAqc3VnZ2VzdGVkTmFtZSkKK3N0YXRpYyBOU1VSTCAqdGVt cG9yYXJ5RmlsZVVSTEZvckRhdGFJbnRlcmFjdGlvbkNvbnRlbnQoTlNVUkwgKnVybCwgTlNTdHJp bmcgKnN1Z2dlc3RlZE5hbWUpCiB7CiAgICAgc3RhdGljIE5TU3RyaW5nICpkZWZhdWx0RGF0YUlu dGVyYWN0aW9uRmlsZU5hbWUgPSBAImZpbGUiOwogICAgIHN0YXRpYyBOU1N0cmluZyAqZGF0YUlu dGVyYWN0aW9uRGlyZWN0b3J5UHJlZml4ID0gQCJkYXRhLWludGVyYWN0aW9uIjsKLSAgICBpZiAo IWZpbGVFeHRlbnNpb24ubGVuZ3RoKQorICAgIGlmICghdXJsKQogICAgICAgICByZXR1cm4gbmls OwogCiAgICAgTlNTdHJpbmcgKnRlbXBvcmFyeURhdGFJbnRlcmFjdGlvbkRpcmVjdG9yeSA9IFdl YkNvcmU6OmNyZWF0ZVRlbXBvcmFyeURpcmVjdG9yeShkYXRhSW50ZXJhY3Rpb25EaXJlY3RvcnlQ cmVmaXgpOwogICAgIGlmICghdGVtcG9yYXJ5RGF0YUludGVyYWN0aW9uRGlyZWN0b3J5KQogICAg ICAgICByZXR1cm4gbmlsOwogCi0gICAgTlNTdHJpbmcgKmZpbGVuYW1lV2l0aEV4dGVuc2lvbiA9 IFtzdWdnZXN0ZWROYW1lID86IGRlZmF1bHREYXRhSW50ZXJhY3Rpb25GaWxlTmFtZSBzdHJpbmdC eUFwcGVuZGluZ1BhdGhFeHRlbnNpb246ZmlsZUV4dGVuc2lvbl07Ci0gICAgcmV0dXJuIFtOU1VS TCBmaWxlVVJMV2l0aFBhdGg6W3RlbXBvcmFyeURhdGFJbnRlcmFjdGlvbkRpcmVjdG9yeSBzdHJp bmdCeUFwcGVuZGluZ1BhdGhDb21wb25lbnQ6ZmlsZW5hbWVXaXRoRXh0ZW5zaW9uXV07CisgICAg c3VnZ2VzdGVkTmFtZSA9IFtzdWdnZXN0ZWROYW1lID86IGRlZmF1bHREYXRhSW50ZXJhY3Rpb25G aWxlTmFtZSBzdHJpbmdCeUFwcGVuZGluZ1BhdGhFeHRlbnNpb246dXJsLnBhdGhFeHRlbnNpb25d OworICAgIHJldHVybiBbTlNVUkwgZmlsZVVSTFdpdGhQYXRoOlt0ZW1wb3JhcnlEYXRhSW50ZXJh Y3Rpb25EaXJlY3Rvcnkgc3RyaW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OnVybC5sYXN0UGF0 aENvbXBvbmVudCA/OiBzdWdnZXN0ZWROYW1lXV07CiB9CiAKIC0gKHZvaWQpZG9BZnRlckxvYWRp bmdQcm92aWRlZENvbnRlbnRJbnRvRmlsZVVSTHM6KFdlYkl0ZW1Qcm92aWRlckZpbGVMb2FkQmxv Y2spYWN0aW9uCkBAIC00ODMsNyArNDgzLDcgQEAgLSAodm9pZClkb0FmdGVyTG9hZGluZ1Byb3Zp ZGVkQ29udGVudEludG9GaWxlVVJMczooV2ViSXRlbVByb3ZpZGVyRmlsZUxvYWRCbG9jaykKICAg ICAgICAgICAgIC8vIEFmdGVyIGV4ZWN1dGluZyB0aGlzIGNvbXBsZXRpb24gYmxvY2ssIFVJS2l0 IHJlbW92ZXMgdGhlIGZpbGUgYXQgdGhlIGdpdmVuIFVSTC4gSG93ZXZlciwgd2UgbmVlZCB0aGlz IGRhdGEgdG8gcGVyc2lzdCBsb25nZXIgZm9yIHRoZSB3ZWIgY29udGVudCBwcm9jZXNzLgogICAg ICAgICAgICAgLy8gVG8gYWRkcmVzcyB0aGlzLCB3ZSBoYXJkIGxpbmsgdGhlIGdpdmVuIFVSTCB0 byBhIG5ldyB0ZW1wb3JhcnkgZmlsZSBpbiB0aGUgdGVtcG9yYXJ5IGRpcmVjdG9yeS4gVGhpcyBm b2xsb3dzIHRoZSBzYW1lIGZsb3cgYXMgcmVndWxhciBmaWxlIHVwbG9hZCwgaW4KICAgICAgICAg ICAgIC8vIFdLRmlsZVVwbG9hZFBhbmVsLm1tLiBUaGUgdGVtcG9yYXJ5IGZpbGVzIGFyZSBjbGVh bmVkIHVwIGJ5IHRoZSBzeXN0ZW0gYXQgYSBsYXRlciB0aW1lLgotICAgICAgICAgICAgUmV0YWlu UHRyPE5TVVJMPiBkZXN0aW5hdGlvblVSTCA9IHRlbXBvcmFyeUZpbGVVUkxGb3JEYXRhSW50ZXJh Y3Rpb25Db250ZW50KHVybC5wYXRoRXh0ZW5zaW9uLCBzdWdnZXN0ZWROYW1lLmdldCgpID86IHVy bC5sYXN0UGF0aENvbXBvbmVudCk7CisgICAgICAgICAgICBSZXRhaW5QdHI8TlNVUkw+IGRlc3Rp bmF0aW9uVVJMID0gdGVtcG9yYXJ5RmlsZVVSTEZvckRhdGFJbnRlcmFjdGlvbkNvbnRlbnQodXJs LCBzdWdnZXN0ZWROYW1lLmdldCgpKTsKICAgICAgICAgICAgIGlmIChkZXN0aW5hdGlvblVSTCAm JiAhZXJyb3IgJiYgW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1bHRNYW5hZ2VyXSBsaW5rSXRlbUF0VVJM OnVybCB0b1VSTDpkZXN0aW5hdGlvblVSTC5nZXQoKSBlcnJvcjpuaWxdKSB7CiAgICAgICAgICAg ICAgICAgW3NldEZpbGVVUkxzTG9jayBsb2NrXTsKICAgICAgICAgICAgICAgICBbdHlwZVRvRmls ZVVSTE1hcHMgc2V0T2JqZWN0OltOU0RpY3Rpb25hcnkgZGljdGlvbmFyeVdpdGhPYmplY3Q6ZGVz dGluYXRpb25VUkwuZ2V0KCkgZm9yS2V5OnR5cGVJZGVudGlmaWVyLmdldCgpXSBhdEluZGV4ZWRT dWJzY3JpcHQ6aW5kZXhJbkl0ZW1Qcm92aWRlckFycmF5XTsK