172162 2017-05-15 23:09:34 -0700 [WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based contexts when offscreen target provides no native window 2017-05-16 06:04:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cgarcia oldest_to_newest 1308999 0 zan 2017-05-15 23:09:34 -0700 [WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based contexts when offscreen target provides no native window 1309000 1 310231 zan 2017-05-15 23:11:20 -0700 Created attachment 310231 Patch 1309056 2 310231 cgarcia 2017-05-16 01:00:45 -0700 Comment on attachment 310231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310231&action=review > Source/WebCore/platform/graphics/egl/GLContextEGLWPE.cpp:36 > + if (!context) > + context = createPbufferContext(platformDisplay, sharingContext); Why not falling back to a surfaceless context if available? 1309104 3 zan 2017-05-16 05:48:03 -0700 (In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 310231 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=310231&action=review > > > Source/WebCore/platform/graphics/egl/GLContextEGLWPE.cpp:36 > > + if (!context) > > + context = createPbufferContext(platformDisplay, sharingContext); > > Why not falling back to a surfaceless context if available? I'll look into it. Will add a FIXME until then. 1309113 4 zan 2017-05-16 06:04:33 -0700 Committed r216930: <http://trac.webkit.org/changeset/216930> 310231 2017-05-15 23:11:20 -0700 2017-05-16 01:00:45 -0700 Patch bug-172162-20170516081119.patch text/plain 2268 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmEzZTc2ZjQxM2Y1NTFi NGM4N2JmNTdiN2ZhZmEwNmYzNWUxNGE5Yi4uMWE0NTFhMDFkNTNlNTlkNDk4YmQxN2ZhY2YxNWY3 ZjQ3OTcxOGYyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA1LTE1ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBHTENvbnRl eHRFR0w6OmNyZWF0ZVdQRUNvbnRleHQoKSBzaG91bGQgZmFsbCBiYWNrIHRvIHBidWZmZXItYmFz ZWQgY29udGV4dHMgd2hlbiBvZmZzY3JlZW4gdGFyZ2V0IHByb3ZpZGVzIG5vIG5hdGl2ZSB3aW5k b3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjE2 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4g Y3JlYXRpbmcgYW4gb2Zmc2NyZWVuIEdMQ29udGV4dCwgdGhlIHVuZGVybHlpbmcgaW1wbGVtZW50 YXRpb24gbWlnaHQKKyAgICAgICAgcHJvdmlkZSBhIG1vY2sgbmF0aXZlIHdpbmRvdyB0aGF0J3Mg dG8gYmUgdXNlZCBhcyB0aGUgd2luZG93IHRhcmdldCB1cG9uCisgICAgICAgIHdoaWNoIGEgd2lu ZG93LWJhc2VkIEdMQ29udGV4dCBzaG91bGQgYmUgY3JlYXRlZC4gQnV0IHdlIHNob3VsZCBhbHNv IHN1cHBvcnQKKyAgICAgICAgZmFsbGluZyBiYWNrIHRvIHBidWZmZXItYmFzZWQgR0xDb250ZXh0 cyB3aGVuIHRoZSB1bmRlcmx5aW5nIGltcGxlbWVudGF0aW9uCisgICAgICAgIGNhbid0IHByb3Zp ZGUgc3VjaCBtb2NrIHRhcmdldHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9lZ2wv R0xDb250ZXh0RUdMV1BFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdMQ29udGV4dEVHTDo6Y3Jl YXRlV1BFQ29udGV4dCk6CisKIDIwMTctMDUtMTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IFJlYWx0aW1lTWVkaWFTb3VyY2UgZGF0YSBwcm9k dWN0aW9uIGFuZCBzdGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZWdsL0dMQ29udGV4dEVHTFdQRS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMV1BFLmNwcAppbmRleCA5ZjNmNDJkNzY0Mjg2M2VmYTg2 YTc0ODViNjQzOTNjNTljZGQ4MDUxLi41M2NlZDk2YzdhOWIxYjc0NGZiNjZmN2IwZjRjNzBkNDQy NGJkNWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wv R0xDb250ZXh0RUdMV1BFLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9lZ2wvR0xDb250ZXh0RUdMV1BFLmNwcApAQCAtMjgsNyArMjgsMTMgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogc3RkOjp1bmlxdWVfcHRyPEdMQ29udGV4dEVHTD4gR0xDb250ZXh0RUdMOjpjcmVh dGVXUEVDb250ZXh0KFBsYXRmb3JtRGlzcGxheSYgcGxhdGZvcm1EaXNwbGF5LCBFR0xDb250ZXh0 IHNoYXJpbmdDb250ZXh0KQogewogICAgIGF1dG8gb2Zmc2NyZWVuVGFyZ2V0ID0gZG93bmNhc3Q8 UGxhdGZvcm1EaXNwbGF5V1BFPihwbGF0Zm9ybURpc3BsYXkpLmNyZWF0ZUVHTE9mZnNjcmVlblRh cmdldCgpOwotICAgIGF1dG8gY29udGV4dCA9IGNyZWF0ZVdpbmRvd0NvbnRleHQob2Zmc2NyZWVu VGFyZ2V0LT5uYXRpdmVXaW5kb3coKSwgcGxhdGZvcm1EaXNwbGF5LCBzaGFyaW5nQ29udGV4dCk7 CisKKyAgICBzdGQ6OnVuaXF1ZV9wdHI8R0xDb250ZXh0RUdMPiBjb250ZXh0OworICAgIGlmIChv ZmZzY3JlZW5UYXJnZXQtPm5hdGl2ZVdpbmRvdygpKQorICAgICAgICBjb250ZXh0ID0gY3JlYXRl V2luZG93Q29udGV4dChvZmZzY3JlZW5UYXJnZXQtPm5hdGl2ZVdpbmRvdygpLCBwbGF0Zm9ybURp c3BsYXksIHNoYXJpbmdDb250ZXh0KTsKKyAgICBpZiAoIWNvbnRleHQpCisgICAgICAgIGNvbnRl eHQgPSBjcmVhdGVQYnVmZmVyQ29udGV4dChwbGF0Zm9ybURpc3BsYXksIHNoYXJpbmdDb250ZXh0 KTsKKwogICAgIGlmIChjb250ZXh0KQogICAgICAgICBjb250ZXh0LT5tX3dwZVRhcmdldCA9IFdU Rk1vdmUob2Zmc2NyZWVuVGFyZ2V0KTsKICAgICByZXR1cm4gY29udGV4dDsK