172160 2017-05-15 22:45:57 -0700 [GLib] Use RunLoopSourcePriority::RunLoopTimer as the GSocketMonitor's GSource priority 2017-05-16 05:57:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan bugs-noreply cgarcia oldest_to_newest 1308991 0 zan 2017-05-15 22:45:57 -0700 [GLib] Use RunLoopSourcePriority::RunLoopTimer as the GSocketMonitor's GSource priority 1308993 1 310229 zan 2017-05-15 22:46:56 -0700 Created attachment 310229 Patch 1309054 2 310229 cgarcia 2017-05-16 00:58:23 -0700 Comment on attachment 310229 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310229&action=review > Source/WebKit2/ChangeLog:11 > + * Platform/IPC/glib/GSocketMonitor.cpp: > + (IPC::GSocketMonitor::start): Explicitly set the priority for the GSocketMonitor's > + GSource object to RunLoopSourcePriority::RunLoopTimer, equating the dispatch > + priority to that of RunLoop::Timer objects. I'm not sure this is the priority we want. Messages sent to the io thread will be done by WorkQueue::dispatch which uses the RunLoopDispatcher priority. So, in the case of the GTK+ port this is giving more priority to socket events. We want at least the same priority, or even more to the dispatchs, so that for example a connectionDidClose() message could be dispatched even if the socket has data to read. So, I would use RunLoopDispatcher instead of RunLoopTimer to use the same priority in both GTK+ and WPE ports. 1309097 3 310254 zan 2017-05-16 05:02:59 -0700 Created attachment 310254 Patch 1309110 4 310254 zan 2017-05-16 05:57:18 -0700 Comment on attachment 310254 Patch Clearing flags on attachment: 310254 Committed r216929: <http://trac.webkit.org/changeset/216929> 1309111 5 zan 2017-05-16 05:57:22 -0700 All reviewed patches have been landed. Closing bug. 310229 2017-05-15 22:46:56 -0700 2017-05-16 05:02:56 -0700 Patch bug-172160-20170516074655.patch text/plain 1932 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjNhNmRmNGY1YWU5MjU3 N2ZiY2FlZTA2OGMzZGFhNjllYWI5ZjMxMi4uNzlhMDY0NTI5NGUwYjg4OWI0OWJiYmY1ZWI5YTQ0 NDk5MTk0ZWQzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTE1ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xpYl0gVXNlIFJ1 bkxvb3BTb3VyY2VQcmlvcml0eTo6UnVuTG9vcFRpbWVyIGFzIHRoZSBHU29ja2V0TW9uaXRvcidz IEdTb3VyY2UgcHJpb3JpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MjE2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogUGxhdGZvcm0vSVBDL2dsaWIvR1NvY2tldE1vbml0b3IuY3BwOgorICAgICAg ICAoSVBDOjpHU29ja2V0TW9uaXRvcjo6c3RhcnQpOiBFeHBsaWNpdGx5IHNldCB0aGUgcHJpb3Jp dHkgZm9yIHRoZSBHU29ja2V0TW9uaXRvcidzCisgICAgICAgIEdTb3VyY2Ugb2JqZWN0IHRvIFJ1 bkxvb3BTb3VyY2VQcmlvcml0eTo6UnVuTG9vcFRpbWVyLCBlcXVhdGluZyB0aGUgZGlzcGF0Y2gK KyAgICAgICAgcHJpb3JpdHkgdG8gdGhhdCBvZiBSdW5Mb29wOjpUaW1lciBvYmplY3RzLgorCiAy MDE3LTA1LTE1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBT aW1wbGlmeSBSZWFsdGltZU1lZGlhU291cmNlIGRhdGEgcHJvZHVjdGlvbiBhbmQgc3RhdGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9nbGliL0dTb2NrZXRNb25pdG9y LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9nbGliL0dTb2NrZXRNb25pdG9yLmNw cAppbmRleCA4ZDEwMWNmNGYxMzE3MTVmZDhhNmRmYTFjMjQ4M2NlY2NhZjBjYjA2Li4yOTMxM2Zj N2M0ZDYwMGI2MWIzMzY1ZTk1NDI3NjExOGE0YTQ1NmQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9JUEMvZ2xpYi9HU29ja2V0TW9uaXRvci5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvUGxhdGZvcm0vSVBDL2dsaWIvR1NvY2tldE1vbml0b3IuY3BwCkBAIC0yNyw2ICsyNyw3 IEBACiAjaW5jbHVkZSAiR1NvY2tldE1vbml0b3IuaCIKIAogI2luY2x1ZGUgPGdpby9naW8uaD4K KyNpbmNsdWRlIDx3dGYvZ2xpYi9SdW5Mb29wU291cmNlUHJpb3JpdHkuaD4KIAogbmFtZXNwYWNl IElQQyB7CiAKQEAgLTUxLDkgKzUyLDcgQEAgdm9pZCBHU29ja2V0TW9uaXRvcjo6c3RhcnQoR1Nv Y2tldCogc29ja2V0LCBHSU9Db25kaXRpb24gY29uZGl0aW9uLCBSdW5Mb29wJiBydW4KICAgICBn X3NvdXJjZV9zZXRfbmFtZShtX3NvdXJjZS5nZXQoKSwgIltXZWJLaXRdIFNvY2tldCBtb25pdG9y Iik7CiAgICAgbV9jYWxsYmFjayA9IFdURk1vdmUoY2FsbGJhY2spOwogICAgIGdfc291cmNlX3Nl dF9jYWxsYmFjayhtX3NvdXJjZS5nZXQoKSwgcmVpbnRlcnByZXRfY2FzdDxHU291cmNlRnVuYz4o c29ja2V0U291cmNlQ2FsbGJhY2spLCB0aGlzLCBudWxscHRyKTsKLSNpZiBQTEFURk9STShXUEUp Ci0gICAgZ19zb3VyY2Vfc2V0X3ByaW9yaXR5KG1fc291cmNlLmdldCgpLCBHX1BSSU9SSVRZX0hJ R0ggKyAzMCk7Ci0jZW5kaWYKKyAgICBnX3NvdXJjZV9zZXRfcHJpb3JpdHkobV9zb3VyY2UuZ2V0 KCksIFJ1bkxvb3BTb3VyY2VQcmlvcml0eTo6UnVuTG9vcFRpbWVyKTsKICAgICBnX3NvdXJjZV9h dHRhY2gobV9zb3VyY2UuZ2V0KCksIHJ1bkxvb3AubWFpbkNvbnRleHQoKSk7CiB9CiAK 310254 2017-05-16 05:02:59 -0700 2017-05-16 05:57:18 -0700 Patch bug-172160-20170516140258.patch text/plain 1972 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjNhNmRmNGY1YWU5MjU3 N2ZiY2FlZTA2OGMzZGFhNjllYWI5ZjMxMi4uYmFiYTEwZjJjMDJiZjliMmY4ZWNmYzk1ZjZhZmVk ZThlZDdhZTI1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTE2ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xpYl0gVXNlIFJ1 bkxvb3BTb3VyY2VQcmlvcml0eTo6UnVuTG9vcERpc3BhdGNoZXIgYXMgdGhlIEdTb2NrZXRNb25p dG9yJ3MgR1NvdXJjZSBwcmlvcml0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTcyMTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvZ2xpYi9HU29ja2V0TW9uaXRvci5jcHA6Cisg ICAgICAgIChJUEM6OkdTb2NrZXRNb25pdG9yOjpzdGFydCk6IEV4cGxpY2l0bHkgc2V0IHRoZSBw cmlvcml0eSBmb3IgdGhlIEdTb2NrZXRNb25pdG9yJ3MKKyAgICAgICAgR1NvdXJjZSBvYmplY3Qg dG8gUnVuTG9vcFNvdXJjZVByaW9yaXR5OjpSdW5Mb29wRGlzcGF0Y2hlciwgZXF1YXRpbmcgaXQg dG8gdGhlCisgICAgICAgIHByaW9yaXR5IHRoYXQncyB1c2VkIGluIFJ1bkxvb3AgZm9yIGRpc3Bh dGNoZXMgb2YgdGhlIHF1ZXVlZCBmdW5jdGlvbnMuCisKIDIwMTctMDUtMTUgIFlvdWVubiBGYWJs ZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IFJlYWx0aW1lTWVkaWFT b3VyY2UgZGF0YSBwcm9kdWN0aW9uIGFuZCBzdGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vSVBDL2dsaWIvR1NvY2tldE1vbml0b3IuY3BwIGIvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vSVBDL2dsaWIvR1NvY2tldE1vbml0b3IuY3BwCmluZGV4IDhkMTAxY2Y0ZjEzMTcx NWZkOGE2ZGZhMWMyNDgzY2VjY2FmMGNiMDYuLmQxZTRmY2M1MTVjMjgxYjQ4MmM1NDI4YmYyNzIw N2VmMjllZTRiZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9nbGli L0dTb2NrZXRNb25pdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvZ2xp Yi9HU29ja2V0TW9uaXRvci5jcHAKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlICJHU29ja2V0 TW9uaXRvci5oIgogCiAjaW5jbHVkZSA8Z2lvL2dpby5oPgorI2luY2x1ZGUgPHd0Zi9nbGliL1J1 bkxvb3BTb3VyY2VQcmlvcml0eS5oPgogCiBuYW1lc3BhY2UgSVBDIHsKIApAQCAtNTEsOSArNTIs NyBAQCB2b2lkIEdTb2NrZXRNb25pdG9yOjpzdGFydChHU29ja2V0KiBzb2NrZXQsIEdJT0NvbmRp dGlvbiBjb25kaXRpb24sIFJ1bkxvb3AmIHJ1bgogICAgIGdfc291cmNlX3NldF9uYW1lKG1fc291 cmNlLmdldCgpLCAiW1dlYktpdF0gU29ja2V0IG1vbml0b3IiKTsKICAgICBtX2NhbGxiYWNrID0g V1RGTW92ZShjYWxsYmFjayk7CiAgICAgZ19zb3VyY2Vfc2V0X2NhbGxiYWNrKG1fc291cmNlLmdl dCgpLCByZWludGVycHJldF9jYXN0PEdTb3VyY2VGdW5jPihzb2NrZXRTb3VyY2VDYWxsYmFjayks IHRoaXMsIG51bGxwdHIpOwotI2lmIFBMQVRGT1JNKFdQRSkKLSAgICBnX3NvdXJjZV9zZXRfcHJp b3JpdHkobV9zb3VyY2UuZ2V0KCksIEdfUFJJT1JJVFlfSElHSCArIDMwKTsKLSNlbmRpZgorICAg IGdfc291cmNlX3NldF9wcmlvcml0eShtX3NvdXJjZS5nZXQoKSwgUnVuTG9vcFNvdXJjZVByaW9y aXR5OjpSdW5Mb29wRGlzcGF0Y2hlcik7CiAgICAgZ19zb3VyY2VfYXR0YWNoKG1fc291cmNlLmdl dCgpLCBydW5Mb29wLm1haW5Db250ZXh0KCkpOwogfQogCg==