172153 2017-05-15 18:10:31 -0700 [SOUP] Remove LATEST_RECORD_VERSION from GnuTLS priority string 2017-05-16 10:29:08 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED https://bugzilla.gnome.org/show_bug.cgi?id=782218 P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply bugzilla cgarcia commit-queue mcatanzaro oldest_to_newest 1308915 0 mcatanzaro 2017-05-15 18:10:31 -0700 Based on discussion with Nikos in https://bugzilla.gnome.org/show_bug.cgi?id=782218, we should remove LATEST_RECORD_VERSION from our GnuTLS priority string. This causes GnuTLS to use the latest TLS record version (the record format is separate from the TLS protocol version), which we needed a couple years ago (after dropping SSLv3) for maximum compatibility with broken web servers. But it's not needed anymore, and is causing new compatibility problems with other broken web servers, so let's get rid of it. 1308919 1 310201 mcatanzaro 2017-05-15 18:16:33 -0700 Created attachment 310201 Patch 1309047 2 310201 commit-queue 2017-05-16 00:44:44 -0700 Comment on attachment 310201 Patch Clearing flags on attachment: 310201 Committed r216915: <http://trac.webkit.org/changeset/216915> 1309048 3 commit-queue 2017-05-16 00:44:46 -0700 All reviewed patches have been landed. Closing bug. 1309172 4 mcatanzaro 2017-05-16 10:29:08 -0700 By the way, since this only fixes compatibility with extremely broken TLS servers, and since there is a significant risk of unexpected regressions with other broken servers, I would not recommend backporting this. 310201 2017-05-15 18:16:33 -0700 2017-05-16 00:44:44 -0700 Patch bug-172153-20170515201632.patch text/plain 3073 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWIzZmFmMWIyNTYzYTQ0 MjMwZGVhZDgxNjczMjcxNTI3MTlmNGMwOC4uMDZkNGIxM2E5M2EzOGFhZDNhNmQzZDZiM2Q4MDMy NjlkMjAzYmYyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA1LTE1ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0g UmVtb3ZlIExBVEVTVF9SRUNPUkRfVkVSU0lPTiBmcm9tIEdudVRMUyBwcmlvcml0eSBzdHJpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjE1Mwor CisgICAgICAgIEJhc2VkIG9uIGRpc2N1c3Npb24gd2l0aCBOaWtvcyBpbiBodHRwczovL2J1Z3pp bGxhLmdub21lLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgyMjE4LCB3ZQorICAgICAgICBzaG91bGQg cmVtb3ZlIExBVEVTVF9SRUNPUkRfVkVSU0lPTiBmcm9tIG91ciBHbnVUTFMgcHJpb3JpdHkgc3Ry aW5nLiBUaGlzIGNhdXNlcyBHbnVUTFMgdG8KKyAgICAgICAgdXNlIHRoZSBsYXRlc3QgVExTIHJl Y29yZCB2ZXJzaW9uICh0aGUgcmVjb3JkIGZvcm1hdCBpcyBzZXBhcmF0ZSBmcm9tIHRoZSBUTFMg cHJvdG9jb2wKKyAgICAgICAgdmVyc2lvbiksIHdoaWNoIHdlIG5lZWRlZCBhIGNvdXBsZSB5ZWFy cyBhZ28gKGFmdGVyIGRyb3BwaW5nIFNTTHYzKSBmb3IgbWF4aW11bQorICAgICAgICBjb21wYXRp YmlsaXR5IHdpdGggYnJva2VuIHdlYiBzZXJ2ZXJzLiBCdXQgaXQncyBub3QgbmVlZGVkIGFueW1v cmUsIGFuZCBpcyBjYXVzaW5nIG5ldworICAgICAgICBjb21wYXRpYmlsaXR5IHByb2JsZW1zIHdp dGggb3RoZXIgYnJva2VuIHdlYiBzZXJ2ZXJzLCBzbyBsZXQncyBnZXQgcmlkIG9mIGl0LgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1By b2Nlc3MvRW50cnlQb2ludC91bml4L05ldHdvcmtQcm9jZXNzTWFpbi5jcHA6CisgICAgICAgICht YWluKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL0VudHJ5UG9pbnQvdW5peC9XZWJQcm9jZXNzTWFp bi5jcHA6CisgICAgICAgIChtYWluKToKKwogMjAxNy0wNS0xNSAgQnJlbnQgRnVsZ2hhbSAgPGJm dWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBDb3JyZWN0IHR5cG8gKHBhcnQgb2YgcjIxNjc5 MCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9FbnRyeVBvaW50 L3VuaXgvTmV0d29ya1Byb2Nlc3NNYWluLmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL0VudHJ5UG9pbnQvdW5peC9OZXR3b3JrUHJvY2Vzc01haW4uY3BwCmluZGV4IGIyODJlMTZh Mzc4MTBhN2Q3ZjEyM2QwNWNmYTA3MWY3NjJjM2Q1ODIuLjZjMGRiMWU3NDBmOWQ0NWQwZTMzODc5 YjIwMDFkMTg2YzA3ZWM3YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL0VudHJ5UG9pbnQvdW5peC9OZXR3b3JrUHJvY2Vzc01haW4uY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL05ldHdvcmtQcm9jZXNzL0VudHJ5UG9pbnQvdW5peC9OZXR3b3JrUHJvY2Vzc01haW4u Y3BwCkBAIC0zOSw3ICszOSw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKICAg ICAvLyBvdmVyd3JpdGUgdGhpcyBwcmlvcml0eSBzdHJpbmcgaWYgaXQncyBhbHJlYWR5IHNldCBi eSB0aGUgdXNlci4KICAgICAvLyBodHRwczovL2J1Z3ppbGxhLmdub21lLm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzM4NjMzCiAgICAgLy8gV0FSTklORzogVGhpcyBuZWVkcyB0byBiZSBLRVBUIElOIFNZ TkMgd2l0aCBXZWJQcm9jZXNzTWFpbi5jcHAuCi0gICAgc2V0ZW52KCJHX1RMU19HTlVUTFNfUFJJ T1JJVFkiLCAiTk9STUFMOiVDT01QQVQ6JUxBVEVTVF9SRUNPUkRfVkVSU0lPTjohVkVSUy1TU0wz LjA6IUFSQ0ZPVVItMTI4IiwgMCk7CisgICAgc2V0ZW52KCJHX1RMU19HTlVUTFNfUFJJT1JJVFki LCAiTk9STUFMOiVDT01QQVQ6IVZFUlMtU1NMMy4wOiFBUkNGT1VSLTEyOCIsIDApOwogCiAgICAg cmV0dXJuIE5ldHdvcmtQcm9jZXNzTWFpblVuaXgoYXJnYywgYXJndik7CiB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0VudHJ5UG9pbnQvdW5peC9XZWJQcm9jZXNzTWFp bi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0VudHJ5UG9pbnQvdW5peC9XZWJQcm9j ZXNzTWFpbi5jcHAKaW5kZXggNWY0NWQwMWFmNzhhZTg2NjhjOWRlNzdhZGMxYmYwMWFiMDEwOGNk YS4uNDgwZjlkMGMzNjUxZWVjMDVhZTE0ZTkxMDU4MmVjNzAxNDVkODA3NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9FbnRyeVBvaW50L3VuaXgvV2ViUHJvY2Vzc01haW4u Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRW50cnlQb2ludC91bml4L1dlYlBy b2Nlc3NNYWluLmNwcApAQCAtMzksNyArMzksNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioq IGFyZ3YpCiAgICAgLy8gb3ZlcndyaXRlIHRoaXMgcHJpb3JpdHkgc3RyaW5nIGlmIGl0J3MgYWxy ZWFkeSBzZXQgYnkgdGhlIHVzZXIuCiAgICAgLy8gaHR0cHM6Ly9idWd6aWxsYS5nbm9tZS5vcmcv c2hvd19idWcuY2dpP2lkPTczODYzMwogICAgIC8vIFdBUk5JTkc6IFRoaXMgbmVlZHMgdG8gYmUg S0VQVCBJTiBTWU5DIHdpdGggV2ViUHJvY2Vzc01haW4uY3BwLgotICAgIHNldGVudigiR19UTFNf R05VVExTX1BSSU9SSVRZIiwgIk5PUk1BTDolQ09NUEFUOiVMQVRFU1RfUkVDT1JEX1ZFUlNJT046 IVZFUlMtU1NMMy4wOiFBUkNGT1VSLTEyOCIsIDApOworICAgIHNldGVudigiR19UTFNfR05VVExT X1BSSU9SSVRZIiwgIk5PUk1BTDolQ09NUEFUOiFWRVJTLVNTTDMuMDohQVJDRk9VUi0xMjgiLCAw KTsKIAogICAgIHJldHVybiBXZWJQcm9jZXNzTWFpblVuaXgoYXJnYywgYXJndik7CiB9Cg==