172149 2017-05-15 17:30:24 -0700 Make it possible to adjust which edges are affected by safe area insets 2017-05-16 10:37:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton bdakin dino sam simon.fraser oldest_to_newest 1308895 0 thorton 2017-05-15 17:30:24 -0700 Make it possible to adjust which edges are affected by safe area insets 1308896 1 310194 thorton 2017-05-15 17:31:26 -0700 Created attachment 310194 Patch 1308939 2 310194 sam 2017-05-15 19:28:15 -0700 Comment on attachment 310194 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310194&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:160 > @property (nonatomic, readonly) BOOL _safeAreaShouldAffectObscuredInsets WK_API_AVAILABLE(ios(WK_IOS_TBA)); > +@property (nonatomic, setter=_setObscuredInsetEdgesAffectedBySafeArea:) UIRectEdge _obscuredInsetEdgesAffectedBySafeArea WK_API_AVAILABLE(ios(WK_IOS_TBA)); Does it make sense to have both of these? Since you could just set _obscuredInsetEdgesAffectedBySafeArea to UIRectEdgeNone. Or does _safeAreaShouldAffectObscuredInsets do more than that? 1309044 3 thorton 2017-05-16 00:36:39 -0700 (In reply to Sam Weinig from comment #2) > Comment on attachment 310194 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=310194&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:160 > > @property (nonatomic, readonly) BOOL _safeAreaShouldAffectObscuredInsets WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > +@property (nonatomic, setter=_setObscuredInsetEdgesAffectedBySafeArea:) UIRectEdge _obscuredInsetEdgesAffectedBySafeArea WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > Does it make sense to have both of these? Since you could just set > _obscuredInsetEdgesAffectedBySafeArea to UIRectEdgeNone. Or does > _safeAreaShouldAffectObscuredInsets do more than that? Please note that _safeAreaShouldAffectObscuredInsets is read-only. It exposes the intent of the page, not of the API client. 1309168 4 thorton 2017-05-16 10:21:02 -0700 http://trac.webkit.org/changeset/216935/webkit 1309174 5 sam 2017-05-16 10:37:55 -0700 (In reply to Tim Horton from comment #3) > (In reply to Sam Weinig from comment #2) > > Comment on attachment 310194 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=310194&action=review > > > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:160 > > > @property (nonatomic, readonly) BOOL _safeAreaShouldAffectObscuredInsets WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > > +@property (nonatomic, setter=_setObscuredInsetEdgesAffectedBySafeArea:) UIRectEdge _obscuredInsetEdgesAffectedBySafeArea WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > > > Does it make sense to have both of these? Since you could just set > > _obscuredInsetEdgesAffectedBySafeArea to UIRectEdgeNone. Or does > > _safeAreaShouldAffectObscuredInsets do more than that? > > Please note that _safeAreaShouldAffectObscuredInsets is read-only. It > exposes the intent of the page, not of the API client. Ah. These are some tricky names to wrap ones head around :(. 310194 2017-05-15 17:31:26 -0700 2017-05-16 10:18:56 -0700 Patch bug-172149-20170515173125.patch text/plain 6449 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWJiNmRmODhlMWFmMjNm MTdlYWNhMzBjMWQ2NTM2OGViZTkxMWQwOS4uYzJkNWE1NTc4MTNlMjVjMWM1MjAwMzdiODc3YmQw MjVjN2ZiMzdiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA1LTE1ICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIGl0 IHBvc3NpYmxlIHRvIGFkanVzdCB3aGljaCBlZGdlcyBhcmUgYWZmZWN0ZWQgYnkgc2FmZSBhcmVh IGluc2V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcyMTQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMTU2NDcyOT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX2luaXRpYWxpemVXaXRoQ29uZmln dXJhdGlvbjpdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9jb21wdXRlZENvbnRlbnRJbnNldF0p OgorICAgICAgICAoLVtXS1dlYlZpZXcgX29ic2N1cmVkSW5zZXRFZGdlc0FmZmVjdGVkQnlTYWZl QXJlYV0pOgorICAgICAgICAoLVtXS1dlYlZpZXcgX3NldE9ic2N1cmVkSW5zZXRFZGdlc0FmZmVj dGVkQnlTYWZlQXJlYTpdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d1ByaXZhdGUuaDoKKyAgICAgICAgQWRkIFNQSSB0byBhZGp1c3Qgd2hpY2ggZWRnZXMgYXJlIHRh a2VuIGludG8gYWNjb3VudCwgYW5kIGFkanVzdCB0aGUgZGVmYXVsdC4KKwogMjAxNy0wNS0xNSAg QnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk IGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXcubW0KaW5kZXggMTkwZWFmMWM5ZmMzMzk5NzFkMDY2ZmVjZWI2YmE5OWEyZDFiOWViMS4u NmIzOGY3NTMzZTI5NzQ4M2QyNzg3ODhjZmM0OTBjMTYyMzY4YjQxZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTI0NCw2ICsyNDQs NyBAQCBAaW1wbGVtZW50YXRpb24gV0tXZWJWaWV3IHsKIAogICAgIFVJRWRnZUluc2V0cyBfdW5v YnNjdXJlZFNhZmVBcmVhSW5zZXRzOwogICAgIEJPT0wgX2hhdmVTZXRVbm9ic2N1cmVkU2FmZUFy ZWFJbnNldHM7CisgICAgVUlSZWN0RWRnZSBfb2JzY3VyZWRJbnNldEVkZ2VzQWZmZWN0ZWRCeVNh ZmVBcmVhOwogCiAgICAgVUlJbnRlcmZhY2VPcmllbnRhdGlvbiBfaW50ZXJmYWNlT3JpZW50YXRp b25PdmVycmlkZTsKICAgICBCT09MIF9vdmVycmlkZXNJbnRlcmZhY2VPcmllbnRhdGlvbjsKQEAg LTUyMyw2ICs1MjQsNyBAQCAtICh2b2lkKV9pbml0aWFsaXplV2l0aENvbmZpZ3VyYXRpb246KFdL V2ViVmlld0NvbmZpZ3VyYXRpb24gKiljb25maWd1cmF0aW9uCiAgICAgW19zY3JvbGxWaWV3IGFk ZFN1YnZpZXc6X2NvbnRlbnRWaWV3LmdldCgpXTsKICAgICBbX3Njcm9sbFZpZXcgYWRkU3Vidmll dzpbX2NvbnRlbnRWaWV3IHVuc2NhbGVkVmlld11dOwogICAgIFtzZWxmIF91cGRhdGVTY3JvbGxW aWV3QmFja2dyb3VuZF07CisgICAgX29ic2N1cmVkSW5zZXRFZGdlc0FmZmVjdGVkQnlTYWZlQXJl YSA9IFVJUmVjdEVkZ2VUb3AgfCBVSVJlY3RFZGdlTGVmdCB8IFVJUmVjdEVkZ2VSaWdodDsKIAog ICAgIF92aWV3cG9ydE1ldGFUYWdXaWR0aCA9IFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRzOjpW YWx1ZUF1dG87CiAgICAgX2luaXRpYWxTY2FsZUZhY3RvciA9IDE7CkBAIC0xMzU2LDEwICsxMzU4 LDE0IEBAIC0gKFVJRWRnZUluc2V0cylfY29tcHV0ZWRDb250ZW50SW5zZXQKICNpZiBfX0lQSE9O RV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMTAwMDAKICAgICBpZiAoc2VsZi5fc2FmZUFy ZWFTaG91bGRBZmZlY3RPYnNjdXJlZEluc2V0cykgewogICAgICAgICBVSUVkZ2VJbnNldHMgc3lz dGVtSW5zZXRzID0gW19zY3JvbGxWaWV3IF9zeXN0ZW1Db250ZW50SW5zZXRdOwotICAgICAgICBp bnNldHMudG9wICs9IHN5c3RlbUluc2V0cy50b3A7Ci0gICAgICAgIGluc2V0cy5ib3R0b20gKz0g c3lzdGVtSW5zZXRzLmJvdHRvbTsKLSAgICAgICAgaW5zZXRzLmxlZnQgKz0gc3lzdGVtSW5zZXRz LmxlZnQ7Ci0gICAgICAgIGluc2V0cy5yaWdodCArPSBzeXN0ZW1JbnNldHMucmlnaHQ7CisgICAg ICAgIGlmIChfb2JzY3VyZWRJbnNldEVkZ2VzQWZmZWN0ZWRCeVNhZmVBcmVhICYgVUlSZWN0RWRn ZVRvcCkKKyAgICAgICAgICAgIGluc2V0cy50b3AgKz0gc3lzdGVtSW5zZXRzLnRvcDsKKyAgICAg ICAgaWYgKF9vYnNjdXJlZEluc2V0RWRnZXNBZmZlY3RlZEJ5U2FmZUFyZWEgJiBVSVJlY3RFZGdl Qm90dG9tKQorICAgICAgICAgICAgaW5zZXRzLmJvdHRvbSArPSBzeXN0ZW1JbnNldHMuYm90dG9t OworICAgICAgICBpZiAoX29ic2N1cmVkSW5zZXRFZGdlc0FmZmVjdGVkQnlTYWZlQXJlYSAmIFVJ UmVjdEVkZ2VMZWZ0KQorICAgICAgICAgICAgaW5zZXRzLmxlZnQgKz0gc3lzdGVtSW5zZXRzLmxl ZnQ7CisgICAgICAgIGlmIChfb2JzY3VyZWRJbnNldEVkZ2VzQWZmZWN0ZWRCeVNhZmVBcmVhICYg VUlSZWN0RWRnZVJpZ2h0KQorICAgICAgICAgICAgaW5zZXRzLnJpZ2h0ICs9IHN5c3RlbUluc2V0 cy5yaWdodDsKICAgICB9CiAjZW5kaWYKIApAQCAtNDU1MSw2ICs0NTU3LDIxIEBAIC0gKHZvaWQp X3NldE9ic2N1cmVkSW5zZXRzOihVSUVkZ2VJbnNldHMpb2JzY3VyZWRJbnNldHMKICAgICBbc2Vs ZiBfc2NoZWR1bGVWaXNpYmxlQ29udGVudFJlY3RVcGRhdGVdOwogfQogCistIChVSVJlY3RFZGdl KV9vYnNjdXJlZEluc2V0RWRnZXNBZmZlY3RlZEJ5U2FmZUFyZWEKK3sKKyAgICByZXR1cm4gX29i c2N1cmVkSW5zZXRFZGdlc0FmZmVjdGVkQnlTYWZlQXJlYTsKK30KKworLSAodm9pZClfc2V0T2Jz Y3VyZWRJbnNldEVkZ2VzQWZmZWN0ZWRCeVNhZmVBcmVhOihVSVJlY3RFZGdlKWVkZ2VzCit7Cisg ICAgaWYgKGVkZ2VzID09IF9vYnNjdXJlZEluc2V0RWRnZXNBZmZlY3RlZEJ5U2FmZUFyZWEpCisg ICAgICAgIHJldHVybjsKKworICAgIF9vYnNjdXJlZEluc2V0RWRnZXNBZmZlY3RlZEJ5U2FmZUFy ZWEgPSBlZGdlczsKKworICAgIFtzZWxmIF9zY2hlZHVsZVZpc2libGVDb250ZW50UmVjdFVwZGF0 ZV07Cit9CisKIC0gKFVJRWRnZUluc2V0cylfdW5vYnNjdXJlZFNhZmVBcmVhSW5zZXRzCiB7CiAg ICAgcmV0dXJuIF91bm9ic2N1cmVkU2FmZUFyZWFJbnNldHM7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCmluZGV4IDRlNDhj ZDVmMzhmYzliMWJlY2U5ZDM5YTA1ZjAzZTNhZDBlZWI2YzAuLjE0YmUyYzNkNGU3MGZmMTE0MTJj ODdjYWEwNzBiNjgzNWUyYTQ1ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCkBAIC0xNTcsNiArMTU3LDcgQEAgdHlw ZWRlZiBOU19FTlVNKE5TSW50ZWdlciwgX1dLSW1tZWRpYXRlQWN0aW9uVHlwZSkgewogCiBAcHJv cGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRVbm9ic2N1cmVkU2FmZUFyZWFJbnNldHM6KSBV SUVkZ2VJbnNldHMgX3Vub2JzY3VyZWRTYWZlQXJlYUluc2V0cyBXS19BUElfQVZBSUxBQkxFKGlv cyhXS19JT1NfVEJBKSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIEJPT0wgX3Nh ZmVBcmVhU2hvdWxkQWZmZWN0T2JzY3VyZWRJbnNldHMgV0tfQVBJX0FWQUlMQUJMRShpb3MoV0tf SU9TX1RCQSkpOworQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0T2JzY3VyZWRJbnNl dEVkZ2VzQWZmZWN0ZWRCeVNhZmVBcmVhOikgVUlSZWN0RWRnZSBfb2JzY3VyZWRJbnNldEVkZ2Vz QWZmZWN0ZWRCeVNhZmVBcmVhIFdLX0FQSV9BVkFJTEFCTEUoaW9zKFdLX0lPU19UQkEpKTsKIAog Ly8gQW4gYW5jZXN0b3IgdmlldyB3aG9zZSBib3VuZHMgd2lsbCBiZSBpbnRlcnNlY3RlZCB3aXRo IHRob3NlIG9mIHRoaXMgV0tXZWJWaWV3IHRvIGRldGVybWluZSB0aGUgdmlzaWJsZSByZWdpb24g b2YgY29udGVudCB0byByZW5kZXIuCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIFVJ VmlldyAqX2VuY2xvc2luZ1ZpZXdGb3JFeHBvc2VkUmVjdENvbXB1dGF0aW9uIFdLX0FQSV9BVkFJ TEFCTEUoaW9zKFdLX0lPU19UQkEpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjYWFlOWIyYTAyY2U0OWI1ZDZjYTkxMzU5 MTgzOWE2NDQ4NTZiNDRjLi4yYmJjZGE5YWQ1OTBjODA4ZDc4MWIzZGY0OGE1NmNlM2UzNDY3MGJj IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDUtMTUgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBpdCBwb3NzaWJsZSB0byBhZGp1c3Qg d2hpY2ggZWRnZXMgYXJlIGFmZmVjdGVkIGJ5IHNhZmUgYXJlYSBpbnNldHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjE0OQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzE1NjQ3Mjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmYXN0L3ZpZXdwb3J0L2lvcy92aWV3cG9ydC1maXQtYXV0by1leHBl Y3RlZC50eHQ6CisgICAgICAgICogZmFzdC92aWV3cG9ydC9pb3Mvdmlld3BvcnQtZml0LWNvbnRh aW4tZXhwZWN0ZWQudHh0OgorCiAyMDE3LTA1LTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgU2ltcGxlIGxpbmUgbGF5b3V0OiBMZWFkaW5nIHdoaXRlc3BhY2Ug Zm9sbG93ZWQgYnkgYSA8YnI+IHByb2R1Y2VzIGFuIGV4dHJhIGxpbmVicmVhay4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvaW9zL3ZpZXdwb3J0LWZpdC1hdXRvLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvaW9zL3ZpZXdwb3J0LWZpdC1hdXRv LWV4cGVjdGVkLnR4dAppbmRleCA0YTY4Njc3MDY5YTI5NjdmM2MwOWU5YTk2OTIzMTRlMzQ5ZTNi NDY1Li45YjA0MjU0NWNmNDM0ZGMyZWM2YmFjMjg2OThjNDQ5MmY3YTc2OTJmIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0L2lvcy92aWV3cG9ydC1maXQtYXV0by1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC9pb3Mvdmlld3BvcnQtZml0LWF1 dG8tZXhwZWN0ZWQudHh0CkBAIC0xLDYgKzEsNiBAQAogVmlld3BvcnQ6IGluaXRpYWwtc2NhbGU9 MSwgdmlld3BvcnQtZml0PWF1dG8KIAotV2luZG93IFNpemU6IDI2MCB4IDUwOAorV2luZG93IFNp emU6IDI2MCB4IDUzOAogCiBzY2FsZQkxLjAwMDAwCiBtYXhTY2FsZQk1LjAwMDAwCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0L2lvcy92aWV3cG9ydC1maXQtY29udGFpbi1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0L2lvcy92aWV3cG9ydC1maXQt Y29udGFpbi1leHBlY3RlZC50eHQKaW5kZXggYzY4NTE0Mjk3MDNmZDNjYmVlNTQyN2U3MGVhZGVh NGQzYzViNmM1MC4uNzk1MjcxMGYwYWNiMjUyNDJiM2ZhNjFmY2U5OGZlYTUwMjYzZjExOSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC9pb3Mvdmlld3BvcnQtZml0LWNvbnRh aW4tZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvaW9zL3ZpZXdw b3J0LWZpdC1jb250YWluLWV4cGVjdGVkLnR4dApAQCAtMSw2ICsxLDYgQEAKIFZpZXdwb3J0OiBp bml0aWFsLXNjYWxlPTEsIHZpZXdwb3J0LWZpdD1jb250YWluCiAKLVdpbmRvdyBTaXplOiAyNjAg eCA1MDgKK1dpbmRvdyBTaXplOiAyNjAgeCA1MzgKIAogc2NhbGUJMS4wMDAwMAogbWF4U2NhbGUJ NS4wMDAwMAo=