<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>172128</bug_id>
          
          <creation_ts>2017-05-15 10:49:16 -0700</creation_ts>
          <short_desc>[WK2][macOS][iOS] Allow Network process to access nsurlstoraged&apos;s top level domain data cache</short_desc>
          <delta_ts>2017-05-15 14:22:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ap</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1308717</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-05-15 10:49:16 -0700</bug_when>
    <thetext>We extended the sandbox last cycle to permit access to nsurlstoraged&apos;s top level domain data cache. At the time, we believed this was only needed in the WebContent process. However, further logging and feedback from the networking teams reveal that the Network process should also have been granted this access.

This bug allows the Network Process to access the nsurlstoraged&apos;s data cache.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308720</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-05-15 10:51:56 -0700</bug_when>
    <thetext>&lt;rdar://problem/30871490&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308722</commentid>
    <comment_count>2</comment_count>
      <attachid>310149</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-05-15 10:58:23 -0700</bug_when>
    <thetext>Created attachment 310149
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308750</commentid>
    <comment_count>3</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2017-05-15 12:19:13 -0700</bug_when>
    <thetext>Is there an explanation about why this is only needed on certain OS versions?  Will this be permanent?  Should we have done it before?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308752</commentid>
    <comment_count>4</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-05-15 12:29:17 -0700</bug_when>
    <thetext>(In reply to Alex Christensen from comment #3)
&gt; Is there an explanation about why this is only needed on certain OS
&gt; versions?  Will this be permanent?  Should we have done it before?

It&apos;s not needed on older OS&apos;s since the cache was not really being used. We want it to be used in an upcoming release, and beyond.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308781</commentid>
    <comment_count>5</comment_count>
      <attachid>310149</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2017-05-15 13:53:54 -0700</bug_when>
    <thetext>Comment on attachment 310149
Patch

In bugzilla I have no comment on the existence of such an upcoming release, much less our plans if such a thing exists.  But r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308794</commentid>
    <comment_count>6</comment_count>
      <attachid>310149</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-15 14:22:01 -0700</bug_when>
    <thetext>Comment on attachment 310149
Patch

Clearing flags on attachment: 310149

Committed r216877: &lt;http://trac.webkit.org/changeset/216877&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308795</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-15 14:22:03 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>310149</attachid>
            <date>2017-05-15 10:58:23 -0700</date>
            <delta_ts>2017-05-15 14:22:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-172128-20170515105826.patch</filename>
            <type>text/plain</type>
            <size>2208</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjg2MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA1LTE1ICBCcmVudCBG
dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW21hY09TXVtpT1Nd
IEFsbG93IE5ldHdvcmsgcHJvY2VzcyB0byBhY2Nlc3MgbnN1cmxzdG9yYWdlZCdzIHRvcCBsZXZl
bCBkb21haW4gZGF0YSBjYWNoZSAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE3MjEyOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzA4NzE0OTA+CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3Jr
UHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbjoKKyAgICAg
ICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdv
cmtpbmcuc2I6CisKIDIwMTctMDUtMTUgIEd3YW5nIFlvb24gSHdhbmcgIDx5b29uQGlnYWxpYS5j
b20+CiAKICAgICAgICAgW1dQRV0gVW5yZXZpZXdlZCBkZWJ1ZyBidWlsZCBmaXgKSW5kZXg6IFNv
dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtQ
cm9jZXNzLnNiLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz
L21hYy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtQcm9jZXNzLnNiLmluCShyZXZpc2lvbiAyMTY4
NjIpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktp
dC5OZXR3b3JrUHJvY2Vzcy5zYi5pbgkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsMTEgQEAK
IChkZWZpbmUgKGhvbWUtbGl0ZXJhbCBob21lLXJlbGF0aXZlLWxpdGVyYWwpCiAgICAgKGxpdGVy
YWwgKHN0cmluZy1hcHBlbmQgKHBhcmFtICJIT01FX0RJUiIpIGhvbWUtcmVsYXRpdmUtbGl0ZXJh
bCkpKQogCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDAKKzs7
IENGTmV0d29yaworKGFsbG93IGZpbGUtcmVhZC1kYXRhIChwYXRoICIvcHJpdmF0ZS92YXIvZGIv
bnN1cmxzdG9yYWdlZC9kYWZzYURhdGEuYmluIikpCisjZW5kaWYKKwogOzsgUmVtb3ZlIHdoZW4g
PHJkYXI6Ly9wcm9ibGVtLzI5NjQ2MDk0PiBpcyBmaXhlZC4KIChkZWZpbmUgKEhFWC1wYXR0ZXJu
LW1hdGNoLWdlbmVyYXRvciBwYXR0ZXJuLWRlc2NyaXB0b3IpCiAgICAgKGxldHJlYyAoKHBhdHRl
cm4tc3RyaW5nICIiKSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9TYW5kYm94UHJv
ZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYgo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT
b3VyY2UvV2ViS2l0Mi9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2Vi
S2l0Lk5ldHdvcmtpbmcuc2IJKHJldmlzaW9uIDIxNjg2MikKKysrIFNvdXJjZS9XZWJLaXQyL1Jl
c291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5z
Ygkod29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsMTAgQEAKIAogKG5ldHdvcmstY2xpZW50IChy
ZW1vdGUgdGNwKSAocmVtb3RlIHVkcCkpCiAKKzs7IGFsbG93IDNyZCBwYXJ0eSBhcHBsaWNhdGlv
bnMgdG8gYWNjZXNzIG5zdXJsc3RvcmFnZWQncyB0b3AgbGV2ZWwgZG9tYWluIGRhdGEgY2FjaGUK
KyhhbGxvdy13ZWxsLWtub3duLXN5c3RlbS1ncm91cC1jb250YWluZXItc3VicGF0aC1yZWFkCisg
ICAgIi9zeXN0ZW1ncm91cC5jb20uYXBwbGUubnN1cmxzdG9yYWdlZHJlc291cmNlcy9MaWJyYXJ5
L2RhZnNhRGF0YS5iaW4iKQorCiA7OyBTZWN1cml0eSBmcmFtZXdvcmsKIChhbGxvdyBtYWNoLWxv
b2t1cAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLm9jc3BkIikK
</data>

          </attachment>
      

    </bug>

</bugzilla>