172123 2017-05-15 09:36:27 -0700 RealtimeOutgoingVideoSource should support sinkWants for rotation 2017-05-16 14:18:24 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf buildbot commit-queue eric.carlson jonlee webkit-bug-importer oldest_to_newest 1308676 0 youennf 2017-05-15 09:36:27 -0700 This would ensure rotation is handled even when RTP CVO is not on 1308695 1 webkit-bug-importer 2017-05-15 10:14:17 -0700 <rdar://problem/32200017> 1309263 2 310294 youennf 2017-05-16 13:30:09 -0700 Created attachment 310294 Patch 1309267 3 buildbot 2017-05-16 13:32:53 -0700 Attachment 310294 did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/video/i420_buffer.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1309288 4 310294 commit-queue 2017-05-16 14:18:23 -0700 Comment on attachment 310294 Patch Clearing flags on attachment: 310294 Committed r216947: <http://trac.webkit.org/changeset/216947> 1309289 5 commit-queue 2017-05-16 14:18:24 -0700 All reviewed patches have been landed. Closing bug. 310294 2017-05-16 13:30:09 -0700 2017-05-16 14:18:23 -0700 Patch bug-172123-20170516133008.patch text/plain 5252 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2OTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBlZjE1YzVjOTg4MjU2NmY1YWNkM2VjYmNhNjk1YzBmMTM3YTFjNmFjLi40MmM1 ZTY1NGM5NTZhMWYzZjdiOGUzOGFiZWU4NDBhYjY0N2FiYjM2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wNS0xNiAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVhbHRpbWVPdXRnb2luZ1ZpZGVv U291cmNlIHNob3VsZCBzdXBwb3J0IHNpbmtXYW50cyBmb3Igcm90YXRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjEyMworICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzIyMDAwMTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTb3VyY2Uvd2VicnRjL2FwaS92aWRlby9pNDIwX2J1ZmZlci5oOiBF eHBvcnRpbmcgcm90YXRlIHJvdXRpbmUuCisKIDIwMTctMDUtMDggIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFRVUk5TIGdhdGhlcmluZyBpcyBub3Qgd29ya2lu ZyBwcm9wZXJseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGYyNWQwN2ZlNGY4ZDRlYjM5MjM2MjY1YmNlYzA5NjVm YzdjODExZWEuLjgxZGNiYzM5MWM3MmI0NmI3NTIzMTI1ZTNiYTc2OGMwYzdjYjVlZmYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxNy0wNS0xNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlIHNob3Vs ZCBzdXBwb3J0IHNpbmtXYW50cyBmb3Igcm90YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjEyMworICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzIyMDAwMTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ292ZXJlZCBieSBtYW51YWwgdGVzdGluZy4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlh c3RyZWFtL21hYy9SZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlOjpBZGRPclVwZGF0ZVNpbmspOiBUcmln Z2VyaW5nIHBpeGVsIHJvdGF0aW9uIGJhc2VkIG9uIHNpbmsuCisgICAgICAgIChXZWJDb3JlOjpS ZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2U6OnNlbmRGcmFtZSk6IERvaW5nIHRoZSByb3RhdGlv biB1c2luZyBsaWJ3ZWJydGMgQVBJLgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL21h Yy9SZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2UuaDoKKworMjAxNy0wNS0xNiAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKICAgICAgICAgTW9kZXJuaXplIFdlYktpdDIgZ2V0 VXNlck1lZGlhIHBhc3Npbmcgb2YgcGFyYW1ldGVycwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyMTYxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGly ZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL2FwaS92aWRlby9pNDIwX2J1ZmZlci5oIGIv U291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvYXBpL3ZpZGVvL2k0MjBf YnVmZmVyLmgKaW5kZXggOGQ4YzEyMWUzMTQ0YWFiN2M5Y2IyM2UwNjBhOWFlZWViMGZjYjk1OC4u ZTMwZmRjOWQ1ZDMxYjg3MmNhOTU1OTExZjdhYmYwMWFlM2M4OGU3OCAxMDA2NDQKLS0tIGEvU291 cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvYXBpL3ZpZGVvL2k0MjBfYnVm ZmVyLmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvYXBp L3ZpZGVvL2k0MjBfYnVmZmVyLmgKQEAgLTQwLDcgKzQwLDcgQEAgY2xhc3MgSTQyMEJ1ZmZlciA6 IHB1YmxpYyBWaWRlb0ZyYW1lQnVmZmVyIHsKICAgICAgIGNvbnN0IHVpbnQ4X3QqIGRhdGFfdiwg aW50IHN0cmlkZV92KTsKIAogICAvLyBSZXR1cm5zIGEgcm90YXRlZCBjb3B5IG9mIHxzcmN8Lgot ICBzdGF0aWMgcnRjOjpzY29wZWRfcmVmcHRyPEk0MjBCdWZmZXI+IFJvdGF0ZShjb25zdCBWaWRl b0ZyYW1lQnVmZmVyJiBzcmMsCisgIFdFQlJUQ19EWUxJQl9FWFBPUlQgc3RhdGljIHJ0Yzo6c2Nv cGVkX3JlZnB0cjxJNDIwQnVmZmVyPiBSb3RhdGUoY29uc3QgVmlkZW9GcmFtZUJ1ZmZlciYgc3Jj LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBWaWRlb1Jv dGF0aW9uIHJvdGF0aW9uKTsKIAogICAvLyBTZXRzIHRoZSBidWZmZXIgdG8gYWxsIGJsYWNrLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0 aW1lT3V0Z29pbmdWaWRlb1NvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlLmNwcAppbmRleCA1Yzk2MjNi ZGU4MDkxYzJlMGQyNmVjYTk3MjNhYTEyN2U5YThhMGJjLi42MDdmNDc4NzRmNjJkMjk4YjNjMmFj OGRhM2I0YjQzZmM4NjU5NjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ1ZpZGVv U291cmNlLmNwcApAQCAtMzEsNiArMzEsNyBAQAogCiAjaWYgVVNFKExJQldFQlJUQykKIAorI2lu Y2x1ZGUgPHdlYnJ0Yy9hcGkvdmlkZW8vaTQyMF9idWZmZXIuaD4KICNpbmNsdWRlIDx3ZWJydGMv Y29tbW9uX3ZpZGVvL2luY2x1ZGUvY29yZXZpZGVvX2ZyYW1lX2J1ZmZlci5oPgogI2luY2x1ZGUg PHdlYnJ0Yy9jb21tb25fdmlkZW8vbGlieXV2L2luY2x1ZGUvd2VicnRjX2xpYnl1di5oPgogI2lu Y2x1ZGUgPHdlYnJ0Yy9tZWRpYS9iYXNlL3ZpZGVvZnJhbWUuaD4KQEAgLTExNyw5ICsxMTgsMTMg QEAgYm9vbCBSZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2U6OkdldFN0YXRzKFN0YXRzKikKICAg ICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlOjpB ZGRPclVwZGF0ZVNpbmsocnRjOjpWaWRlb1NpbmtJbnRlcmZhY2U8d2VicnRjOjpWaWRlb0ZyYW1l Piogc2luaywgY29uc3QgcnRjOjpWaWRlb1NpbmtXYW50cyYpCit2b2lkIFJlYWx0aW1lT3V0Z29p bmdWaWRlb1NvdXJjZTo6QWRkT3JVcGRhdGVTaW5rKHJ0Yzo6VmlkZW9TaW5rSW50ZXJmYWNlPHdl YnJ0Yzo6VmlkZW9GcmFtZT4qIHNpbmssIGNvbnN0IHJ0Yzo6VmlkZW9TaW5rV2FudHMmIHNpbmtX YW50cykKIHsKLSAgICAvLyBGSVhNRTogc3VwcG9ydCBzaW5rV2FudHMKKyAgICBBU1NFUlQoIXNp bmtXYW50cy5ibGFja19mcmFtZXMpOworCisgICAgaWYgKHNpbmtXYW50cy5yb3RhdGlvbl9hcHBs aWVkKQorICAgICAgICBtX3Nob3VsZEFwcGx5Um90YXRpb24gPSB0cnVlOworCiAgICAgaWYgKCFt X3NpbmtzLmNvbnRhaW5zKHNpbmspKQogICAgICAgICBtX3NpbmtzLmFwcGVuZChzaW5rKTsKIH0K QEAgLTE0Nyw2ICsxNTIsMTIgQEAgdm9pZCBSZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2U6OnNl bmRPbmVCbGFja0ZyYW1lKCkKIAogdm9pZCBSZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2U6OnNl bmRGcmFtZShydGM6OnNjb3BlZF9yZWZwdHI8d2VicnRjOjpWaWRlb0ZyYW1lQnVmZmVyPiYmIGJ1 ZmZlcikKIHsKKyAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIG1ha2UgQVZWaWRlb0NhcHR1cmVTb3Vy Y2UgaGFuZGxlIHRoZSByb3RhdGlvbiB3aGVuZXZlciBwb3NzaWJsZS4KKyAgICBpZiAobV9zaG91 bGRBcHBseVJvdGF0aW9uICYmIG1fY3VycmVudFJvdGF0aW9uICE9IHdlYnJ0Yzo6a1ZpZGVvUm90 YXRpb25fMCkgeworICAgICAgICAvLyBUaGlzIGltcGxlbWVudGF0aW9uIGlzIGluZWZmaWNpZW50 LCB3ZSBzaG91bGQgcm90YXRlIG9uIHRoZSBDTVNhbXBsZUJ1ZmZlciBkaXJlY3RseSBpbnN0ZWFk IG9mIGRvaW5nIHRoaXMgZG91YmxlIGFsbG9jYXRpb24uCisgICAgICAgIGJ1ZmZlciA9IGJ1ZmZl ci0+TmF0aXZlVG9JNDIwQnVmZmVyKCk7CisgICAgICAgIGJ1ZmZlciA9IHdlYnJ0Yzo6STQyMEJ1 ZmZlcjo6Um90YXRlKCpidWZmZXIsIG1fY3VycmVudFJvdGF0aW9uKTsKKyAgICB9CiAgICAgd2Vi cnRjOjpWaWRlb0ZyYW1lIGZyYW1lKGJ1ZmZlciwgMCwgMCwgbV9jdXJyZW50Um90YXRpb24pOwog ICAgIGZvciAoYXV0byogc2luayA6IG1fc2lua3MpCiAgICAgICAgIHNpbmstPk9uRnJhbWUoZnJh bWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFj L1JlYWx0aW1lT3V0Z29pbmdWaWRlb1NvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdWaWRlb1NvdXJjZS5oCmluZGV4IGMwN2Iz NDRlZDliNGE1MzZhMjIxZGM2N2Y3NGNmMTBhNTFlYmZjNTUuLjMxM2E5ZWZiMjM2ODljMzBmMjVl MTVkZmMzNjAzN2ZmOWI5MmJjNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL21hYy9SZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2UuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ1ZpZGVv U291cmNlLmgKQEAgLTk3LDYgKzk3LDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1faXNTdG9wcGVk IHsgZmFsc2UgfTsKICAgICBUaW1lciBtX2JsYWNrRnJhbWVUaW1lcjsKICAgICBydGM6OnNjb3Bl ZF9yZWZwdHI8d2VicnRjOjpWaWRlb0ZyYW1lQnVmZmVyPiBtX2JsYWNrRnJhbWU7CisgICAgYm9v bCBtX3Nob3VsZEFwcGx5Um90YXRpb24geyBmYWxzZSB9OwogfTsKIAogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQo=