17211 2008-02-07 15:01:51 -0800 MSVC7 fixes 2008-02-09 04:01:42 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED Wx P2 Normal --- 1 kevino webkit-unassigned oldest_to_newest 69711 0 kevino 2008-02-07 15:01:51 -0800 Couple quick MSVC7 fixes. First, USER_TIMER_MINIMUM/MAXIMUM is not defined under MSVC 2003 SDK for some reason, and second, there seems to be a problem with the Interlocked* functions on MSVC7. Fixes are attached. 69712 1 18992 kevino 2008-02-07 15:02:41 -0800 Created attachment 18992 fixing MSVC7 build 69770 2 18992 ap 2008-02-08 05:30:31 -0800 Comment on attachment 18992 fixing MSVC7 build + - On MSVC7, when the Interlocked* functions are used, the ref count gets out of sync. Weird! 69849 3 18992 aroben 2008-02-08 14:24:23 -0800 Comment on attachment 18992 fixing MSVC7 build r=me 69850 4 18992 eric 2008-02-08 14:24:23 -0800 Comment on attachment 18992 fixing MSVC7 build This looks fine to me. I think sfalken or aroben or one of the frequent windows hackers should give it the official r+. 69851 5 18992 eric 2008-02-08 14:24:45 -0800 Comment on attachment 18992 fixing MSVC7 build Stupid bugzilla. 69912 6 mrowe 2008-02-09 04:01:42 -0800 This was landed in <http://trac.webkit.org/projects/webkit/changeset/30108>. Kevin, can you make sure to close the bugs when you land the patches? 18992 2008-02-07 15:02:41 -0800 2008-02-08 14:24:45 -0800 fixing MSVC7 build msvc7fixes.patch text/plain 1984 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDA3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMDItMDcgIEtldmluIE9sbGl2aWVyIDxrZXZpbm9AdGhlb2xs aXZpZXJzLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBNU1ZDNyBmaXhlcy4gCisKKyAgICAgICAgKiBwbGF0Zm9ybS9UaHJlYWRpbmcuaDoKKyAg ICAgICAgLSBPbiBNU1ZDNywgd2hlbiB0aGUgSW50ZXJsb2NrZWQqIGZ1bmN0aW9ucyBhcmUgdXNl ZCwgdGhlIHJlZiBjb3VudCBnZXRzIG91dCBvZiBzeW5jLgorICAgICAgICAgIChNU1ZDOCBzZWVt cyBub3QgdG8gaGF2ZSB0aGlzIHByb2JsZW0uKSBVc2UgdGhlIG9sZCBpbXBsZW1lbnRhdGlvbiB3 aGljaCB3b3JrcyBjb3JyZWN0bHkuCisgICAgICAgICogcGxhdGZvcm0vd2luL1NoYXJlZFRpbWVy V2luLmNwcDoKKyAgICAgICAgLSBVU0VSX1RJTUVSX01JTklNVU0vTUFYSU1VTSBhcmVuJ3QgZGVm aW5lZCBpbiB3aW51c2VyLmggZm9yIHRoZSBNU1ZDIDIwMDMgUGxhdGZvcm0gU0RLCisgICAgICAg ICAgc28gZGVmaW5lIHRoZW0gaWYgdGhleSBhcmUgbm90IGFscmVhZHkgZGVmaW5lZC4KKwogMjAw OC0wMi0wNyAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGZv ciBidWcgNjI0OCwgaW1wbGVtZW50IHRoZSBudGgtKiBDU1MzIHNlbGVjdG9ycy4gIFBhdGNoIGJh c2VkIG9uIG9yaWdpbmFsIEtIVE1MIHdvcmsgZnJvbSBBbGxhbiBKZW5zZW4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vVGhyZWFkaW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9U aHJlYWRpbmcuaAkocmV2aXNpb24gMzAwNzQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL1RocmVhZGlu Zy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAsNyArMTYwLDcgQEAKICAgICBQbGF0Zm9ybUNvbmRp dGlvbiBtX2NvbmRpdGlvbjsKIH07CiAKLSNpZiBQTEFURk9STShXSU5fT1MpCisjaWYgUExBVEZP Uk0oV0lOX09TKSAmJiAhQ09NUElMRVIoTVNWQzcpCiAjZGVmaW5lIFdURl9VU0VfTE9DS0ZSRUVf VEhSRUFEU0FGRVNIQVJFRCAxCiAKIGlubGluZSB2b2lkIGF0b21pY0luY3JlbWVudChpbnQgdm9s YXRpbGUqIGFkZGVuZCkgeyBJbnRlcmxvY2tlZEluY3JlbWVudChyZWludGVycHJldF9jYXN0PGxv bmcgdm9sYXRpbGUqPihhZGRlbmQpKTsgfQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS93aW4vU2hh cmVkVGltZXJXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vd2luL1NoYXJl ZFRpbWVyV2luLmNwcAkocmV2aXNpb24gMzAwNzQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3dpbi9T aGFyZWRUaW1lcldpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwLDYgKzQwLDE2IEBACiAKICNp bmNsdWRlIDx3aW5kb3dzLmg+CiAKKy8vIFRoZXNlIGFyZW4ndCBpbiB3aW51c2VyLmggd2l0aCB0 aGUgTVNWUyAyMDAzIFBsYXRmb3JtIFNESywgCisvLyBzbyB1c2UgZGVmYXVsdCB2YWx1ZXMgaW4g dGhhdCBjYXNlLgorI2lmbmRlZiBVU0VSX1RJTUVSX01JTklNVU0KKyNkZWZpbmUgVVNFUl9USU1F Ul9NSU5JTVVNIDB4MDAwMDAwMEEKKyNlbmRpZgorCisjaWZuZGVmIFVTRVJfVElNRVJfTUFYSU1V TQorI2RlZmluZSBVU0VSX1RJTUVSX01BWElNVU0gMHg3RkZGRkZGRgorI2VuZGlmCisKICNpZiBQ TEFURk9STShXSU4pCiAjaW5jbHVkZSAiUGx1Z2luVmlldy5oIgogI2VuZGlmCg==