172106 2017-05-15 01:03:04 -0700 AX: Inaccessible content on webkit.org main page 2017-05-15 14:36:37 -0700 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 172096 1 jcraig webkit-unassigned commit-queue joepeck jond oldest_to_newest 1308601 0 jcraig 2017-05-15 01:03:04 -0700 AX: Inaccessible content on webkit.org main page. Using VoiceOver, many links are called "Clickable link" or "Clickable link to tweet" (instead of the relevant article title), and some images are unlabeled, causing gibberish file names to be spoken: e.g. "C-6tYGVXkAE_j6q.jpg" Part of this was resolved in bug 172096. 1308604 1 310117 jcraig 2017-05-15 01:13:41 -0700 Created attachment 310117 patch 1308732 2 310117 joepeck 2017-05-15 11:21:44 -0700 Comment on attachment 310117 patch View in context: https://bugs.webkit.org/attachment.cgi?id=310117&action=review r=me > Websites/webkit.org/wp-content/themes/webkit/widgets/post.php:62 > + <a class="tile-link" href="<?php the_permalink(); ?>"><?php echo $title; ?></a> Should we be escaping $title at all? (It seems we don't down below, so I'm fine with this as is). 1308786 3 jcraig 2017-05-15 14:08:08 -0700 (In reply to Joseph Pecoraro from comment #2) > Should we be escaping $title at all? (It seems we don't down below, so I'm > fine with this as is). Yeah, this patch was intended to be as low risk as possible, so I just deferred to existing usage. 1308808 4 310117 commit-queue 2017-05-15 14:36:35 -0700 Comment on attachment 310117 patch Clearing flags on attachment: 310117 Committed r216879: <http://trac.webkit.org/changeset/216879> 1308809 5 commit-queue 2017-05-15 14:36:37 -0700 All reviewed patches have been landed. Closing bug. 310117 2017-05-15 01:13:41 -0700 2017-05-15 14:36:35 -0700 patch wk172106.diff text/plain 4009 jcraig SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTY4NTgpCisrKyBXZWJzaXRlcy93 ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3 LTA1LTE1ICBKYW1lcyBDcmFpZyAgPGpjcmFpZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IElu YWNjZXNzaWJsZSBjb250ZW50IG9uIHdlYmtpdC5vcmcgbWFpbiBwYWdlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIxMDYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdwLWNvbnRlbnQvdGhlbWVzL3dl YmtpdC93aWRnZXRzL2ljb24ucGhwOiBSZXNvbHZlZCBsaW5rIHRpdGxlLgorICAgICAgICAqIHdw LWNvbnRlbnQvdGhlbWVzL3dlYmtpdC93aWRnZXRzL3Bvc3QucGhwOiBSZXNvbHZlZCBsaW5rIHRp dGxlLgorICAgICAgICAqIHdwLWNvbnRlbnQvdGhlbWVzL3dlYmtpdC93aWRnZXRzL3R3aXR0ZXIu cGhwOiBSZXNvbHZlZCBsaW5rIHRpdGxlcy4gU3VwcHJlc3NlZCB1bmxhYmVsZWQgaW1hZ2VzIHdp dGggYWx0PSIiLgorCiAyMDE3LTA1LTE0ICBKYW1lcyBDcmFpZyAgPGpjcmFpZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgVXBsb2FkIHBvc3RlciBpbWFnZXMgYW5kIHdvcmtpbmcgY2FwdGlvbmVkIHZp ZGVvCkluZGV4OiBXZWJzaXRlcy93ZWJraXQub3JnL3dwLWNvbnRlbnQvdGhlbWVzL3dlYmtpdC93 aWRnZXRzL2ljb24ucGhwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3dlYmtpdC5vcmcvd3AtY29u dGVudC90aGVtZXMvd2Via2l0L3dpZGdldHMvaWNvbi5waHAJKHJldmlzaW9uIDIxNjg1NSkKKysr IFdlYnNpdGVzL3dlYmtpdC5vcmcvd3AtY29udGVudC90aGVtZXMvd2Via2l0L3dpZGdldHMvaWNv bi5waHAJKHdvcmtpbmcgY29weSkKQEAgLTMwLDcgKzMwLDcgQEAgY2xhc3MgV2ViS2l0SWNvblRp bGVXaWRnZXQgZXh0ZW5kcyBXUF9XaQogICAgICAgICAKICAgICAgICAgPz4KICAgICAgICAgPGRp diBjbGFzcz0iPD9waHAgZWNobyBlc2NfYXR0cihqb2luKCcgJywgJGNsYXNzZXMpKTsgPz4iPgot ICAgICAgICAgICAgPGEgY2xhc3M9InRpbGUtbGluayIgaHJlZj0iPD9waHAgZWNobyBlc2NfdXJs KCR1cmwpOyA/PiI+Q2xpY2thYmxlIGxpbms8L2E+CisgICAgICAgICAgICA8YSBjbGFzcz0idGls ZS1saW5rIiBocmVmPSI8P3BocCBlY2hvIGVzY191cmwoJHVybCk7ID8+Ij48P3BocCBlY2hvIG5s MmJyKGVzY19odG1sKCR0ZXh0KSk7ID8+PC9hPgogICAgICAgICAgICAgPGRpdiBjbGFzcz0iaWNv biI+PC9kaXY+CiAgICAgICAgICAgICA8aDI+PD9waHAgZWNobyBubDJicihlc2NfaHRtbCgkdGV4 dCkpOyA/PjwvaDI+CiAgICAgICAgICAgICA8P3BocCBpZiAoIWVtcHR5KCRzdWJ0ZXh0KSk6ID8+ PHA+PD9waHAgZWNobyBubDJicihlc2NfaHRtbCgkc3VidGV4dCkpOyA/PjwvcD48P3BocCBlbmRp ZjsgPz4KSW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvd3AtY29udGVudC90aGVtZXMvd2Via2l0 L3dpZGdldHMvcG9zdC5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvd2Via2l0Lm9yZy93cC1j b250ZW50L3RoZW1lcy93ZWJraXQvd2lkZ2V0cy9wb3N0LnBocAkocmV2aXNpb24gMjE2ODU1KQor KysgV2Vic2l0ZXMvd2Via2l0Lm9yZy93cC1jb250ZW50L3RoZW1lcy93ZWJraXQvd2lkZ2V0cy9w b3N0LnBocAkod29ya2luZyBjb3B5KQpAQCAtNTksNyArNTksNyBAQCBjbGFzcyBXZWJLaXRQb3N0 VGlsZVdpZGdldCBleHRlbmRzIFdQX1dpCiAgICAgICAgIAogICAgICAgICA/PgogICAgICAgICAg ICAgPGRpdiA8P3BocCBlY2hvIHBvc3RfY2xhc3Moam9pbignICcsICRjbGFzc2VzKSk7ID8+Pgot ICAgICAgICAgICAgICAgIDxhIGNsYXNzPSJ0aWxlLWxpbmsiIGhyZWY9Ijw/cGhwIHRoZV9wZXJt YWxpbmsoKTsgPz4iPkNsaWNrYWJsZSBsaW5rPC9hPgorICAgICAgICAgICAgICAgIDxhIGNsYXNz PSJ0aWxlLWxpbmsiIGhyZWY9Ijw/cGhwIHRoZV9wZXJtYWxpbmsoKTsgPz4iPjw/cGhwIGVjaG8g JHRpdGxlOyA/PjwvYT4KICAgICAgICAgICAgICAgICA8ZGl2IGNsYXNzPSJiYWNrZ3JvdW5kLWlt YWdlIj4KICAgICAgICAgICAgICAgICAgICAgPGRpdiBjbGFzcz0iZmVhdHVyZWQtaW1hZ2UiPD9w aHAgZWNobyAkaW1hZ2U7ID8+PjwvZGl2PgogICAgICAgICAgICAgICAgICAgICA8P3BocCBpZiAo ICRmZWF0dXJlZCApOiA/PjxkaXYgY2xhc3M9ImJhY2tncm91bmQtdmlnbmV0dGUiPjwvZGl2Pjw/ cGhwIGVuZGlmOyA/PgpJbmRleDogV2Vic2l0ZXMvd2Via2l0Lm9yZy93cC1jb250ZW50L3RoZW1l cy93ZWJraXQvd2lkZ2V0cy90d2l0dGVyLnBocAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy93ZWJr aXQub3JnL3dwLWNvbnRlbnQvdGhlbWVzL3dlYmtpdC93aWRnZXRzL3R3aXR0ZXIucGhwCShyZXZp c2lvbiAyMTY4NTUpCisrKyBXZWJzaXRlcy93ZWJraXQub3JnL3dwLWNvbnRlbnQvdGhlbWVzL3dl YmtpdC93aWRnZXRzL3R3aXR0ZXIucGhwCSh3b3JraW5nIGNvcHkpCkBAIC02OCwxMCArNjgsMTAg QEAgY2xhc3MgV2ViS2l0VHdpdHRlclRpbGVXaWRnZXQgZXh0ZW5kcyBXZQogCiAgICAgICAgID8+ CiAgICAgICAgIDxkaXYgY2xhc3M9Ijw/cGhwIGVjaG8gZXNjX2F0dHIoam9pbignICcsICRjbGFz c2VzKSk7ID8+Ij4KLSAgICAgICAgICAgIDxhIGhyZWY9Ijw/cGhwIGVjaG8gZXNjX3VybCgkbGlu ayk7ID8+IiBjbGFzcz0idGlsZS1saW5rIj5DbGlja2FibGUgbGluayB0byB0d2VldDwvYT4KKyAg ICAgICAgICAgIDxhIGhyZWY9Ijw/cGhwIGVjaG8gZXNjX3VybCgkbGluayk7ID8+IiBjbGFzcz0i dGlsZS1saW5rIj5Ud2VldDogPD9waHAgZWNobyAkdGV4dDsgPz48L2E+CiAgICAgICAgICAgICA8 ZGl2IGNsYXNzPSJ0aWxlLWNvbnRlbnQiPgogICAgICAgICAgICAgPD9waHAgaWYgKCAhIGVtcHR5 KCRJbWFnZSkgKTogPz4KLSAgICAgICAgICAgIDxpbWcgc3JjPSI8P3BocCBlY2hvIGVzY191cmwo JEltYWdlLT5tZWRpYV91cmxfaHR0cHMpOyA/PiI+CisgICAgICAgICAgICA8aW1nIHNyYz0iPD9w aHAgZWNobyBlc2NfdXJsKCRJbWFnZS0+bWVkaWFfdXJsX2h0dHBzKTsgPz4iIGFsdD0iIj4KICAg ICAgICAgICAgIDw/cGhwIGVsc2U6ID8+CiAgICAgICAgICAgICA8P3BocCBlbmRpZjs/PgogICAg ICAgICAgICAgICAgIDxwPjw/cGhwIGVjaG8gJHRleHQ7ID8+PC9wPgpAQCAtOTQsNyArOTQsNyBA QCBjbGFzcyBXZWJLaXRUd2l0dGVyVGlsZVdpZGdldCBleHRlbmRzIFdlCiAKICAgICAgICAgPz4K ICAgICAgICAgPGRpdiBjbGFzcz0iPD9waHAgZWNobyBlc2NfYXR0cihqb2luKCcgJywgJGNsYXNz ZXMpKTsgPz4iPgotICAgICAgICAgICAgPGEgY2xhc3M9InRpbGUtbGluayIgaHJlZj0iPD9waHAg ZWNobyBlc2NfdXJsKCR1cmwpOyA/PiI+Q2xpY2thYmxlIGxpbms8L2E+CisgICAgICAgICAgICA8 YSBjbGFzcz0idGlsZS1saW5rIiBocmVmPSI8P3BocCBlY2hvIGVzY191cmwoJHVybCk7ID8+Ij48 P3BocCBlY2hvIG5sMmJyKGVzY19odG1sKCRvcHRpb25zWyd0ZXh0J10pKTsgPz48L2E+CiAgICAg ICAgICAgICA8ZGl2IGNsYXNzPSJpY29uIHR3aXR0ZXItaWNvbiI+PC9kaXY+CiAgICAgICAgICAg ICA8aDI+PD9waHAgZWNobyBubDJicihlc2NfaHRtbCgkb3B0aW9uc1sndGV4dCddKSk7ID8+PC9o Mj4KICAgICAgICAgPC9kaXY+Cg==