172079 2017-05-13 17:59:42 -0700 [cURL] Remove a call to Windows API 2017-11-22 13:53:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 daewoong.jang daewoong.jang basuke buildbot commit-queue galpeter ysuzuki oldest_to_newest 1308363 0 daewoong.jang 2017-05-13 17:59:42 -0700 Replace MoveFileEx with WebCore::moveFile to support curl on other platforms. 1308364 1 310042 daewoong.jang 2017-05-13 18:02:03 -0700 Created attachment 310042 Patch 1317213 2 312381 daewoong.jang 2017-06-08 22:30:50 -0700 Created attachment 312381 updated patch 1317262 3 312381 ysuzuki 2017-06-09 00:34:34 -0700 Comment on attachment 312381 updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=312381&action=review > Source/WebCore/platform/network/curl/CurlDownload.cpp:342 > + moveFile(m_tempPath, m_destination); Is there any implementation of moveFile for Windows? 1317312 4 312415 daewoong.jang 2017-06-09 02:36:43 -0700 Created attachment 312415 updated patch 1317325 5 312415 ysuzuki 2017-06-09 03:30:48 -0700 Comment on attachment 312415 updated patch r=me 1317342 6 312415 commit-queue 2017-06-09 04:00:15 -0700 Comment on attachment 312415 updated patch Clearing flags on attachment: 312415 Committed r217977: <http://trac.webkit.org/changeset/217977> 1317343 7 commit-queue 2017-06-09 04:00:17 -0700 All reviewed patches have been landed. Closing bug. 1374285 8 don.olmstead 2017-11-22 13:53:40 -0800 *** Bug 173963 has been marked as a duplicate of this bug. *** 310042 2017-05-13 18:02:03 -0700 2017-06-08 22:30:50 -0700 Patch bug172079.diff text/plain 1311 daewoong.jang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjgyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA1LTEzICBEYWV3b29u ZyBKYW5nICA8ZGFld29vbmcuamFuZ0BuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtjVVJMXSBS ZW1vdmUgYSBjYWxsIHRvIFdpbmRvd3MgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIwNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q3VybERvd25sb2FkOjptb3ZlRmlsZVRvRGVzdGluYXRp b24pOgorCiAyMDE3LTA1LTEzICBKYXZpZXIgRmVybmFuZGV6ICA8amZlcm5hbmRlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtjc3MtYWxpZ25dIEltcGxlbWVudCB0aGUgcGxhY2Utc2VsZiBzaG9y dGhhbmQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93 bmxvYWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y3VybC9DdXJsRG93bmxvYWQuY3BwCShyZXZpc2lvbiAyMTY4MjIpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzM5LDcgKzMzOSw3IEBAIHZvaWQgQ3VybERvd25sb2FkOjptb3ZlRmlsZVRvRGVzdGluYXRp b24KICAgICBpZiAobV9kZXN0aW5hdGlvbi5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAot ICAgIDo6TW92ZUZpbGVFeChtX3RlbXBQYXRoLmNoYXJhY3RlcnNXaXRoTnVsbFRlcm1pbmF0aW9u KCkuZGF0YSgpLCBtX2Rlc3RpbmF0aW9uLmNoYXJhY3RlcnNXaXRoTnVsbFRlcm1pbmF0aW9uKCku ZGF0YSgpLCBNT1ZFRklMRV9DT1BZX0FMTE9XRUQgfCBNT1ZFRklMRV9SRVBMQUNFX0VYSVNUSU5H KTsKKyAgICBtb3ZlRmlsZShtX3RlbXBQYXRoLCBtX2Rlc3RpbmF0aW9uKTsKIH0KIAogdm9pZCBD dXJsRG93bmxvYWQ6OndyaXRlRGF0YVRvRmlsZShjb25zdCBjaGFyKiBkYXRhLCBpbnQgc2l6ZSkK 312381 2017-06-08 22:30:50 -0700 2017-06-09 02:36:59 -0700 updated patch bug172079.diff text/plain 1308 daewoong.jang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzk2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA2LTA4ICBEYWV3b29u ZyBKYW5nICA8ZGFld29vbmcuamFuZ0BuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtjVVJMXSBS ZW1vdmUgYSBjYWxsIHRvIFdpbmRvd3MgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIwNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q3VybERvd25sb2FkOjptb3ZlRmlsZVRvRGVzdGluYXRp b24pOgorCiAyMDE3LTA2LTA4ICBZb2F2IFdlaXNzICA8eW9hdkB5b2F2LndzPgogCiAgICAgICAg IFtwcmVsb2FkXSBNYW5kYXRvcnkgYGFzYCB2YWx1ZSBhbmQgcmVsYXRlZCBzcGVjIGFsaWdubWVu dHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxv YWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9DdXJsRG93bmxvYWQuY3BwCShyZXZpc2lvbiAyMTc5NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzM5LDcgKzMzOSw3IEBAIHZvaWQgQ3VybERvd25sb2FkOjptb3ZlRmlsZVRvRGVzdGluYXRpb24K ICAgICBpZiAobV9kZXN0aW5hdGlvbi5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAotICAg IDo6TW92ZUZpbGVFeChtX3RlbXBQYXRoLmNoYXJhY3RlcnNXaXRoTnVsbFRlcm1pbmF0aW9uKCku ZGF0YSgpLCBtX2Rlc3RpbmF0aW9uLmNoYXJhY3RlcnNXaXRoTnVsbFRlcm1pbmF0aW9uKCkuZGF0 YSgpLCBNT1ZFRklMRV9DT1BZX0FMTE9XRUQgfCBNT1ZFRklMRV9SRVBMQUNFX0VYSVNUSU5HKTsK KyAgICBtb3ZlRmlsZShtX3RlbXBQYXRoLCBtX2Rlc3RpbmF0aW9uKTsKIH0KIAogdm9pZCBDdXJs RG93bmxvYWQ6OndyaXRlRGF0YVRvRmlsZShjb25zdCBjaGFyKiBkYXRhLCBpbnQgc2l6ZSkK 312415 2017-06-09 02:36:43 -0700 2017-06-09 04:00:15 -0700 updated patch bug172079.diff text/plain 2226 daewoong.jang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzk3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2LTA5ICBEYWV3b29u ZyBKYW5nICA8ZGFld29vbmcuamFuZ0BuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtjVVJMXSBS ZW1vdmUgYSBjYWxsIHRvIFdpbmRvd3MgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIwNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q3VybERvd25sb2FkOjptb3ZlRmlsZVRvRGVzdGluYXRp b24pOgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Om1vdmVGaWxlKToKKwogMjAxNy0wNi0wOSAgWmFuIERvYmVyc2VrICA8emRvYmVy c2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gRW5hYmxlIEVOQ1JZUFRFRF9NRURJQSBm b3IgYnVpbGQtd2Via2l0IGJ1aWxkcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jdXJsL0N1cmxEb3dubG9hZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxEb3dubG9hZC5jcHAJKHJldmlzaW9uIDIxNzk1NCkK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMzksNyArMzM5LDcgQEAgdm9pZCBDdXJsRG93bmxvYWQ6Om1v dmVGaWxlVG9EZXN0aW5hdGlvbgogICAgIGlmIChtX2Rlc3RpbmF0aW9uLmlzRW1wdHkoKSkKICAg ICAgICAgcmV0dXJuOwogCi0gICAgOjpNb3ZlRmlsZUV4KG1fdGVtcFBhdGguY2hhcmFjdGVyc1dp dGhOdWxsVGVybWluYXRpb24oKS5kYXRhKCksIG1fZGVzdGluYXRpb24uY2hhcmFjdGVyc1dpdGhO dWxsVGVybWluYXRpb24oKS5kYXRhKCksIE1PVkVGSUxFX0NPUFlfQUxMT1dFRCB8IE1PVkVGSUxF X1JFUExBQ0VfRVhJU1RJTkcpOworICAgIG1vdmVGaWxlKG1fdGVtcFBhdGgsIG1fZGVzdGluYXRp b24pOwogfQogCiB2b2lkIEN1cmxEb3dubG9hZDo6d3JpdGVEYXRhVG9GaWxlKGNvbnN0IGNoYXIq IGRhdGEsIGludCBzaXplKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVT eXN0ZW1XaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9G aWxlU3lzdGVtV2luLmNwcAkocmV2aXNpb24gMjE3OTU0KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzcsNiArMTc3 LDEzIEBAIGJvb2wgZGVsZXRlRW1wdHlEaXJlY3RvcnkoY29uc3QgU3RyaW5nJgogICAgIHJldHVy biAhIVJlbW92ZURpcmVjdG9yeVcoZmlsZW5hbWUuY2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRp b24oKS5kYXRhKCkpOwogfQogCitib29sIG1vdmVGaWxlKGNvbnN0IFN0cmluZyYgb2xkUGF0aCwg Y29uc3QgU3RyaW5nJiBuZXdQYXRoKQoreworICAgIFN0cmluZyBvbGRGaWxlbmFtZSA9IG9sZFBh dGg7CisgICAgU3RyaW5nIG5ld0ZpbGVuYW1lID0gbmV3UGF0aDsKKyAgICByZXR1cm4gISE6Ok1v dmVGaWxlRXgob2xkRmlsZW5hbWUuY2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKS5kYXRh KCksIG5ld0ZpbGVuYW1lLmNoYXJhY3RlcnNXaXRoTnVsbFRlcm1pbmF0aW9uKCkuZGF0YSgpLCBN T1ZFRklMRV9DT1BZX0FMTE9XRUQgfCBNT1ZFRklMRV9SRVBMQUNFX0VYSVNUSU5HKTsKK30KKwog U3RyaW5nIHBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChjb25zdCBTdHJpbmcmIHBhdGgsIGNvbnN0 IFN0cmluZyYgY29tcG9uZW50KQogewogICAgIFZlY3RvcjxVQ2hhcj4gYnVmZmVyKE1BWF9QQVRI KTsK