172065 2017-05-12 19:18:21 -0700 AccessibilityRenderObject::textUnderElement needs to assert on unclean tree. 2017-05-13 11:43:45 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan aboxhall apinheiro bfulgham buildbot cfleizach commit-queue dmazzoni jcraig jdiggs samuel_white simon.fraser webkit-bug-importer oldest_to_newest 1308229 0 zalan 2017-05-12 19:18:21 -0700 This is pretty much rolling out https://trac.webkit.org/changeset/192103/webkit 1308230 1 webkit-bug-importer 2017-05-12 19:19:21 -0700 <rdar://problem/32170759> 1308234 2 309996 zalan 2017-05-12 19:26:21 -0700 Created attachment 309996 Patch 1308311 3 309996 commit-queue 2017-05-13 11:43:43 -0700 Comment on attachment 309996 Patch Clearing flags on attachment: 309996 Committed r216825: <http://trac.webkit.org/changeset/216825> 1308312 4 commit-queue 2017-05-13 11:43:45 -0700 All reviewed patches have been landed. Closing bug. 309996 2017-05-12 19:26:21 -0700 2017-05-13 11:43:43 -0700 Patch bug-172065-20170512192620.patch text/plain 3556 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQyNGM1YWQwNjViMmE2 M2RmY2M1MTAzZDUwZjljZTk5OGU0MzIyZi4uYThjYjJlNDgwZGU2NGEyZjJlNDM5ODczYmZmYTM5 NjE2ZjFlNWFkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA1LTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWNjZXNzaWJpbGl0eVJlbmRl ck9iamVjdDo6dGV4dFVuZGVyRWxlbWVudCBuZWVkcyB0byBhc3NlcnQgb24gdW5jbGVhbiB0cmVl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyMDY1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjE5MjEw MyBjaGFuZ2VkIHRoZSBhc3NlcnQgbG9naWMgaW5jb3JyZWN0bHkuIElmIHRoZSB0cmVlIGlzIGRp cnR5LCByZWdhcmRsZXNzIG9mIHRoZSByZW5kZXJlcidzIHR5cGUsCisgICAgICAgIFRleHRJdGVy YXRvciB3aWxsIGVuZCB1cCBmb3JjaW5nIHN0eWxlIHVwZGF0ZS9sYXlvdXQgb24gdGhlIHJlbmRl ciB0cmVlLgorICAgICAgICBUaGUgb3JpZ2luYWwgYXNzZXJ0IHdvdWxkIGhhdmUgaGl0IHdpdGgg YnVnIDE3MTU0NiBwcmlvciB0byByMjE2NzI2LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3Q6OnRleHRVbmRlckVsZW1lbnQpOgorCiAyMDE3LTA1LTExICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IERlZmVyIHRleHQgY2hh bmdlcyB1bnRpbCBhZnRlciB0aGUgdHJlZSBpcyBjbGVhbiBpZiBuZWVkZWQuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0LmNwcAppbmRleCBmMGVjYWY5YmIwMDQyYjhmNjM1OTkxYzkyYTk5ZTBkMzFiOTQwN2M5Li5m MDc3ZjlhNzY5ZTM3MmEzNjMyZjQ5YjhhMmE2ODgzZTAyNDNjMjhjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dC5jcHAKQEAgLTYyNCwxNSArNjI0LDEyIEBAIFN0cmluZyBBY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0Ojp0ZXh0VW5kZXJFbGVtZW50KEFjY2Vzc2liaWxpdHlUZXh0VW5kZXJFbGVtZW50CiAgICAg aWYgKG1fcmVuZGVyZXItPmlzQlIoKSkKICAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiXG4i KTsKIAotICAgIGJvb2wgaXNSZW5kZXJUZXh0ID0gaXM8UmVuZGVyVGV4dD4oKm1fcmVuZGVyZXIp OwotCiAgICAgaWYgKHNob3VsZEdldFRleHRGcm9tTm9kZShtb2RlKSkKICAgICAgICAgcmV0dXJu IEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0Ojp0ZXh0VW5kZXJFbGVtZW50KG1vZGUpOwogCiAgICAg Ly8gV2UgdXNlIGEgdGV4dCBpdGVyYXRvciBmb3IgdGV4dCBvYmplY3RzIEFORCBmb3IgdGhvc2Ug Y2FzZXMgd2hlcmUgd2UgYXJlCiAgICAgLy8gZXhwbGljaXRseSBhc2tpbmcgZm9yIHRoZSBmdWxs IHRleHQgdW5kZXIgYSBnaXZlbiBlbGVtZW50LgotICAgIGJvb2wgc2hvdWxkSW5jbHVkZUFsbENo aWxkcmVuID0gbW9kZS5jaGlsZHJlbkluY2x1c2lvbiA9PSBBY2Nlc3NpYmlsaXR5VGV4dFVuZGVy RWxlbWVudE1vZGU6OlRleHRVbmRlckVsZW1lbnRNb2RlSW5jbHVkZUFsbENoaWxkcmVuOwotICAg IGlmIChpc1JlbmRlclRleHQgfHwgc2hvdWxkSW5jbHVkZUFsbENoaWxkcmVuKSB7CisgICAgaWYg KGlzPFJlbmRlclRleHQ+KCptX3JlbmRlcmVyKSB8fCBtb2RlLmNoaWxkcmVuSW5jbHVzaW9uID09 IEFjY2Vzc2liaWxpdHlUZXh0VW5kZXJFbGVtZW50TW9kZTo6VGV4dFVuZGVyRWxlbWVudE1vZGVJ bmNsdWRlQWxsQ2hpbGRyZW4pIHsKICAgICAgICAgLy8gSWYgcG9zc2libGUsIHVzZSBhIHRleHQg aXRlcmF0b3IgdG8gZ2V0IHRoZSB0ZXh0LCBzbyB0aGF0IHdoaXRlc3BhY2UKICAgICAgICAgLy8g aXMgaGFuZGxlZCBjb25zaXN0ZW50bHkuCiAgICAgICAgIERvY3VtZW50KiBub2RlRG9jdW1lbnQg PSBudWxscHRyOwpAQCAtNjY2LDExICs2NjMsMTAgQEAgU3RyaW5nIEFjY2Vzc2liaWxpdHlSZW5k ZXJPYmplY3Q6OnRleHRVbmRlckVsZW1lbnQoQWNjZXNzaWJpbGl0eVRleHRVbmRlckVsZW1lbnQK ICAgICAgICAgICAgICAgICBpZiAoZnJhbWUtPmRvY3VtZW50KCkgIT0gbm9kZURvY3VtZW50KQog ICAgICAgICAgICAgICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAKLSAgICAgICAgICAgICAgICAv LyBUaGUgdHJlZSBzaG91bGQgYmUgc3RhYmxlIGJlZm9yZSBsb29raW5nIHRocm91Z2ggdGhlIGNo aWxkcmVuIG9mIGEgbm9uLVJlbmRlciBUZXh0IG9iamVjdC4KLSAgICAgICAgICAgICAgICAvLyBP dGhlcndpc2UsIGZ1cnRoZXIgdXNlcyBvZiBUZXh0SXRlcmF0b3Igd2lsbCBmb3JjZSBhIGxheW91 dCB1cGRhdGUsIHBvdGVudGlhbGx5IGFsdGVyaW5nCi0gICAgICAgICAgICAgICAgLy8gdGhlIGFj Y2Vzc2liaWxpdHkgdHJlZSBhbmQgY2F1c2luZyBjcmFzaGVzIGluIHRoZSBsb29wIHRoYXQgY29t cHV0ZXMgdGhlIHJlc3VsdCB0ZXh0LgotICAgICAgICAgICAgICAgIEFTU0VSVCgoaXNSZW5kZXJU ZXh0IHx8ICFzaG91bGRJbmNsdWRlQWxsQ2hpbGRyZW4pIHx8ICghbm9kZURvY3VtZW50LT5yZW5k ZXJWaWV3KCktPmxheW91dFN0YXRlKCkgJiYgIW5vZGVEb2N1bWVudC0+Y2hpbGROZWVkc1N0eWxl UmVjYWxjKCkpKTsKLQorICAgICAgICAgICAgICAgIC8vIFJlbmRlcnMgcmVmZXJlbmNlZCBieSBh Y2Nlc3NpYmlsaXR5IG9iamVjdHMgY291bGQgZ2V0IGRlc3Ryb3llZCwgaWYgVGV4dEl0ZXJhdG9y IGVuZHMgdXAgdHJpZ2dlcmluZworICAgICAgICAgICAgICAgIC8vIHN0eWxlIHVwZGF0ZS9sYXlv dXQgaGVyZS4gU2VlIGFsc28gQVhPYmplY3RDYWNoZTo6ZGVmZXJUZXh0Q2hhbmdlZElmTmVlZGVk KCkuCisgICAgICAgICAgICAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIW5v ZGVEb2N1bWVudC0+Y2hpbGROZWVkc1N0eWxlUmVjYWxjKCkpOworICAgICAgICAgICAgICAgIEFT U0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKCFub2RlRG9jdW1lbnQtPnZpZXcoKS0+aXNJ blJlbmRlclRyZWVMYXlvdXQoKSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIHBsYWluVGV4dCh0 ZXh0UmFuZ2UuZ2V0KCksIHRleHRJdGVyYXRvckJlaGF2aW9yRm9yVGV4dFJhbmdlKCkpOwogICAg ICAgICAgICAgfQogICAgICAgICB9Cg==