172047 2017-05-12 14:08:12 -0700 Only ever initialize LibWebRTCProvider's staticFactoryAndThreads() factories once. 2017-05-15 15:34:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble buildbot commit-queue eric.carlson youennf oldest_to_newest 1308049 0 jer.noble 2017-05-12 14:08:12 -0700 Only ever initialize LibWebRTCProvider's staticFactoryAndThreads() factories once. 1308821 1 310172 jer.noble 2017-05-15 15:00:16 -0700 Created attachment 310172 Patch 1308823 2 buildbot 2017-05-15 15:02:55 -0700 Attachment 310172 did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:66: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:67: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1308834 3 310172 commit-queue 2017-05-15 15:34:19 -0700 Comment on attachment 310172 Patch Clearing flags on attachment: 310172 Committed r216884: <http://trac.webkit.org/changeset/216884> 1308835 4 commit-queue 2017-05-15 15:34:20 -0700 All reviewed patches have been landed. Closing bug. 310172 2017-05-15 15:00:16 -0700 2017-05-15 15:34:19 -0700 Patch bug-172047-20170515150116.patch text/plain 2455 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNlYTYzMzg5OTc4NTU4 MTBiNGZmYzkzOTczNmUyMjQ4ZGZhZTdhNi4uMmJlMGYwZDM1YTc5MWI5ZmFkMzU5YWIwNjIyY2Q5 ZGZmZWUwZjI5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE3LTA1LTEyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIE9ubHkgZXZlciBpbml0aWFs aXplIExpYldlYlJUQ1Byb3ZpZGVyJ3Mgc3RhdGljRmFjdG9yeUFuZFRocmVhZHMoKSBmYWN0b3Jp ZXMgb25jZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3MjA0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdyYXAgdGhlIGluaXRpbGl6YXRpb24gb2YgdGhlIGZhY3RvcmllcyBjb250YWluZWQgaW4gc3Rh dGljRmFjdG9yeUFuZFRocmVhZHMoKSBpbiBhIGNhbGxfb25jZSB0byBlbnN1cmUKKyAgICAgICAg bmV3IGZhY3RvcmllcyBhcmVuJ3QgY3JlYXRlZCBldmVyeSB0aW1lIGl0J3MgY2FsbGVkLgorCisg ICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnN0YXRpY0ZhY3RvcnlBbmRUaHJlYWRzKToKKworMjAx Ny0wNS0xMiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKwogICAgICAgICBbTWVk aWFTdHJlYW1dIFN0cmVhbXMgd2hpbGUgcGxheSB3aGlsZSBwYWdlIGlzIGluIGJhY2tncm91bmQg Y2FuIGdldCAic3R1Y2siIHdoZW4gcGFnZSBpcyBmb3Jncm91bmRlZC4KICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjAyMgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJv dmlkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRj L0xpYldlYlJUQ1Byb3ZpZGVyLmNwcAppbmRleCA1MmEzMjllZGQ5MTMxNTg2NzZlMDViNmE5YTZm OTJhODE4MzZkNjBkLi4xZTBkNWMyNWU5NWNhNzJmMjEyMzY0NmVmZDhjOWQ3OGI4OGQ3YjA0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMv TGliV2ViUlRDUHJvdmlkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlh c3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlci5jcHAKQEAgLTYxLDggKzYxLDExIEBA IHN0YXRpYyBpbmxpbmUgUGVlckNvbm5lY3Rpb25GYWN0b3J5QW5kVGhyZWFkcyYgc3RhdGljRmFj dG9yeUFuZFRocmVhZHMoKQogewogICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxQZWVyQ29ubmVj dGlvbkZhY3RvcnlBbmRUaHJlYWRzPiBmYWN0b3J5QW5kVGhyZWFkczsKICNpZiBQTEFURk9STShD T0NPQSkKLSAgICBmYWN0b3J5QW5kVGhyZWFkcy5nZXQoKS5lbmNvZGVyRmFjdG9yeUdldHRlciA9 IFtdKCkgLT4gc3RkOjp1bmlxdWVfcHRyPGNyaWNrZXQ6OldlYlJ0Y1ZpZGVvRW5jb2RlckZhY3Rv cnk+IHsgcmV0dXJuIHN0ZDo6bWFrZV91bmlxdWU8VmlkZW9Ub29sYm94VmlkZW9FbmNvZGVyRmFj dG9yeT4oKTsgfTsKLSAgICBmYWN0b3J5QW5kVGhyZWFkcy5nZXQoKS5kZWNvZGVyRmFjdG9yeUdl dHRlciA9IFtdKCkgLT4gc3RkOjp1bmlxdWVfcHRyPGNyaWNrZXQ6OldlYlJ0Y1ZpZGVvRGVjb2Rl ckZhY3Rvcnk+IHsgcmV0dXJuIHN0ZDo6bWFrZV91bmlxdWU8d2VicnRjOjpWaWRlb1Rvb2xib3hW aWRlb0RlY29kZXJGYWN0b3J5PigpOyB9OworICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBvbmNl OworICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2UsIFtdIHsKKyAgICAgICAgZmFjdG9yeUFuZFRocmVh ZHMuZ2V0KCkuZW5jb2RlckZhY3RvcnlHZXR0ZXIgPSBbXSgpIC0+IHN0ZDo6dW5pcXVlX3B0cjxj cmlja2V0OjpXZWJSdGNWaWRlb0VuY29kZXJGYWN0b3J5PiB7IHJldHVybiBzdGQ6Om1ha2VfdW5p cXVlPFZpZGVvVG9vbGJveFZpZGVvRW5jb2RlckZhY3Rvcnk+KCk7IH07CisgICAgICAgIGZhY3Rv cnlBbmRUaHJlYWRzLmdldCgpLmRlY29kZXJGYWN0b3J5R2V0dGVyID0gW10oKSAtPiBzdGQ6OnVu aXF1ZV9wdHI8Y3JpY2tldDo6V2ViUnRjVmlkZW9EZWNvZGVyRmFjdG9yeT4geyByZXR1cm4gc3Rk OjptYWtlX3VuaXF1ZTx3ZWJydGM6OlZpZGVvVG9vbGJveFZpZGVvRGVjb2RlckZhY3Rvcnk+KCk7 IH07CisgICAgfSk7CiAjZW5kaWYKICAgICByZXR1cm4gZmFjdG9yeUFuZFRocmVhZHMuZ2V0KCk7 CiB9Cg==