172041 2017-05-12 12:50:44 -0700 Add some logging for layer tree commits, and resize and orientation change events 2017-05-12 13:09:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser buildbot cdumez dbates esprehn+autocc kangil.han simon.fraser thorton oldest_to_newest 1308001 0 simon.fraser 2017-05-12 12:50:44 -0700 Add some logging for layer tree commits, and resize and orientation change events 1308004 1 309929 simon.fraser 2017-05-12 12:52:51 -0700 Created attachment 309929 Patch 1308008 2 309929 thorton 2017-05-12 12:59:40 -0700 Comment on attachment 309929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309929&action=review > Source/WebCore/dom/Document.cpp:6973 > + LOG(Events, "Document %p orientationChanged - orientation %d)", this, orientation); What is that closed paren. 1308017 3 simon.fraser 2017-05-12 13:09:53 -0700 https://trac.webkit.org/r216778 309929 2017-05-12 12:52:51 -0700 2017-05-12 12:59:40 -0700 Patch bug-172041-20170512125250.patch text/plain 5088 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTVlNzEwZGEwNWM2N2Q0 NjQ4YWY0ZDVkZmM1NTdiNWM2MWZhN2YzZS4uNGYwN2Q5ZjM1Y2VjMzA0MmNmYjBkM2NkZmUyYWZk MGM3Y2RiMWI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA1LTEyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzb21lIGxv Z2dpbmcgZm9yIGxheWVyIHRyZWUgY29tbWl0cywgYW5kIHJlc2l6ZSBhbmQgb3JpZW50YXRpb24g Y2hhbmdlIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTcyMDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIHNvbWUgbG9nZ2luZyB0aGF0J3MgdXNlZnVsIGR1cmluZyByb3RhdGlvbiBpbnZl c3RpZ2F0aW9ucy4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpEb2N1bWVudDo6b3JpZW50YXRpb25DaGFuZ2VkKToKKyAgICAgICAgKiBwYWdlL0ZyYW1l Vmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnNlbmRSZXNpemVFdmVudElm TmVlZGVkKToKKwogMjAxNy0wNS0wOCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFRleHQgb3ZlcmxhcHMgb24gaHR0cDovL3d3dy5kdWRlbi5kZS9yZWNodHNjaHJl aWJ1bmcvQWNyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGI3YmZjMDU0NDgzMDVlZmQzOGM3NDhlZDgwMTFjNGM2 OGQ1MWRiZjYuLmY0ZjVjNTc0MTgxNTg1NmYxMDVhNjM2ODM1NzI0YzliM2I3YWRmODMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNy0wNS0xMiAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc29tZSBsb2dnaW5nIGZvciBsYXllciB0 cmVlIGNvbW1pdHMsIGFuZCByZXNpemUgYW5kIG9yaWVudGF0aW9uIGNoYW5nZSBldmVudHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjA0MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzb21lIGxv Z2dpbmcgdGhhdCdzIHVzZWZ1bCBkdXJpbmcgcm90YXRpb24gaW52ZXN0aWdhdGlvbnMuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tX ZWJWaWV3IF9kaWRDb21taXRMYXllclRyZWU6XSk6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3Lm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9kaWRDb21taXRMYXll clRyZWU6XSk6CisKIDIwMTctMDUtMDggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBNb3ZlICdzdHlsZScgZnJvbSBFbGVtZW50IHRvIEhUTUxFbGVtZW50IC8gU1ZH RWxlbWVudCBhbmQgbWFrZSBpdCBzZXR0YWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXgg Y2EyNWZjYWJjZDhjNmYyYzRmZDNjNjA4NDU1ZjNkMmE0NmE1NTQ0Mi4uMjRmMDRiYTI4ZGYwYzJk ZDc5MDQwN2ZhZjgyYmIyZDllYjMwMmRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC02 OTcwLDYgKzY5NzAsNyBAQCB2b2lkIERvY3VtZW50OjpkaWRSZW1vdmVJbkRvY3VtZW50U2hhZG93 Um9vdChTaGFkb3dSb290JiBzaGFkb3dSb290KQogCiB2b2lkIERvY3VtZW50OjpvcmllbnRhdGlv bkNoYW5nZWQoaW50IG9yaWVudGF0aW9uKQogeworICAgIExPRyhFdmVudHMsICJEb2N1bWVudCAl cCBvcmllbnRhdGlvbkNoYW5nZWQgLSBvcmllbnRhdGlvbiAlZCkiLCB0aGlzLCBvcmllbnRhdGlv bik7CiAgICAgZGlzcGF0Y2hXaW5kb3dFdmVudChFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5v cmllbnRhdGlvbmNoYW5nZUV2ZW50LCBmYWxzZSwgZmFsc2UpKTsKICAgICBtX29yaWVudGF0aW9u Tm90aWZpZXIub3JpZW50YXRpb25DaGFuZ2VkKG9yaWVudGF0aW9uKTsKIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcAppbmRleCAzMTBmM2I0MGJmMzIxODFkNGEzYWUyM2NkZWQxNGQ2MTkyOGQ0 MzdjLi4zNzk1YjE0NmJiYmMwNGYxMGQyMzIwNTIyNjJlNDM2NGNlNTliZGViIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0zNjI1LDYgKzM2MjUsOCBAQCB2b2lkIEZyYW1lVmlldzo6 c2VuZFJlc2l6ZUV2ZW50SWZOZWVkZWQoKQogICAgIGJvb2wgaXNNYWluRnJhbWUgPSBmcmFtZSgp LmlzTWFpbkZyYW1lKCk7CiAgICAgYm9vbCBjYW5TZW5kUmVzaXplRXZlbnRTeW5jaHJvbm91c2x5 ID0gaXNNYWluRnJhbWUgJiYgIW1fc2hvdWxkQXV0b1NpemU7CiAKKyAgICBMT0coRXZlbnRzLCAi RnJhbWVWaWV3ICVwIHNlbmRSZXNpemVFdmVudElmTmVlZGVkIHNlbmRpbmcgcmVzaXplIGV2ZW50 LCBzaXplICVkeCVkIChjYW5TZW5kUmVzaXplRXZlbnRTeW5jaHJvbm91c2x5ICVkKSIsIHRoaXMs IGN1cnJlbnRTaXplLndpZHRoKCksIGN1cnJlbnRTaXplLmhlaWdodCgpLCBjYW5TZW5kUmVzaXpl RXZlbnRTeW5jaHJvbm91c2x5KTsKKwogICAgIFJlZjxFdmVudD4gcmVzaXplRXZlbnQgPSBFdmVu dDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5yZXNpemVFdmVudCwgZmFsc2UsIGZhbHNlKTsKICAgICBp ZiAoY2FuU2VuZFJlc2l6ZUV2ZW50U3luY2hyb25vdXNseSkKICAgICAgICAgZnJhbWUoKS5kb2N1 bWVudCgpLT5kaXNwYXRjaFdpbmRvd0V2ZW50KHJlc2l6ZUV2ZW50KTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggMzAzZDhkNzdkOWVi ZDMwNzY0N2E1ZjNjZDU3NmJjYjAxMzFiOWYzYS4uM2Y1ODM3ZDQxOTAxYThkYzMwZDI5NDBmYmIw Y2Y0ZDNjMWFkOGY3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXcubW0KQEAgLTE0NjMsNiArMTQ2Myw4IEBAIC0gKHZvaWQpX2RpZENvbW1pdExh eWVyVHJlZTooY29uc3QgV2ViS2l0OjpSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbiYpbGF5ZXJU cmVlCiAgICAgaWYgKCFbc2VsZiB1c2VzU3RhbmRhcmRDb250ZW50Vmlld10pCiAgICAgICAgIHJl dHVybjsKIAorICAgIExPR19XSVRIX1NUUkVBTShWaXNpYmxlUmVjdHMsIHN0cmVhbSA8PCAiLVtX S1dlYlZpZXcgX2RpZENvbW1pdExheWVyVHJlZTpdIHRyYW5zYWN0aW9uSUQgIiA8PCAgbGF5ZXJU cmVlVHJhbnNhY3Rpb24udHJhbnNhY3Rpb25JRCgpIDw8ICIgX2R5bmFtaWNWaWV3cG9ydFVwZGF0 ZU1vZGUgIiA8PCAoaW50KV9keW5hbWljVmlld3BvcnRVcGRhdGVNb2RlKTsKKwogICAgIGlmIChf ZHluYW1pY1ZpZXdwb3J0VXBkYXRlTW9kZSAhPSBEeW5hbWljVmlld3BvcnRVcGRhdGVNb2RlOjpO b3RSZXNpemluZykgewogICAgICAgICBpZiAoX3Jlc2l6ZUFuaW1hdGlvblRyYW5zZm9ybVRyYW5z YWN0aW9uSUQgJiYgbGF5ZXJUcmVlVHJhbnNhY3Rpb24udHJhbnNhY3Rpb25JRCgpID49IF9yZXNp emVBbmltYXRpb25UcmFuc2Zvcm1UcmFuc2FjdGlvbklELnZhbHVlKCkpIHsKICAgICAgICAgICAg IF9yZXNpemVBbmltYXRpb25UcmFuc2Zvcm1UcmFuc2FjdGlvbklEID0gc3RkOjpudWxsb3B0Owpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1t IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCmluZGV4IDQz NjM1MGQxMTYzOGMzMjFiMDc3ZDBjMTdmNTE5NmQwNTQ0ZTI5ZGYuLmRlZGE4ZDk3ZDgxZjg5NWY3 MDFjOWIyYWZhOTE0NmZiMTliZDIxZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXcubW0KQEAgLTU1OSw2ICs1NTksOCBAQCAtICh2b2lkKV9kaWRDb21t aXRMYXllclRyZWU6KGNvbnN0IFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24mKWxh eWVyVHJlZQogICAgIENHUG9pbnQgc2Nyb2xsT3JpZ2luID0gLWxheWVyVHJlZVRyYW5zYWN0aW9u LnNjcm9sbE9yaWdpbigpOwogICAgIENHUmVjdCBjb250ZW50Qm91bmRzID0geyBzY3JvbGxPcmln aW4sIGNvbnRlbnRzU2l6ZSB9OwogCisgICAgTE9HX1dJVEhfU1RSRUFNKFZpc2libGVSZWN0cywg c3RyZWFtIDw8ICItW1dLQ29udGVudFZpZXcgX2RpZENvbW1pdExheWVyVHJlZTpdIHRyYW5zYWN0 aW9uSUQgIiA8PCAgbGF5ZXJUcmVlVHJhbnNhY3Rpb24udHJhbnNhY3Rpb25JRCgpIDw8ICIgY29u dGVudEJvdW5kcyAiIDw8IEZsb2F0UmVjdChjb250ZW50Qm91bmRzKSk7CisKICAgICBCT09MIGJv dW5kc0NoYW5nZWQgPSAhQ0dSZWN0RXF1YWxUb1JlY3QoW3NlbGYgYm91bmRzXSwgY29udGVudEJv dW5kcyk7CiAgICAgaWYgKGJvdW5kc0NoYW5nZWQpCiAgICAgICAgIFtzZWxmIHNldEJvdW5kczpj b250ZW50Qm91bmRzXTsK