172035 2017-05-12 10:14:38 -0700 Memory pressure response should only do sync bmalloc scavenge in sync mode. 2017-05-12 11:21:50 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue ggaren kling msaboff oldest_to_newest 1307915 0 kling 2017-05-12 10:14:38 -0700 Telling bmalloc to synchronously scavenge when we're not in a hurry is silly. Let's not be that silly. 1307919 1 309909 kling 2017-05-12 10:18:54 -0700 Created attachment 309909 Patch 1307922 2 309909 msaboff 2017-05-12 10:24:37 -0700 Comment on attachment 309909 Patch r=me 1307930 3 msaboff 2017-05-12 10:32:48 -0700 One thing to note, in my testing on iOS all memory pressure notifications are critical. I have never seen WARN events. 1307958 4 309909 commit-queue 2017-05-12 11:21:48 -0700 Comment on attachment 309909 Patch Clearing flags on attachment: 309909 Committed r216770: <http://trac.webkit.org/changeset/216770> 1307959 5 commit-queue 2017-05-12 11:21:50 -0700 All reviewed patches have been landed. Closing bug. 309909 2017-05-12 10:18:54 -0700 2017-05-12 11:21:48 -0700 Patch bug-172035.diff text/plain 2704 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NTFlMDNjMjI4OS4uYTBmMTkzNDI1YmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOSBAQAogMjAxNy0wNS0xMiAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+ CiAKKyAgICAgICAgTWVtb3J5IHByZXNzdXJlIHJlc3BvbnNlIHNob3VsZCBvbmx5IGRvIHN5bmMg Ym1hbGxvYyBzY2F2ZW5nZSBpbiBzeW5jIG1vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIwMzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IGNhbGwgV1RGOjpyZWxlYXNlRmFzdE1hbGxvY0Zy ZWVNZW1vcnkoKSBhbmQgaGlzIHRocmVhZGluZy1yZWxhdGVkIGZyaWVuZHMKKyAgICAgICAgd2hl biByZWxlYXNlTWVtb3J5KCkgaXMgaW52b2tlZCB3aXRoIFN5bmNocm9ub3VzOjpZZXMsIG9yIGlm IGl0J3MgYSBjcml0aWNhbAorICAgICAgICBwcmVzc3VyZSByZXNwb25zZSAobWFpbnRhaW5pbmcg dGhlIGJlaGF2aW9yIGFkZGVkIGluIHIyMTU3NzUuKQorCisgICAgICAgICogcGFnZS9NZW1vcnlS ZWxlYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJlbGVhc2VNZW1vcnkpOgorCisyMDE3LTA1 LTEyICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAgICBNZWRpYVJl c291cmNlTG9hZGVyIHNob3VsZG4ndCBrZWVwIGl0cyBIVE1MTWVkaWFFbGVtZW50IGFsaXZlLgog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyMDMyCiAg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDgxNjE0ND4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvTWVtb3J5UmVsZWFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL01lbW9yeVJl bGVhc2UuY3BwCmluZGV4IDQ2MTA5NjIyNmZmLi4yMTRlOWQzMjU5MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9NZW1vcnlSZWxlYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL01lbW9yeVJlbGVhc2UuY3BwCkBAIC0xMTAsMjQgKzExMCwyNiBAQCB2b2lkIHJlbGVhc2VN ZW1vcnkoQ3JpdGljYWwgY3JpdGljYWwsIFN5bmNocm9ub3VzIHN5bmNocm9ub3VzKQogewogICAg IFRyYWNlU2NvcGUgc2NvcGUoTWVtb3J5UHJlc3N1cmVIYW5kbGVyU3RhcnQsIE1lbW9yeVByZXNz dXJlSGFuZGxlckVuZCwgc3RhdGljX2Nhc3Q8dWludDY0X3Q+KGNyaXRpY2FsKSwgc3RhdGljX2Nh c3Q8dWludDY0X3Q+KHN5bmNocm9ub3VzKSk7CiAKLSAgICAvLyBSZXR1cm4gdW51c2VkIHBhZ2Vz IGJhY2sgdG8gdGhlIE9TIG5vdyBhcyB0aGlzIHdpbGwgbGlrZWx5IGdpdmUgdXMgYSBsaXR0bGUg bWVtb3J5IHRvIHdvcmsgd2l0aC4KLSAgICBXVEY6OnJlbGVhc2VGYXN0TWFsbG9jRnJlZU1lbW9y eSgpOwotCi0gICAgaWYgKGNyaXRpY2FsID09IENyaXRpY2FsOjpZZXMpCisgICAgaWYgKGNyaXRp Y2FsID09IENyaXRpY2FsOjpZZXMpIHsKKyAgICAgICAgLy8gUmV0dXJuIHVudXNlZCBwYWdlcyBi YWNrIHRvIHRoZSBPUyBub3cgYXMgdGhpcyB3aWxsIGxpa2VseSBnaXZlIHVzIGEgbGl0dGxlIG1l bW9yeSB0byB3b3JrIHdpdGguCisgICAgICAgIFdURjo6cmVsZWFzZUZhc3RNYWxsb2NGcmVlTWVt b3J5KCk7CiAgICAgICAgIHJlbGVhc2VDcml0aWNhbE1lbW9yeShzeW5jaHJvbm91cyk7CisgICAg fQogCiAgICAgcmVsZWFzZU5vbmNyaXRpY2FsTWVtb3J5KCk7CiAKICAgICBwbGF0Zm9ybVJlbGVh c2VNZW1vcnkoY3JpdGljYWwpOwogCi0gICAgLy8gRmFzdE1hbGxvYyBoYXMgbG9jay1mcmVlIHRo cmVhZCBzcGVjaWZpYyBjYWNoZXMgdGhhdCBjYW4gb25seSBiZSBjbGVhcmVkIGZyb20gdGhlIHRo cmVhZCBpdHNlbGYuCi0gICAgV29ya2VyVGhyZWFkOjpyZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1v cnlJbkFsbFRocmVhZHMoKTsKKyAgICBpZiAoc3luY2hyb25vdXMgPT0gU3luY2hyb25vdXM6Olll cykgeworICAgICAgICAvLyBGYXN0TWFsbG9jIGhhcyBsb2NrLWZyZWUgdGhyZWFkIHNwZWNpZmlj IGNhY2hlcyB0aGF0IGNhbiBvbmx5IGJlIGNsZWFyZWQgZnJvbSB0aGUgdGhyZWFkIGl0c2VsZi4K KyAgICAgICAgV29ya2VyVGhyZWFkOjpyZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnlJbkFsbFRo cmVhZHMoKTsKICNpZiBFTkFCTEUoQVNZTkNfU0NST0xMSU5HKSAmJiAhUExBVEZPUk0oSU9TKQot ICAgIFNjcm9sbGluZ1RocmVhZDo6ZGlzcGF0Y2goW10oKSB7Ci0gICAgICAgIFdURjo6cmVsZWFz ZUZhc3RNYWxsb2NGcmVlTWVtb3J5KCk7Ci0gICAgfSk7CisgICAgICAgIFNjcm9sbGluZ1RocmVh ZDo6ZGlzcGF0Y2goW10oKSB7CisgICAgICAgICAgICBXVEY6OnJlbGVhc2VGYXN0TWFsbG9jRnJl ZU1lbW9yeSgpOworICAgICAgICB9KTsKICNlbmRpZgotICAgIFdURjo6cmVsZWFzZUZhc3RNYWxs b2NGcmVlTWVtb3J5KCk7CisgICAgICAgIFdURjo6cmVsZWFzZUZhc3RNYWxsb2NGcmVlTWVtb3J5 KCk7CisgICAgfQogCiAjaWYgRU5BQkxFKFJFU09VUkNFX1VTQUdFKQogICAgIFBhZ2U6OmZvckVh Y2hQYWdlKFsmXShQYWdlJiBwYWdlKSB7Cg==