172025 2017-05-12 01:52:01 -0700 [GTK] ASSERTION FAILED: !m_flushingLayers 2017-05-12 04:42:59 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply buildbot clopez cmarcelo kondapallykalyan luiz noam yoon zan oldest_to_newest 1307821 0 cgarcia 2017-05-12 01:52:01 -0700 Many layout tests using accelerated compositing are crashing in the GTK+ debug bot because of this assert. It happens when dumping the layers, RenderLayerCompositor::layerTreeAsText() calls flushPendingLayerChanges() and at some point one of the layers calls client().notifyFlushRequired(). CoordinatedGraphicsLayer::notifyFlushRequired() has an early return when the coordinator is flushing layer, but in this case the CompositingCoordinator doesn't know anything about this layer flush. Thread 1 (Thread 0x7f22d48aca40 (LWP 995)): #0 0x00007f22e3a09201 in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:292 #1 0x00000000047d6ce8 in (anonymous namespace)::RenderLayerCompositor::scheduleLayerFlush (this=0x7f22d3f703b0, canThrottle=false) at ../../Source/WebCore/rendering/RenderLayerCompositor.cpp:405 #2 0x00000000047d6c5a in (anonymous namespace)::RenderLayerCompositor::notifyFlushRequired (this=0x7f22d3f703b0, layer=0x7f22843db200) at ../../Source/WebCore/rendering/RenderLayerCompositor.cpp:394 #3 0x0000000004d066bd in (anonymous namespace)::CoordinatedGraphicsLayer::notifyFlushRequired (this=0x7f22843db200) at ../../Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:63 #4 0x0000000004d066ec in (anonymous namespace)::CoordinatedGraphicsLayer::didChangeLayerState (this=0x7f22843db200) at ../../Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:69 #5 0x0000000004d085f5 in (anonymous namespace)::CoordinatedGraphicsLayer::syncImageBacking (this=0x7f22843db200) at ../../Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:637 #6 0x0000000004d08c6a in (anonymous namespace)::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly (this=0x7f22843db200) at ../../Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:737 #7 0x0000000004d081db in (anonymous namespace)::CoordinatedGraphicsLayer::flushCompositingState (this=0x7f22843db200, rect=...) at ../../Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:584 #8 0x00000000047d70e1 in (anonymous namespace)::RenderLayerCompositor::flushPendingLayerChanges (this=0x7f22d3f703b0, isFlushRoot=true) at ../../Source/WebCore/rendering/RenderLayerCompositor.cpp:455 #9 0x00000000047dbe60 in (anonymous namespace)::RenderLayerCompositor::layerTreeAsText (this=0x7f22d3f703b0, flags=0) at ../../Source/WebCore/rendering/RenderLayerCompositor.cpp:1814 #10 0x00000000042f1b56 in (anonymous namespace)::Frame::layerTreeAsText (this=0x7f22d3f92000, flags=0) at ../../Source/WebCore/page/Frame.cpp:924 #11 0x00007f22866173bc in (anonymous namespace)::Internals::layerTreeAsText (this=0x7f22d3ff5f00, document=..., flags=0) at ../../Source/WebCore/testing/Internals.cpp:2264 #12 0x00007f2286595878 in (anonymous namespace)::jsInternalsPrototypeFunctionLayerTreeAsTextCaller (state=0x7ffcc6bb3da0, castedThis=0x7f226f1c8820, throwScope=...) at DerivedSources/WebCore/JSInternals.cpp:4001 #13 0x00007f22865b120e in (anonymous namespace)::BindingCaller<WebCore::JSInternals>::callOperation<WebCore::jsInternalsPrototypeFunctionLayerTreeAsTextCaller, (WebCore::CastedThisErrorBehavior)0> (state=0x7ffcc6bb3da0, operationName=0x7f22866a11fa "layerTreeAsText") at ../../Source/WebCore/bindings/js/JSDOMBindingCaller.h:71 #14 0x00007f22865956d7 in (anonymous namespace)::jsInternalsPrototypeFunctionLayerTreeAsText (state=0x7ffcc6bb3da0) at DerivedSources/WebCore/JSInternals.cpp:3987 #15 0x00007f228cdbe028 in ?? () #16 0x00007ffcc6bb3e20 in ?? () #17 0x00007f22e3500b07 in llint_entry () at ../../Source/WTF/wtf/RefPtr.h:80 Backtrace stopped: frame did not save the PC I'm not sure, but I think this could have started when we switched to the display refresh monitor, which also makes me wonder if we should be using the GraphicsLayerUpdater for some of the layers. This is causing the debug bot to always exit early :-( 1307822 1 cgarcia 2017-05-12 01:55:37 -0700 I forgot to mention that this doesn't happen when tests are run individually, only when several tests are run in the same UI process. 1307829 2 309885 cgarcia 2017-05-12 02:44:20 -0700 Created attachment 309885 Patch 1307834 3 cgarcia 2017-05-12 03:00:58 -0700 *** Bug 170009 has been marked as a duplicate of this bug. *** 1307835 4 cgarcia 2017-05-12 03:03:37 -0700 Many expectations were updated in r214306, but that was not enough, because it doesn't matter the test itself, it happens when several tests using AC are run in the same worker. I'll revert the expectations added in r214306 1307845 5 cgarcia 2017-05-12 04:42:59 -0700 Committed r216759: <http://trac.webkit.org/changeset/216759> 309885 2017-05-12 02:44:20 -0700 2017-05-12 03:45:46 -0700 Patch wk-sync-image-backing-crash.diff text/plain 1616 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZjBhZTBlMjg4ZS4uMzIwZWIwZWI5N2YgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wNS0xMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQVNTRVJUSU9OIEZBSUxFRDogIW1fZmx1c2hpbmdM YXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 MjAyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBwcm9ibGVtIGlzIHRoYXQgc3luY0ltYWdlQmFja2luZygpIGlzIGNhbGxpbmcgZGlkQ2hhbmdl TGF5ZXJTdGF0ZSgpLiBBbGwgc3luYyBtZXRob2RzIGFyZSBjYWxsZWQgYnkKKyAgICAgICAgZmx1 c2hDb21wb3NpdGluZ1N0YXRlRm9yVGhpc0xheWVyT25seSgpIHdoaWxlIGZsdXNoaW5nIGxheWVy cywgc28gbm9uZSBvZiB0aGVtIHNob3VsZCBjYWxsIGRpZENoYW5nZSBtZXRob2QgdGhhdAorICAg ICAgICB3aWxsIHNjaGVkdWxlIGEgbmV3IGZsdXNoIHdoaWxlIGZsdXNoaW5nLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhp Y3NMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6 OnN5bmNJbWFnZUJhY2tpbmcpOgorCiAyMDE3LTA1LTExICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgRHJvcCByZW1haW5pbmcgdXNlcyBvZiBQYXNzUmVmUHRyIGlu IFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3Jh cGhpY3NMYXllci5jcHAKaW5kZXggYTI2NjJlZjBiOTYuLmE2MWZiNjgwMjQzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29v cmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcApA QCAtNjMyLDkgKzYzMiw2IEBAIHZvaWQgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpzeW5jSW1h Z2VCYWNraW5nKCkKICAgICAgICAgbV9sYXllclN0YXRlLmltYWdlQ2hhbmdlZCA9IHRydWU7CiAg ICAgfSBlbHNlCiAgICAgICAgIHJlbGVhc2VJbWFnZUJhY2tpbmdJZk5lZWRlZCgpOwotCi0gICAg Ly8gc3luY0ltYWdlQmFja2luZygpIGNoYW5nZWQgbV9sYXllclN0YXRlLmltYWdlSUQuCi0gICAg ZGlkQ2hhbmdlTGF5ZXJTdGF0ZSgpOwogfQogCiB2b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NMYXll cjo6c3luY0xheWVyU3RhdGUoKQo=