172009 2017-05-11 19:29:01 -0700 [WinCairo] ASSERTION FAILED: !frameIsCompleteAtIndex(index) || !frameHasDecodedNativeImageCompatibleWithOptionsAtIndex(index, subsamplingLevel, decodingOptions) 2017-05-15 19:43:40 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 170836 171900 1 fujii webkit-unassigned sabouhallawa oldest_to_newest 1307680 0 fujii 2017-05-11 19:29:01 -0700 I see the following assertion failure at some web sites. > ASSERTION FAILED: !frameIsCompleteAtIndex(index) || !frameHasDecodedNativeImageCompatibleWithOptionsAtIndex(index, subsamplingLevel, decodingOptions) > C:\webkit\ga\Source\WebCore\platform\graphics\ImageFrameCache.cpp(250) : WebCore::ImageFrameCache::cacheAsyncFrameNativeImageAtIndex Callstack: > WTF.dll!WTFCrash() Line 292 C++ > WebKit.dll!WebCore::ImageFrameCache::cacheAsyncFrameNativeImageAtIndex(WTF::RefPtr<_cairo_surface> && nativeImage, unsigned __int64 index, WebCore::SubsamplingLevel subsamplingLevel, const WebCore::DecodingOptions & decodingOptions) Line 250 C++ > WebKit.dll!WebCore::ImageFrameCache::startAsyncDecodingQueue::__l2::void <lambda>(void)::__l4::<lambda>() Line 301 C++ > WebKit.dll!WTF::Function<void __cdecl(void)>::CallableWrapper<void <lambda>(void) >::call() Line 89 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 52 C++ > WTF.dll!WTF::dispatchFunctionsFromMainThread() Line 131 C++ > WTF.dll!WTF::ThreadingWindowWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 47 C++ > [External Code] > WebKit.dll!WebKitMessageLoop::run(HACCEL__ * hAccelTable) Line 97 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 189 C++ > MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 857 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 249 C++ > [External Code] I tested with WinCairo port, debug build, trunk@216673. https://play.google.com/ https://www.sony.co.jp/ 1307761 1 309864 fujii 2017-05-11 21:43:09 -0700 Created attachment 309864 WIP patch I think this patch solves the problem. How do you think, Said? 1307907 2 sabouhallawa 2017-05-12 09:46:44 -0700 I am not sure how you verified your patch. The async image decoding for large images has been disabled for almost two weeks now and the animated images does not start decoding until all the data is received. The change <http://trac.webkit.org/changeset/216471> caused another regression which is being addressed in https://bugs.webkit.org/show_bug.cgi?id=171900. I suggested in the attached patch removing this particular assertion for now. I suggested also changing function ImageFrameCache::requestFrameAsyncDecodingAtIndex() to let the caller decide whether async image decoding is needed or not. 1308943 3 fujii 2017-05-15 19:43:40 -0700 I don't see this assertion failure after fixing bug 171900. Thank you. 309864 2017-05-11 21:43:09 -0700 2017-05-11 21:43:09 -0700 WIP patch Bug172009.patch text/plain 1446 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlRnJhbWVD YWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUZyYW1lQ2Fj aGUuY3BwCmluZGV4IGI0YjI4ZDQ0MDc4Li5iODVmMDM0MDExNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VGcmFtZUNhY2hlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUZyYW1lQ2FjaGUuY3BwCkBAIC0zMTIs MTMgKzMxMiwxMyBAQCBib29sIEltYWdlRnJhbWVDYWNoZTo6cmVxdWVzdEZyYW1lQXN5bmNEZWNv ZGluZ0F0SW5kZXgoc2l6ZV90IGluZGV4LCBTdWJzYW1wbGluZwogCiAgICAgLy8gQWxsb3cgbmV3 IHJlcXVlc3RzIGZvciB0aGUgc2FtZSBmcmFtZSBpZiB0aGUgZnJhbWUgaXMgaW5jb21wbGV0ZS4K ICAgICBBU1NFUlQoaW5kZXggPCBtX2ZyYW1lcy5zaXplKCkpOwotICAgIGlmIChmcmFtZUlzQ29t cGxldGVBdEluZGV4KGluZGV4KSkgewotICAgICAgICAvLyBXZSBuZWVkIHRvIGNvYWxlc2NlIG11 bHRpcGxlIHJlcXVlc3RzIGZvciBkZWNvZGluZyB0aGUgc2FtZSBJbWFnZUZyYW1lIHdoaWxlIGl0 Ci0gICAgICAgIC8vIGlzIHN0aWxsIGJlaW5nIGRlY29kZWQuIFRoaXMgbWF5IGhhcHBlbiBpZiB0 aGUgaW1hZ2UgcmVjdGFuZ2xlIGlzIHJlcGFpbnRlZAotICAgICAgICAvLyBtdWx0aXBsZSB0aW1l cyB3aGlsZSB0aGUgSW1hZ2VGcmFtZSBoYXMgbm90IGZpbmlzaGVkIGRlY29kaW5nLgotICAgICAg ICBpZiAoZnJhbWVJc0JlaW5nRGVjb2RlZEFuZElzQ29tcGF0aWJsZVdpdGhPcHRpb25zQXRJbmRl eChpbmRleCwgc2l6ZUZvckRyYXdpbmcpKQotICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAg Ly8gV2UgbmVlZCB0byBjb2FsZXNjZSBtdWx0aXBsZSByZXF1ZXN0cyBmb3IgZGVjb2RpbmcgdGhl IHNhbWUgSW1hZ2VGcmFtZSB3aGlsZSBpdAorICAgIC8vIGlzIHN0aWxsIGJlaW5nIGRlY29kZWQu IFRoaXMgbWF5IGhhcHBlbiBpZiB0aGUgaW1hZ2UgcmVjdGFuZ2xlIGlzIHJlcGFpbnRlZAorICAg IC8vIG11bHRpcGxlIHRpbWVzIHdoaWxlIHRoZSBJbWFnZUZyYW1lIGhhcyBub3QgZmluaXNoZWQg ZGVjb2RpbmcuCisgICAgaWYgKGZyYW1lSXNCZWluZ0RlY29kZWRBbmRJc0NvbXBhdGlibGVXaXRo T3B0aW9uc0F0SW5kZXgoaW5kZXgsIHNpemVGb3JEcmF3aW5nKSkKKyAgICAgICAgcmV0dXJuIHRy dWU7CiAKKyAgICBpZiAoZnJhbWVJc0NvbXBsZXRlQXRJbmRleChpbmRleCkpIHsKICAgICAgICAg aWYgKGZyYW1lSGFzRGVjb2RlZE5hdGl2ZUltYWdlQ29tcGF0aWJsZVdpdGhPcHRpb25zQXRJbmRl eChpbmRleCwgc3Vic2FtcGxpbmdMZXZlbCwgc2l6ZUZvckRyYXdpbmcpKQogICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgIH0K