172008 2017-05-11 19:20:16 -0700 WebAssembly: implement name section's module name 2017-07-05 13:51:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159775 174098 1 jfbastien jfbastien buildbot commit-queue fpizlo jfbastien keith_miller mark.lam msaboff saam oldest_to_newest 1307678 0 jfbastien 2017-05-11 19:20:16 -0700 See https://github.com/WebAssembly/design/pull/1055 1325127 1 314485 jfbastien 2017-07-03 08:32:48 -0700 Created attachment 314485 patch 1325128 2 buildbot 2017-07-03 08:33:46 -0700 Attachment 314485 did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmFormat.h:248: static_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1325591 3 314485 keith_miller 2017-07-05 09:23:00 -0700 Comment on attachment 314485 patch r=me. 1325606 4 314485 commit-queue 2017-07-05 09:52:02 -0700 Comment on attachment 314485 patch Clearing flags on attachment: 314485 Committed r219134: <http://trac.webkit.org/changeset/219134> 1325607 5 commit-queue 2017-07-05 09:52:04 -0700 All reviewed patches have been landed. Closing bug. 1325751 6 314485 saam 2017-07-05 13:51:38 -0700 Comment on attachment 314485 patch View in context: https://bugs.webkit.org/attachment.cgi?id=314485&action=review > Source/JavaScriptCore/ChangeLog:26 > + so I can't write a simple binary test; and using the name is a > + slightly riskier change because it requires changing StackVisitor > + + StackFrame (where they print "[wasm code]") which requires > + figuring out the frame's Module. The latter bit isn't trivial > + because we only know wasm frames from their tag bits, and > + CodeBlocks are always nullptr. I think we should just have Wasm::Callee's know their names. We can also have Wasm::Callee know its module. I don't think it's bad for these to grow a bit in size. This seems inevitable for doing wasm debugging. 314485 2017-07-03 08:32:48 -0700 2017-07-05 09:52:02 -0700 patch 0001-WebAssembly-implement-name-section-s-module-name-ski.patch text/plain 5138 jfbastien RnJvbSBiYzg2MGRmN2RkYzU4YjIxZDVhYWI5MDA4MmZkNWJiNDdlOWE0NDMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBNb24sIDMgSnVsIDIwMTcgMDg6MzI6MTQgLTA3MDAKU3ViamVjdDogW1BBVENIXSBXZWJBc3Nl bWJseTogaW1wbGVtZW50IG5hbWUgc2VjdGlvbidzIG1vZHVsZSBuYW1lLCBza2lwCiB1bmtub3du IHNlY3Rpb25zCgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgIHwgMzUgKysrKysrKysrKysrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vV2FzbUZvcm1hdC5oICAgICAgICAgICAgfCAgMyArKwogLi4uL0phdmFTY3JpcHRD b3JlL3dhc20vV2FzbU5hbWVTZWN0aW9uUGFyc2VyLmNwcCAgfCAxNSArKysrKysrKystCiAzIGZp bGVzIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwppbmRleCBmMjVkY2YxLi42MmZjYjIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwzOCBAQAorMjAxNy0wNy0wMyAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBh cHBsZS5jb20+CisKKyAgICAgICAgV2ViQXNzZW1ibHk6IGltcGxlbWVudCBuYW1lIHNlY3Rpb24n cyBtb2R1bGUgbmFtZSwgc2tpcCB1bmtub3duIHNlY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIwMDgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXJzZSB0aGUgV2ViQXNzZW1ibHkgbW9kdWxl IG5hbWUgcHJvcGVybHksIGFuZCBza2lwIHVua25vd24KKyAgICAgICAgc2VjdGlvbnMuIFRoaXMg aXMgdXNlZnVsIGJlY2F1c2UgYXMgdG9vbGNoYWlucyBzdXBwb3J0IG5ldyB0eXBlcworICAgICAg ICBvZiBuYW1lcyB3ZSB3YW50IHRvIGtlZXAgZGlzcGxheWluZyB0aGUgaW5mb3JtYXRpb24gd2Ug a25vdyBhYm91dAorICAgICAgICBhbmQgc2ltcGx5IGlnbm9yZSBuZXcgaW5mb3JtYXRpb24uIFRo YXQgY2FwYWJpbGl0eSB3YXMgZGVzaWduZWQKKyAgICAgICAgaW50byBXZWJBc3NlbWJseSdzIG5h bWUgc2VjdGlvbi4KKworICAgICAgICBGYWlsdXJlIHRvIGNvbW1pdCB0aGlzIHBhdGNoIHdvdWxk IG1lYW4gdGhhdCBXZWJLaXQgd29uJ3QgZGlzcGxheQorICAgICAgICBzdGFjayB0cmFjZSBpbmZv cm1hdGlvbiwgd2hpY2ggd291bGQgbWFrZSBkZXZlbG9wZXJzIHNhZC4KKworICAgICAgICBNb2R1 bGUgbmFtZXMgd2VyZSBhZGRlZCBoZXJlOiBodHRwczovL2dpdGh1Yi5jb20vV2ViQXNzZW1ibHkv ZGVzaWduL3B1bGwvMTA1NQorCisgICAgICAgIE5vdGUgdGhhdCB0aGlzIHBhdGNoIGRvZXNuJ3Qg ZG8gYW55dGhpbmcgd2l0aCB0aGUgcGFyc2VkIG5hbWUhIFR3bworICAgICAgICByZWFzb25zIGZv ciB0aGlzOiBtb2R1bGUgbmFtZXMgYXJlbid0IHN1cHBvcnRlZCBpbiBiaW5hcnllbiB5ZXQsCisg ICAgICAgIHNvIEkgY2FuJ3Qgd3JpdGUgYSBzaW1wbGUgYmluYXJ5IHRlc3Q7IGFuZCB1c2luZyB0 aGUgbmFtZSBpcyBhCisgICAgICAgIHNsaWdodGx5IHJpc2tpZXIgY2hhbmdlIGJlY2F1c2UgaXQg cmVxdWlyZXMgY2hhbmdpbmcgU3RhY2tWaXNpdG9yCisgICAgICAgICsgU3RhY2tGcmFtZSAod2hl cmUgdGhleSBwcmludCAiW3dhc20gY29kZV0iKSB3aGljaCByZXF1aXJlcworICAgICAgICBmaWd1 cmluZyBvdXQgdGhlIGZyYW1lJ3MgTW9kdWxlLiBUaGUgbGF0dGVyIGJpdCBpc24ndCB0cml2aWFs CisgICAgICAgIGJlY2F1c2Ugd2Ugb25seSBrbm93IHdhc20gZnJhbWVzIGZyb20gdGhlaXIgdGFn IGJpdHMsIGFuZAorICAgICAgICBDb2RlQmxvY2tzIGFyZSBhbHdheXMgbnVsbHB0ci4KKworICAg ICAgICBCaW5hcnllbiBidWc6IGh0dHBzOi8vZ2l0aHViLmNvbS9XZWJBc3NlbWJseS9iaW5hcnll bi9pc3N1ZXMvMTAxMAorCisgICAgICAgIEkgZmlsZWQgIzE3NDA5OCB0byB1c2UgdGhlIG1vZHVs ZSBuYW1lLgorCisgICAgICAgICogd2FzbS9XYXNtRm9ybWF0Lmg6CisgICAgICAgIChKU0M6Oldh c206OmlzVmFsaWROYW1lVHlwZSk6CisgICAgICAgICogd2FzbS9XYXNtTmFtZVNlY3Rpb25QYXJz ZXIuY3BwOgorCiAyMDE3LTA2LTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgog CiAgICAgICAgIEZ1bmN0aW9uIGNvbnN0cnVjdG9yIG5lZWRzIHRvIGZvbGxvdyB0aGUgc3BlYyBh bmQgdmFsaWRhdGUgcGFyYW1ldGVycyBhbmQgYm9keSBpbmRlcGVuZGVudGx5CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtRm9ybWF0LmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd2FzbS9XYXNtRm9ybWF0LmgKaW5kZXggNjE4YTM3OC4uY2M2NTk3MSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUZvcm1hdC5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21Gb3JtYXQuaApAQCAtMjM2LDYgKzIzNiw3IEBAIHN0 cnVjdCBDdXN0b21TZWN0aW9uIHsKIH07CiAKIGVudW0gY2xhc3MgTmFtZVR5cGUgOiB1aW50OF90 IHsKKyAgICBNb2R1bGUgPSAwLAogICAgIEZ1bmN0aW9uID0gMSwKICAgICBMb2NhbCA9IDIsCiB9 OwpAQCAtMjQ0LDYgKzI0NSw3IEBAIHRlbXBsYXRlPHR5cGVuYW1lIEludD4KIGlubGluZSBib29s IGlzVmFsaWROYW1lVHlwZShJbnQgdmFsKQogewogICAgIHN3aXRjaCAodmFsKSB7CisgICAgY2Fz ZSBzdGF0aWNfY2FzdDxJbnQ+KE5hbWVUeXBlOjpNb2R1bGUpOgogICAgIGNhc2Ugc3RhdGljX2Nh c3Q8SW50PihOYW1lVHlwZTo6RnVuY3Rpb24pOgogICAgIGNhc2Ugc3RhdGljX2Nhc3Q8SW50PihO YW1lVHlwZTo6TG9jYWwpOgogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAgLTI1Miw2ICsyNTQsNyBA QCBpbmxpbmUgYm9vbCBpc1ZhbGlkTmFtZVR5cGUoSW50IHZhbCkKIH0KICAgICAKIHN0cnVjdCBO YW1lU2VjdGlvbiB7CisgICAgTmFtZSBtb2R1bGVOYW1lOwogICAgIFZlY3RvcjxOYW1lPiBmdW5j dGlvbk5hbWVzOwogICAgIGNvbnN0IE5hbWUqIGdldChzaXplX3QgZnVuY3Rpb25JbmRleFNwYWNl KQogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21OYW1l U2VjdGlvblBhcnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtTmFtZVNl Y3Rpb25QYXJzZXIuY3BwCmluZGV4IDhjMDRmNTguLmE1ODI4OWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21OYW1lU2VjdGlvblBhcnNlci5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbU5hbWVTZWN0aW9uUGFyc2VyLmNwcApAQCAtNDIs MTIgKzQyLDI1IEBAIGF1dG8gTmFtZVNlY3Rpb25QYXJzZXI6OnBhcnNlKCkgLT4gUmVzdWx0CiAg ICAgICAgIHVpbnQ4X3QgbmFtZVR5cGU7CiAgICAgICAgIHVpbnQzMl90IHBheWxvYWRMZW5ndGg7 CiAgICAgICAgIFdBU01fUEFSU0VSX0ZBSUxfSUYoIXBhcnNlVUludDcobmFtZVR5cGUpLCAiY2Fu J3QgZ2V0IG5hbWUgdHlwZSBmb3IgcGF5bG9hZCAiLCBwYXlsb2FkTnVtYmVyKTsKLSAgICAgICAg V0FTTV9QQVJTRVJfRkFJTF9JRighaXNWYWxpZE5hbWVUeXBlKG5hbWVUeXBlKSwgIm5hbWUgdHlw ZSAiLCBuYW1lVHlwZSwgIiBpcyBpbnZhbGlkIGZvciBwYXlsb2FkICIsIHBheWxvYWROdW1iZXIp OwogICAgICAgICBXQVNNX1BBUlNFUl9GQUlMX0lGKCFwYXJzZVZhclVJbnQzMihwYXlsb2FkTGVu Z3RoKSwgImNhbid0IGdldCBwYXlsb2FkIGxlbmd0aCBmb3IgcGF5bG9hZCAiLCBwYXlsb2FkTnVt YmVyKTsKICAgICAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRihwYXlsb2FkTGVuZ3RoID4gbGVuZ3Ro KCkgLSBtX29mZnNldCwgInBheWxvYWQgbGVuZ3RoIGlzIHRvbyBiaWcgZm9yIHBheWxvYWQgIiwg cGF5bG9hZE51bWJlcik7CiAgICAgICAgIGNvbnN0IGF1dG8gcGF5bG9hZFN0YXJ0ID0gbV9vZmZz ZXQ7CisgICAgICAgIAorICAgICAgICBpZiAoIWlzVmFsaWROYW1lVHlwZShuYW1lVHlwZSkpIHsK KyAgICAgICAgICAgIC8vIFVua25vd24gbmFtZSBzZWN0aW9uIGVudHJpZXMgYXJlIHNpbXBseSBp Z25vcmVkLiBUaGlzIGFsbG93cyB1cyB0byBzdXBwb3J0IG5ld2VyIHRvb2xjaGFpbnMgd2l0aG91 dCBicmVha2luZyBvbGRlciBmZWF0dXJlcy4KKyAgICAgICAgICAgIG1fb2Zmc2V0ICs9IHBheWxv YWRMZW5ndGg7CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQogCiAgICAgICAgIHN3 aXRjaCAoc3RhdGljX2Nhc3Q8TmFtZVR5cGU+KG5hbWVUeXBlKSkgeworICAgICAgICBjYXNlIE5h bWVUeXBlOjpNb2R1bGU6IHsKKyAgICAgICAgICAgIHVpbnQzMl90IG5hbWVMZW47CisgICAgICAg ICAgICBOYW1lIG5hbWVTdHJpbmc7CisgICAgICAgICAgICBXQVNNX1BBUlNFUl9GQUlMX0lGKCFw YXJzZVZhclVJbnQzMihuYW1lTGVuKSwgImNhbid0IGdldCBtb2R1bGUncyBuYW1lIGxlbmd0aCBm b3IgcGF5bG9hZCAiLCBwYXlsb2FkTnVtYmVyKTsKKyAgICAgICAgICAgIFdBU01fUEFSU0VSX0ZB SUxfSUYoIWNvbnN1bWVVVEY4U3RyaW5nKG5hbWVTdHJpbmcsIG5hbWVMZW4pLCAiY2FuJ3QgZ2V0 IG1vZHVsZSdzIG5hbWUgb2YgbGVuZ3RoICIsIG5hbWVMZW4sICIgZm9yIHBheWxvYWQgIiwgcGF5 bG9hZE51bWJlcik7CisgICAgICAgICAgICBuYW1lU2VjdGlvbi5tb2R1bGVOYW1lID0gV1RGTW92 ZShuYW1lU3RyaW5nKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CiAgICAgICAgIGNh c2UgTmFtZVR5cGU6OkZ1bmN0aW9uOiB7CiAgICAgICAgICAgICB1aW50MzJfdCBjb3VudDsKICAg ICAgICAgICAgIFdBU01fUEFSU0VSX0ZBSUxfSUYoIXBhcnNlVmFyVUludDMyKGNvdW50KSwgImNh bid0IGdldCBmdW5jdGlvbiBjb3VudCBmb3IgcGF5bG9hZCAiLCBwYXlsb2FkTnVtYmVyKTsKLS0g CjIuOS4zCgo=