171996 2017-05-11 15:31:12 -0700 Annotate Ref::ptr() with RETURNS_NONNULL 2017-05-11 16:33:34 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin buildbot cmarcelo commit-queue dbates kling oldest_to_newest 1307511 0 cdumez 2017-05-11 15:31:12 -0700 Annotate Ref::ptr() with RETURNS_NONNULL as it can never return null. 1307513 1 309798 cdumez 2017-05-11 15:31:50 -0700 Created attachment 309798 Patch 1307520 2 309798 kling 2017-05-11 15:37:30 -0700 Comment on attachment 309798 Patch k 1307522 3 cdumez 2017-05-11 15:39:23 -0700 (In reply to Andreas Kling from comment #2) > Comment on attachment 309798 [details] > Patch > > k FYI, this did not impact binary size. 1307570 4 commit-queue 2017-05-11 16:33:02 -0700 The commit-queue encountered the following flaky tests while processing attachment 309798: workers/bomb.html bug 171985 (author: fpizlo@apple.com) http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org) The commit-queue is continuing to process your patch. 1307571 5 309798 commit-queue 2017-05-11 16:33:33 -0700 Comment on attachment 309798 Patch Clearing flags on attachment: 309798 Committed r216700: <http://trac.webkit.org/changeset/216700> 1307572 6 commit-queue 2017-05-11 16:33:34 -0700 All reviewed patches have been landed. Closing bug. 309798 2017-05-11 15:31:50 -0700 2017-05-11 16:33:33 -0700 Patch bug-171996-20170511153206.patch text/plain 1281 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2Njg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGVjZGRiMzNmYmVkNTIxMTFiYzA3MTk1 ZDZjMDhmZTQwNmIyYzFhMzUuLmRmNjU1ZDAyMjEzOWRjYWU5MzEyYWU1OTFhNWM0MWIyMjVmOTMz ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDUtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBBbm5vdGF0ZSBSZWY6OnB0cigpIHdpdGggUkVUVVJOU19O T05OVUxMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzE5OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB bm5vdGF0ZSBSZWY6OnB0cigpIHdpdGggUkVUVVJOU19OT05OVUxMIGFzIGl0IGNhbiBuZXZlciBy ZXR1cm4gbnVsbC4KKworICAgICAgICAqIHd0Zi9SZWYuaDoKKyAgICAgICAgKFdURjo6UmVmOjpw dHIpOiBEZWxldGVkLgorCiAyMDE3LTA1LTA5ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmVtb3ZlIHN1cHBvcnQgZm9yIGxlZ2FjeSBOb3RpZmljYXRpb25zCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9SZWYuaCBiL1NvdXJjZS9XVEYvd3RmL1JlZi5oCmluZGV4 IDgzMDk2NGZlYmVhNjYxYWQ3N2Q3NjZjNDhkNjQyMWQ5OTJjNjUwYmQuLmRmNTY4ZjE4ZDFkN2Qz NGNkMjNmMTkyM2IzNTUxYTZhM2M1NmNjMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Jl Zi5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1JlZi5oCkBAIC0xMzQsNyArMTM0LDcgQEAgcHVibGlj OgogICAgIH0KIAogICAgIFQqIG9wZXJhdG9yLT4oKSBjb25zdCB7IEFTU0VSVChtX3B0cik7IHJl dHVybiBtX3B0cjsgfQotICAgIFQqIHB0cigpIGNvbnN0IHsgQVNTRVJUKG1fcHRyKTsgcmV0dXJu IG1fcHRyOyB9CisgICAgVCogcHRyKCkgY29uc3QgUkVUVVJOU19OT05OVUxMIHsgQVNTRVJUKG1f cHRyKTsgcmV0dXJuIG1fcHRyOyB9CiAgICAgVCYgZ2V0KCkgY29uc3QgeyBBU1NFUlQobV9wdHIp OyByZXR1cm4gKm1fcHRyOyB9CiAgICAgb3BlcmF0b3IgVCYoKSBjb25zdCB7IEFTU0VSVChtX3B0 cik7IHJldHVybiAqbV9wdHI7IH0KICAgICBib29sIG9wZXJhdG9yISgpIGNvbnN0IHsgQVNTRVJU KG1fcHRyKTsgcmV0dXJuICEqbV9wdHI7IH0K