171989 2017-05-11 14:27:15 -0700 REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change 2017-05-11 16:34:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bburg commit-queue jer.noble joepeck lforschler mark.lam simon.fraser ysuzuki oldest_to_newest 1307470 0 joepeck 2017-05-11 14:27:15 -0700 Attempting to print out a WTF::String results in lldb produces: (lldb) p selectorText Traceback (most recent call last): File "/Users/pecoraro/Code/safari/OpenSource/Tools/lldb/lldb_webkit.py", line 53, in WTFString_SummaryProvider return "{ length = %d, contents = '%s' }" % (provider.get_length(), provider.to_string()) File "/Users/pecoraro/Code/safari/OpenSource/Tools/lldb/lldb_webkit.py", line 275, in to_string return impl.to_string() File "/Users/pecoraro/Code/safari/OpenSource/Tools/lldb/lldb_webkit.py", line 245, in to_string return lstring_to_string(self.get_data8(), error, self.get_length()) File "/Users/pecoraro/Code/safari/OpenSource/Tools/lldb/lldb_webkit.py", line 219, in lstring_to_string string = contents.decode('utf8') AttributeError: 'NoneType' object has no attribute 'decode' Traceback (most recent call last): File "/Users/pecoraro/Code/safari/OpenSource/Tools/lldb/lldb_webkit.py", line 60, in WTFStringImpl_SummaryProvider return "{ length = %d, is8bit = %d, contents = '%s' }" % (provider.get_length(), provider.is_8bit(), provider.to_string()) File "/Users/pecoraro/Code/safari/OpenSource/Tools/lldb/lldb_webkit.py", line 245, in to_string return lstring_to_string(self.get_data8(), error, self.get_length()) File "/Users/pecoraro/Code/safari/OpenSource/Tools/lldb/lldb_webkit.py", line 219, in lstring_to_string string = contents.decode('utf8') AttributeError: 'NoneType' object has no attribute 'decode' (WTF::String) $1 = { m_impl = { m_ptr = 0x0000000123034980 } } Expected: (lldb) p selectorText (WTF::String) $0 = { length = 38, contents = 'head, link, meta, script, style, title' } { m_impl = { m_ptr = 0x0000000123034980 { length = 38, is8bit = 1, contents = 'head, link, meta, script, style, title' } } } 1307473 1 309786 joepeck 2017-05-11 14:29:51 -0700 Created attachment 309786 [PATCH] Proposed Fix 1307474 2 309787 joepeck 2017-05-11 14:30:54 -0700 Created attachment 309787 [PATCH] Proposed Fix 1307479 3 309787 bburg 2017-05-11 14:39:21 -0700 Comment on attachment 309787 [PATCH] Proposed Fix r=me 1307481 4 mark.lam 2017-05-11 14:40:23 -0700 r=me too. 1307492 5 simon.fraser 2017-05-11 14:55:39 -0700 Very nice. 1307517 6 commit-queue 2017-05-11 15:32:33 -0700 The commit-queue encountered the following flaky tests while processing attachment 309787: workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. 1307518 7 309787 commit-queue 2017-05-11 15:33:01 -0700 Comment on attachment 309787 [PATCH] Proposed Fix Rejecting attachment 309787 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 309787, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ingContext should implement WebGLRenderingContextBase The copy of the patch that failed is found in: /Volumes/Data/EWS/WebKit/.git/rebase-apply/patch When you have resolved this problem, run "git rebase --continue". If you prefer to skip this patch, run "git rebase --skip" instead. To check out the original branch and stop rebasing, run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2719. Full output: http://webkit-queues.webkit.org/results/3721293 1307528 8 bburg 2017-05-11 15:43:03 -0700 (In reply to WebKit Commit Bot from comment #7) > Comment on attachment 309787 [details] > [PATCH] Proposed Fix > > Rejecting attachment 309787 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', > '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', > 'land-attachment', '--force-clean', '--non-interactive', > '--parent-command=commit-queue', 309787, '--port=mac']" exit_code: 2 cwd: > /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > ingContext should implement WebGLRenderingContextBase > The copy of the patch that failed is found in: > /Volumes/Data/EWS/WebKit/.git/rebase-apply/patch > > When you have resolved this problem, run "git rebase --continue". > If you prefer to skip this patch, run "git rebase --skip" instead. > To check out the original branch and stop rebasing, run "git rebase --abort". > > rebase refs/remotes/origin/master: command returned error: 1 > > Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2719. > > Full output: http://webkit-queues.webkit.org/results/3721293 You had one job, commit-queue bot.. you are fired. 1307539 9 309787 joepeck 2017-05-11 16:04:43 -0700 Comment on attachment 309787 [PATCH] Proposed Fix Lets try setting the flag again. I really don't want to do an entire clean build to land this. 1307573 10 309787 commit-queue 2017-05-11 16:34:22 -0700 Comment on attachment 309787 [PATCH] Proposed Fix Clearing flags on attachment: 309787 Committed r216701: <http://trac.webkit.org/changeset/216701> 1307574 11 commit-queue 2017-05-11 16:34:24 -0700 All reviewed patches have been landed. Closing bug. 309786 2017-05-11 14:29:51 -0700 2017-05-11 14:30:54 -0700 [PATCH] Proposed Fix fix-lldb-1.patch text/plain 1667 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZjEx NjY5YzgzYy4uMWE0YjVkM2JjY2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNy0wNS0xMSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIxNjIxNyk6 IGxsZGJfd2Via2l0LnB5IG5vIGxvbmdlciBwcmludHMgb3V0IGEgV1RGU3RyaW5nLCBTdHJpbmdJ bXBsIG5lZWRzIHRvIGhhbmRsZSBTdHJpbmdJbXBsU2hhcGUgY2hhbmdlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE5ODkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxsZGIvbGxkYl93ZWJraXQucHk6 CisgICAgICAgIChXVEZTdHJpbmdJbXBsUHJvdmlkZXIuZ2V0X2RhdGE4KToKKyAgICAgICAgKFdU RlN0cmluZ0ltcGxQcm92aWRlci5nZXRfZGF0YTE2KToKKyAgICAgICAgbV9kYXRhOCBhbmQgbV9k YXRhMTYgYXJlIG5vdyBwYXJ0IG9mIHRoZSBzdXBlcmNsYXNzIFN0cmluZ0ltcGxTaGFwZQorICAg ICAgICBpbnN0ZWFkIG9mIGRpcmVjdGx5IGluIFN0cmluZ0ltcGwsICBzbyBmaXJzdCBnZXQgdGhp cyBzaGFwZSBieSBnZXR0aW5nCisgICAgICAgIGluZGV4IDAsIGFuZCB0aGUgZGF0YSBwcm9wZXJ0 aWVzIGFyZSB0aGUgc2FtZSBvZmZzZXQgd2l0aGluIHRoYXQuCisKIDIwMTctMDUtMDkgIEpvbmF0 aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIGJ1aWxkIEltYWdlRGlm ZiB3aXRoIGhvc3QgU0RLIGZyb20gTWFrZQpkaWZmIC0tZ2l0IGEvVG9vbHMvbGxkYi9sbGRiX3dl YmtpdC5weSBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkKaW5kZXggMzAyOGVjOTFmMmYuLmYz NjBmYTBmMmVhIDEwMDY0NAotLS0gYS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5CisrKyBiL1Rv b2xzL2xsZGIvbGxkYl93ZWJraXQucHkKQEAgLTIzMCwxMCArMjMwLDEwIEBAIGNsYXNzIFdURlN0 cmluZ0ltcGxQcm92aWRlcjoKICAgICAgICAgcmV0dXJuIHNlbGYudmFsb2JqLkdldENoaWxkTWVt YmVyV2l0aE5hbWUoJ21fbGVuZ3RoJykuR2V0VmFsdWVBc1Vuc2lnbmVkKDApCiAKICAgICBkZWYg Z2V0X2RhdGE4KHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi52YWxvYmouR2V0Q2hpbGRBdElu ZGV4KDIpLkdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ21fZGF0YTgnKQorICAgICAgICByZXR1cm4g c2VsZi52YWxvYmouR2V0Q2hpbGRBdEluZGV4KDApLkdldENoaWxkQXRJbmRleCgyKS5HZXRDaGls ZE1lbWJlcldpdGhOYW1lKCdtX2RhdGE4JykKIAogICAgIGRlZiBnZXRfZGF0YTE2KHNlbGYpOgot ICAgICAgICByZXR1cm4gc2VsZi52YWxvYmouR2V0Q2hpbGRBdEluZGV4KDIpLkdldENoaWxkTWVt YmVyV2l0aE5hbWUoJ21fZGF0YTE2JykKKyAgICAgICAgcmV0dXJuIHNlbGYudmFsb2JqLkdldENo aWxkQXRJbmRleCgwKS5HZXRDaGlsZEF0SW5kZXgoMikuR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgn bV9kYXRhMTYnKQogCiAgICAgZGVmIHRvX3N0cmluZyhzZWxmKToKICAgICAgICAgZXJyb3IgPSBs bGRiLlNCRXJyb3IoKQo= 309787 2017-05-11 14:30:54 -0700 2017-05-11 16:34:22 -0700 [PATCH] Proposed Fix fix-lldb-2.patch text/plain 1665 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZjEx NjY5YzgzYy4uZTZkYTA1ZjBmOGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNy0wNS0xMSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIxNjIxNyk6 IGxsZGJfd2Via2l0LnB5IG5vIGxvbmdlciBwcmludHMgb3V0IGEgV1RGU3RyaW5nLCBTdHJpbmdJ bXBsIG5lZWRzIHRvIGhhbmRsZSBTdHJpbmdJbXBsU2hhcGUgY2hhbmdlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE5ODkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxsZGIvbGxkYl93ZWJraXQucHk6 CisgICAgICAgIChXVEZTdHJpbmdJbXBsUHJvdmlkZXIuZ2V0X2RhdGE4KToKKyAgICAgICAgKFdU RlN0cmluZ0ltcGxQcm92aWRlci5nZXRfZGF0YTE2KToKKyAgICAgICAgbV9kYXRhOCBhbmQgbV9k YXRhMTYgYXJlIG5vdyBwYXJ0IG9mIHRoZSBzdXBlcmNsYXNzIFN0cmluZ0ltcGxTaGFwZQorICAg ICAgICBpbnN0ZWFkIG9mIGRpcmVjdGx5IGluIFN0cmluZ0ltcGwuIFNvIGZpcnN0IGdldCB0aGUg c2hhcGUgYnkgZ2V0dGluZworICAgICAgICBpbmRleCAwLCBhbmQgdGhlIGRhdGEgcHJvcGVydGll cyBhcmUgdGhlIHNhbWUgb2Zmc2V0IHdpdGhpbiB0aGF0LgorCiAyMDE3LTA1LTA5ICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBidWlsZCBJbWFnZURpZmYg d2l0aCBob3N0IFNESyBmcm9tIE1ha2UKZGlmZiAtLWdpdCBhL1Rvb2xzL2xsZGIvbGxkYl93ZWJr aXQucHkgYi9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5CmluZGV4IDMwMjhlYzkxZjJmLi5mMzYw ZmEwZjJlYSAxMDA2NDQKLS0tIGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weQorKysgYi9Ub29s cy9sbGRiL2xsZGJfd2Via2l0LnB5CkBAIC0yMzAsMTAgKzIzMCwxMCBAQCBjbGFzcyBXVEZTdHJp bmdJbXBsUHJvdmlkZXI6CiAgICAgICAgIHJldHVybiBzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJl cldpdGhOYW1lKCdtX2xlbmd0aCcpLkdldFZhbHVlQXNVbnNpZ25lZCgwKQogCiAgICAgZGVmIGdl dF9kYXRhOChzZWxmKToKLSAgICAgICAgcmV0dXJuIHNlbGYudmFsb2JqLkdldENoaWxkQXRJbmRl eCgyKS5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX2RhdGE4JykKKyAgICAgICAgcmV0dXJuIHNl bGYudmFsb2JqLkdldENoaWxkQXRJbmRleCgwKS5HZXRDaGlsZEF0SW5kZXgoMikuR2V0Q2hpbGRN ZW1iZXJXaXRoTmFtZSgnbV9kYXRhOCcpCiAKICAgICBkZWYgZ2V0X2RhdGExNihzZWxmKToKLSAg ICAgICAgcmV0dXJuIHNlbGYudmFsb2JqLkdldENoaWxkQXRJbmRleCgyKS5HZXRDaGlsZE1lbWJl cldpdGhOYW1lKCdtX2RhdGExNicpCisgICAgICAgIHJldHVybiBzZWxmLnZhbG9iai5HZXRDaGls ZEF0SW5kZXgoMCkuR2V0Q2hpbGRBdEluZGV4KDIpLkdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ21f ZGF0YTE2JykKIAogICAgIGRlZiB0b19zdHJpbmcoc2VsZik6CiAgICAgICAgIGVycm9yID0gbGxk Yi5TQkVycm9yKCkK