171982 2017-05-11 11:48:30 -0700 The iBooks application is not able to get current position. 2017-05-12 03:11:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan benjamin bfulgham buildbot webkit-bug-importer oldest_to_newest 1307367 0 pvollan 2017-05-11 11:48:30 -0700 Geolocation requests from iBooks are currently being blocked. 1307375 1 309742 pvollan 2017-05-11 11:57:07 -0700 Created attachment 309742 Patch 1307390 2 309742 bfulgham 2017-05-11 12:26:16 -0700 Comment on attachment 309742 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309742&action=review lgtm. r=me. > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=171982 Add radar here, please. > Source/WebCore/ChangeLog:8 > + Geolocation requests from iBooks are currently blocked. Make an excemption from the policy for iBooks. EXEMPTION 1307832 3 pvollan 2017-05-12 02:59:54 -0700 <rdar://problem/29318409> 1307836 4 pvollan 2017-05-12 03:10:23 -0700 Committed <https://trac.webkit.org/changeset/216757/webkit>. 1307837 5 pvollan 2017-05-12 03:11:11 -0700 (In reply to Brent Fulgham from comment #2) > Comment on attachment 309742 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309742&action=review > > lgtm. r=me. > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=171982 > > Add radar here, please. > > > Source/WebCore/ChangeLog:8 > > + Geolocation requests from iBooks are currently blocked. Make an excemption from the policy for iBooks. > > EXEMPTION Thanks for reviewing! 309742 2017-05-11 11:57:07 -0700 2017-05-11 12:26:16 -0700 Patch bug-171982-20170511115706.patch text/plain 2342 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjY4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA1LTExICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBUaGUgaUJvb2tzIGFwcGxp Y2F0aW9uIGlzIG5vdCBhYmxlIHRvIGdldCBjdXJyZW50IHBvc2l0aW9uLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxOTgyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2VvbG9jYXRpb24gcmVxdWVzdHMg ZnJvbSBpQm9va3MgYXJlIGN1cnJlbnRseSBibG9ja2VkLiBNYWtlIGFuIGV4Y2VtcHRpb24gZnJv bSB0aGUgcG9saWN5IGZvciBpQm9va3MuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHdl IGN1cnJlbnRseSBjYW4ndCBtb2NrIHRoZSBpQm9va3MgYXBwbGljYXRpb24gYnVuZGxlIElELgor CisgICAgICAgICogTW9kdWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjppc1JlcXVlc3RGcm9tSUJvb2tzKToKKyAgICAgICAgKFdlYkNvcmU6Okdlb2xv Y2F0aW9uOjpzaG91bGRCbG9ja0dlb2xvY2F0aW9uUmVxdWVzdHMpOgorCiAyMDE3LTA1LTExICBG cmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbmlmeSBoYXNUb3Vj aFNjcm9sbGFibGVPdmVyZmxvdy9uZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcgY29uY2VwdHMKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vR2VvbG9jYXRpb24uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vR2VvbG9jYXRp b24uY3BwCShyZXZpc2lvbiAyMTY2NTIpCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dlb2xv Y2F0aW9uL0dlb2xvY2F0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAsNiArNDAsNyBAQAog I2luY2x1ZGUgIkdlb3Bvc2l0aW9uLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBv c2l0aW9uRXJyb3IuaCIKKyNpbmNsdWRlICJSdW50aW1lQXBwbGljYXRpb25DaGVja3MuaCIKICNp bmNsdWRlICJTZWN1cml0eU9yaWdpbi5oIgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgog I2luY2x1ZGUgPHd0Zi9SZWYuaD4KQEAgLTM0NiwxMyArMzQ3LDI0IEBAIHN0YXRpYyB2b2lkIGxv Z0Vycm9yKGNvbnN0IFN0cmluZyYgdGFyZ2UKICAgICBkb2N1bWVudC0+YWRkQ29uc29sZU1lc3Nh Z2UoTWVzc2FnZVNvdXJjZTo6U2VjdXJpdHksIE1lc3NhZ2VMZXZlbDo6RXJyb3IsIG1lc3NhZ2Uu dG9TdHJpbmcoKSk7CiB9CiAKKy8vIEZJWE1FOiByZW1vdmUgdGhpcyBmdW5jdGlvbiB3aGVuIGlC b29rcyBoYXZlIHJlZ2lzdGVyZWQgdGhlaXIgdXJsIHNjaGVtZSBhcyBsb2NhbCAocmRhcjovL3By b2JsZW0vMzIxMzc4MjEpLgorc3RhdGljIGJvb2wgaXNSZXF1ZXN0RnJvbUlCb29rcygpCit7Cisj aWYgUExBVEZPUk0oTUFDKQorICAgIHJldHVybiBNYWNBcHBsaWNhdGlvbjo6aXNJQm9va3MoKTsK KyNlbGlmIFBMQVRGT1JNKElPUykKKyAgICByZXR1cm4gSU9TQXBwbGljYXRpb246OmlzSUJvb2tz KCk7CisjZW5kaWYKKyAgICByZXR1cm4gZmFsc2U7Cit9CisgICAgCiBib29sIEdlb2xvY2F0aW9u OjpzaG91bGRCbG9ja0dlb2xvY2F0aW9uUmVxdWVzdHMoKQogewogICAgIGJvb2wgaXNTZWN1cmUg PSBTZWN1cml0eU9yaWdpbjo6aXNTZWN1cmUoZG9jdW1lbnQoKS0+dXJsKCkpOwogICAgIGJvb2wg aGFzTWl4ZWRDb250ZW50ID0gZG9jdW1lbnQoKS0+Zm91bmRNaXhlZENvbnRlbnQoKTsKICAgICBi b29sIGlzTG9jYWxGaWxlID0gZG9jdW1lbnQoKS0+dXJsKCkuaXNMb2NhbEZpbGUoKTsKICAgICBp ZiAoc2VjdXJpdHlPcmlnaW4oKS0+Y2FuUmVxdWVzdEdlb2xvY2F0aW9uKCkpIHsKLSAgICAgICAg aWYgKGlzTG9jYWxGaWxlIHx8IChpc1NlY3VyZSAmJiAhaGFzTWl4ZWRDb250ZW50KSkKKyAgICAg ICAgaWYgKGlzTG9jYWxGaWxlIHx8IChpc1NlY3VyZSAmJiAhaGFzTWl4ZWRDb250ZW50KSB8fCBp c1JlcXVlc3RGcm9tSUJvb2tzKCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQog ICAgIAo=