171979 2017-05-11 10:49:14 -0700 JSWeakCreate/Retain/Release should take a JSContextGroupRef and not a JSContextRef 2017-05-11 11:02:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo buildbot keith_miller mark.lam msaboff saam oldest_to_newest 1307318 0 fpizlo 2017-05-11 10:49:14 -0700 Patch forthcoming. 1307321 1 309724 fpizlo 2017-05-11 10:50:19 -0700 Created attachment 309724 the patch 1307328 2 309724 mark.lam 2017-05-11 10:55:12 -0700 Comment on attachment 309724 the patch r=me 1307334 3 fpizlo 2017-05-11 11:02:00 -0700 Landed in https://trac.webkit.org/changeset/216684/webkit 309724 2017-05-11 10:50:19 -0700 2017-05-11 10:55:12 -0700 the patch blah.patch text/plain 3929 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE2NjgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE3LTA1LTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SlNXZWFrQ3JlYXRlL1JldGFpbi9SZWxlYXNlIHNob3VsZCB0YWtlIGEgSlNDb250ZXh0R3JvdXBS ZWYgYW5kIG5vdCBhIEpTQ29udGV4dFJlZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTcxOTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIAorICAgICAgICBGdW5jdGlvbnMgdGhhdCBkb24ndCBleGVjdXRlIGFy Yml0cmFyeSBKUyBidXQganVzdCBuZWVkIGFjY2VzcyB0byB0aGUgVk0gc2hvdWxkIHRha2UgYQor ICAgICAgICBKU0NvbnRleHRHcm91cFJlZiwgbm90IGEgSlNDb250ZXh0UmVmLgorCisgICAgICAg ICogQVBJL0pTV2Vha1ByaXZhdGUuY3BwOgorICAgICAgICAoSlNXZWFrQ3JlYXRlKToKKyAgICAg ICAgKEpTV2Vha1JldGFpbik6CisgICAgICAgIChKU1dlYWtSZWxlYXNlKToKKyAgICAgICAgKiBB UEkvSlNXZWFrUHJpdmF0ZS5oOgorICAgICAgICAqIEFQSS90ZXN0cy90ZXN0YXBpLmM6CisgICAg ICAgICh0ZXN0TWFya2luZ0NvbnN0cmFpbnRzKToKKwogMjAxNy0wNS0xMSAgTWFyayBMYW0gIDxt YXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgV29ya2VyVGhyZWFkOjpzdG9wKCkgc2hvdWxk IGNhbGwgc2NoZWR1bGVFeGVjdXRpb25UZXJtaW5hdGlvbigpIGxhc3QuCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQVBJL0pTV2Vha1ByaXZhdGUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXZWFrUHJpdmF0ZS5jcHAJKHJldmlzaW9uIDIxNjY4MSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXZWFrUHJpdmF0ZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQyLDI0ICs0MiwyNCBAQCBzdHJ1Y3QgT3BhcXVlSlNXZWFrIDogVGhyZWFkU2Fm ZVJlZkNvdW50CiAgICAgV2VhazxKU09iamVjdD4gd2VhazsKIH07CiAKLUpTV2Vha1JlZiBKU1dl YWtDcmVhdGUoSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIG9iamVjdFJlZikKK0pT V2Vha1JlZiBKU1dlYWtDcmVhdGUoSlNDb250ZXh0R3JvdXBSZWYgY29udGV4dEdyb3VwLCBKU09i amVjdFJlZiBvYmplY3RSZWYpCiB7Ci0gICAgRXhlY1N0YXRlKiBleGVjID0gdG9KUyhjb250ZXh0 KTsKLSAgICBKU0xvY2tIb2xkZXIgbG9ja2VyKGV4ZWMpOworICAgIFZNKiB2bSA9IHRvSlMoY29u dGV4dEdyb3VwKTsKKyAgICBKU0xvY2tIb2xkZXIgbG9ja2VyKHZtKTsKICAgICByZXR1cm4gbmV3 IE9wYXF1ZUpTV2Vhayh0b0pTKG9iamVjdFJlZikpOwogfQogCi12b2lkIEpTV2Vha1JldGFpbihK U0NvbnRleHRSZWYgY29udGV4dCwgSlNXZWFrUmVmIHdlYWtSZWYpCit2b2lkIEpTV2Vha1JldGFp bihKU0NvbnRleHRHcm91cFJlZiBjb250ZXh0R3JvdXAsIEpTV2Vha1JlZiB3ZWFrUmVmKQogewot ICAgIEV4ZWNTdGF0ZSogZXhlYyA9IHRvSlMoY29udGV4dCk7Ci0gICAgSlNMb2NrSG9sZGVyIGxv Y2tlcihleGVjKTsKKyAgICBWTSogdm0gPSB0b0pTKGNvbnRleHRHcm91cCk7CisgICAgSlNMb2Nr SG9sZGVyIGxvY2tlcih2bSk7CiAgICAgd2Vha1JlZi0+cmVmKCk7CiB9CiAKLXZvaWQgSlNXZWFr UmVsZWFzZShKU0NvbnRleHRSZWYgY29udGV4dCwgSlNXZWFrUmVmIHdlYWtSZWYpCit2b2lkIEpT V2Vha1JlbGVhc2UoSlNDb250ZXh0R3JvdXBSZWYgY29udGV4dEdyb3VwLCBKU1dlYWtSZWYgd2Vh a1JlZikKIHsKLSAgICBFeGVjU3RhdGUqIGV4ZWMgPSB0b0pTKGNvbnRleHQpOwotICAgIEpTTG9j a0hvbGRlciBsb2NrZXIoZXhlYyk7CisgICAgVk0qIHZtID0gdG9KUyhjb250ZXh0R3JvdXApOwor ICAgIEpTTG9ja0hvbGRlciBsb2NrZXIodm0pOwogICAgIHdlYWtSZWYtPmRlcmVmKCk7CiB9CiAK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXZWFrUHJpdmF0ZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXZWFrUHJpdmF0ZS5oCShyZXZpc2lv biAyMTY2ODEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTV2Vha1ByaXZhdGUuaAko d29ya2luZyBjb3B5KQpAQCAtMzQsMTAgKzM0LDEwIEBAIGV4dGVybiAiQyIgewogCiB0eXBlZGVm IGNvbnN0IHN0cnVjdCBPcGFxdWVKU1dlYWsqIEpTV2Vha1JlZjsKIAotSlNfRVhQT1JUIEpTV2Vh a1JlZiBKU1dlYWtDcmVhdGUoSlNDb250ZXh0UmVmLCBKU09iamVjdFJlZik7CitKU19FWFBPUlQg SlNXZWFrUmVmIEpTV2Vha0NyZWF0ZShKU0NvbnRleHRHcm91cFJlZiwgSlNPYmplY3RSZWYpOwog Ci1KU19FWFBPUlQgdm9pZCBKU1dlYWtSZXRhaW4oSlNDb250ZXh0UmVmLCBKU1dlYWtSZWYpOwot SlNfRVhQT1JUIHZvaWQgSlNXZWFrUmVsZWFzZShKU0NvbnRleHRSZWYsIEpTV2Vha1JlZik7CitK U19FWFBPUlQgdm9pZCBKU1dlYWtSZXRhaW4oSlNDb250ZXh0R3JvdXBSZWYsIEpTV2Vha1JlZik7 CitKU19FWFBPUlQgdm9pZCBKU1dlYWtSZWxlYXNlKEpTQ29udGV4dEdyb3VwUmVmLCBKU1dlYWtS ZWYpOwogCiBKU19FWFBPUlQgSlNPYmplY3RSZWYgSlNXZWFrR2V0T2JqZWN0KEpTV2Vha1JlZik7 CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jCShyZXZp c2lvbiAyMTY2ODEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGku Ywkod29ya2luZyBjb3B5KQpAQCAtMTE2MSw3ICsxMTYxLDcgQEAgc3RhdGljIHZvaWQgdGVzdE1h cmtpbmdDb25zdHJhaW50cyh2b2lkKQogICAgIEpTQ29udGV4dEdyb3VwQWRkTWFya2luZ0NvbnN0 cmFpbnQoZ3JvdXAsIG1hcmtpbmdDb25zdHJhaW50LCB3ZWFrUmVmcyk7CiAgICAgCiAgICAgZm9y IChpID0gbnVtV2Vha1JlZnM7IGktLTspCi0gICAgICAgIHdlYWtSZWZzW2ldID0gSlNXZWFrQ3Jl YXRlKGNvbnRleHQsIEpTT2JqZWN0TWFrZUFycmF5KGNvbnRleHQsIDAsIE5VTEwsIE5VTEwpKTsK KyAgICAgICAgd2Vha1JlZnNbaV0gPSBKU1dlYWtDcmVhdGUoZ3JvdXAsIEpTT2JqZWN0TWFrZUFy cmF5KGNvbnRleHQsIDAsIE5VTEwsIE5VTEwpKTsKICAgICAKICAgICBKU1N5bmNocm9ub3VzR2Fy YmFnZUNvbGxlY3RGb3JEZWJ1Z2dpbmcoY29udGV4dCk7CiAgICAgCkBAIC0xMTc1LDcgKzExNzUs NyBAQCBzdGF0aWMgdm9pZCB0ZXN0TWFya2luZ0NvbnN0cmFpbnRzKHZvaWQpCiAgICAgYXNzZXJ0 VHJ1ZShkZWFkQ291bnQgIT0gMCwgIkF0IGxlYXN0IHNvbWUgb2JqZWN0cyBkaWVkIik7CiAgICAg CiAgICAgZm9yIChpID0gbnVtV2Vha1JlZnM7IGktLTspCi0gICAgICAgIEpTV2Vha1JlbGVhc2Uo Y29udGV4dCwgd2Vha1JlZnNbaV0pOworICAgICAgICBKU1dlYWtSZWxlYXNlKGdyb3VwLCB3ZWFr UmVmc1tpXSk7CiAgICAgCiAgICAgSlNDb250ZXh0R3JvdXBSZWxlYXNlKGdyb3VwKTsKIAo=