171965 2017-05-10 21:16:30 -0700 Stop using PassRefPtr in WebGPU code 2017-05-11 10:55:47 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen bdakin buildbot commit-queue darin dino esprehn+autocc gyuyoung.kim simon.fraser thorton oldest_to_newest 1307173 0 cdumez 2017-05-10 21:16:30 -0700 Stop using PassRefPtr in WebGPU code. This is new code :( 1307174 1 309689 cdumez 2017-05-10 21:18:55 -0700 Created attachment 309689 Patch 1307331 2 309689 commit-queue 2017-05-11 10:55:46 -0700 Comment on attachment 309689 Patch Clearing flags on attachment: 309689 Committed r216683: <http://trac.webkit.org/changeset/216683> 1307332 3 commit-queue 2017-05-11 10:55:47 -0700 All reviewed patches have been landed. Closing bug. 309689 2017-05-10 21:18:55 -0700 2017-05-11 10:55:46 -0700 Patch bug-171965-20170510211854.patch text/plain 6193 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVlOWI5MWVhY2ZlMGJh Y2Q4NzQwYmI0NzE0MzIwNzQ5NzI4N2Q4My4uOTc4ZWFiMTQ0MjgxM2RjYTI3NzE4NzRmY2E3NDMz ZGQ0ZjlmNjlkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA1LTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyBQYXNzUmVm UHRyIGluIFdlYkdQVSBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzE5NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTdG9wIHVzaW5nIFBhc3NSZWZQdHIgaW4gV2ViR1BVIGNvZGUuCisKKyAgICAg ICAgKiBodG1sL2NhbnZhcy9XZWJHUFVEcmF3YWJsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX ZWJHUFVEcmF3YWJsZTo6V2ViR1BVRHJhd2FibGUpOgorICAgICAgICAqIGh0bWwvY2FudmFzL1dl YkdQVVJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR1BVUmVuZGVy aW5nQ29udGV4dDo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OldlYkdQVVJlbmRlcmluZ0Nv bnRleHQ6OldlYkdQVVJlbmRlcmluZ0NvbnRleHQpOgorICAgICAgICAqIGh0bWwvY2FudmFzL1dl YkdQVVJlbmRlcmluZ0NvbnRleHQuaDoKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHUFVUZXh0 dXJlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdQVVRleHR1cmU6OmNyZWF0ZUZyb21EcmF3 YWJsZVRleHR1cmUpOgorICAgICAgICAoV2ViQ29yZTo6V2ViR1BVVGV4dHVyZTo6V2ViR1BVVGV4 dHVyZSk6CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR1BVVGV4dHVyZS5oOgorCiAyMDE3LTA1 LTEwICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJFTEVBU0Vf QVNTRVJUIGF0IFdlYkF1ZGlvU291cmNlUHJvdmlkZXJBVkZPYmpDOjpwcm92aWRlSW5wdXQoKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR1BVRHJhd2FibGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR1BVRHJhd2FibGUuY3BwCmluZGV4IDU0 YjY0OWIzNzY2YjUwNGY3M2ExNzdiMzlkNzkzOGMwYTYxYzU4NmUuLjMyYTc0OTdiN2E2ODFjNGYz ZjA2NWJkNTQwMTQ0YmJjYjhkY2Q5MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL1dlYkdQVURyYXdhYmxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHUFVEcmF3YWJsZS5jcHAKQEAgLTQ3LDggKzQ3LDggQEAgV2ViR1BVRHJhd2FibGU6Oldl YkdQVURyYXdhYmxlKFdlYkdQVVJlbmRlcmluZ0NvbnRleHQqIGNvbnRleHQpCiAgICAgaWYgKCFt X2RyYXdhYmxlKQogICAgICAgICByZXR1cm47CiAKLSAgICBSZWZQdHI8R1BVVGV4dHVyZT4gZHJh d2FibGVUZXh0dXJlID0gR1BVVGV4dHVyZTo6Y3JlYXRlRnJvbURyYXdhYmxlKG1fZHJhd2FibGUu Z2V0KCkpOwotICAgIG1fdGV4dHVyZSA9IFdlYkdQVVRleHR1cmU6OmNyZWF0ZUZyb21EcmF3YWJs ZVRleHR1cmUoY29udGV4dCwgZHJhd2FibGVUZXh0dXJlKTsKKyAgICBhdXRvIGRyYXdhYmxlVGV4 dHVyZSA9IEdQVVRleHR1cmU6OmNyZWF0ZUZyb21EcmF3YWJsZShtX2RyYXdhYmxlLmdldCgpKTsK KyAgICBtX3RleHR1cmUgPSBXZWJHUFVUZXh0dXJlOjpjcmVhdGVGcm9tRHJhd2FibGVUZXh0dXJl KGNvbnRleHQsIFdURk1vdmUoZHJhd2FibGVUZXh0dXJlKSk7CiB9CiAKIFdlYkdQVURyYXdhYmxl Ojp+V2ViR1BVRHJhd2FibGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvV2ViR1BVUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHUFVSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCAyMGIyMzJlYzA5NDhlNjNiNDg3Y2Nk NTNiMDhmZjFlN2ZiZjVlZjU4Li42ZGIxZGE0ODJmMThjNzBmMjQ0OTIwYjExMzMwNTVkOGJlNjE3 ZWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHUFVSZW5kZXJp bmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHUFVSZW5k ZXJpbmdDb250ZXh0LmNwcApAQCAtODIsMTUgKzgyLDE1IEBAIHN0ZDo6dW5pcXVlX3B0cjxXZWJH UFVSZW5kZXJpbmdDb250ZXh0PiBXZWJHUFVSZW5kZXJpbmdDb250ZXh0OjpjcmVhdGUoSFRNTENh bnZhCiAgICAgfQogCiAgICAgc3RkOjp1bmlxdWVfcHRyPFdlYkdQVVJlbmRlcmluZ0NvbnRleHQ+ IHJlbmRlcmluZ0NvbnRleHQgPSBudWxscHRyOwotICAgIHJlbmRlcmluZ0NvbnRleHQgPSBzdGQ6 OnVuaXF1ZV9wdHI8V2ViR1BVUmVuZGVyaW5nQ29udGV4dD4obmV3IFdlYkdQVVJlbmRlcmluZ0Nv bnRleHQoY2FudmFzLCBkZXZpY2UpKTsKKyAgICByZW5kZXJpbmdDb250ZXh0ID0gc3RkOjp1bmlx dWVfcHRyPFdlYkdQVVJlbmRlcmluZ0NvbnRleHQ+KG5ldyBXZWJHUFVSZW5kZXJpbmdDb250ZXh0 KGNhbnZhcywgZGV2aWNlLnJlbGVhc2VOb25OdWxsKCkpKTsKICAgICByZW5kZXJpbmdDb250ZXh0 LT5zdXNwZW5kSWZOZWVkZWQoKTsKIAogICAgIHJldHVybiByZW5kZXJpbmdDb250ZXh0OwogfQog Ci1XZWJHUFVSZW5kZXJpbmdDb250ZXh0OjpXZWJHUFVSZW5kZXJpbmdDb250ZXh0KEhUTUxDYW52 YXNFbGVtZW50JiBjYW52YXMsIFBhc3NSZWZQdHI8R1BVRGV2aWNlPiBkZXZpY2UpCitXZWJHUFVS ZW5kZXJpbmdDb250ZXh0OjpXZWJHUFVSZW5kZXJpbmdDb250ZXh0KEhUTUxDYW52YXNFbGVtZW50 JiBjYW52YXMsIFJlZjxHUFVEZXZpY2U+JiYgZGV2aWNlKQogICAgIDogR1BVQmFzZWRDYW52YXNS ZW5kZXJpbmdDb250ZXh0KGNhbnZhcykKLSAgICAsIG1fZGV2aWNlKGRldmljZSkKKyAgICAsIG1f ZGV2aWNlKFdURk1vdmUoZGV2aWNlKSkKIHsKICAgICBpbml0aWFsaXplTmV3Q29udGV4dCgpOwog fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR1BVUmVuZGVyaW5n Q29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR1BVUmVuZGVyaW5nQ29u dGV4dC5oCmluZGV4IDE5Nzc1YTRlODBlNTRlZTQ5Y2QzZGUzMzFjNmI0NDg0ZjE1NDQyOGYuLjlk ZThhM2ExZTdkNzIzZjIzNzEzZGUyMjg3ZmIxNDVmNzI0NGUwN2EgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdQVVJlbmRlcmluZ0NvbnRleHQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHUFVSZW5kZXJpbmdDb250ZXh0LmgKQEAgLTkxLDcg KzkxLDcgQEAgcHJvdGVjdGVkOgogICAgIHZvaWQgaW5pdGlhbGl6ZU5ld0NvbnRleHQoKTsKIAog cHJpdmF0ZToKLSAgICBXZWJHUFVSZW5kZXJpbmdDb250ZXh0KEhUTUxDYW52YXNFbGVtZW50Jiwg UGFzc1JlZlB0cjxHUFVEZXZpY2U+KTsKKyAgICBXZWJHUFVSZW5kZXJpbmdDb250ZXh0KEhUTUxD YW52YXNFbGVtZW50JiwgUmVmPEdQVURldmljZT4mJik7CiAKICAgICBSZWZQdHI8R1BVRGV2aWNl PiBtX2RldmljZTsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9X ZWJHUFVUZXh0dXJlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdQVVRleHR1 cmUuY3BwCmluZGV4IDI5MDBiMjRlYThiNDk4NTE2MDc3YWQ4ZWU1OGQ0NjhkOGI4Y2E4ZDguLjBj MDA0ODRkODhjZWY3NzIwMjRjMDllNmVlZjgzMThiYjFjMDRlOTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdQVVRleHR1cmUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvY2FudmFzL1dlYkdQVVRleHR1cmUuY3BwCkBAIC0zNCw5ICszNCw5IEBACiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAotUmVmPFdlYkdQVVRleHR1cmU+IFdlYkdQVVRleHR1cmU6OmNy ZWF0ZUZyb21EcmF3YWJsZVRleHR1cmUoV2ViR1BVUmVuZGVyaW5nQ29udGV4dCogY29udGV4dCwg UGFzc1JlZlB0cjxHUFVUZXh0dXJlPiBkcmF3YWJsZVRleHR1cmUpCitSZWY8V2ViR1BVVGV4dHVy ZT4gV2ViR1BVVGV4dHVyZTo6Y3JlYXRlRnJvbURyYXdhYmxlVGV4dHVyZShXZWJHUFVSZW5kZXJp bmdDb250ZXh0KiBjb250ZXh0LCBSZWZQdHI8R1BVVGV4dHVyZT4mJiBkcmF3YWJsZVRleHR1cmUp CiB7Ci0gICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgV2ViR1BVVGV4dHVyZShjb250ZXh0LCBkcmF3 YWJsZVRleHR1cmUpKTsKKyAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBXZWJHUFVUZXh0dXJlKGNv bnRleHQsIFdURk1vdmUoZHJhd2FibGVUZXh0dXJlKSkpOwogfQogCiBSZWY8V2ViR1BVVGV4dHVy ZT4gV2ViR1BVVGV4dHVyZTo6Y3JlYXRlKFdlYkdQVVJlbmRlcmluZ0NvbnRleHQqIGNvbnRleHQs IFdlYkdQVVRleHR1cmVEZXNjcmlwdG9yKiBkZXNjcmlwdG9yKQpAQCAtNDQsOSArNDQsOSBAQCBS ZWY8V2ViR1BVVGV4dHVyZT4gV2ViR1BVVGV4dHVyZTo6Y3JlYXRlKFdlYkdQVVJlbmRlcmluZ0Nv bnRleHQqIGNvbnRleHQsIFdlYkdQVQogICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFdlYkdQVVRl eHR1cmUoY29udGV4dCwgZGVzY3JpcHRvcikpOwogfQogCi1XZWJHUFVUZXh0dXJlOjpXZWJHUFVU ZXh0dXJlKFdlYkdQVVJlbmRlcmluZ0NvbnRleHQqIGNvbnRleHQsIFBhc3NSZWZQdHI8R1BVVGV4 dHVyZT4gZHJhd2FibGVUZXh0dXJlKQorV2ViR1BVVGV4dHVyZTo6V2ViR1BVVGV4dHVyZShXZWJH UFVSZW5kZXJpbmdDb250ZXh0KiBjb250ZXh0LCBSZWZQdHI8R1BVVGV4dHVyZT4mJiBkcmF3YWJs ZVRleHR1cmUpCiAgICAgOiBXZWJHUFVPYmplY3QoY29udGV4dCkKLSAgICAsIG1fdGV4dHVyZShk cmF3YWJsZVRleHR1cmUpCisgICAgLCBtX3RleHR1cmUoV1RGTW92ZShkcmF3YWJsZVRleHR1cmUp KQogewogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHUFVU ZXh0dXJlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHUFVUZXh0dXJlLmgKaW5k ZXggZDI1YjBiYmU0MzYwODEwMDg2NTQyYmFiMjlmOGZjMDUyNmY3OTFjZi4uMzBmMmU0ZDFjYWM4 ZDNjMDE1MWY2Mjc1OTUyY2NhMmQxNzk3OWFmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvV2ViR1BVVGV4dHVyZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdQVVRleHR1cmUuaApAQCAtMzcsNyArMzcsNyBAQCBjbGFzcyBXZWJHUFVUZXh0dXJl RGVzY3JpcHRvcjsKIGNsYXNzIFdlYkdQVVRleHR1cmUgOiBwdWJsaWMgV2ViR1BVT2JqZWN0IHsK IHB1YmxpYzoKICAgICB2aXJ0dWFsIH5XZWJHUFVUZXh0dXJlKCk7Ci0gICAgc3RhdGljIFJlZjxX ZWJHUFVUZXh0dXJlPiBjcmVhdGVGcm9tRHJhd2FibGVUZXh0dXJlKFdlYkdQVVJlbmRlcmluZ0Nv bnRleHQqLCBQYXNzUmVmUHRyPEdQVVRleHR1cmU+KTsKKyAgICBzdGF0aWMgUmVmPFdlYkdQVVRl eHR1cmU+IGNyZWF0ZUZyb21EcmF3YWJsZVRleHR1cmUoV2ViR1BVUmVuZGVyaW5nQ29udGV4dCos IFJlZlB0cjxHUFVUZXh0dXJlPiYmKTsKICAgICBzdGF0aWMgUmVmPFdlYkdQVVRleHR1cmU+IGNy ZWF0ZShXZWJHUFVSZW5kZXJpbmdDb250ZXh0KiwgV2ViR1BVVGV4dHVyZURlc2NyaXB0b3IqKTsK IAogICAgIHVuc2lnbmVkIGxvbmcgd2lkdGgoKSBjb25zdDsKQEAgLTQ2LDcgKzQ2LDcgQEAgcHVi bGljOgogICAgIEdQVVRleHR1cmUqIHRleHR1cmUoKSBjb25zdCB7IHJldHVybiBtX3RleHR1cmUu Z2V0KCk7IH0KIAogcHJpdmF0ZToKLSAgICBXZWJHUFVUZXh0dXJlKFdlYkdQVVJlbmRlcmluZ0Nv bnRleHQqLCBQYXNzUmVmUHRyPEdQVVRleHR1cmU+KTsKKyAgICBXZWJHUFVUZXh0dXJlKFdlYkdQ VVJlbmRlcmluZ0NvbnRleHQqLCBSZWZQdHI8R1BVVGV4dHVyZT4mJik7CiAgICAgV2ViR1BVVGV4 dHVyZShXZWJHUFVSZW5kZXJpbmdDb250ZXh0KiwgV2ViR1BVVGV4dHVyZURlc2NyaXB0b3IqKTsK IAogICAgIFJlZlB0cjxHUFVUZXh0dXJlPiBtX3RleHR1cmU7Cg==