171962 2017-05-10 19:53:42 -0700 Computing optionalDefArgWidth in CheckSpecial should not consider Scratch roles 2017-05-11 23:05:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 171826 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ticaiolima ysuzuki oldest_to_newest 1307144 0 saam 2017-05-10 19:53:42 -0700 I think we should be using isLateDef and not isAnyDef. 1307381 1 fpizlo 2017-05-11 12:05:01 -0700 (In reply to Saam Barati from comment #0) > I think we should be using isLateDef and not isAnyDef. I think it should be "Arg::isAnyDef(role) && role != Arg::Scratch". The def that this code is looking for could be early or late. The thing you're trying to ignore are Scratches, which aren't really defs for the purpose of this code. 1307400 2 309756 saam 2017-05-11 12:56:34 -0700 Created attachment 309756 patch 1307500 3 309756 commit-queue 2017-05-11 15:11:22 -0700 Comment on attachment 309756 patch Rejecting attachment 309756 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 309756, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ingContext should implement WebGLRenderingContextBase The copy of the patch that failed is found in: /Volumes/Data/EWS/WebKit/.git/rebase-apply/patch When you have resolved this problem, run "git rebase --continue". If you prefer to skip this patch, run "git rebase --skip" instead. To check out the original branch and stop rebasing, run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2719. Full output: http://webkit-queues.webkit.org/results/3721150 1307784 4 309756 commit-queue 2017-05-11 23:05:57 -0700 Comment on attachment 309756 patch Clearing flags on attachment: 309756 Committed r216734: <http://trac.webkit.org/changeset/216734> 1307785 5 commit-queue 2017-05-11 23:05:59 -0700 All reviewed patches have been landed. Closing bug. 309756 2017-05-11 12:56:34 -0700 2017-05-11 23:05:57 -0700 patch c-backup.diff text/plain 4898 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE2Njg4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDE3LTA1LTExICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IENvbXB1dGluZyBvcHRpb25hbERlZkFyZ1dpZHRoIGluIENoZWNrU3BlY2lhbCBzaG91bGQgbm90 IGNvbnNpZGVyIFNjcmF0Y2ggcm9sZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MTk2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBwdXJwb3NlIG9mIGdldHRpbmcgdGhlIHJlc3VsdCB3aWR0aCBp cyB0byBnZXQgdGhlIHdpZHRoIG9mCisgICAgICAgIHRoZSByZXN1bHQgb2YgdGhlIGFyaXRobWV0 aWMuIEl0IGRvZXMgbm90IGNhcmUgYWJvdXQgdGhhdCB0aGUKKyAgICAgICAgQ2hlY2sgaGFwcGVu cyB0byBkZWZpbmUgc2NyYXRjaGVzLgorCisgICAgICAgICogYjMvQjNDaGVja1NwZWNpYWwuY3Bw OgorICAgICAgICAoSlNDOjpCMzo6Q2hlY2tTcGVjaWFsOjpmb3JFYWNoQXJnKToKKyAgICAgICAg KiBiMy90ZXN0YjMuY3BwOgorICAgICAgICAoSlNDOjpCMzo6dGVzdENoZWNrTXVsKToKKyAgICAg ICAgKEpTQzo6QjM6OnRlc3RDaGVja011bE1lbW9yeSk6CisgICAgICAgIChKU0M6OkIzOjp0ZXN0 Q2hlY2tNdWw2NCk6CisgICAgICAgIChKU0M6OkIzOjp0ZXN0Q2hlY2tNdWxGb2xkKToKKyAgICAg ICAgKEpTQzo6QjM6OnRlc3RDaGVja011bEZvbGRGYWlsKToKKyAgICAgICAgKEpTQzo6QjM6OnRl c3RDaGVja011bEFyZ3VtZW50QWxpYXNpbmc2NCk6CisgICAgICAgIChKU0M6OkIzOjp0ZXN0Q2hl Y2tNdWxBcmd1bWVudEFsaWFzaW5nMzIpOgorICAgICAgICAoSlNDOjpCMzo6dGVzdENoZWNrTXVs NjRTU2hyKToKKwogMjAxNy0wNS0xMSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIEpTV2Vha0NyZWF0ZS9SZXRhaW4vUmVsZWFzZSBzaG91bGQgdGFrZSBhIEpTQ29u dGV4dEdyb3VwUmVmIGFuZCBub3QgYSBKU0NvbnRleHRSZWYKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9iMy9CM0NoZWNrU3BlY2lhbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL0IzQ2hlY2tTcGVjaWFsLmNwcAkocmV2aXNpb24gMjE2Njg4KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzQ2hlY2tTcGVjaWFsLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTEyLDcgKzExMiw3IEBAIHZvaWQgQ2hlY2tTcGVjaWFsOjpmb3JFYWNoQXJnKEluc3QmIGlu c3QKICAgICBJbnN0IGhpZGRlbiA9IGhpZGRlbkJyYW5jaChpbnN0KTsKICAgICBoaWRkZW4uZm9y RWFjaEFyZygKICAgICAgICAgWyZdIChBcmcmIGFyZywgQXJnOjpSb2xlIHJvbGUsIEJhbmsgYmFu aywgV2lkdGggd2lkdGgpIHsKLSAgICAgICAgICAgIGlmIChBcmc6OmlzQW55RGVmKHJvbGUpKSB7 CisgICAgICAgICAgICBpZiAoQXJnOjppc0FueURlZihyb2xlKSAmJiByb2xlICE9IEFyZzo6U2Ny YXRjaCkgewogICAgICAgICAgICAgICAgIEFTU0VSVCghb3B0aW9uYWxEZWZBcmdXaWR0aCk7IC8v IFRoZXJlIGNhbiBvbmx5IGJlIG9uZSBEZWYnZWQgYXJnLgogICAgICAgICAgICAgICAgIG9wdGlv bmFsRGVmQXJnV2lkdGggPSB3aWR0aDsKICAgICAgICAgICAgIH0KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9iMy90ZXN0YjMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9iMy90ZXN0YjMuY3BwCShyZXZpc2lvbiAyMTY2ODgpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYjMvdGVzdGIzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTYyNCwxMiArOTYyNCw2IEBA IHZvaWQgdGVzdENoZWNrTmVnNjQoKQogCiB2b2lkIHRlc3RDaGVja011bCgpCiB7Ci0jaWZuZGVm IE5ERUJVRwotICAgIGlmIChpc0FSTTY0KCkpIHsKLSAgICAgICAgLy8gRklYTUU6IGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE4MjYKLSAgICAgICAgcmV0dXJuOwot ICAgIH0KLSNlbmRpZgogICAgIFByb2NlZHVyZSBwcm9jOwogICAgIEJhc2ljQmxvY2sqIHJvb3Qg PSBwcm9jLmFkZEJsb2NrKCk7CiAgICAgVmFsdWUqIGFyZzEgPSByb290LT5hcHBlbmROZXc8VmFs dWU+KApAQCAtOTY2NywxMiArOTY2MSw2IEBAIHZvaWQgdGVzdENoZWNrTXVsKCkKIAogdm9pZCB0 ZXN0Q2hlY2tNdWxNZW1vcnkoKQogewotI2lmbmRlZiBOREVCVUcKLSAgICBpZiAoaXNBUk02NCgp KSB7Ci0gICAgICAgIC8vIEZJWE1FOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTcxODI2Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0jZW5kaWYKICAgICBQcm9jZWR1 cmUgcHJvYzsKICAgICBCYXNpY0Jsb2NrKiByb290ID0gcHJvYy5hZGRCbG9jaygpOwogCkBAIC05 NzYxLDEyICs5NzQ5LDYgQEAgdm9pZCB0ZXN0Q2hlY2tNdWwyKCkKIAogdm9pZCB0ZXN0Q2hlY2tN dWw2NCgpCiB7Ci0jaWZuZGVmIE5ERUJVRwotICAgIGlmIChpc0FSTTY0KCkpIHsKLSAgICAgICAg Ly8gRklYTUU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE4MjYK LSAgICAgICAgcmV0dXJuOwotICAgIH0KLSNlbmRpZgogICAgIFByb2NlZHVyZSBwcm9jOwogICAg IEJhc2ljQmxvY2sqIHJvb3QgPSBwcm9jLmFkZEJsb2NrKCk7CiAgICAgVmFsdWUqIGFyZzEgPSBy b290LT5hcHBlbmROZXc8QXJndW1lbnRSZWdWYWx1ZT4ocHJvYywgT3JpZ2luKCksIEdQUkluZm86 OmFyZ3VtZW50R1BSMCk7CkBAIC05ODAwLDEyICs5NzgyLDYgQEAgdm9pZCB0ZXN0Q2hlY2tNdWw2 NCgpCiAKIHZvaWQgdGVzdENoZWNrTXVsRm9sZChpbnQgYSwgaW50IGIpCiB7Ci0jaWZuZGVmIE5E RUJVRwotICAgIGlmIChpc0FSTTY0KCkpIHsKLSAgICAgICAgLy8gRklYTUU6IGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE4MjYKLSAgICAgICAgcmV0dXJuOwotICAg IH0KLSNlbmRpZgogICAgIFByb2NlZHVyZSBwcm9jOwogICAgIEJhc2ljQmxvY2sqIHJvb3QgPSBw cm9jLmFkZEJsb2NrKCk7CiAgICAgVmFsdWUqIGFyZzEgPSByb290LT5hcHBlbmROZXc8Q29uc3Qz MlZhbHVlPihwcm9jLCBPcmlnaW4oKSwgYSk7CkBAIC05ODI0LDEyICs5ODAwLDYgQEAgdm9pZCB0 ZXN0Q2hlY2tNdWxGb2xkKGludCBhLCBpbnQgYikKIAogdm9pZCB0ZXN0Q2hlY2tNdWxGb2xkRmFp bChpbnQgYSwgaW50IGIpCiB7Ci0jaWZuZGVmIE5ERUJVRwotICAgIGlmIChpc0FSTTY0KCkpIHsK LSAgICAgICAgLy8gRklYTUU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzE4MjYKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLSNlbmRpZgogICAgIFByb2NlZHVyZSBw cm9jOwogICAgIEJhc2ljQmxvY2sqIHJvb3QgPSBwcm9jLmFkZEJsb2NrKCk7CiAgICAgVmFsdWUq IGFyZzEgPSByb290LT5hcHBlbmROZXc8Q29uc3QzMlZhbHVlPihwcm9jLCBPcmlnaW4oKSwgYSk7 CkBAIC05ODUxLDEyICs5ODIxLDYgQEAgdm9pZCB0ZXN0Q2hlY2tNdWxGb2xkRmFpbChpbnQgYSwg aW50IGIpCiAKIHZvaWQgdGVzdENoZWNrTXVsQXJndW1lbnRBbGlhc2luZzY0KCkKIHsKLSNpZm5k ZWYgTkRFQlVHCi0gICAgaWYgKGlzQVJNNjQoKSkgewotICAgICAgICAvLyBGSVhNRTogaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTgyNgotICAgICAgICByZXR1cm47 Ci0gICAgfQotI2VuZGlmCiAgICAgUHJvY2VkdXJlIHByb2M7CiAgICAgQmFzaWNCbG9jayogcm9v dCA9IHByb2MuYWRkQmxvY2soKTsKICAgICBWYWx1ZSogYXJnMSA9IHJvb3QtPmFwcGVuZE5ldzxB cmd1bWVudFJlZ1ZhbHVlPihwcm9jLCBPcmlnaW4oKSwgR1BSSW5mbzo6YXJndW1lbnRHUFIwKTsK QEAgLTk4OTQsMTIgKzk4NTgsNiBAQCB2b2lkIHRlc3RDaGVja011bEFyZ3VtZW50QWxpYXNpbmc2 NCgpCiAKIHZvaWQgdGVzdENoZWNrTXVsQXJndW1lbnRBbGlhc2luZzMyKCkKIHsKLSNpZm5kZWYg TkRFQlVHCi0gICAgaWYgKGlzQVJNNjQoKSkgewotICAgICAgICAvLyBGSVhNRTogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTgyNgotICAgICAgICByZXR1cm47Ci0g ICAgfQotI2VuZGlmCiAgICAgUHJvY2VkdXJlIHByb2M7CiAgICAgQmFzaWNCbG9jayogcm9vdCA9 IHByb2MuYWRkQmxvY2soKTsKICAgICBWYWx1ZSogYXJnMSA9IHJvb3QtPmFwcGVuZE5ldzxWYWx1 ZT4oCkBAIC05OTQzLDEyICs5OTAxLDYgQEAgdm9pZCB0ZXN0Q2hlY2tNdWxBcmd1bWVudEFsaWFz aW5nMzIoKQogCiB2b2lkIHRlc3RDaGVja011bDY0U1NocigpCiB7Ci0jaWZuZGVmIE5ERUJVRwot ICAgIGlmIChpc0FSTTY0KCkpIHsKLSAgICAgICAgLy8gRklYTUU6IGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE4MjYKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLSNl bmRpZgogICAgIFByb2NlZHVyZSBwcm9jOwogICAgIEJhc2ljQmxvY2sqIHJvb3QgPSBwcm9jLmFk ZEJsb2NrKCk7CiAgICAgVmFsdWUqIGFyZzEgPSByb290LT5hcHBlbmROZXc8VmFsdWU+KAo=