171952 2017-05-10 16:14:15 -0700 [WTF] Export additional symbols in threading 2017-05-23 12:51:49 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead annulen benjamin buildbot cdumez cmarcelo commit-queue dbates mcatanzaro oldest_to_newest 1307066 0 don.olmstead 2017-05-10 16:14:15 -0700 sendMessageScoped and installSignalHandler are not exported as symbols for JSC. 1307069 1 309654 don.olmstead 2017-05-10 16:21:41 -0700 Created attachment 309654 Patch Adds WTF_EXPORT_PRIVATE to the functions 1308897 2 mcatanzaro 2017-05-15 17:31:44 -0700 What does this fix? If those needed to be exported, then the build wouldn't work at all, right? 1311702 3 don.olmstead 2017-05-22 18:14:06 -0700 (In reply to Michael Catanzaro from comment #2) > What does this fix? If those needed to be exported, then the build wouldn't > work at all, right? These symbols look to be used by WASM related code. Since there is no FTL support on Windows there is no WASM support. When it is there these will be required. https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/wasm/WasmMachineThreads.cpp#L60 https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp#L127 Currently we're hitting this in the PlayStation port which also uses declspec. 1311703 4 don.olmstead 2017-05-22 18:30:52 -0700 Actually it looks like when https://bugs.webkit.org/show_bug.cgi?id=171865 was reverted the WTF_EXPORT_PRIVATE symbol isn't exported so landing will cause a build breakage. 1311721 5 don.olmstead 2017-05-22 19:10:52 -0700 Nvm its good for review 1311999 6 309654 commit-queue 2017-05-23 12:51:48 -0700 Comment on attachment 309654 Patch Clearing flags on attachment: 309654 Committed r217291: <http://trac.webkit.org/changeset/217291> 1312000 7 commit-queue 2017-05-23 12:51:49 -0700 All reviewed patches have been landed. Closing bug. 309654 2017-05-10 16:21:41 -0700 2017-05-23 12:51:48 -0700 Patch bug-171952.diff text/plain 1991 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMWRkYzFkNjlmZmIuLmVkNmY1YmM2MzY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3 LTA1LTEwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAYW0uc29ueS5jb20+CisKKyAgICAg ICAgW1dURl0gRXhwb3J0IGFkZGl0aW9uYWwgc3ltYm9scyBpbiB0aHJlYWRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTk1MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1RocmVhZE1lc3Nh Z2UuaDoKKyAgICAgICAgKiB3dGYvdGhyZWFkcy9TaWduYWxzLmg6CisKIDIwMTctMDUtMTAgIEFk cmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1v dmUgc29tZSBsYXN0IHJlbW5hbnRzIG9mIHRoZSBFRkwgcG9ydApkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvVGhyZWFkTWVzc2FnZS5oIGIvU291cmNlL1dURi93dGYvVGhyZWFkTWVzc2FnZS5o CmluZGV4IDlhZTUzZjI5Y2Y3Li4yNjhhZGQ0Mzg3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93 dGYvVGhyZWFkTWVzc2FnZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1RocmVhZE1lc3NhZ2UuaApA QCAtNDYsNyArNDYsNyBAQCBlbnVtIGNsYXNzIE1lc3NhZ2VTdGF0dXMgewogLy8gVGhpcyBtZXRo b2QgYWxsb3dzIHVzIHRvIHNlbmQgYSBtZXNzYWdlIHdoaWNoIHdpbGwgYmUgcnVuIGluIGEgc2ln bmFsIGhhbmRsZXIgb24gdGhlIGRlc2lyZWQgdGhyZWFkLgogLy8gVGhlcmUgYXJlIHNldmVyYWwg Y2F2ZWF0ZXMgdG8gdGhpcyBtZXRob2QgaG93ZXZlciwgVGhpcyBmdW5jdGlvbiB1c2VzIHNpZ25h bHMgc28geW91ciBtZXNzYWdlIHNob3VsZAogLy8gYmUgc3luYyBzaWduYWwgc2FmZS4KLU1lc3Nh Z2VTdGF0dXMgc2VuZE1lc3NhZ2VTY29wZWQoVGhyZWFkJiwgY29uc3QgVGhyZWFkTWVzc2FnZSYp OworV1RGX0VYUE9SVF9QUklWQVRFIE1lc3NhZ2VTdGF0dXMgc2VuZE1lc3NhZ2VTY29wZWQoVGhy ZWFkJiwgY29uc3QgVGhyZWFkTWVzc2FnZSYpOwogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jdG9y PgogTWVzc2FnZVN0YXR1cyBzZW5kTWVzc2FnZShUaHJlYWQmIHRhcmdldFRocmVhZCwgY29uc3Qg RnVuY3RvciYgZnVuYykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFs cy5oIGIvU291cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmgKaW5kZXggMWU0ZWI0NmVhYTcu LmYyOWQ0ZGRiN2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMu aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuaApAQCAtODUsNyArODUsNyBA QCB1c2luZyBTaWduYWxIYW5kbGVyID0gRnVuY3Rpb248U2lnbmFsQWN0aW9uKGludCwgc2lnaW5m b190Kiwgdm9pZCopPjsKIC8vIE5vdGU6IFlvdXIgc2lnbmFsIGhhbmRsZXIgd2lsbCBiZSBjYWxs ZWQgZXZlcnkgdGltZSB0aGUgaGFuZGxlciBmb3IgdGhlIGRlc2lyZWQgc2lnbmFsIGlzIGNhbGxl ZC4KIC8vIFRodXMgaXQgaXMgeW91ciByZXNwb25zaWJpbGl0eSB0byBkaXNjZXJuIGlmIHRoZSBz aWduYWwgZmlyZWQgd2FzIHlvdXJzLgogLy8gVGhpcyBmdW5jdGlvbiBpcyBjdXJyZW50bHkgYSBv bmUgd2F5IHN0cmVldCBpLmUuIG9uY2UgaW5zdGFsbGVkLCBhIHNpZ25hbCBoYW5kbGVyIGNhbm5v dCBiZSB1bmluc3RhbGxlZC4KLXZvaWQgaW5zdGFsbFNpZ25hbEhhbmRsZXIoU2lnbmFsLCBTaWdu YWxIYW5kbGVyJiYpOworV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgaW5zdGFsbFNpZ25hbEhhbmRs ZXIoU2lnbmFsLCBTaWduYWxIYW5kbGVyJiYpOwogCiB9IC8vIG5hbWVzcGFjZSBXVEYKIAo=