171933 2017-05-10 11:02:47 -0700 Drop custom bindings code now window.open() 2017-05-10 13:50:06 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez buildbot cdumez commit-queue esprehn+autocc ggaren kondapallykalyan sam oldest_to_newest 1306918 0 cdumez 2017-05-10 11:02:47 -0700 Drop custom bindings code now window.open(). 1306919 1 309618 cdumez 2017-05-10 11:05:11 -0700 Created attachment 309618 Patch 1306973 2 309618 ggaren 2017-05-10 13:18:59 -0700 Comment on attachment 309618 Patch r=me 1306988 3 309618 commit-queue 2017-05-10 13:50:04 -0700 Comment on attachment 309618 Patch Clearing flags on attachment: 309618 Committed r216615: <http://trac.webkit.org/changeset/216615> 1306989 4 commit-queue 2017-05-10 13:50:06 -0700 All reviewed patches have been landed. Closing bug. 309618 2017-05-10 11:05:11 -0700 2017-05-10 13:50:04 -0700 Patch bug-171933-20170510110511.patch text/plain 5917 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTYwYjgxYTZjN2Y0YzY5 ODgxYzBhNzlkN2U4NzdkMDZkMDQ2MjMyNi4uOTFkZmU4ZTYxZDg4MGE5NDg1NjA3YTMyZTdiMTA4 MWE4ZTVkNmExNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA1LTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBjdXN0b20gYmluZGlu Z3MgY29kZSBub3cgd2luZG93Lm9wZW4oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTcxOTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRHJvcCBjdXN0b20gYmluZGluZ3MgY29kZSBub3cgd2luZG93Lm9w ZW4oKSBhcyBpdCBpcyBub3QgZG9pbmcgYW55dGhpbmcgc3BlY2lhbC4KKworICAgICAgICAqIGJp bmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9N V2luZG93OjpvcGVuKTogRGVsZXRlZC4KKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6Om9wZW4pOgorICAgICAgICAqIHBhZ2UvRE9NV2lu ZG93Lmg6CisgICAgICAgICogcGFnZS9ET01XaW5kb3cuaWRsOgorICAgICAgICAqIHRlc3Rpbmcv SW50ZXJuYWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6b3BlbkR1bW15SW5z cGVjdG9yRnJvbnRlbmQpOgorCiAyMDE3LTA1LTEwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjA3MzcyKSBWaXNpYmlsaXR5IHByb3Bl cnR5IGlzIG5vdCBpbmhlcml0ZWQgd2hlbiB1c2VkIGluIGFuIGFuaW1hdGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwCmluZGV4IGJmMWVi OTkxNWY1ODc2M2NiZTAzYTM4MDM0ZjNiMjI1NjNkNmNhNWMuLjZjOTRiOTljYjIxMTM2ZGU1NjM4 NGFmMmViYmNlMTQyMmIyOGEzZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAKQEAgLTQ2MiwyNSArNDYyLDYgQEAgSlNWYWx1ZSBKU0RP TVdpbmRvdzo6ZXZlbnQoRXhlY1N0YXRlJiBzdGF0ZSkgY29uc3QKIAogLy8gQ3VzdG9tIGZ1bmN0 aW9ucwogCi1KU1ZhbHVlIEpTRE9NV2luZG93OjpvcGVuKEV4ZWNTdGF0ZSYgc3RhdGUpCi17Ci0g ICAgVk0mIHZtID0gc3RhdGUudm0oKTsKLSAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19T Q09QRSh2bSk7Ci0KLSAgICBTdHJpbmcgdXJsU3RyaW5nID0gY29udmVydDxJRExOdWxsYWJsZTxJ RExVU1ZTdHJpbmc+PihzdGF0ZSwgc3RhdGUuYXJndW1lbnQoMCkpOwotICAgIFJFVFVSTl9JRl9F WENFUFRJT04oc2NvcGUsIEpTVmFsdWUoKSk7Ci0gICAgSlNWYWx1ZSB0YXJnZXRWYWx1ZSA9IHN0 YXRlLmFyZ3VtZW50KDEpOwotICAgIEF0b21pY1N0cmluZyB0YXJnZXQgPSB0YXJnZXRWYWx1ZS5p c1VuZGVmaW5lZE9yTnVsbCgpID8gQXRvbWljU3RyaW5nKCJfYmxhbmsiLCBBdG9taWNTdHJpbmc6 OkNvbnN0cnVjdEZyb21MaXRlcmFsKSA6IHRhcmdldFZhbHVlLnRvU3RyaW5nKCZzdGF0ZSktPnRv QXRvbWljU3RyaW5nKCZzdGF0ZSk7Ci0gICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgSlNW YWx1ZSgpKTsKLSAgICBTdHJpbmcgd2luZG93RmVhdHVyZXNTdHJpbmcgPSBjb252ZXJ0PElETE51 bGxhYmxlPElETERPTVN0cmluZz4+KHN0YXRlLCBzdGF0ZS5hcmd1bWVudCgyKSk7Ci0gICAgUkVU VVJOX0lGX0VYQ0VQVElPTihzY29wZSwgSlNWYWx1ZSgpKTsKLQotICAgIFJlZlB0cjxET01XaW5k b3c+IG9wZW5lZFdpbmRvdyA9IHdyYXBwZWQoKS5vcGVuKHVybFN0cmluZywgdGFyZ2V0LCB3aW5k b3dGZWF0dXJlc1N0cmluZywgYWN0aXZlRE9NV2luZG93KCZzdGF0ZSksIGZpcnN0RE9NV2luZG93 KCZzdGF0ZSkpOwotICAgIGlmICghb3BlbmVkV2luZG93KQotICAgICAgICByZXR1cm4ganNOdWxs KCk7Ci0gICAgcmV0dXJuIHRvSlMoJnN0YXRlLCBvcGVuZWRXaW5kb3cuZ2V0KCkpOwotfQotCiBj bGFzcyBEaWFsb2dIYW5kbGVyIHsKIHB1YmxpYzoKICAgICBleHBsaWNpdCBEaWFsb2dIYW5kbGVy KEV4ZWNTdGF0ZSYgZXhlYykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2lu ZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAppbmRleCAwNTU4Yzc1 Y2Y0ODcxYTc5NTc5MmI3Y2Q5OGM5OGVlMjg2YThmNTM4Li43ZmQwYzYyM2RkYzQ2YmY3YzJkM2Qw NjJkMTliMTc1ZmQwODQ2NWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdp bmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCkBAIC0yMjI3 LDcgKzIyMjcsNyBAQCBSZWZQdHI8RnJhbWU+IERPTVdpbmRvdzo6Y3JlYXRlV2luZG93KGNvbnN0 IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zdCBBdG9taWNTdHJpbgogICAgIHJldHVybiB3aW5kb3dG ZWF0dXJlcy5ub29wZW5lciA/IG51bGxwdHIgOiBuZXdGcmFtZTsKIH0KIAotUmVmUHRyPERPTVdp bmRvdz4gRE9NV2luZG93OjpvcGVuKGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zdCBBdG9t aWNTdHJpbmcmIGZyYW1lTmFtZSwgY29uc3QgU3RyaW5nJiB3aW5kb3dGZWF0dXJlc1N0cmluZywg RE9NV2luZG93JiBhY3RpdmVXaW5kb3csIERPTVdpbmRvdyYgZmlyc3RXaW5kb3cpCitSZWZQdHI8 RE9NV2luZG93PiBET01XaW5kb3c6Om9wZW4oRE9NV2luZG93JiBhY3RpdmVXaW5kb3csIERPTVdp bmRvdyYgZmlyc3RXaW5kb3csIGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zdCBBdG9taWNT dHJpbmcmIGZyYW1lTmFtZSwgY29uc3QgU3RyaW5nJiB3aW5kb3dGZWF0dXJlc1N0cmluZykKIHsK ICAgICBpZiAoIWlzQ3VycmVudGx5RGlzcGxheWVkSW5GcmFtZSgpKQogICAgICAgICByZXR1cm4g bnVsbHB0cjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmggYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCmluZGV4IDljYzQwY2EyMzA0M2I5YmJjODdi OWVkZWYwMGIyYTlhNmVlMTkyYTcuLmRjNzlkZDQxMjNmZmMwZjU3M2JhZjY2NTNlOWEzMWI1OWU3 ZmJmMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaApAQCAtMTQ5LDcgKzE0OSw3IEBAIHB1Ymxp YzoKICAgICB2b2lkIHByaW50KCk7CiAgICAgdm9pZCBzdG9wKCk7CiAKLSAgICBXRUJDT1JFX0VY UE9SVCBSZWZQdHI8RE9NV2luZG93PiBvcGVuKGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25z dCBBdG9taWNTdHJpbmcmIGZyYW1lTmFtZSwgY29uc3QgU3RyaW5nJiB3aW5kb3dGZWF0dXJlc1N0 cmluZywgRE9NV2luZG93JiBhY3RpdmVXaW5kb3csIERPTVdpbmRvdyYgZmlyc3RXaW5kb3cpOwor ICAgIFdFQkNPUkVfRVhQT1JUIFJlZlB0cjxET01XaW5kb3c+IG9wZW4oRE9NV2luZG93JiBhY3Rp dmVXaW5kb3csIERPTVdpbmRvdyYgZmlyc3RXaW5kb3csIGNvbnN0IFN0cmluZyYgdXJsU3RyaW5n LCBjb25zdCBBdG9taWNTdHJpbmcmIGZyYW1lTmFtZSwgY29uc3QgU3RyaW5nJiB3aW5kb3dGZWF0 dXJlc1N0cmluZyk7CiAKICAgICB2b2lkIHNob3dNb2RhbERpYWxvZyhjb25zdCBTdHJpbmcmIHVy bFN0cmluZywgY29uc3QgU3RyaW5nJiBkaWFsb2dGZWF0dXJlc1N0cmluZywgRE9NV2luZG93JiBh Y3RpdmVXaW5kb3csIERPTVdpbmRvdyYgZmlyc3RXaW5kb3csIHN0ZDo6ZnVuY3Rpb248dm9pZChE T01XaW5kb3cmKT4gcHJlcGFyZURpYWxvZ0Z1bmN0aW9uKTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5k b3cuaWRsCmluZGV4IDA2ZTIwOWExYzBlNWI4YTI2OGZkZDE3MTU0YzMyYjM1N2NiYzYxZGYuLjA0 NmY2MWUyZGVkYmMyOTkxNzBlNDA3YThmNzkxMTk3YjBkYmJhZDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RP TVdpbmRvdy5pZGwKQEAgLTc2LDcgKzc2LDcgQEAgdHlwZWRlZiBVU1ZTdHJpbmcgQ1NTT01TdHJp bmc7CiAgICAgW1JlcGxhY2VhYmxlLCBEb05vdENoZWNrU2VjdXJpdHlPbkdldHRlcl0gcmVhZG9u bHkgYXR0cmlidXRlIERPTVdpbmRvdz8gb3BlbmVyOwogICAgIFtSZXBsYWNlYWJsZSwgRG9Ob3RD aGVja1NlY3VyaXR5T25HZXR0ZXJdIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01XaW5kb3c/IHBhcmVu dDsKICAgICBbQ2hlY2tTZWN1cml0eUZvck5vZGVdIHJlYWRvbmx5IGF0dHJpYnV0ZSBFbGVtZW50 PyBmcmFtZUVsZW1lbnQ7Ci0gICAgW0N1c3RvbV0gRE9NV2luZG93PyBvcGVuKG9wdGlvbmFsIFVT VlN0cmluZyB1cmwgPSAiYWJvdXQ6YmxhbmsiLCBvcHRpb25hbCBET01TdHJpbmcgdGFyZ2V0ID0g Il9ibGFuayIsIG9wdGlvbmFsIFtUcmVhdE51bGxBcz1FbXB0eVN0cmluZ10gRE9NU3RyaW5nIGZl YXR1cmVzID0gIiIpOworICAgIFtDYWxsV2l0aD1BY3RpdmVXaW5kb3cmRmlyc3RXaW5kb3ddIERP TVdpbmRvdz8gb3BlbihvcHRpb25hbCBVU1ZTdHJpbmcgdXJsID0gImFib3V0OmJsYW5rIiwgb3B0 aW9uYWwgRE9NU3RyaW5nIHRhcmdldCA9ICJfYmxhbmsiLCBvcHRpb25hbCBbVHJlYXROdWxsQXM9 RW1wdHlTdHJpbmddIERPTVN0cmluZyBmZWF0dXJlcyA9ICIiKTsKIAogICAgIC8vIFRoZSB1c2Vy IGFnZW50LgogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBOYXZpZ2F0b3IgbmF2aWdhdG9yOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwIGIvU291cmNlL1dl YkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCmluZGV4IDM5M2JiN2ViYWYzOTQ2OGFhMzhkMTA1 NzZlMDg2OTYwODc4Mjg1NzMuLmUyNGQ3MTk1NTg2NTNlZGUwZjY5OTM2ZmIzZGJhY2NmODBhNGYx NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKQEAgLTIxODAsNyArMjE4MCw3 IEBAIFJlZlB0cjxET01XaW5kb3c+IEludGVybmFsczo6b3BlbkR1bW15SW5zcGVjdG9yRnJvbnRl bmQoY29uc3QgU3RyaW5nJiB1cmwpCiB7CiAgICAgYXV0byogaW5zcGVjdGVkUGFnZSA9IGNvbnRl eHREb2N1bWVudCgpLT5mcmFtZSgpLT5wYWdlKCk7CiAgICAgYXV0byogd2luZG93ID0gaW5zcGVj dGVkUGFnZS0+bWFpbkZyYW1lKCkuZG9jdW1lbnQoKS0+ZG9tV2luZG93KCk7Ci0gICAgYXV0byBm cm9udGVuZFdpbmRvdyA9IHdpbmRvdy0+b3Blbih1cmwsICIiLCAiIiwgKndpbmRvdywgKndpbmRv dyk7CisgICAgYXV0byBmcm9udGVuZFdpbmRvdyA9IHdpbmRvdy0+b3Blbigqd2luZG93LCAqd2lu ZG93LCB1cmwsICIiLCAiIik7CiAgICAgbV9pbnNwZWN0b3JGcm9udGVuZCA9IHN0ZDo6bWFrZV91 bmlxdWU8SW5zcGVjdG9yU3R1YkZyb250ZW5kPigqaW5zcGVjdGVkUGFnZSwgZnJvbnRlbmRXaW5k b3cuY29weVJlZigpKTsKICAgICByZXR1cm4gZnJvbnRlbmRXaW5kb3c7CiB9Cg==