171931 2017-05-10 10:38:18 -0700 WebAssemby: builder doesn't do Memory section maximum correctly 2017-05-10 11:22:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 161709 1 jfbastien jfbastien commit-queue fpizlo jfbastien keith_miller mark.lam msaboff saam oldest_to_newest 1306907 0 jfbastien 2017-05-10 10:38:18 -0700 It gets confused by 0 maximum because it's falsy, like undefined. 1306908 1 309616 jfbastien 2017-05-10 10:40:27 -0700 Created attachment 309616 patch 1306909 2 309616 keith_miller 2017-05-10 10:42:07 -0700 Comment on attachment 309616 patch r=me. 1306927 3 309616 commit-queue 2017-05-10 11:22:34 -0700 Comment on attachment 309616 patch Clearing flags on attachment: 309616 Committed r216598: <http://trac.webkit.org/changeset/216598> 1306928 4 commit-queue 2017-05-10 11:22:35 -0700 All reviewed patches have been landed. Closing bug. 309616 2017-05-10 10:40:27 -0700 2017-05-10 11:22:34 -0700 patch 0001-Memory-section-in-Builder.patch text/plain 4264 jfbastien RnJvbSAwMGFlZTU4Yjk0ZTM1OWI1YTkzMjE2NGY1MWY3NGE1ZDM4OTAwMjZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBXZWQsIDEwIE1heSAyMDE3IDEwOjQwOjEyIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gTWVtb3J5 IHNlY3Rpb24gaW4gQnVpbGRlcgoKLS0tCiBKU1Rlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8IDEzICsrKysrKysrKysKIEpTVGVzdHMvd2FzbS9CdWlsZGVy LmpzICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDQgKy0tCiBKU1Rlc3RzL3dhc20vQnVp bGRlcl9XZWJBc3NlbWJseUJpbmFyeS5qcyAgICAgICAgICB8ICA4ICsrLS0tLQogSlNUZXN0cy93 YXNtL2Z1bmN0aW9uLXRlc3RzL21lbW9yeS1ncm93LWludmFsaWQuanMgfCAyOSArKysrKysrKysr KysrKysrKysrKysrCiA0IGZpbGVzIGNoYW5nZWQsIDQ2IGluc2VydGlvbnMoKyksIDggZGVsZXRp b25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgSlNUZXN0cy93YXNtL2Z1bmN0aW9uLXRlc3RzL21l bW9yeS1ncm93LWludmFsaWQuanMKCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pT VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg2MGU4MjkuLjM2MDQ5NDUgMTAwNjQ0Ci0tLSBhL0pTVGVz dHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTctMDUtMTAgIEpGIEJhc3RpZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIFdl YkFzc2VtYnk6IGJ1aWxkZXIgZG9lc24ndCBkbyBNZW1vcnkgc2VjdGlvbiBtYXhpbXVtIGNvcnJl Y3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcx OTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 YXNtL0J1aWxkZXIuanM6CisgICAgICAgIChleHBvcnQuZGVmYXVsdC5CdWlsZGVyLnByb3RvdHlw ZS5fcmVnaXN0ZXJTZWN0aW9uQnVpbGRlcnMuY29uc3Quc2VjdGlvbi5pbi5XQVNNLmRlc2NyaXB0 aW9uLnNlY3Rpb24uc3dpdGNoLnNlY3Rpb24uY2FzZS5zdHJpbmdfYXBwZWFyZWRfaGVyZS50aGlz LnNlY3Rpb24pOgorICAgICAgICAqIHdhc20vQnVpbGRlcl9XZWJBc3NlbWJseUJpbmFyeS5qczoK KyAgICAgICAgKGNvbnN0LmVtaXR0ZXJzLk1lbW9yeSk6CisgICAgICAgICogd2FzbS9mdW5jdGlv bi10ZXN0cy9tZW1vcnktZ3Jvdy1pbnZhbGlkLmpzOiBBZGRlZC4KKwogMjAxNy0wNS0xMCAgRmls aXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIE51bGwgcG9pbnRlciBkZXJl ZmVyZW5jZSBpbiBXVEY6OlJlZlB0cjxXVEY6OlN0cmluZ0ltcGw+OjpvcGVyYXRvciEoKSB1bmRl ciBzbG93X3BhdGhfZ2V0X2RpcmVjdF9wbmFtZQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy93YXNtL0J1 aWxkZXIuanMgYi9KU1Rlc3RzL3dhc20vQnVpbGRlci5qcwppbmRleCBkZWU3ODZkLi4wNGFkZjhh NyAxMDA2NDQKLS0tIGEvSlNUZXN0cy93YXNtL0J1aWxkZXIuanMKKysrIGIvSlNUZXN0cy93YXNt L0J1aWxkZXIuanMKQEAgLTUxNyw4ICs1MTcsOCBAQCBleHBvcnQgZGVmYXVsdCBjbGFzcyBCdWls ZGVyIHsKICAgICAgICAgICAgICAgICAgICAgY29uc3QgcyA9IHRoaXMuX2FkZFNlY3Rpb24oc2Vj dGlvbik7CiAgICAgICAgICAgICAgICAgICAgIGNvbnN0IG1lbW9yeUJ1aWxkZXIgPSB7CiAgICAg ICAgICAgICAgICAgICAgICAgICBFbmQ6ICgpID0+IHRoaXMsCi0gICAgICAgICAgICAgICAgICAg ICAgICBJbml0aWFsTWF4UGFnZXM6IChpbml0aWFsLCBtYXgpID0+IHsKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzLmRhdGEucHVzaCh7IGluaXRpYWwsIG1heCB9KTsKKyAgICAgICAgICAg ICAgICAgICAgICAgIEluaXRpYWxNYXhQYWdlczogKGluaXRpYWwsIG1heGltdW0pID0+IHsKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzLmRhdGEucHVzaCh7IGluaXRpYWwsIG1heGltdW0g fSk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIF9lcnJvckhhbmRsaW5nUHJv eHlGb3IobWVtb3J5QnVpbGRlcik7CiAgICAgICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAg ICAgICAgICAgICAgIH07CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3dhc20vQnVpbGRlcl9XZWJBc3Nl bWJseUJpbmFyeS5qcyBiL0pTVGVzdHMvd2FzbS9CdWlsZGVyX1dlYkFzc2VtYmx5QmluYXJ5Lmpz CmluZGV4IDA4MWRlOTkuLmU5NDk4MzUgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvd2FzbS9CdWlsZGVy X1dlYkFzc2VtYmx5QmluYXJ5LmpzCisrKyBiL0pTVGVzdHMvd2FzbS9CdWlsZGVyX1dlYkFzc2Vt Ymx5QmluYXJ5LmpzCkBAIC0xNTQsMTIgKzE1NCw4IEBAIGNvbnN0IGVtaXR0ZXJzID0gewogICAg IE1lbW9yeTogKHNlY3Rpb24sIGJpbikgPT4gewogICAgICAgICAvLyBGbGFncywgY3VycmVudGx5 IGNhbiBvbmx5IGJlIFswLDFdCiAgICAgICAgIHB1dChiaW4sICJ2YXJ1aW50MSIsIHNlY3Rpb24u ZGF0YS5sZW5ndGgpOwotICAgICAgICBmb3IgKGNvbnN0IG1lbW9yeSBvZiBzZWN0aW9uLmRhdGEp IHsKLSAgICAgICAgICAgIHB1dChiaW4sICJ2YXJ1aW50MzIiLCBtZW1vcnkubWF4ID8gMSA6IDAp OwotICAgICAgICAgICAgcHV0KGJpbiwgInZhcnVpbnQzMiIsIG1lbW9yeS5pbml0aWFsKTsKLSAg ICAgICAgICAgIGlmIChtZW1vcnkubWF4KQotICAgICAgICAgICAgICAgIHB1dChiaW4sICJ2YXJ1 aW50MzIiLCBtZW1vcnkubWF4KTsKLSAgICAgICAgfQorICAgICAgICBmb3IgKGNvbnN0IG1lbW9y eSBvZiBzZWN0aW9uLmRhdGEpCisgICAgICAgICAgICBwdXRSZXNpemFibGVMaW1pdHMoYmluLCBt ZW1vcnkuaW5pdGlhbCwgbWVtb3J5Lm1heGltdW0pOwogICAgIH0sCiAKICAgICBHbG9iYWw6IChz ZWN0aW9uLCBiaW4pID0+IHsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvd2FzbS9mdW5jdGlvbi10ZXN0 cy9tZW1vcnktZ3Jvdy1pbnZhbGlkLmpzIGIvSlNUZXN0cy93YXNtL2Z1bmN0aW9uLXRlc3RzL21l bW9yeS1ncm93LWludmFsaWQuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u ZWY2MmZkNgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvd2FzbS9mdW5jdGlvbi10ZXN0cy9t ZW1vcnktZ3Jvdy1pbnZhbGlkLmpzCkBAIC0wLDAgKzEsMjkgQEAKK2ltcG9ydCAqIGFzIGFzc2Vy dCBmcm9tICcuLi9hc3NlcnQuanMnOworaW1wb3J0IEJ1aWxkZXIgZnJvbSAnLi4vQnVpbGRlci5q cyc7CisKK2NvbnN0IHZlcmJvc2UgPSBmYWxzZTsKKworY29uc3QgaW5pdGlhbCA9IDA7Citjb25z dCBtYXggPSAwOworCitjb25zdCBidWlsZGVyID0gKG5ldyBCdWlsZGVyKCkpCisgICAgLlR5cGUo KS5FbmQoKQorICAgIC5GdW5jdGlvbigpLkVuZCgpCisgICAgLk1lbW9yeSgpLkluaXRpYWxNYXhQ YWdlcyhpbml0aWFsLCBtYXgpLkVuZCgpCisgICAgLkV4cG9ydCgpLkZ1bmN0aW9uKCJjdXJyZW50 IikuRnVuY3Rpb24oImdyb3ciKS5FbmQoKQorICAgIC5Db2RlKCkKKyAgICAgICAgLkZ1bmN0aW9u KCJjdXJyZW50IiwgeyBwYXJhbXM6IFtdLCByZXQ6ICJpMzIiIH0pLkN1cnJlbnRNZW1vcnkoMCku UmV0dXJuKCkuRW5kKCkKKyAgICAgICAgLkZ1bmN0aW9uKCJncm93IiwgeyBwYXJhbXM6IFsiaTMy Il0sIHJldDogImkzMiIgfSkuR2V0TG9jYWwoMCkuR3Jvd01lbW9yeSgwKS5SZXR1cm4oKS5FbmQo KQorICAgIC5FbmQoKTsKKworbGV0IGluc3RhbmNlID0gbmV3IFdlYkFzc2VtYmx5Lkluc3RhbmNl KG5ldyBXZWJBc3NlbWJseS5Nb2R1bGUoYnVpbGRlci5XZWJBc3NlbWJseSgpLmdldCgpKSk7CisK K2NvbnN0IGN1cnJlbnQgPSBpbnN0YW5jZS5leHBvcnRzLmN1cnJlbnQoKTsKK2NvbnN0IGJ5ID0g MjsKK2NvbnN0IHJlc3VsdCA9IGluc3RhbmNlLmV4cG9ydHMuZ3JvdyhjdXJyZW50ICsgYnkpOwor aWYgKHZlcmJvc2UpCisgICAgcHJpbnQoYEdyb3cgZnJvbSAke2N1cnJlbnR9IChtYXggJHttYXh9 KSB0byAke2N1cnJlbnQgKyBieX0gcmV0dXJuZWQgJHtyZXN1bHR9LCBjdXJyZW50IG5vdyAke2lu c3RhbmNlLmV4cG9ydHMuY3VycmVudCgpfWApOworCithc3NlcnQuZXEocmVzdWx0LCAtMSk7Cith c3NlcnQuZXEoY3VycmVudCwgaW5zdGFuY2UuZXhwb3J0cy5jdXJyZW50KCkpOworYXNzZXJ0Lmxl KGluc3RhbmNlLmV4cG9ydHMuY3VycmVudCgpLCBtYXgpOwotLSAKMi45LjMKCg==