171923 2017-05-10 08:09:03 -0700 Refactor ScrollingCoordinator::setSynchronousScrollingReasons to accept a FrameView 2017-06-01 10:46:09 -0700 1 1 1 Unclassified WebKit Frames Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 171667 172806 1 fred.wang fred.wang buildbot cmarcelo commit-queue jamesr luiz simon.fraser tonikitoo oldest_to_newest 1306854 0 fred.wang 2017-05-10 08:09:03 -0700 Currently ScrollingCoordinator::setSynchronousScrollingReasons implementations only take SynchronousScrollingReasons and applies it to the main frame. We should pass the desired FrameView to which the reasons apply in order to prepare support for fast scrolling in other frames (bug 171667). 1306857 1 309606 fred.wang 2017-05-10 08:24:35 -0700 Created attachment 309606 Patch 1306898 2 309606 commit-queue 2017-05-10 09:57:54 -0700 Comment on attachment 309606 Patch Clearing flags on attachment: 309606 Committed r216592: <http://trac.webkit.org/changeset/216592> 1306899 3 commit-queue 2017-05-10 09:57:57 -0700 All reviewed patches have been landed. Closing bug. 309606 2017-05-10 08:24:35 -0700 2017-05-10 09:57:54 -0700 Patch 171923.patch text/plain 6981 fred.wang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMjU3YjgzMmI0ZS4uNTE1NjI0ZGNkNzIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwzMSBAQAogMjAxNy0wNS0xMCAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+ CiAKKyAgICAgICAgUmVmYWN0b3IgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldFN5bmNocm9ub3Vz U2Nyb2xsaW5nUmVhc29ucyB0byBhY2NlcHQgYSBGcmFtZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTkyMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSBTY3JvbGxpbmdDb29yZGlu YXRvcjo6c2V0U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zIGltcGxlbWVudGF0aW9ucyBhc3N1 bWVzCisgICAgICAgIFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyBhcHBseSB0byB0aGUgbWFp biBmcmFtZS4gVGhpcyBjb21taXQgYWxsb3dzIHRvIHNwZWNpZnkKKyAgICAgICAgYSBGcmFtZVZp ZXcgaW4gb3JkZXIgdG8gcHJlcGFyZSBzdXBwb3J0IGZvciBmYXN0IHNjcm9sbGluZyBvZiBmcmFt ZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2VzLgorCisgICAg ICAgICogcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpBc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yOjpzZXRTeW5jaHJvbm91c1Nj cm9sbGluZ1JlYXNvbnMpOiBVc2UgdGhlIEZyYW1lVmlldyB0bworICAgICAgICBmaW5kIHRoZSBz dGF0ZSBub2RlLgorICAgICAgICAoV2ViQ29yZTo6QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6 dXBkYXRlU2Nyb2xsTGF5ZXJQb3NpdGlvbik6IFJlbmFtZSB0aGlzIGZ1bmN0aW9uCisgICAgICAg IHVwZGF0ZU1haW5GcmFtZVNjcm9sbExheWVyUG9zaXRpb24gYW5kIHVzZSB0aGUgc3BlY2lmaWVk IEZyYW1lVmlldy4KKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3Jk aW5hdG9yLmg6IEFkZCBGcmFtZVZpZXcgcGFyYW1ldGVyLgorICAgICAgICAqIHBhZ2Uvc2Nyb2xs aW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGlu Z0Nvb3JkaW5hdG9yOjp1cGRhdGVTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMpOiBSZW1vdmUg dGhlIGNvbnN0IHNpbmNlCisgICAgICAgIEFzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IgdXNlcyBz Y3JvbGxMYXllckZvckZyYW1lVmlldy4gUGFzcyB0aGUgZnJhbWVWaWV3IHRvCisgICAgICAgIHNl dFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucy4KKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdDb29yZGluYXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRp bmF0b3I6OnNldFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyk6IEFkZCBGcmFtZVZpZXcgcGFy YW1ldGVyLgorCisyMDE3LTA1LTEwICBGcmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4K KwogICAgICAgICBBZGQgaGV1cmlzdGljIHRvIGF2b2lkIGZsYXR0ZW5pbmcgImZ1bGxzY3JlZW4i IGlmcmFtZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3MTkxNAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9Bc3lu Y1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCmluZGV4IDc2OWNkMjgxZGZlLi5hMmZlYjNl Y2MzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3Jv bGxpbmdDb29yZGluYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcv QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5jcHAKQEAgLTU4MSwzMiArNTgxLDI1IEBAIHZvaWQg QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6dXBkYXRlVmlld3BvcnRDb25zdHJhaW5lZE5vZGUo U2Nyb2xsaW5nTm9kZUlEIG5vCiAgICAgfQogfQogCi12b2lkIEFzeW5jU2Nyb2xsaW5nQ29vcmRp bmF0b3I6OnNldFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhTeW5jaHJvbm91c1Njcm9sbGlu Z1JlYXNvbnMgcmVhc29ucykKK3ZvaWQgQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6c2V0U3lu Y2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKEZyYW1lVmlldyYgZnJhbWVWaWV3LCBTeW5jaHJvbm91 c1Njcm9sbGluZ1JlYXNvbnMgcmVhc29ucykKIHsKLSAgICBpZiAoIW1fc2Nyb2xsaW5nU3RhdGVU cmVlLT5yb290U3RhdGVOb2RlKCkpCisgICAgU2Nyb2xsaW5nU3RhdGVGcmFtZVNjcm9sbGluZ05v ZGUqIHNjcm9sbGluZ1N0YXRlTm9kZSA9IHN0YXRpY19jYXN0PFNjcm9sbGluZ1N0YXRlRnJhbWVT Y3JvbGxpbmdOb2RlKj4obV9zY3JvbGxpbmdTdGF0ZVRyZWUtPnN0YXRlTm9kZUZvcklEKGZyYW1l Vmlldy5zY3JvbGxMYXllcklEKCkpKTsKKyAgICBpZiAoIXNjcm9sbGluZ1N0YXRlTm9kZSkKICAg ICAgICAgcmV0dXJuOwogCiAgICAgLy8gVGhlIEZyYW1lVmlldydzIEdyYXBoaWNzTGF5ZXIgaXMg bGlrZWx5IHRvIGJlIG91dC1vZi1zeW5jaCB3aXRoIHRoZSBQbGF0Zm9ybUxheWVyCiAgICAgLy8g YXQgdGhpcyBwb2ludC4gU28gd2UnbGwgdXBkYXRlIGl0IGJlZm9yZSB3ZSBzd2l0Y2ggYmFjayB0 byBtYWluIHRocmVhZCBzY3JvbGxpbmcKICAgICAvLyBpbiBvcmRlciB0byBhdm9pZCBsYXllciBw b3NpdGlvbmluZyBidWdzLgogICAgIGlmIChyZWFzb25zKQotICAgICAgICB1cGRhdGVNYWluRnJh bWVTY3JvbGxMYXllclBvc2l0aW9uKCk7Ci0gICAgbV9zY3JvbGxpbmdTdGF0ZVRyZWUtPnJvb3RT dGF0ZU5vZGUoKS0+c2V0U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKHJlYXNvbnMpOworICAg ICAgICB1cGRhdGVTY3JvbGxMYXllclBvc2l0aW9uKGZyYW1lVmlldyk7CisgICAgc2Nyb2xsaW5n U3RhdGVOb2RlLT5zZXRTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMocmVhc29ucyk7CiB9CiAK LXZvaWQgQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6dXBkYXRlTWFpbkZyYW1lU2Nyb2xsTGF5 ZXJQb3NpdGlvbigpCit2b2lkIEFzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnVwZGF0ZVNjcm9s bExheWVyUG9zaXRpb24oRnJhbWVWaWV3JiBmcmFtZVZpZXcpCiB7CiAgICAgQVNTRVJUKGlzTWFp blRocmVhZCgpKTsKLQotICAgIGlmICghbV9wYWdlKQotICAgICAgICByZXR1cm47Ci0KLSAgICBG cmFtZVZpZXcqIGZyYW1lVmlldyA9IG1fcGFnZS0+bWFpbkZyYW1lKCkudmlldygpOwotICAgIGlm ICghZnJhbWVWaWV3KQotICAgICAgICByZXR1cm47Ci0KLSAgICBpZiAoR3JhcGhpY3NMYXllciog c2Nyb2xsTGF5ZXIgPSBzY3JvbGxMYXllckZvckZyYW1lVmlldygqZnJhbWVWaWV3KSkKLSAgICAg ICAgc2Nyb2xsTGF5ZXItPnNldFBvc2l0aW9uKC1mcmFtZVZpZXctPnNjcm9sbFBvc2l0aW9uKCkp OworICAgIGlmIChHcmFwaGljc0xheWVyKiBzY3JvbGxMYXllciA9IHNjcm9sbExheWVyRm9yRnJh bWVWaWV3KGZyYW1lVmlldykpCisgICAgICAgIHNjcm9sbExheWVyLT5zZXRQb3NpdGlvbigtZnJh bWVWaWV3LnNjcm9sbFBvc2l0aW9uKCkpOwogfQogCiBib29sIEFzeW5jU2Nyb2xsaW5nQ29vcmRp bmF0b3I6OmlzUnViYmVyQmFuZEluUHJvZ3Jlc3MoKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5oIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5oCmlu ZGV4IDk5YzIwMzNlMGYwLi40ZjIwODcxYzY4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaApAQCAtMTE1 LDEyICsxMTUsMTIgQEAgcHJpdmF0ZToKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHJlY29uY2ls ZVZpZXdwb3J0Q29uc3RyYWluZWRMYXllclBvc2l0aW9ucyhjb25zdCBMYXlvdXRSZWN0JiB2aWV3 cG9ydFJlY3QsIFNjcm9sbGluZ0xheWVyUG9zaXRpb25BY3Rpb24pIG92ZXJyaWRlOwogICAgIFdF QkNPUkVfRVhQT1JUIHZvaWQgc2Nyb2xsYWJsZUFyZWFTY3JvbGxiYXJMYXllckRpZENoYW5nZShT Y3JvbGxhYmxlQXJlYSYsIFNjcm9sbGJhck9yaWVudGF0aW9uKSBvdmVycmlkZTsKIAotICAgIFdF QkNPUkVfRVhQT1JUIHZvaWQgc2V0U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKFN5bmNocm9u b3VzU2Nyb2xsaW5nUmVhc29ucykgb3ZlcnJpZGU7CisgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBz ZXRTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMoRnJhbWVWaWV3JiwgU3luY2hyb25vdXNTY3Jv bGxpbmdSZWFzb25zKSBmaW5hbDsKIAogICAgIHZpcnR1YWwgdm9pZCBzY2hlZHVsZVRyZWVTdGF0 ZUNvbW1pdCgpID0gMDsKIAogICAgIHZvaWQgZW5zdXJlUm9vdFN0YXRlTm9kZUZvckZyYW1lVmll dyhGcmFtZVZpZXcmKTsKLSAgICB2b2lkIHVwZGF0ZU1haW5GcmFtZVNjcm9sbExheWVyUG9zaXRp b24oKTsKKyAgICB2b2lkIHVwZGF0ZVNjcm9sbExheWVyUG9zaXRpb24oRnJhbWVWaWV3Jik7CiAK ICAgICB2b2lkIHVwZGF0ZVNjcm9sbFBvc2l0aW9uQWZ0ZXJBc3luY1Njcm9sbFRpbWVyRmlyZWQo KTsKICAgICB2b2lkIHNldEV2ZW50VHJhY2tpbmdSZWdpb25zRGlydHkoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcApp bmRleCAxZDllNDIzZDkyMS4uNmRiZDNhOGE1MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKQEAgLTM0MywxNCAr MzQzLDE0IEBAIFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyBTY3JvbGxpbmdDb29yZGluYXRv cjo6c3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKGNvCiAgICAgcmV0dXJuIHN5bmNocm9ub3Vz U2Nyb2xsaW5nUmVhc29uczsKIH0KIAotdm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6dXBkYXRl U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKGNvbnN0IEZyYW1lVmlldyYgZnJhbWVWaWV3KQor dm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6dXBkYXRlU3luY2hyb25vdXNTY3JvbGxpbmdSZWFz b25zKEZyYW1lVmlldyYgZnJhbWVWaWV3KQogewogICAgIC8vIEZJWE1FOiBPbmNlIHdlIHN1cHBv cnQgYXN5bmMgc2Nyb2xsaW5nIG9mIGlmcmFtZXMsIHdlJ2xsIGhhdmUgdG8gdHJhY2sgdGhlIHN5 bmNocm9ub3VzIHNjcm9sbGluZwogICAgIC8vIHJlYXNvbnMgcGVyIGZyYW1lIChtYXliZSBvbiBz Y3JvbGxpbmcgdHJlZSBub2RlcykuCiAgICAgaWYgKCFmcmFtZVZpZXcuZnJhbWUoKS5pc01haW5G cmFtZSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBzZXRTeW5jaHJvbm91c1Njcm9sbGluZ1Jl YXNvbnMoc3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKGZyYW1lVmlldykpOworICAgIHNldFN5 bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhmcmFtZVZpZXcsIHN5bmNocm9ub3VzU2Nyb2xsaW5n UmVhc29ucyhmcmFtZVZpZXcpKTsKIH0KIAogdm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6c2V0 Rm9yY2VTeW5jaHJvbm91c1Njcm9sbExheWVyUG9zaXRpb25VcGRhdGVzKGJvb2wgZm9yY2VTeW5j aHJvbm91c1Njcm9sbExheWVyUG9zaXRpb25VcGRhdGVzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKaW5kZXggMzgxNzg1ZmRk YmUuLjU2YjA5OTNhMGRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9TY3JvbGxpbmdDb29yZGluYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKQEAgLTIzNCwxMCArMjM0LDEwIEBAIHByb3RlY3Rl ZDoKICAgICBQYWdlKiBtX3BhZ2U7IC8vIEZJWE1FOiBpZGVhbGx5IHRoaXMgd291bGQgYmUgYSBy ZWZlcmVuY2UgYnV0IGl0IGdldHMgbnVsbGVkIG9uIGFzeW5jIHRlYXJkb3duLgogCiBwcml2YXRl OgotICAgIHZpcnR1YWwgdm9pZCBzZXRTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMoU3luY2hy b25vdXNTY3JvbGxpbmdSZWFzb25zKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgc2V0U3luY2hyb25v dXNTY3JvbGxpbmdSZWFzb25zKEZyYW1lVmlldyYsIFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29u cykgeyB9CiAKICAgICB2aXJ0dWFsIGJvb2wgaGFzVmlzaWJsZVNsb3dSZXBhaW50Vmlld3BvcnRD b25zdHJhaW5lZE9iamVjdHMoY29uc3QgRnJhbWVWaWV3JikgY29uc3Q7Ci0gICAgdm9pZCB1cGRh dGVTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMoY29uc3QgRnJhbWVWaWV3Jik7CisgICAgdm9p ZCB1cGRhdGVTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMoRnJhbWVWaWV3Jik7CiAKICAgICBF dmVudFRyYWNraW5nUmVnaW9ucyBhYnNvbHV0ZUV2ZW50VHJhY2tpbmdSZWdpb25zRm9yRnJhbWUo Y29uc3QgRnJhbWUmKSBjb25zdDsKICAgICAK