171907 2017-05-09 20:14:03 -0700 Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub 2017-05-10 11:53:38 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 ross.kirsling webkit-unassigned commit-queue inspector-bugzilla-changes joepeck oldest_to_newest 1306715 0 ross.kirsling 2017-05-09 20:14:03 -0700 Verification steps: 1. Ensure that InspectorFrontendHostStub is being used, or at the least, that InspectorFrontendHost.copyText is overridden to the stub implementation. 2. Do something that copies to the clipboard (e.g. Copy as cURL). -- Clipboard is not updated (console error: "Clipboard access is denied"). Details: - The copyText stub is calling document.execCommand("copy"), but there's no current selection, so this is guaranteed to fail. - More specifically, instead of setting up the text to copy as a selection, we're just setting an unused field _textToCopy, which is a remnant of the old Inspector: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js?rev=154828 1306720 1 309574 ross.kirsling 2017-05-09 20:22:21 -0700 Created attachment 309574 Patch 1306914 2 309574 joepeck 2017-05-10 10:52:16 -0700 Comment on attachment 309574 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309574&action=review r=me > Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js:124 > + const textarea = document.createElement("textarea"); Nit: We would typically use `let` instead of const, but it doesn't really matter. Our style for when we use `const` tends to be when the value is the equivalent of a compile time constant. So `const timeToWait = 1000;" but not `const timeToWait = x * y;`. Maybe we should change that style though. 1306925 3 309619 ross.kirsling 2017-05-10 11:22:04 -0700 Created attachment 309619 Patch 1306937 4 309619 commit-queue 2017-05-10 11:53:37 -0700 Comment on attachment 309619 Patch Clearing flags on attachment: 309619 Committed r216602: <http://trac.webkit.org/changeset/216602> 1306938 5 commit-queue 2017-05-10 11:53:38 -0700 All reviewed patches have been landed. Closing bug. 309574 2017-05-09 20:22:21 -0700 2017-05-10 11:22:02 -0700 Patch bug-171907-20170509202232.patch text/plain 1889 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 ZWNhZjFhNzdhNzhhNjc5OGEzODIzMWYwZDcwNmI2M2M4ZGJmZmY2Li5iNTkyZGNmMzUyMmMzZTJj YzkxMmEyMDYwOTgxYWNkNWQ5OTI5NTIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0wNS0wOSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ29weSB0byBjbGlwYm9hcmQgZmFpbHMg dmlhIEluc3BlY3RvckZyb250ZW5kSG9zdFN0dWIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTkwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL0luc3BlY3RvckZyb250 ZW5kSG9zdFN0dWIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSW5zcGVjdG9yRnJvbnRlbmRI b3N0U3R1Yi5wcm90b3R5cGUuY29weVRleHQpOgorICAgICAgICBBY3R1YWxseSBtYWtlIGEgdGV4 dCBzZWxlY3Rpb24gYmVmb3JlIGF0dGVtcHRpbmcgdG8gY29weSB0byBjbGlwYm9hcmQuCisKIDIw MTctMDQtMjUgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogT3BlbiB0aGUgbmV3IGJ1ZyBwYWdlIGluIHRoZSBuZXcgdGFiCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL0luc3Bl Y3RvckZyb250ZW5kSG9zdFN0dWIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMKaW5kZXggNmI1N2E5MGZhNTI1 MGQ4YTM2MjcyYjUyNWMwMWQ3ZDYzMDg0N2M0OC4uNmYwMDc1MmM0NWQ5ZWE5MDJkNjY0YmQ0Yjhj MjM0YmE3YzEyMDc3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQmFzZS9JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5q cwpAQCAtMTIxLDkgKzEyMSwxNSBAQCBpZiAoIXdpbmRvdy5JbnNwZWN0b3JGcm9udGVuZEhvc3Qp IHsKIAogICAgICAgICBjb3B5VGV4dDogZnVuY3Rpb24odGV4dCkKICAgICAgICAgewotICAgICAg ICAgICAgdGhpcy5fdGV4dFRvQ29weSA9IHRleHQ7CisgICAgICAgICAgICBjb25zdCB0ZXh0YXJl YSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRleHRhcmVhIik7CisgICAgICAgICAgICB0ZXh0 YXJlYS50ZXh0Q29udGVudCA9IHRleHQ7CisgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVu ZENoaWxkKHRleHRhcmVhKTsKKyAgICAgICAgICAgIHRleHRhcmVhLnNlbGVjdCgpOworCiAgICAg ICAgICAgICBpZiAoIWRvY3VtZW50LmV4ZWNDb21tYW5kKCJjb3B5IikpCi0gICAgICAgICAgICAg ICAgY29uc29sZS5lcnJvcigiQ2xpcGJvYXJkIGFjY2VzcyBpcyBkZW5pZWQiKTsKKyAgICAgICAg ICAgICAgICBjb25zb2xlLmVycm9yKCJDb3VsZCBub3QgY29weSB0byBjbGlwYm9hcmQuIik7CisK KyAgICAgICAgICAgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQodGV4dGFyZWEpOwogICAgICAg ICB9LAogCiAgICAgICAgIGtpbGxUZXh0OiBmdW5jdGlvbih0ZXh0LCBzaG91bGRTdGFydE5ld1Nl cXVlbmNlKQo= 309619 2017-05-10 11:22:04 -0700 2017-05-10 11:53:37 -0700 Patch bug-171907-20170510112216.patch text/plain 1887 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 ZWNhZjFhNzdhNzhhNjc5OGEzODIzMWYwZDcwNmI2M2M4ZGJmZmY2Li5kMDRmYzhkYmExMTBiOGU3 OTdmNDUyZjY3NmJlNTliOTkwNWE0MDg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0wNS0xMCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ29weSB0byBjbGlwYm9hcmQgZmFpbHMg dmlhIEluc3BlY3RvckZyb250ZW5kSG9zdFN0dWIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTkwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL0luc3BlY3RvckZyb250 ZW5kSG9zdFN0dWIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSW5zcGVjdG9yRnJvbnRlbmRI b3N0U3R1Yi5wcm90b3R5cGUuY29weVRleHQpOgorICAgICAgICBBY3R1YWxseSBtYWtlIGEgdGV4 dCBzZWxlY3Rpb24gYmVmb3JlIGF0dGVtcHRpbmcgdG8gY29weSB0byBjbGlwYm9hcmQuCisKIDIw MTctMDQtMjUgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogT3BlbiB0aGUgbmV3IGJ1ZyBwYWdlIGluIHRoZSBuZXcgdGFiCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL0luc3Bl Y3RvckZyb250ZW5kSG9zdFN0dWIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMKaW5kZXggNmI1N2E5MGZhNTI1 MGQ4YTM2MjcyYjUyNWMwMWQ3ZDYzMDg0N2M0OC4uOTA1Zjk1YTZmNTQ0ZTRiNTM2ZmM3NDNhYmI0 NjkxMzMwZTlhYmQ1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQmFzZS9JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5q cwpAQCAtMTIxLDkgKzEyMSwxNSBAQCBpZiAoIXdpbmRvdy5JbnNwZWN0b3JGcm9udGVuZEhvc3Qp IHsKIAogICAgICAgICBjb3B5VGV4dDogZnVuY3Rpb24odGV4dCkKICAgICAgICAgewotICAgICAg ICAgICAgdGhpcy5fdGV4dFRvQ29weSA9IHRleHQ7CisgICAgICAgICAgICBsZXQgdGV4dGFyZWEg PSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0ZXh0YXJlYSIpOworICAgICAgICAgICAgdGV4dGFy ZWEudGV4dENvbnRlbnQgPSB0ZXh0OworICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRD aGlsZCh0ZXh0YXJlYSk7CisgICAgICAgICAgICB0ZXh0YXJlYS5zZWxlY3QoKTsKKwogICAgICAg ICAgICAgaWYgKCFkb2N1bWVudC5leGVjQ29tbWFuZCgiY29weSIpKQotICAgICAgICAgICAgICAg IGNvbnNvbGUuZXJyb3IoIkNsaXBib2FyZCBhY2Nlc3MgaXMgZGVuaWVkIik7CisgICAgICAgICAg ICAgICAgY29uc29sZS5lcnJvcigiQ291bGQgbm90IGNvcHkgdG8gY2xpcGJvYXJkLiIpOworCisg ICAgICAgICAgICBkb2N1bWVudC5ib2R5LnJlbW92ZUNoaWxkKHRleHRhcmVhKTsKICAgICAgICAg fSwKIAogICAgICAgICBraWxsVGV4dDogZnVuY3Rpb24odGV4dCwgc2hvdWxkU3RhcnROZXdTZXF1 ZW5jZSkK